Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

> what happens if you add libatomic in configure on your system? > ./configure CFLAGS="-latomic" > > > does it fail that there is no such lib? That works fine for me. But, on the x86 and ARM machines I have to hand, everything also works perfectly without this additional flag. This is what I

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

what happens if you add libatomic in configure on your system? ./configure CFLAGS="-latomic" does it fail that there is no such lib? On 10 February 2017 at 13:31, Joe Savage wrote: > Thanks, Maxim. Assuming that's the last of the additional comments, I think > I've

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

Thanks, Maxim. Assuming that's the last of the additional comments, I think I've cleaned everything up ready for v3. That is, besides the potential issue with libatomic. > > +/** > > + * Clean up any stale flows within a fraglist > > + * > > + * @param fl Pointer to the shared fraglist to

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

here I need to take some break. Will continue to review later in separate email... > +/** > + * Add a single fragment to a shared fraglist > + * > + * @param fl Pointer to the shared fraglist to add "frag" to > + * @param frag Pointer to the fragment to add to "fl" > + * @param

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

On 02/09/17 19:22, Joe Savage wrote: > +int main(void) > +{ > + odp_instance_t instance; > + odp_pool_t fragment_pool; > + odp_shm_t shm; > + odp_cpumask_t cpumask; > + odph_odpthread_t threads[MAX_WORKERS] = {}; > + odp_packet_t

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

> >>> +int main(void) > >>> +{ > >>> + odp_instance_t instance; > >>> + odp_pool_t fragment_pool; > >>> + odp_shm_t shm; > >>> + odp_cpumask_t cpumask; > >>> + odph_odpthread_t threads[MAX_WORKERS] = {}; > >>> + odp_packet_t dequeued_pkts[NUM_PACKETS]; > >>> + int i; >

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

On 02/09/17 17:28, Joe Savage wrote: > Thanks, Maxim. A few comments on some of the feedback so far. > >>> +int main(void) >>> +{ >>> + odp_instance_t instance; >>> + odp_pool_t fragment_pool; >>> + odp_shm_t shm; >>> + odp_cpumask_t cpumask; >>> + odph_odpthread_t

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

Thanks, Maxim. A few comments on some of the feedback so far. > > +int main(void) > > +{ > > + odp_instance_t instance; > > + odp_pool_t fragment_pool; > > + odp_shm_t shm; > > + odp_cpumask_t cpumask; > > + odph_odpthread_t threads[MAX_WORKERS] = {}; > > + odp_packet_t

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

On 01/30/17 13:32, Joe Savage wrote: > Add an example application implementing lock-free IPv4 fragmentation > and reassembly functionality using ODP's packet "concat" and "split". > > Signed-off-by: Joe Savage > --- > (This code contribution is provided under the terms of

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

On 02/08/17 14:03, Joe Savage wrote: >> we use autotools and check to add or not add cflags or ldflags should be >> there. >> I think in that case it's better to make such check in that file: >> ./platform/linux-generic/m4/configure.m4 >> >> So check should be code compilation with libatomic and

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

> we use autotools and check to add or not add cflags or ldflags should be > there. > I think in that case it's better to make such check in that file: > ./platform/linux-generic/m4/configure.m4 > > So check should be code compilation with libatomic and without and set or > not set it in ldflags.

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

On 8 February 2017 at 12:36, Joe Savage wrote: > > No, only which I wrote before. Main comment is that we need it compile > in our CI env, > > so you need to add atomic library as Ola wrote. And few places where > variables need go > > on top. > > Okay then. There were some

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

> No, only which I wrote before. Main comment is that we need it compile in our > CI env, > so you need to add atomic library as Ola wrote. And few places where > variables need go > on top. Okay then. There were some unresolved issues in the email to which I replied to prompt you, but if you

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

On 8 February 2017 at 12:15, Joe Savage wrote: > Any further thoughts on these issues, Maxim? I'm keen to get this patch > merged already! > > No, only which I wrote before. Main comment is that we need it compile in our CI env, so you need to add atomic library as Ola

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

Any further thoughts on these issues, Maxim? I'm keen to get this patch merged already! > > > I raised question about coding style question on today’s arch call > > > discussion. And agreement was: > > > > > > 1. variables are on top. (actually we discussed that but looks like > > > forget to

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

On 02/02/2017, 17:26, "Maxim Uvarov" wrote: >>> >>>My point is: >>> >>>original packet -> wrongly fragmented -> original packet >>>vs >>>original packet -> good fragmented -> original packet >>> >>>result is the same, middle is different. >>I don't understand. How do

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

On 02/01/17 18:50, Ola Liljedahl wrote: > On 1 February 2017 at 16:19, Maxim Uvarov wrote: >> On 02/01/17 13:26, Joe Savage wrote: >>> Hey Maxim, >>> >>> I'm adding the mailing list to the CCs. >>> >> >> sorry, looks like I pressed replay instead of replay all. >> >> I

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

> > I raised question about coding style question on today’s arch call > > discussion. And agreement was: > > > > 1. variables are on top. (actually we discussed that but looks like > > forget to document.) Some exceptions acceptable if you link to 3-rd > > party code which you can not modify.

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

On 1 February 2017 at 16:19, Maxim Uvarov wrote: > On 02/01/17 13:26, Joe Savage wrote: >> Hey Maxim, >> >> I'm adding the mailing list to the CCs. >> > > sorry, looks like I pressed replay instead of replay all. > > I raised question about coding style question on

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

On 02/01/17 13:26, Joe Savage wrote: > Hey Maxim, > > I'm adding the mailing list to the CCs. > sorry, looks like I pressed replay instead of replay all. I raised question about coding style question on today’s arch call discussion. And agreement was: 1. variables are on top. (actually we

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

Hey Maxim, I'm adding the mailing list to the CCs. > > +#include > > +#include > > + > > +#include "odp_ipfragreass_ip.h" > > +#include "odp_ipfragreass_fragment.h" > > + > > +int fragment_ipv4_packet(odp_packet_t orig_packet, odp_packet_t *out, > > +int *out_len) > >

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

On Mon, Jan 30, 2017 at 4:32 AM, Joe Savage wrote: > Add an example application implementing lock-free IPv4 fragmentation > and reassembly functionality using ODP's packet "concat" and "split". > > Signed-off-by: Joe Savage Reviewed-and-tested-by: Bill

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

checkpatch is only a tool to help reviewers so I would also say we accept the warning in this case, an error maybe not. On 31 January 2017 at 04:19, Joe Savage wrote: > > > Checkpatch still has some issues with this: > > > > > > ill at Ubuntu15:~/linaro/review$

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

> > Checkpatch still has some issues with this: > > > > ill at Ubuntu15:~/linaro/review$ ./scripts/checkpatch.pl > > 0001-example-add-IPv4-fragmentation-reassembly-example.patch > > WARNING: 'DONT' may be misspelled - perhaps 'DON'T'? > > #1056: FILE: example/ipfragreass/odp_ipfragreass_ip.h:20: >

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

On 30 January 2017 at 23:50, Bill Fischofer wrote: > Checkpatch still has some issues with this: > > ill@Ubuntu15:~/linaro/review$ ./scripts/checkpatch.pl > 0001-example-add-IPv4-fragmentation-reassembly-example.patch > WARNING: 'DONT' may be misspelled - perhaps

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

Checkpatch still has some issues with this: ill@Ubuntu15:~/linaro/review$ ./scripts/checkpatch.pl 0001-example-add-IPv4-fragmentation-reassembly-example.patch WARNING: 'DONT' may be misspelled - perhaps 'DON'T'? #1056: FILE: example/ipfragreass/odp_ipfragreass_ip.h:20: +#define IP_FRAG_DONT