Re: [lng-odp] [PATCHv3] linux-generic: mmap: jumbo frames support

2015-03-03 Thread Maxim Uvarov
On 03/03/15 17:48, Ola Liljedahl wrote: Some of these explanations should be present in the code. Perhaps actually have the calculation in the code and let the compiler do the work. Currently, nobody seems to understand how you get from A to B. Ok, will add in new version. Maxim. On 3 March

Re: [lng-odp] [PATCHv1 2/3] validation: crypto: add common test cleanup

2015-03-03 Thread Robbie King (robking)
CU_ASSERT doesn't seem to work within the term_global routine, apparently they can only be called within the tests themselves? At the moment I'm inclined to leave my patch as is. -Original Message- From: Robbie King (robking) Sent: Tuesday, March 03, 2015 9:08 AM To: 'Maxim Uvarov';

Re: [lng-odp] [RFC 0/2] validation: crypto: remove code duplication

2015-03-03 Thread Robbie King (robking)
Sorry Taras I haven't. I'll try to get to it today. -Original Message- From: Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Tuesday, March 03, 2015 11:24 AM To: Robbie King (robking) Cc: lng-odp@lists.linaro.org; mike.hol...@linaro.org Subject: Re: [RFC 0/2] validation:

[lng-odp] [PATCH] example: odp_generator: use odp_timer

2015-03-03 Thread Ola Liljedahl
Use ODP timer facility instead of POSIX sleep/nanosleep. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309) example/generator/odp_generator.c | 105 +++--- 1

Re: [lng-odp] [RFC 0/2] validation: crypto: remove code duplication

2015-03-03 Thread Taras Kondratiuk
On 02/27/2015 01:19 AM, Taras Kondratiuk wrote: Current crypto tests have a few issues: - Asynchronous tests assume that operation is always executed asynchronously, but specification does not demand it (I hope I read it correctly). So tests have to handle synchronous operations also. - If

Re: [lng-odp] [PATCHv3] linux-generic: mmap: jumbo frames support

2015-03-03 Thread Ciprian Barbu
On Tue, Mar 3, 2015 at 12:28 PM, Maxim Uvarov maxim.uva...@linaro.org wrote: Support for jumbo frames for linux-generic with unsegmented buffers. Test for pkio is also adjusted to work with 9*1024=9216 bytes packets. https://bugs.linaro.org/show_bug.cgi?id=509 Signed-off-by: Maxim Uvarov

[lng-odp] [PATCHv4] linux-generic: mmap: jumbo frames support

2015-03-03 Thread Maxim Uvarov
Support for jumbo frames for linux-generic with unsegmented buffers. Test for pkio is also adjusted to work with 9*1024=9216 bytes packets. https://bugs.linaro.org/show_bug.cgi?id=509 Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org --- v4: - fix work on real interfaces (make check under

Re: [lng-odp] [PATCH v1] validation: classification: pktio skip value set to zero

2015-03-03 Thread Bill Fischofer
Per Maxim's post this was merged earlier today. Commit id is f9900bf2612bf9f9a7f28082c59baf9d16335d9f On Tue, Mar 3, 2015 at 1:23 PM, Bala Manoharan bala.manoha...@linaro.org wrote: Can this be merged now? Regards, Bala On 3 March 2015 at 06:07, Bill Fischofer bill.fischo...@linaro.org

Re: [lng-odp] [PATCHv2 0/3] validation: crypto: cleanup termination

2015-03-03 Thread Maxim Uvarov
Merged, Maxim. On 02/28/15 00:33, Mike Holmes wrote: On 26 February 2015 at 19:08, Bill Fischofer bill.fischo...@linaro.org mailto:bill.fischo...@linaro.org wrote: For this series: Reviewed-and-tested-by: Bill Fischofer bill.fischo...@linaro.org

[lng-odp] [Bug 1282] test/validation/odp_crypto fails to terminate cleanly

2015-03-03 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1282 Maxim Uvarov maxim.uva...@linaro.org changed: What|Removed |Added Resolution|--- |FIXED

Re: [lng-odp] [RFC 0/2] validation: crypto: remove code duplication

2015-03-03 Thread Robbie King (robking)
Nice cleanup, makes it easier to move to per test initialization/termination. Reviewed-by: Robert King robk...@cisco.com -Original Message- From: Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Thursday, February 26, 2015 6:19 PM To: lng-odp@lists.linaro.org Cc:

Re: [lng-odp] [PATCH v2] linux-generic: thread: reuse thread ids

2015-03-03 Thread Savolainen, Petri (Nokia - FI/Espoo)
Ping. From: ext Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Tuesday, March 03, 2015 1:21 AM To: Petri Savolainen Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [PATCH v2] linux-generic: thread: reuse thread ids On Mon, Mar 2, 2015 at 8:45 AM, Petri Savolainen

[lng-odp] [PATCHv2] validation: strongtypes: add unit tests for strong type display functions

2015-03-03 Thread Bill Fischofer
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- test/validation/.gitignore| 1 + test/validation/Makefile.am | 2 + test/validation/odp_strongtypes.c | 86 +++ 3 files changed, 89 insertions(+) create mode 100644

Re: [lng-odp] [PATCH v1] validation: classification: pktio skip value set to zero

2015-03-03 Thread Bala
Sorry there were two patches and I had missed this commit id. Regards, Bala On Wednesday 04 March 2015 12:55 AM, Bill Fischofer wrote: Per Maxim's post this was merged earlier today. Commit id is f9900bf2612bf9f9a7f28082c59baf9d16335d9f On Tue, Mar 3, 2015 at 1:23 PM, Bala Manoharan

Re: [lng-odp] [PATCHv4] linux-generic: mmap: jumbo frames support

2015-03-03 Thread Bill Fischofer
On Tue, Mar 3, 2015 at 11:06 AM, Maxim Uvarov maxim.uva...@linaro.org wrote: Support for jumbo frames for linux-generic with unsegmented buffers. Test for pkio is also adjusted to work with 9*1024=9216 bytes packets. https://bugs.linaro.org/show_bug.cgi?id=509 Signed-off-by: Maxim Uvarov

Re: [lng-odp] [PATCH] example: odp_generator: use odp_timer

2015-03-03 Thread Bill Fischofer
On Tue, Mar 3, 2015 at 10:19 AM, Ola Liljedahl ola.liljed...@linaro.org wrote: Use ODP timer facility instead of POSIX sleep/nanosleep. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org Reviewed-by: Bill Fischofer bill.fischo...@linaro.org --- (This document/code contribution

[lng-odp] [Bug 1281] test/validation/odp_classification fails to terminate cleanly

2015-03-03 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1281 Bala Manoharan bala.manoha...@linaro.org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[lng-odp] [Bug 1230] classification set skip value ignored

2015-03-03 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1230 Bala Manoharan bala.manoha...@linaro.org changed: What|Removed |Added Resolution|--- |FIXED

Re: [lng-odp] [PATCHv1 2/3] validation: crypto: add common test cleanup

2015-03-03 Thread Maxim Uvarov
On 03/03/15 18:43, Robbie King (robking) wrote: CU_ASSERT doesn't seem to work within the term_global routine, apparently they can only be called within the tests themselves? At the moment I'm inclined to leave my patch as is. ok. -Original Message- From: Robbie King (robking) Sent:

Re: [lng-odp] [PATCHv3] linux-generic: mmap: jumbo frames support

2015-03-03 Thread Maxim Uvarov
On 03/03/15 16:10, Ciprian Barbu wrote: On Tue, Mar 3, 2015 at 12:28 PM, Maxim Uvarov maxim.uva...@linaro.org wrote: Support for jumbo frames for linux-generic with unsegmented buffers. Test for pkio is also adjusted to work with 9*1024=9216 bytes packets.

Re: [lng-odp] [PATCHv1 2/3] validation: crypto: add common test cleanup

2015-03-03 Thread Robbie King (robking)
I believe this will always print the one of the two legs even when successful: if ((ODP_POOL_INVALID != pool odp_pool_destroy(pool)) fprintf(stderr, Completion pool destroy failed.\n); else fprintf(stderr, Completion pool not found.\n); I will change to the CUnit

[lng-odp] [PATCHv3] linux-generic: mmap: jumbo frames support

2015-03-03 Thread Maxim Uvarov
Support for jumbo frames for linux-generic with unsegmented buffers. Test for pkio is also adjusted to work with 9*1024=9216 bytes packets. https://bugs.linaro.org/show_bug.cgi?id=509 Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org --- v3: use ODP_PACKED macro. v2: separate test for jumbo

Re: [lng-odp] [PATCH v1] validation: classification: destroy pktio default inqueue during teardown

2015-03-03 Thread Maxim Uvarov
Applied, Maxim. On 03/03/15 03:37, Bill Fischofer wrote: On Fri, Feb 27, 2015 at 8:15 AM, bala.manoha...@linaro.org mailto:bala.manoha...@linaro.org wrote: From: Balasubramanian Manoharan bala.manoha...@linaro.org mailto:bala.manoha...@linaro.org Destroys pktio default inqueue

Re: [lng-odp] [PATCHv3] linux-generic: mmap: jumbo frames support

2015-03-03 Thread Ola Liljedahl
Some of these explanations should be present in the code. Perhaps actually have the calculation in the code and let the compiler do the work. Currently, nobody seems to understand how you get from A to B. On 3 March 2015 at 15:25, Maxim Uvarov maxim.uva...@linaro.org wrote: On 03/03/15 16:10,