[lng-odp] [PATCH] linux-generic/odp_impl: add implementation version details

2015-05-06 Thread Mike Holmes
Signed-off-by: Mike Holmes --- configure.ac | 1 + platform/Makefile.inc | 3 +++ platform/linux-generic/odp_impl.c | 14 -- scripts/git_hash.sh | 9 + 4 files changed, 25 insertions(+), 2 deletions(-) create mode 100755 scrip

Re: [lng-odp] validation: running the tests from the platform side (again :-) )

2015-05-06 Thread Mike Holmes
On 6 May 2015 at 11:26, Christophe Milard wrote: > > Hi, > > Yet another try to reach a acceptable solution regarding the test > environment, following tuesday meeting. > Here comes the n+2th proposal...:-) > The goal is now to improve this proposal with your comments, and then finally > pick up

Re: [lng-odp] [PATCHv5 0/2] validation: renaming and regrouping tests

2015-05-06 Thread Maxim Uvarov
Merged, Maxim. On 05/05/2015 20:10, Mike Holmes wrote: On 5 May 2015 at 11:49, Christophe Milard mailto:christophe.mil...@linaro.org>> wrote: Same as version 4 but excluding the renaming of the pktio module, which remains, for the time being, inconsistent with the doxygen defgro

Re: [lng-odp] FW: [API-NEXT PATCH v4 1/4] api: packet: rename user_data to user_area

2015-05-06 Thread Maxim Uvarov
Merged, Maxim. On 05/06/2015 14:43, Bill Fischofer wrote: Sorry about that. Obviously I hit reply vs. reply all. On Wed, May 6, 2015 at 1:49 AM, Savolainen, Petri (Nokia - FI/Espoo) mailto:petri.savolai...@nokia.com>> wrote: Forwarding to the list… *From:*ext Bill Fischofer [mailto

[lng-odp] validation: running the tests from the platform side (again :-) )

2015-05-06 Thread Christophe Milard
Hi, Yet another try to reach a acceptable solution regarding the test environment, following tuesday meeting. Here comes the n+2th proposal...:-) The goal is now to improve this proposal with your comments, and then finally pick up the best alternative between the proposal from last week (running

Re: [lng-odp] rename odp_pktio to odp_packet_io test

2015-05-06 Thread Bill Fischofer
The abstract type we're using is odp_pktio_t so code and tests surrounding that type should be based on that name to make that clear. On Wed, May 6, 2015 at 4:41 AM, Maxim Uvarov wrote: > > > On 6 May 2015 at 12:00, Ciprian Barbu wrote: > >> On Tue, May 5, 2015 at 7:09 PM, Mike Holmes >> wrote

Re: [lng-odp] [PATCH] test: pktio: add missing atomic init

2015-05-06 Thread Bill Fischofer
On Wed, May 6, 2015 at 4:10 AM, Nicolas Morey-Chaisemartin wrote: > Signed-off-by: Nicolas Morey-Chaisemartin > Reviewed-by: Bill Fischofer > --- > test/validation/odp_pktio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/test/validation/odp_pktio.c b/test/validation/odp_pktio.c

Re: [lng-odp] [API-NEXT PATCH] linux-generic: odp_impl: concatenate api version with implementation version

2015-05-06 Thread Mike Holmes
Are we happy with this output from the test? I think the owner is well known, and adding "Linaro/LNG" feels wrong to me - do people feel strongly that we add an owner ODP API version: 1.0.4 ODP implementation version: linux-generic 1.0.4-0 (v1.0.4) May 6 201507:54:33 On 6 May 2015 at 07:06, Mi

Re: [lng-odp] FW: [API-NEXT PATCH v4 1/4] api: packet: rename user_data to user_area

2015-05-06 Thread Bill Fischofer
Sorry about that. Obviously I hit reply vs. reply all. On Wed, May 6, 2015 at 1:49 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > Forwarding to the list… > > > > *From:* ext Bill Fischofer [mailto:bill.fischo...@linaro.org] > *Sent:* Tuesday, May 05, 2015 9:15 P

Re: [lng-odp] Query on classification's rules ordering

2015-05-06 Thread Bala Manoharan
Hi, Cos configured using PMR takes precedence over CoS configured using L2 and L3 priority and QoS values. Among L2 and L3 values, odp_cos_with_l3_qos() function contains a boolean "L3_precedence" which indicates whether L2 or L3 priority value takes precedence. Hope this helps, Bala On 6 May 2

Re: [lng-odp] [API-NEXT PATCH] linux-generic: odp_impl: concatenate api version with implementation version

2015-05-06 Thread Mike Holmes
On 6 May 2015 at 03:30, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > Hi, > > This is pure implementation change and thus does not belong to api-next > (but master). I agree the code is implementation, but the change in the release numbering is significant and coupl

[lng-odp] Query on classification's rules ordering

2015-05-06 Thread Sunil Kumar Kori
Hello, I was looking into the ODP v1.0 classification APIs. I have doubt regarding the order of rules to be applied on a single pktio. Following is the scenario: 1. Pktio is configured with l2 priority using odp_cos_with_l2_priority 2. Pktio is configured with l3 qos using odp_cos_

Re: [lng-odp] rename odp_pktio to odp_packet_io test

2015-05-06 Thread Maxim Uvarov
On 6 May 2015 at 12:00, Ciprian Barbu wrote: > On Tue, May 5, 2015 at 7:09 PM, Mike Holmes > wrote: > > > > > > On 5 May 2015 at 11:55, Maxim Uvarov wrote: > >> > >> Hello, > >> > >> I saw in Christophe patch to rename odp_pktio test to odp_packet_io. > >> Christophe did that because doxygen ge

[lng-odp] Query regarding sequence number update in IPSEC application

2015-05-06 Thread nikhil.agar...@freescale.com
Hi, In IPSEC example application, queues are used to update the sequence number. I was wondering why we have used queues to update sequence number which will add to scheduling delays and adversely hit the performance throughput. Is there any specific advantage of using queues over atomic variab

[lng-odp] [PATCH] test: pktio: add missing atomic init

2015-05-06 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin --- test/validation/odp_pktio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/validation/odp_pktio.c b/test/validation/odp_pktio.c index 67e709e..583e291 100644 --- a/test/validation/odp_pktio.c +++ b/test/validation/odp_pktio.c @@ -621,6 +621,

Re: [lng-odp] rename odp_pktio to odp_packet_io test

2015-05-06 Thread Ciprian Barbu
On Tue, May 5, 2015 at 7:09 PM, Mike Holmes wrote: > > > On 5 May 2015 at 11:55, Maxim Uvarov wrote: >> >> Hello, >> >> I saw in Christophe patch to rename odp_pktio test to odp_packet_io. >> Christophe did that because doxygen generated document has packet_io name >> for this chapter. I think th

Re: [lng-odp] [PATCH] update version number from v1.0.3 to v1.0.4

2015-05-06 Thread Ciprian Barbu
On Tue, May 5, 2015 at 4:57 PM, Mike Holmes wrote: > http://people.linaro.org/~mike.holmes/odp-api/html/release.html > > When I paste this it works for me - not sure where it is going wrong does > http://people.linaro.org/~mike.holmes/odp-api/html work for you ? - if so > look at the Release Manag

[lng-odp] [PATCH v3] linux-generic: use inttypes defines to print (u)int32_t values

2015-05-06 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin --- Submitted this patch a couple of weeks ago with a bad title ( [PATCHv2] Use inttypes defines to print (u)int32_t values) and didn't any feedback. platform/linux-generic/odp_buffer.c | 4 ++-- platform/linux-generic/odp_packet.c | 14 +++---

Re: [lng-odp] [API-NEXT PATCH 2/2] api: init: added thread type to local init

2015-05-06 Thread Savolainen, Petri (Nokia - FI/Espoo)
Thread type call is not performance critical. An thread can check in which type it has been initialized (if it does not know that from the start anyway). Worker/ctrl is information for the implementation. E.g. may need to decide does it dedicate (per CPU) HW resources for the thread (== worker)

Re: [lng-odp] [API-NEXT PATCH] linux-generic: odp_impl: concatenate api version with implementation version

2015-05-06 Thread Savolainen, Petri (Nokia - FI/Espoo)
Hi, This is pure implementation change and thus does not belong to api-next (but master). Also the string could contain more information, à la Linux "uname -a" e.g. linux-generic: "Linaro/LNG linux-generic 1.0.1-5 (ODP v1.0.1) Wed May 6 10:17:46 UTC 2015" linux-dpdk: "Linaro/LNG linux-dpdk 1.0