Re: [lng-odp] [PATCH] test: bench_packet: add tests for reference functions

2017-03-13 Thread Elo, Matias (Nokia - FI/Espoo)
> On 13 Mar 2017, at 19:58, Bill Fischofer wrote: > > This is a good start and I have no problem merging this as-is if we want to > do this in stages, but I think a bit more is needed. For one, this is using a > fixed offset for all references. I'd like to see references created with a > coup

[lng-odp] ABI and deprecated API flag

2017-03-13 Thread Honnappa Nagarahalli
Hi, I had few questions after the discussion about ABI and deprecated API flag in the call today. Can someone please answer my questions below? 1) What are we trying to achieve with the ABI? It was mentioned that ABI is only for releases within a version? 2) What is the purpose of the deprecat

Re: [lng-odp] [PATCH] linux-gen: packet: make inline table visible

2017-03-13 Thread Bill Fischofer
On Mon, Mar 13, 2017 at 10:14 AM, Petri Savolainen < petri.savolai...@linaro.org> wrote: > Add visibility markers to make inline offset table visible > applications linking against an installed copy of the library. > > Signed-off-by: Petri Savolainen > Reviewed-by: Bill Fischofer > --- > pla

Re: [lng-odp] [PATCH] test: bench_packet: add tests for reference functions

2017-03-13 Thread Bill Fischofer
This is a good start and I have no problem merging this as-is if we want to do this in stages, but I think a bit more is needed. For one, this is using a fixed offset for all references. I'd like to see references created with a couple of different offsets (e.g., 0 and packet_len/2) to get a better

Re: [lng-odp] Linking problem with --disable-abi-compat

2017-03-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill > Fischofer > Sent: Thursday, March 09, 2017 12:30 PM > To: Peltonen, Janne (Nokia - FI/Espoo) > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] Linking problem with --disable-abi-compat

[lng-odp] [PATCH] linux-gen: packet: make inline table visible

2017-03-13 Thread Petri Savolainen
Add visibility markers to make inline offset table visible applications linking against an installed copy of the library. Signed-off-by: Petri Savolainen --- platform/linux-generic/odp_packet.c | 4 1 file changed, 4 insertions(+) diff --git a/platform/linux-generic/odp_packet.c b/platfor

Re: [lng-odp] [PATCH] validation: packet: do not require a max packet length

2017-03-13 Thread Bill Fischofer
On Mon, Mar 13, 2017 at 9:41 AM, Krishna Garapati < balakrishna.garap...@linaro.org> wrote: > > > On 13 March 2017 at 15:02, Bill Fischofer > wrote: > >> Address bug https://bugs.linaro.org/show_bug.cgi?id=2908 by checking >> the pool capability max packet length and modifying the test in >> test

[lng-odp] [PATCH] test: bench_packet: add tests for reference functions

2017-03-13 Thread Matias Elo
Add microbenchmarks for the new packet reference functions. Signed-off-by: Matias Elo --- test/common_plat/performance/odp_bench_packet.c | 86 + 1 file changed, 86 insertions(+) diff --git a/test/common_plat/performance/odp_bench_packet.c b/test/common_plat/performance

Re: [lng-odp] [PATCH] validation: packet: do not require a max packet length

2017-03-13 Thread Krishna Garapati
On 13 March 2017 at 15:02, Bill Fischofer wrote: > Address bug https://bugs.linaro.org/show_bug.cgi?id=2908 by checking > the pool capability max packet length and modifying the test in > test_extend_ref() to account for implementations that do not limit > packet lengths. > > Signed-off-by: Bill

Re: [lng-odp] [PATCH] validation: packet: do not require a max packet length

2017-03-13 Thread Bala Manoharan
Reviewed-by: Balasubramanian Manoharan mailto:bala.manoha...@linaro.org>> > On 13-Mar-2017, at 7:32 PM, Bill Fischofer wrote: > > Address bug https://bugs.linaro.org/show_bug.cgi?id=2908 by checking > the pool capability max packet length and modifying the test in > test_extend_ref() to account

[lng-odp] [Bug 2908] Packet validation test fails if implementation does not limit packet length

2017-03-13 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2908 Bill Fischofer changed: What|Removed |Added Status|UNCONFIRMED |IN_PROGRESS Ever confirmed|0

[lng-odp] [PATCH] validation: packet: do not require a max packet length

2017-03-13 Thread Bill Fischofer
Address bug https://bugs.linaro.org/show_bug.cgi?id=2908 by checking the pool capability max packet length and modifying the test in test_extend_ref() to account for implementations that do not limit packet lengths. Signed-off-by: Bill Fischofer --- test/common_plat/validation/api/packet/packet.

[lng-odp] [Bug 2908] New: Packet validation test fails if implementation does not limit packet length

2017-03-13 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2908 Bug ID: 2908 Summary: Packet validation test fails if implementation does not limit packet length Product: OpenDataPlane - linux- generic reference Version: v1.14.0.0 Hardware: O

[lng-odp] Binaries removed from snapshots.linaro.org

2017-03-13 Thread Bogdan Pricope
Hi, For ofp-ci, I am using some snapshots binaries. For some reason, this one was removed last week. http://snapshots.linaro.org/debian/images/nano-x86/1/linaro-jessie-nano-20150123-1.tar.gz Please put it back. Thank you, Bogdan

[lng-odp] [PATCH v2] linux-generic: crypto: properly handle errors in packet copy

2017-03-13 Thread Dmitry Eremin-Solenikov
Add proper handling for errors returned by odp_packet_copy_from_pkt(). Signed-off-by: Dmitry Eremin-Solenikov --- platform/linux-generic/odp_crypto.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypt

Re: [lng-odp] [PATCH] linux-generic: crypto: properly handle errors in packet copy

2017-03-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Dmitry Eremin-Solenikov > Sent: Monday, March 06, 2017 5:37 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH] linux-generic: crypto: properly handle errors > in packet copy > > Add