Hi Alex,
I had the same thought while implementing this API.
The reason I decided to go ahead with getting mac address only though
odp_pktio_t is because if we have this API to get mac address directly with
the device name then the user can try to get mac address of a device even
without creating
Hi,
Few points from my side,
1. We are creating pktio and then assigning the created queue to the pktio.
IMO we should abstract the PKTIO, since it is up to the implementation to
either support IPC through dummy interface or shared memory. Lets say if an
implementation does IPC through shared
Thanks for bringing it up Mike. One queue per process is still kept as a
question in the document.
If we agree we need to update the document.
Regards,
Bala
On 26 August 2014 17:58, Mike Holmes mike.hol...@linaro.org wrote:
On 26 August 2014 08:21, Bala Manoharan bala.manoha...@linaro.org
Reviewed-by: Bala Manoharan bala.manoha...@linaro.org
On 26 August 2014 20:11, Taras Kondratiuk taras.kondrat...@linaro.org
wrote:
On 08/25/2014 11:47 PM, Robbie King wrote:
Hello all,
Here is the refactored IPsec example application.
V1: Changes from the existing github version
Hi,
IMO, the synchronization can be called by the application as if the
application does it then it can decide to call sync only when a thread
writes to the shared buffer. whereas if implementation has to do the sync
then it will have to call it every time before scheduler despatches the
buffer.
but not for ARMv8.
On platforms with HW queues, the ODP implementation probably has to
perform the barriers explicitly.
On 2 September 2014 17:09, Bala Manoharan bala.manoha...@linaro.org
wrote:
Hi,
IMO, the synchronization can be called by the application as if the
application does it then it can
] *On Behalf Of *ext Ola Liljedahl
*Sent:* Thursday, September 04, 2014 4:01 PM
*To:* Bala Manoharan; lng-odp@lists.linaro.org
*Subject:* Re: [lng-odp] [PATCH v3 1/1] API support for querying mac
address
I think the prototype should include the size of the buffer as well.
Other types of network
Hi Prashant,
The issue is due to not adding -march=octeon2 which needs to be added
into CFLAGS for compiling for Octeon.
Pls use the following steps for compilation
1. /*Update toolchain in shell PATH variable */
PATH=$toolchain_path/bin:$PATH
2. ./bootstrap
Hi Team,
We will have a Demo dry run on Wednesday afternoon after SC meeting.
Just to make sure things are fine :)
Regards,
Bala
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
Hi Mike,
I would not prefer LOG functions to call abort() on behalf of the
application, this design prevents the applications from calling its
specific clean-up code. coz applications can be written in a way in which
clean-up can be done in a single place at the end of the main function
combining
Yes. I would prefer ODP_ABORT(message) this call can be used by the
application so that there is no need to provide two separate calls for
ODP_ERR and abort().
Regards,
Bala
On 22 September 2014 09:14, Mike Holmes mike.hol...@linaro.org wrote:
On 22 September 2014 11:54, Bala Manoharan
Hi,
IMO, both are fine also I would like to see some guideline as to when to
use destroy and delete accordingly.
So if you create() an entity then its corresponding should be destroy() (ie
in case of BUFFER_POOL)
and if you alloc() an entity then its corresponding should be free() (i.e
in case
Hi,
Pls see my comments inline.
Regards,
Bala
On 6 October 2014 18:44, Anders Roxell anders.rox...@linaro.org wrote:
On 2014-10-06 15:52, Balasubramanian Manoharan wrote:
This patch provides API support for querying mac address using
odp_pktio_t handle.
This patch incorporates the changes
Hi Mike,
Comments inline.
Regards,
Bala
On 6 October 2014 23:34, Mike Holmes mike.hol...@linaro.org wrote:
On 6 October 2014 12:05, Balasubramanian Manoharan
bala.manoha...@linaro.org wrote:
This patch contains ODP Classification API Header Files.
The intent of this patch is to port
as a
separate discussion if required
* Should I add ODP_UNIMPLEMENTED as part of my current patch?
Regards,
Bala
On 7 October 2014 00:16, Mike Holmes mike.hol...@linaro.org wrote:
On 6 October 2014 14:33, Bala Manoharan bala.manoha...@linaro.org wrote:
Hi Mike,
Comments inline.
Regards
On 7 October 2014 12:43, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Balasubramanian Manoharan
Sent: Monday, October 06, 2014 7:16 PM
include/api-internal to move these items into?
-Petri
*From:* lng-odp-boun...@lists.linaro.org [mailto:
lng-odp-boun...@lists.linaro.org] *On Behalf Of *ext Bala Manoharan
*Sent:* Tuesday, October 07, 2014 8:41 PM
*To:* Bill Fischofer
*Cc:* lng-odp@lists.linaro.org
*Subject:* Re
is returned (e.g.
-1).
-- Ola
ETH_ALEN is 6. So looks like patch needed to be update.
Maxim.
On 8 October 2014 19:08, Maxim Uvarov maxim.uva...@linaro.org mailto:
maxim.uva...@linaro.org wrote:
On 10/07/2014 11:47 AM, Bala Manoharan wrote:
On 7 October 2014 12:43
Hi,
Pls find my comments inline.
Regards,
Bala
On 12 October 2014 23:06, Anders Roxell anders.rox...@linaro.org wrote:
Couple of nits see comments inline.
On 2014-10-07 21:45, Balasubramanian Manoharan wrote:
v2: This patch incorporates mike's review comments
This shouldn't be here
.
-Petri
*From:* lng-odp-boun...@lists.linaro.org [mailto:
lng-odp-boun...@lists.linaro.org] *On Behalf Of *ext Bala Manoharan
*Sent:* Friday, October 10, 2014 10:00 AM
*To:* Maxim Uvarov
*Cc:* lng-odp@lists.linaro.org
*Subject:* Re: [lng-odp] [ODP/PATCH v6] API support for querying mac
address
Hi,
We have followed the syntax of defining the opaque handles as typedefs
uint32_t (eg odp_cos_t ) and it seemed to create
a misunderstanding when defining odp_pmr_t and odp_pmr_set_t as structures
when the same are also opaque handles.
I believe this creates a uniform syntax across the whole
at 2:45 AM, Bala Manoharan bala.manoha...@linaro.org
wrote:
Hi,
We have followed the syntax of defining the opaque handles as typedefs
uint32_t (eg odp_cos_t ) and it seemed to create
a misunderstanding when defining odp_pmr_t and odp_pmr_set_t as
structures when the same are also opaque
, Bala Manoharan bala.manoha...@linaro.org
wrote:
Sounds Fair. Just a suggestion from my side should we replace typedef
... odp_objtype_t with typedef platform_handle odp_objtype_t. I am ok
with both approach whichever fits best.
Regards,
Bala
On 17 October 2014 15:50, Bill Fischofer
Yes. I will take this as part during the implementation patch.
We may need to fix the same for odp_queue.h and odp_packet_io.h files also.
Regards,
Bala
On 16 October 2014 23:15, Mike Holmes mike.hol...@linaro.org wrote:
On 16 October 2014 11:26, Balasubramanian Manoharan
Hi,
I have resent this patch with UTF-8 encoding.
Regards,
Bala
On 17 October 2014 16:50, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 10/16/2014 07:26 PM, Balasubramanian Manoharan wrote:
+ * @param[in] val_sz Size of the ‘val’ and ‘mask’ arguments,
+ * that must
...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of Ciprian Barbu
Sent: Tuesday, October 14, 2014 3:32 PM
To: Bala Manoharan
Cc: Savolainen, Petri (NSN - FI/Espoo); lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [ODP/PATCH v6] API support for querying mac
address
On Mon
Hi,
odp_packet_offset_map() API should be used generally if the application
wants to read a specific byte in a packet or
maybe to read any byte in a custom protocol.
odp_packet_l2_map() and odp_packet_l3_map() will be used to get the start
address of l2 and l3 layer.
Regards,
Bala
On 29
inlining?
On Fri, Oct 31, 2014 at 2:08 AM, Bala Manoharan
bala.manoha...@linaro.org wrote:
Hi Anders,
Yesterday in Scheduler meeting we had a discussion regarding moving
typedefs in ODP API files into a separate file.
Taras mentioned that you had previously spent some time on the same.
Can
Thanks Ciprian.
Regards,
Bala
On 19 November 2014 18:36, Ciprian Barbu ciprian.ba...@linaro.org wrote:
Hi,
I used this tool for sending packets in batch mode, used it during OVS
work.
Here is a link:
http://packeth.sourceforge.net/packeth/Home.html
I believe it's going to be really
On 21 November 2014 17:41, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 11/21/2014 11:53 AM, Balasubramanian Manoharan wrote:
+cos_t *pktio_select_cos(pktio_entry_t *entry, uint8_t *pkt_addr,
+ odp_packet_hdr_t *pkt_hdr)
+{
+ pmr_t *pmr;
+ cos_t *cos =
November 2014 18:18, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 11/21/2014 03:32 PM, Bala Manoharan wrote:
Hi Maxim,
Can we have those as separate patches.
I would like to keep this patch as specific for linking pktio with
classification.
I have created this patch from the current odp
Few points,
* Inorder to check ordered state of buffers from second queue they should
be dequeued by a single thread
as scheduler will despatch the buffers from ORDERED queue in initial order
but more than one thread can get the buffer from the same queue at the same
time.
Begards,
Bala
On 21
Hi,
The concern I had with the above testing scenario is that IMO this scenario
does not match perfectly with an application usecase. The testing for
ORDERED queue in my opinion could be,
1. Dequeue work W1-W10 from ORDERED queue Q1
2. Enqueue work W1-W5 to ORDERED queue Q2
3. Enqueue work
Yes. But for testing the basic pktio APIs which I believe is Maxim's
requirement it can be done using loopback interface (configuring a HW
interface as loop is an implementation detail) so that there is no need for
any HW configuration as such while running the validation suite.
Packet classifier
Hi Mike,
As you know these classification patches was submitted as being
interdependent on each other.
But sure I can redo this specific patch to be independently compilable unit.
Also it would be great if I could get review comments on classification
implementation patches so that I can fix any
wrote:
On 11/25/2014 12:34 AM, Mike Holmes wrote:
This no longer applies, can you rebase it ?
git am -3
helps?
On 21 November 2014 08:30, Bala Manoharan bala.manoha...@linaro.org
wrote:
Hi Maxim,
As discussed, as per the current API a pktio can exist without
Ping
On 26 November 2014 at 11:07, Bala Manoharan bala.manoha...@linaro.org
wrote:
Hi,
Pls let me know if there are any additional comments for this patch.
If otherwise please provide reviewed-by
Regards,
Bala
On 25 November 2014 03:24, Anders Roxell anders.rox...@linaro.org wrote
Hi,
I agree with Victor's concern, implementation needs a mechanism to know
what is the amount of valid memory available in the mac_addr pointer.
If I am not wrong the idea of defining the ODP_PKTIO_MAC_ADDR_MAX_LEN was
initially discussed but the same was dropped as there were concerns since
I have only a few minor comments for this patch.
One major query is that Currently this patch does not integrate
headroom/tailroom at segment level
is the feature available in 1.0?
if it is needed to be supported then we need some modifications in segment
handling.
Regards,
Bala
On Tue, Dec 02,
Hi,
In case of synchronous crypto operation the completion event is need only
in case of an error hence the application can check the return code for
failure and get info from completion event buffer only during that
scenario. This will greatly optimize the performance in synchronous crypto
On Wed, Dec 10, 2014 at 12:54:38PM +0200, Ciprian Barbu wrote:
On Tue, Dec 9, 2014 at 7:53 PM, Bill Fischofer
bill.fischo...@linaro.org wrote:
If you've already received the packet there's not much point in classifying
it since the output of classification is the queue that the packet should
From: Balasubramanian Manoharan bala.manoha...@linaro.org
Classification validation consists of two suites
* classification basic
This suite tests the basic classification APIs for creation and
deletion of various PMRs and CoS.
* classification test
This suite tests
From: Balasubramanian Manoharan bala.manoha...@linaro.org
odp_pmr_match_count() API related to statistics count of PMR has been moved out
of ODP 1.0
version and the same will be incorporated once an ODP level common statistics
counter design has
been achieved.
Signed-off-by: Balasubramanian
From: Balasubramanian Manoharan bala.manoha...@linaro.org
This validation consists of two suites
* classification basic
This suite tests the basic classification APIs for creation and
deletion of various PMRs and CoS.
* classification test
This suite tests behavious of
From: Balasubramanian Manoharan bala.manoha...@linaro.org
Fixes the error in vlan qos calculation due to missing convertion of
odp_be_to_cpu_16()
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
platform/linux-generic/odp_classification.c | 4 ++--
1 file changed, 2
From: Balasubramanian Manoharan bala.manoha...@linaro.org
Fixes an issue where ipv4 checksum field was not updated after modifying the src
addr of the packet.
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
test/validation/classification/odp_classification_tests.c | 10
Thanks Shmulik!
Reviewed-by: Bala Manoharan bala.manoha...@linaro.org
On 11 January 2015 at 23:02, Bill Fischofer bill.fischo...@linaro.org
wrote:
Thanks!
On Sun, Jan 11, 2015 at 4:15 AM, Shmulik Ladkani
shmulik.ladk...@gmail.com wrote:
ODP_{BIG,LITTLE}_ENDIAN_BITFIELD were always
This example has dependency with the following bug fix:
https://patches.linaro.org/46130/
Regards,
Bala
On 20 March 2015 at 12:37, bala.manoha...@linaro.org wrote:
From: Balasubramanian Manoharan bala.manoha...@linaro.org
ODP Classifier example
This programs gets pmr rules as command-line
From: Balasubramanian Manoharan bala.manoha...@linaro.org
Fix for incorrect pmr_term_value update in odp_pmr_create_match() and
odp_pmr_create_range() functions.
Fixes https://bugs.linaro.org/show_bug.cgi?id=1381
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
From: Balasubramanian Manoharan bala.manoha...@linaro.org
ODP Classifier example
This programs gets pmr rules as command-line parameter and configures the
classification engine
in the system.
This initial version supports the following
* ODP_PMR_SIP_ADDR pmr term
* PMR term MATCH and RANGE
Reviewed-by: Balasubramanian Manoharan bala.manoha...@linaro.org
On 10 March 2015 at 00:49, Mike Holmes mike.hol...@linaro.org wrote:
On 8 March 2015 at 18:52, Bill Fischofer bill.fischo...@linaro.org wrote:
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
For the series
On 11 March 2015 at 18:31, Ciprian Barbu ciprian.ba...@linaro.org wrote:
So after a little chat we had, Maxim suggested I remove the ioctl code
that needs struct ifreq. There is a USE_MAC_ADDR_HACK define in
odp_ipsec that is now set to 1, removing all that code should fix the
problem.
The
For this series.
Reviewed-by: Bala Manoharanbala.manoha...@linaro.org
On 20 March 2015 at 17:44, Jerin Jacob jerin.ja...@caviumnetworks.com wrote:
On Wed, Mar 18, 2015 at 11:29:03AM -0500, Bill Fischofer wrote:
Ping
This version looks good. For this series:
Reviewed-and-tested-by: Bill
From: Balasubramanian Manoharan bala.manoha...@linaro.org
Fix for incorrect pmr_term_value update in odp_pmr_create_match() and
odp_pmr_create_range() functions.
Fixes https://bugs.linaro.org/show_bug.cgi?id=1381
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
v2: Fixes
Hi,
Since we have the concept of a default CoS in classification, why cant
we associate the above APIs to default CoS, in that way we can avoid
linking this hash function directly to pktio.
coz there comes a discrepancy now as to what happens when both this
API and classification are configured
From: Balasubramanian Manoharan bala.manoha...@linaro.org
Destroys pktio default inqueue for a clean odp_classification_term_global()
Fixes https://bugs.linaro.org/show_bug.cgi?id=1281
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
From: Balasubramanian Manoharan bala.manoha...@linaro.org
odp_pktio_skip_set() value is reset to zero as the validation suite expects
the skip value to be zero.
Fixes https://bugs.linaro.org/show_bug.cgi?id=1230
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
From: Balasubramanian Manoharan bala.manoha...@linaro.org
Fix for return value checking of odp_pool_destroy() function reported by
Coverity.
https://bugs.linaro.org/show_bug.cgi?id=1142
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
From: Balasubramanian Manoharan bala.manoha...@linaro.org
Fixes uninitialized scalar variable qos_tbl in configure_cos_with_l2_priority()
function reported by Coverity.
https://bugs.linaro.org/show_bug.cgi?id=1143
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
From: Balasubramanian Manoharan bala.manoha...@linaro.org
Fixes an issue where ipv4 checksum field was not updated after modifying the src
addr of the packet.
https://bugs.linaro.org/show_bug.cgi?id=1231
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
v2: updates review
On 26 February 2015 at 03:43, Anders Roxell anders.rox...@linaro.org wrote:
why does it say linux-generic: classification: ...
should say: api: classification: ...
This is not an api change just adds documentation for PMR_INVAL and
PMR_SET_INVAL macros
Not sure if this should be also api:
On 26 February 2015 at 03:40, Mike Holmes mike.hol...@linaro.org wrote:
Why is this merged - I have undressed comments ?
/**
+ * @def ODP_PMR_INVAL
+ * Invalid odp_pmr_t value.
+ * This value is returned from odp_pmr_create_match() and
+ * odp_pmr_create_range() functions on failure.
From: Balasubramanian Manoharan bala.manoha...@linaro.org
odp_pmr_match_count() API related to statistics count of PMR has been moved out
of ODP 1.0
version and the same will be incorporated once an ODP level common statistics
counter design has
been achieved.
Signed-off-by: Balasubramanian
On 3 April 2015 at 22:00, Taras Kondratiuk taras.kondrat...@linaro.org wrote:
On 03/30/2015 03:34 PM, Zhujianhua wrote:
@ Jerin Jacob:
What will happen if odp_cos_set_pool(odp_cos_t cos_id, odp_buffer_pool_t
pool_id) was called twice?
Will the new pool_id replace the old one or the CoS have
On 21 April 2015 at 16:57, Maxim Uvarov maxim.uva...@linaro.org wrote:
Bala, one more comment. Please do parsing arguments before odp init.
About this code Mike found that it will be abort if you do not run it under
root due to
unable do raw socket operations.
pktio =
On 21 April 2015 at 18:15, Ola Liljedahl ola.liljed...@linaro.org wrote:
On 21 April 2015 at 14:26, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 04/21/15 15:01, Bill Fischofer wrote:
Behavior is undefined if rules are ambiguous. Consider the following
rules:
protocol == UDP -- CoS A
On 21 April 2015 at 16:57, Maxim Uvarov maxim.uva...@linaro.org wrote:
Bala, one more comment. Please do parsing arguments before odp init.
Sorry missed this comment. parsing argument uses odp shared memory and
we cannot call it before odp init() function.
Regards,
Bala
About this code Mike
From: Balasubramanian Manoharan bala.manoha...@linaro.org
ODP Classifier example
This programs gets pmr rules as command-line parameter and configures the
classification engine
in the system.
This initial version supports the following
* ODP_PMR_SIP_ADDR pmr term
* PMR term MATCH and RANGE
On 23 April 2015 at 16:56, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 04/23/15 13:09, Taras Kondratiuk wrote:
On 04/22/2015 08:54 PM, Maxim Uvarov wrote:
On 04/22/15 19:06, Ciprian Barbu wrote:
On Wed, Apr 22, 2015 at 5:13 PM, Maxim Uvarov
maxim.uva...@linaro.org wrote:
On 04/22/15
Reviewed-by: Balasubramanian Manoharan bala.manoha...@linaro.org
On 24 April 2015 at 19:23, Nicolas Morey-Chaisemartin nmo...@kalray.eu wrote:
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
---
test/validation/classification/odp_classification_tests.c | 1 +
1 file changed, 1
Reviewed-by: Balasubramanian Manoharan bala.manoha...@linaro.org
On 24 April 2015 at 19:23, Nicolas Morey-Chaisemartin nmo...@kalray.eu wrote:
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
---
platform/linux-generic/odp_packet_io.c | 2 ++
1 file changed, 2 insertions(+)
diff
() */
};
};
} odp_packet_parse_flags_t;
Regards,
Bala
On 29 April 2015 at 12:46, Bala Manoharan bala.manoha...@linaro.org wrote:
Hi,
We can optimize the odp_packet_parse_flags_t in the following way to
handle the layered approach for parsing
+typedef struct odp_packet_parse_flags_t {
+ uint32_t eth:1
From: Balasubramanian Manoharan bala.manoha...@linaro.org
This patch removes support for odp_pmr_create_range() function
in the classifier example application.
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
example/classifier/odp_classifier.c | 106
Hi,
We can optimize the odp_packet_parse_flags_t in the following way to
handle the layered approach for parsing
+typedef struct odp_packet_parse_flags_t {
+ uint32_t eth:1; /** See odp_packet_has_eth() */
+ uint32_t jumbo:1; /** See odp_packet_has_jumbo() */
+
one way or another.
-Petri
-Original Message-
From: ext Bala Manoharan [mailto:bala.manoha...@linaro.org]
Sent: Wednesday, April 29, 2015 10:25 AM
To: Savolainen, Petri (Nokia - FI/Espoo)
Cc: ext Zoltan Kiss; lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCH API-NEXT 4/5] api
Hi,
Cos configured using PMR takes precedence over CoS configured using L2 and
L3 priority and QoS values.
Among L2 and L3 values, odp_cos_with_l3_qos() function contains a boolean
L3_precedence which indicates whether L2 or L3 priority value takes
precedence.
Hope this helps,
Bala
On 6 May
Reviewed-by: Balasubramanian Manoharan bala.manoha...@linaro.org
IMO, we can add additional information in odph_linux_pthread_create()
header file documentation that this function is expected to call
odp_init_local() for the thread it creates. Current documentation only says
the following
/**
*
it cannot guarantee
the ingress order preservation if incoming packets are picked up by
different cores and submitted to seq number queue in different order.
Regards
Nikhil
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bala
Manoharan
Sent: Tuesday, May 12, 2015 5
Hi,
These APIs are in the list of changes required for classification and
will be introduced in the next version of ODP.
Regards,
Bala
On 13 May 2015 at 15:12, Agrawal Hemant hem...@freescale.com wrote:
HI,
What is the plan to re-introduce the flow signature based
distribution APIs
Reviewed-by: Balasubramanian Manoharan bala.manoha...@linaro.org
On 15 May 2015 at 02:53, Mike Holmes mike.hol...@linaro.org wrote:
fixes https://bugs.linaro.org/show_bug.cgi?id=1534
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
The case sudo ./example/classifier/odp_classifier -i
On 12 May 2015 at 18:06, Ola Liljedahl ola.liljed...@linaro.org wrote:
On 12 May 2015 at 14:28, Bala Manoharan bala.manoha...@linaro.org wrote:
IMO, using atomic variable instead of atomic queues will work for this Ipsec
example use-case as in this case the critical section is required only
IMO, using atomic variable instead of atomic queues will work for this
Ipsec example use-case as in this case the critical section is required
only for updating the sequence number but in a generic use-case the
atomicity should be protected over a region of code which the application
wants to be
From: Balasubramanian Manoharan bala.manoha...@linaro.org
ODP Classifier example
This programs gets pmr rules as command-line parameter and configures the
classification engine
in the system.
This initial version supports the following
* ODP_PMR_SIP_ADDR pmr term
* PMR term MATCH and RANGE
I would like to get application use-case for different scenarios where
this would be useful before finalizing pool groups and their API
signature.
Also in the above proposal it is not possible to combine multiple
pools to form a pool group, I like this idea as it gives freedom for
implementation
From: Balasubramanian Manoharan bala.manoha...@linaro.org
ODP Classifier example
This programs gets pmr rules as command-line parameter and configures the
classification engine
in the system.
This initial version supports the following
* ODP_PMR_SIP_ADDR pmr term
* PMR term MATCH and RANGE
On 9 April 2015 at 14:38, Taras Kondratiuk taras.kondrat...@linaro.org wrote:
+ mailing list that I've missed initially in the RFC.
On 04/08/2015 10:25 PM, Rosenboim, Leonid wrote:
Taras,
I actually agree with you that a change in the API is justified
that combines the in and out CoS
Reviewed-by: Balasubramanian Manoharan bala.manoha...@linaro.org
On 2 June 2015 at 20:16, Maxim Uvarov maxim.uva...@linaro.org wrote:
packet i/o test can create 2 types of queues: scheduled and
polled. Do not do dequeue from scheduled queue.
https://bugs.linaro.org/show_bug.cgi?id=1383
From: Balasubramanian Manoharan bala.manoha...@linaro.org
This is a vlan priority based L2 loopback application which creates
multiple packet output queues for each vlan priority value and attaches
them to the given pktio interface.
The packets are enqueued into different packet output queues
From: Balasubramanian Manoharan bala.manoha...@linaro.org
This is linux-generic implementation of egress classification.
This is a lock-less implementation for output packet scheduling, shaping
and rate limitting.
Multiple packet output queues with different priority values can be created
and
Reviewed-by: Balasubramanian Manoharan bala.manoha...@linaro.org
On 10 June 2015 at 17:36, Nicolas Morey-Chaisemartin nmo...@kalray.eu
wrote:
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
---
example/classifier/odp_classifier.c | 6 --
1 file changed, 4 insertions(+), 2
Hi,
There is a possibility in classification configuration to attach multiple
PMR rules at the pktio level.
I believe the above example you have described could be solved using the
following rules
pmr1 = odp_pmr_create(rule1);
pmr2 = odp_pmr_create(rule2);
odp_pktio_pmr_match_set_cos(pmr1,
On 25 June 2015 at 02:48, Ivan Khoronzhuk ivan.khoronz...@linaro.org
wrote:
On 24.06.15 19:57, Bala Manoharan wrote:
Hi Ivan,
Pls see my comments inline.
On 24 June 2015 at 09:13, Ivan Khoronzhuk ivan.khoronz...@linaro.org
mailto:ivan.khoronz...@linaro.org wrote:
Guys, sorry I
From: Balasubramanian Manoharan bala.manoha...@linaro.org
This is a UDP source port based loopback application which creates
multiple packet output queues for given UDP port numbers and attaches
them to the given pktio interface. The default packet are enqueued into the
lowest priority value.
Hi Ivan,
Pls see my comments inline.
On 24 June 2015 at 09:13, Ivan Khoronzhuk ivan.khoronz...@linaro.org
wrote:
Guys, sorry I didn't ask the following questions during the ODP meeting.
I had an issue with my microphone and it seems the call was ended quickly.
But I need to ask. Maybe it's
We need the fix for IP address also in the same function as the src and dst
ip address are also kept as zero.
Regards,
Bala
On 10 June 2015 at 20:55, Maxim Uvarov maxim.uva...@linaro.org wrote:
I always fix that for debugging :)
Maxim.
On 06/10/15 18:00, Stuart Haslam wrote:
The test
: genis.riera.pe...@gmail.com
2015-06-10 15:25 GMT+02:00 Bala Manoharan bala.manoha...@linaro.org:
Hi,
There is a possibility in classification configuration to attach multiple
PMR rules at the pktio level.
I believe the above example you have described could be solved using the
following
On 27 May 2015 at 14:04, Ola Liljedahl ola.liljed...@linaro.org wrote:
On 27 May 2015 at 08:00, Bala Manoharan bala.manoha...@linaro.org wrote:
Hi,
On 26 May 2015 at 20:14, Zoltan Kiss zoltan.k...@linaro.org wrote:
On 26/05/15 12:19, Bala Manoharan wrote:
In the current API
Hi,
Yes. Lookback interface should behave like other interfaces in the
system and classification rules if set should get applied.
Regards,
Bala
On 28 May 2015 at 14:51, Ola Liljedahl ola.liljed...@linaro.org wrote:
Is the loopback interface supposed to be supported in all ODP
implementations?
Subject: RE: [lng-odp] [PATCH 1/3] example: classifier: remove extra local init
To: ext Bala Manoharan bala.manoha...@linaro.org
Cc: LNG ODP Mailman List lng-odp@lists.linaro.org
I noticed the same and will add that documentation.
-Petri
From: ext Bala Manoharan [mailto:bala.manoha
Yes. I am also searching this patch in the repo.
Looks like the patch from Petri has been missed.
Regards,
Bala
On 28 May 2015 at 18:31, Savolainen, Petri (Nokia - FI/Espoo)
petri.savolai...@nokia.com wrote:
I send a patch that corrected this, but not sure what happened to it.
-Petri
1 - 100 of 460 matches
Mail list logo
