[lng-odp] [RFC] api: init: add ODP_PRINTF_FORMAT to odp_log_func_t

Hint compiler that the odp_log_func_t (and as a result all of ODP_ABORT/_LOG/_ERR/etc) expects a format and a set of arguments. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- Currently this patch results in huuuge number of errors from all over the ODP sour

Re: [lng-odp] [API-NEXT 1/3] api: hints: rework ODP_DEPRECATED API

On 07.03.2017 14:52, Dmitry Eremin-Solenikov wrote: > diff --git a/include/odp/api/spec/hints.h b/include/odp/api/spec/hints.h > index 82400f07..3b70db6f 100644 > --- a/include/odp/api/spec/hints.h > +++ b/include/odp/api/spec/hints.h > @@ -54,7 +54,20 @@ extern "C"

[lng-odp] [API-NEXT 0/8] crypto rework and support for SHA-1/-512

api-next, because it implements sha-1/512 (and supporting those algorithms was one of main reasons for rewriting auth code). However the rest of the patchset should be applicable to master branch. Dmitry Eremin-Solenikov (8): validation: crypto: add tests for checking message digests

[lng-odp] [API-NEXT 1/8] validation: crypto: add tests for checking message digests

Currently ODP testsuite only verifies generation of digests. Let's also verify that checking the digest actually works. Test that check function will accept valid digest and that it will reject wrong digests. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> ---

[lng-odp] [API-NEXT 2/8] validation: crypto: correct comment for HMAC-SHA-256 tests

Comment for HMAC-SHA-256 tests talks about HMAC-MD5 and respective lengths. Correct it to mention SHA-256 and proper digest lengths. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- test/common_plat/validation/api/crypto/odp_crypto_test_inp.c | 4 ++--

[lng-odp] [API-NEXT 4/8] validation: crypto: add HMAC-SHA-512 test cases

Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../validation/api/crypto/odp_crypto_test_inp.c| 97 +- .../validation/api/crypto/test_vectors.h | 50 +++ .../validation/api/crypto/test_vectors_len.h | 6 ++ 3

[lng-odp] [API-NEXT 7/8] linux-generic: crypto: add SHA-1 authentication support

Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index 5078a3b1..ef

[lng-odp] [API-NEXT 6/8] linux-generic: crypto: switch to EVP interface for cipher algorithms

if there will be more AEAD ciphers. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../linux-generic/include/odp_crypto_internal.h| 14 +- platform/linux-generic/odp_crypto.c| 211 + 2 files changed, 49 insertions(+

[lng-odp] [API-NEXT 8/8] linux-generic: crypto: add HMAC-SHA-512 authentication support

Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index ef79d6f6..0f

[lng-odp] [API-NEXT 5/8] linux-generic: crypto: unify auth code

Authentication code contains similar functions. Instead of replicating them further (e.g. for SHA-1 or SHA-3) factor out common code blocks, moving all difference to session data. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../linux-generic/i

[lng-odp] odp_ipsec_result behaviour

Hello, I was hunting last issues in my IPsec patchset. And suddently I was hit by the fact that I do not fully understand semantics around odp_ipsec_result() function. So here comes several questions: 1) Is is correct, that I have to free the event manually even after the successful return from

Re: [lng-odp] odp_ipsec_result behaviour

On 03.04.2017 23:13, Bill Fischofer wrote: > On Mon, Apr 3, 2017 at 2:48 PM, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org> wrote: >> Hello, >> >> I was hunting last issues in my IPsec patchset. And suddently I was hit >> by the fact that I do n

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

On 05.04.2017 02:31, Ola Liljedahl wrote: > On 05/04/2017, 01:25, "Dmitry Eremin-Solenikov" > <dmitry.ereminsoleni...@linaro.org> wrote: >> On 04.04.2017 23:52, Ola Liljedahl wrote: >>> Sending from my ARM email account, I hope Outlook does not mess up the >

Re: [lng-odp] [PATCH v2] fix native Clang build on ARMv8

On 06.04.2017 20:25, Brian Brooks wrote: > See [1] for details. > > [1] https://lists.linaro.org/pipermail/lng-odp/2017-April/029684.html Brian, not that this is a good long description of the commit. I'd still suggest to just change the line setting CFLAGS from just -mcx16 to -mcx16 -Werror.

Re: [lng-odp] [API-NEXT v3] api: ipsec: factor out definitions for feature support levels

On 17.04.2017 18:13, Maxim Uvarov wrote: > make distcheck fails: > > > In file included from > ../../../platform/linux-generic/include/protocols/ip.h:20:0, > > from > ../../../platform/linux-generic/include/odp_classification_datamodel.h:28, > > from >

[lng-odp] [API-NEXT v4] api: ipsec: factor out definitions for feature support levels

Instead of having magic 0-1-2 numbers, let's have the special enum for feature support levels (unsupported/supported/preferred). Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- include/odp/api/spec/feature.h | 53 i

[lng-odp] [PATCH 4/4] linux-generic: crypto: switch to EVP interface for cipher algorithms

if there will be more AEAD ciphers. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../linux-generic/include/odp_crypto_internal.h| 16 +- platform/linux-generic/odp_crypto.c| 232 + 2 files changed, 52 insertions(+

[lng-odp] [PATCH 1/4] validation: crypto: add tests for checking message digests

Currently ODP testsuite only verifies generation of digests. Let's also verify that checking the digest actually works. Test that check function will accept valid digest and that it will reject wrong digests. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> ---

[lng-odp] [PATCH 2/4] validation: crypto: correct comment for HMAC-SHA-256 tests

Comment for HMAC-SHA-256 tests talks about HMAC-MD5 and respective lengths. Correct it to mention SHA-256 and proper digest lengths. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- test/common_plat/validation/api/crypto/odp_crypto_test_inp.c | 4 ++--

[lng-odp] [PATCH 3/4] linux-generic: crypto: unify auth code

Authentication code contains similar functions. Instead of replicating them further (e.g. for SHA-1 or SHA-3) factor out common code blocks, moving all difference to session data. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../linux-generic/i

[lng-odp] [PATCH 0/4] crypto: rework implementation of encryption and auth code

and auth code. Dmitry Eremin-Solenikov (4): validation: crypto: add tests for checking message digests validation: crypto: correct comment for HMAC-SHA-256 tests linux-generic: crypto: unify auth code linux-generic: crypto: switch to EVP interface for cipher algorithms .../linux-generic

Re: [lng-odp] Regarding github pull request

On 02/08/17 13:56, shally verma wrote: > On Wed, Aug 2, 2017 at 4:15 PM, Maxim Uvarov wrote: >> >> >> On 2 August 2017 at 13:35, shally verma wrote: >>> >>> Hi >>> >>> Based on discussion in yesterday's odp public call, I was trying to >>>

Re: [lng-odp] [PATCH API-NEXT v1 1/1] api:pktio: add MAC address and MTU set functions.

On 02/08/17 10:03, Maxim Uvarov wrote: > On 2 August 2017 at 09:03, shally verma wrote: > >> Shally - One summary to address all responses around output parameter >> "status". >> >> Consider following use case: >> user added mac addresses @ index 0, 1, 2, 3, 4 >>

Re: [lng-odp] [PATCH API-NEXT v1 1/1] api:pktio: add MAC address and MTU set functions.

On 02/08/17 09:03, shally verma wrote: > On Wed, Aug 2, 2017 at 1:39 AM, Maxim Uvarov wrote: >> On 08/01/17 15:02, Bill Fischofer wrote: int odp_pktio_mac_addr(odp_pktio_t pktio, void *mac_addr, int size); /** + * Set the default MAC address of a

Re: [lng-odp] Regarding github pull request

On 2 August 2017 at 15:18, shally verma <shallyvermacav...@gmail.com> wrote: > On Wed, Aug 2, 2017 at 4:37 PM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: >> >> >> On 2 August 2017 at 14:05, Dmitry Eremin-Solenikov >> <dmitry.ereminsoleni...@linaro.org

Re: [lng-odp] [API-NEXT PATCH 1/9] api: ipsec: add salt parameter

On 11.07.2017 15:31, Petri Savolainen wrote: > Added a parameter for passing salt for AES GCM. Currently, > only option for length is 4 bytes, but later on other algorithms > may need more/less salt data. > > Signed-off-by: Petri Savolainen > --- >

Re: [lng-odp] [API-NEXT PATCH 1/9] api: ipsec: add salt parameter

Except the suggestion for PATCH 1/9, the rest of the patches is Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> -- With best wishes Dmitry

Re: [lng-odp] [PATCH API-NEXT v2 0/4] Crypto API updates

On 13.07.2017 23:51, Maxim Uvarov wrote: > On 07/13/17 13:59, Savolainen, Petri (Nokia - FI/Espoo) wrote: >> Dmitry, Maxim, >> >> I think it's OK to merge v1 of this ASAP since it fixes e.g. api-next build >> break. I did send my review yesterday. V2 just adds 4/4 patch on top. >> >> -Petri >> >>

Re: [lng-odp] [API-NEXT PATCH] api: ipsec: add warning status event

; > Signed-off-by: Petri Savolainen <petri.savolai...@linaro.org> Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> Ideally we can have a config option to enable/disable sending such events in ASYNC or even SYNC mode. > --- >

Re: [lng-odp] [PATCH API-NEXT v4 0/2] event subtype implementation

Maxim, Since Crypto patchset takes longer to get in than we expected, maybe we can merge just event subtypes for now? On 04.07.2017 15:54, Dmitry Eremin-Solenikov wrote: > These patches provide event subtype implementation and tests. V3 was: > > Reviewed-by: Petri Savolainen <p

Re: [lng-odp] [PATCH API-NEXT v3 1/3] api: ipsec: pass OUT_INLINE outer headers as const

On 11.07.2017 16:38, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > This change is included in my latest IPsec API patch set. Sure. I will drop it from this patchset as soon as yours gets applied. -- With best wishes Dmitry

Re: [lng-odp] [PATCH API-NEXT v8 6/10] api: crypto: add crypto packet operation interface

On 11.07.2017 16:35, Savolainen, Petri (Nokia - FI/Espoo) wrote: > >> diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h >> index 454855ea..27b12c89 100644 >> --- a/include/odp/api/spec/crypto.h >> +++ b/include/odp/api/spec/crypto.h >> @@ -16,6 +16,7 @@ >> #include >>

Re: [lng-odp] [API-NEXT PATCH v2 1/9] api: ipsec: add salt parameter

On 12.07.2017 15:56, Petri Savolainen wrote: > Added a parameter for passing salt/nonce for algorithms that > need it. Currently, only AES GCM needs it with 4 bytes of > salt. Later on, other cipher or auth algorithms may need > also salt/nonce data. > > Signed-off-by: Petri Savolainen

Re: [lng-odp] [PATCH API-NEXT v4 1/1] api: ipsec: add retain header capability

On 13.07.2017 12:00, Github ODP bot wrote: > From: Nikhil Agarwal <nikhil.agar...@linaro.org> > > Signed-off-by: Nikhil Agarwal <nikhil.agar...@linaro.org> Reviewed-by: Dmitry Eremin-Solenikov > --- > /** Email created from pull request 75 (NikhilA-Linaro:ipsec_ap

Re: [lng-odp] [PATCH API-NEXT v2 4/4] api: crypto: revert deprecation of crypto completion API

] On Behalf Of >>> Github ODP bot >>> Sent: Wednesday, July 12, 2017 5:00 PM >>> To: lng-odp@lists.linaro.org >>> Subject: [lng-odp] [PATCH API-NEXT v2 4/4] api: crypto: revert deprecation >>> of crypto completion API >>> >>> From: Dmitry

Re: [lng-odp] [API-NEXT PATCH v3 1/9] api: ipsec: add salt parameter

: Petri Savolainen <petri.savolai...@linaro.org> Whole series: Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> -- With best wishes Dmitry

Re: [lng-odp] [PATCH v2 1/3] example: ipfragaddress: fix compilation with clang

On 08.07.2017 00:16, Brian Brooks wrote: > On 07/12 16:00:04, Github ODP bot wrote: >> From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> >> >> Clang 3.8 is stricter than GCC wrt register allocation vs 128-bit >> variables. Sometimes it can not unde

Re: [lng-odp] [PATCH API-NEXT v3 1/1] linux-gen: pktio: loop: reset packet subtype on loopback

On 18.07.2017 00:38, Maxim Uvarov wrote: > On 07/12/17 12:00, Github ODP bot wrote: >> From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> >> >> loop interface can get any kind of packets, but should output only basic >> packets. Reset packet subt

Re: [lng-odp] Issues with scalable scheduler

gt; Is not reproducible locally? > > > On 25 July 2017 at 10:01, Dmitry Eremin-Solenikov < > dmitry.ereminsoleni...@linaro.org > <mailto:dmitry.ereminsoleni...@linaro.org>> wrote: > > > Hello colleagues, > > > > While wor

Re: [lng-odp] Issues with scalable scheduler

t; Kevin > > 2017-07-25 19:49 GMT+08:00 Bill Fischofer <bill.fischo...@linaro.org>: >> >> Please open a bug to track this. Great to find this. >> >> On Tue, Jul 25, 2017 at 4:45 AM, Dmitry Eremin-Solenikov >> <dmitry.ereminsoleni...@linaro.org> wrot

Re: [lng-odp] merge master to api-next

On 26/07/17 01:00, Maxim Uvarov wrote: > Merge request is: > > https://github.com/Linaro/odp/pull/71 > > 2 arm build fails with errors. Both are due to scalable scheduler code. > > 1. > > https://travis-ci.org/muvarov/odp/jobs/257478037 > CC odp_rwlock.lo > :1:2: error: instruction

Re: [lng-odp] merge master to api-next

Brian, On 20 July 2017 at 00:23, Brian Brooks <brian.bro...@arm.com> wrote: > On 07/26 10:29:41, Dmitry Eremin-Solenikov wrote: >> On 26/07/17 01:00, Maxim Uvarov wrote: >> > Merge request is: >> > >> > https://github.com/Linaro/odp/pull/71 >>

Re: [lng-odp] merge master to api-next

e also. > > On Wed, Jul 26, 2017 at 1:55 PM, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org > <mailto:dmitry.ereminsoleni...@linaro.org>> wrote: > > Brian, > > > On 20 July 2017 at 00:23, Brian Brooks <brian.bro...@arm.com > <ma

[lng-odp] Issues with scalable scheduler

Hello colleagues, While working on the IPsec testsuite, I detected strange issue. My testsuite works w/o issues using old queue/scheduler implementations but will hang when used with '--enable-schedule-scalable'. I'm trying to get more data from the system, for now you can see the situation at

Re: [lng-odp] [PATCH API-NEXT v9 6/10] api: crypto: add crypto packet operation interface

On 24/07/17 15:12, shally verma wrote: > On Mon, Jul 24, 2017 at 5:27 PM, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org> wrote: >> On 24/07/17 14:11, shally verma wrote: >>> On Tue, Jul 11, 2017 at 7:30 PM, Github ODP bot <odp...@yandex.ru> wrote: &

Re: [lng-odp] [PATCH API-NEXT v9 6/10] api: crypto: add crypto packet operation interface

On 24/07/17 15:28, shally verma wrote: > On Mon, Jul 24, 2017 at 5:55 PM, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org> wrote: >> On 24/07/17 15:12, shally verma wrote: >>> On Mon, Jul 24, 2017 at 5:27 PM, Dmitry Eremin-Solenikov >>> <d

Re: [lng-odp] [PATCH API-NEXT v9 6/10] api: crypto: add crypto packet operation interface

On 24/07/17 14:11, shally verma wrote: > On Tue, Jul 11, 2017 at 7:30 PM, Github ODP bot <odp...@yandex.ru> wrote: >> From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> >> @@ -311,16 +315,15 @@ typedef struct odp_crypto_session_param_t { >> >

[lng-odp] [RFC API-NEXT v2] api: crypto: add crypto packet operation interface

from ODP_EVENT_CRYPTO_COMPL to ODP_EVENT_PACKET. Event subtype (ODP_EVENT_PACKET_CRYPTO) can be used to identify packets with crypto metadata. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- Changes since v1: - Do not remove original crypto API oriented onto

Re: [lng-odp] [PATCH v4 3/9] linux-gen: stop poisoning CPPFLAGS/LDFLAGS with DPDK flags

On 03.07.2017 13:34, Savolainen, Petri (Nokia - FI/Espoo) wrote: >> diff --git a/test/Makefile.inc b/test/Makefile.inc >> index 1ef2a92c..bf31b374 100644 >> --- a/test/Makefile.inc >> +++ b/test/Makefile.inc >> @@ -4,7 +4,7 @@ LIB = $(top_builddir)/lib >> #in the following line, the libs using

Re: [lng-odp] [PATCH API-NEXT v5 6/10] api: crypto: add crypto packet operation interface

Petri, Thank you for the review! I corrected some of the issues you pointed. For the rest (packet_op_mode, odp_crypto_packet_op()/odp_crypto_packet_op_enq()) I would like to keep them as is, as this shows tighter connection between API. If you'd absolutely insist on that, I can remove _packet_

[lng-odp] [PATCH API-NEXT v4 1/2] linux-generic: events subtype implementation

Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/include/odp_buffer_inlines.h | 2 ++ platform/linux-generic/include/odp_buffer_internal.h | 3 +++ platform/linux-generic/odp_crypto.c | 15 +-- platform

[lng-odp] [PATCH API-NEXT v4 0/2] event subtype implementation

ubtype Changes since v1: - Implement odp_event_types() - Update event subtype properly in odp_crypto.c Dmitry Eremin-Solenikov (2): linux-generic: events subtype implementation validation: test correctness of events subtype implementation .../linux-generic/include/odp_buffer_inlines.h

Re: [lng-odp] [PATCH v4 3/9] linux-gen: stop poisoning CPPFLAGS/LDFLAGS with DPDK flags

On 04.07.2017 16:43, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message----- >> From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] >> Sent: Tuesday, July 04, 2017 3:16 PM >> To: Savolainen, Petri (Nokia - FI/Espo

Re: [lng-odp] travis image update debug issues

On 04.07.2017 18:12, Maxim Uvarov wrote: > Hello, > > I have ssh to travis machines for some limited time to debug what is > wrong with pktio tap test after image update. > > I wrote more detail information here: > https://bugs.linaro.org/show_bug.cgi?id=3099 > > In few words packets do not go

Re: [lng-odp] [PATCH CLOUD-DEV v1] [RFC 1/2] odp: add modular framework

On 03.07.2017 11:00, Github ODP bot wrote: > From: Yi He > > Add modular programming framework to support runtime selectable > implementations for variant software subsystems. > > Signed-off-by: Yi He > --- > /** Email created from pull request 65

Re: [lng-odp] [PATCH v4 3/9] linux-gen: stop poisoning CPPFLAGS/LDFLAGS with DPDK flags

On 03.07.2017 13:34, Savolainen, Petri (Nokia - FI/Espoo) wrote: >> diff --git a/test/Makefile.inc b/test/Makefile.inc >> index 1ef2a92c..bf31b374 100644 >> --- a/test/Makefile.inc >> +++ b/test/Makefile.inc >> @@ -4,7 +4,7 @@ LIB = $(top_builddir)/lib >> #in the following line, the libs using

Re: [lng-odp] [PATCH API-NEXT v3 0/2] event subtype implementation

On 16.06.2017 14:48, Dmitry Eremin-Solenikov wrote: > Applies on top of [API-NEXT PATCH v2 0/3] IPSEC packet event > > These patches provide event subtype implementation and tests. Ideally they > should be merged together with event subtypes API definitions. > > Changes since

Re: [lng-odp] [PATCH v1 2/2] travis: add cross-compilation checks

On 27.06.2017 18:51, Maxim Uvarov wrote: > On 06/27/17 16:17, Dmitry Eremin-Solenikov wrote: >> On 27.06.2017 16:15, Maxim Uvarov wrote: >>> On 06/27/17 16:00, Github ODP bot wrote: >>>> + - env echo -e 'Provides\x3a multiarch-support, >

Re: [lng-odp] [Linaro/odp] Zeroing packet data (#18)

Maxim, On 26.04.2017 17:02, muvarov wrote: > From: Github ODP bot > From: Dmitry Eremin-Solenikov > > Check that odp_packet_zero_data() works with single-segment packets and > with segmented packets. > > Signed-off-by: Dmitry Eremin-Solenikov Can we somehow preve

Re: [lng-odp] [Linaro/odp] Zeroing packet data (#18)

On 26.04.2017 17:06, Codecov wrote: > Impacted Files > Coverage Δ > test/common_plat/validation/api/packet/packet.c >

Re: [lng-odp] [PATCH] linux-generic: rwlock: fix odp_rwlock_read_trylock()

On 26.04.2017 20:54, Peltonen, Janne (Nokia - FI/Espoo) wrote: > > That does not work. Since the value of cnt is not checked, the code > would happily take the lock even when a writer already has it. Nice catch. Updated to check for writers. -- With best wishes Dmitry

Re: [lng-odp] [PATCH 4/4] linux-generic: crypto: switch to EVP interface for cipher algorithms

On 25.04.2017 04:41, Dmitry Eremin-Solenikov wrote: > Switch AES-CBC and 3DES-CBC to use generic (EVP) interface instad of low > level interface (as recommended by OpenSSL documentation). This allows > to use the same code path for all non-AEAD ciphers. The only AEAD cipher > (AES-

[lng-odp] [[RFCv2] 3/4] api: ipsec: change semantics of odp_ipsec_result function

one to copy packets from the event in small batches and process them accordingly. - Freeing the event in odp_ipsec_result() leaves space for optimized implementations, where an event is actually a packet with additional metadata. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsol

[lng-odp] [[RFCv2] 2/4] api: ipsec: add default queue for outbound events

If an application has passed invalid SA in async mode, there is no way to report it back to application except using default queue (which does not exist at this moment). Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- include/odp/api/spec/ipsec.h | 7

[lng-odp] [[RFCv2] 4/4] linux-gen: ipsec: draft IPsec implementation

For now it's only a preview with the following limitation: - No inline processing support - No SA lookups - Only IPv4 support - No zeroing of mutable IPv4 options for AH ICV calculation - No replay protection - No ESN support Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsol

[lng-odp] [[RFCv2] 1/4] api: ipsec: mark odp_ipsec_sa_create argument as constant

odp_ipsec_sa_create() should not change its argument. Thus mark it as a constant. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- include/odp/api/spec/ipsec.h | 2 +- platform/linux-generic/odp_ipsec.c | 2 +- 2 files changed, 2 insertions(+), 2 del

Re: [lng-odp] [API-NEXT PATCH v2 4/4] api: crypto: enforce deprecated API status

this later if we see point in it (or maybe a suggestion from distro guys). I'd propose to merge this series as is. So, for the whole patchset: Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> -- With best wishes Dmitry

[lng-odp] [API-NEXT PATCH] api: packet: introduce odp_packet_data_range_t

Rename odp_crypto_data_range_t to odp_packet_data_range_t, as it is relevant not only to the crypto interface. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- include/odp/api/spec/crypto.h | 17 +++-- include/odp/ap

[lng-odp] [PATCH v4] linux-generic: crypto: properly handle errors in packet copy

Add proper handling for errors returned by odp_packet_copy_from_pkt(). Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/platform

Re: [lng-odp] [[RFCv2] 2/4] api: ipsec: add default queue for outbound events

On 28.04.2017 11:29, Peltonen, Janne (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Dmitry >> Eremin- >> Solenikov >> Sent: Friday, April 28, 2017 3:44 AM >> To: Bill F

Re: [lng-odp] [[RFCv2] 3/4] api: ipsec: change semantics of odp_ipsec_result function

On 28.04.2017 12:03, Peltonen, Janne (Nokia - FI/Espoo) wrote: > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill >> Fischofer >> Sent: Friday, April 28, 2017 4:06 AM >> To: Dmitry Eremin-Solenikov &

Re: [lng-odp] IPsec SA disabling

On 28.04.2017 12:27, Peltonen, Janne (Nokia - FI/Espoo) wrote: > Hi, > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Dmitry >> Eremin- >> Solenikov >> Sent: Friday, April 28, 2017 11:59 AM >> To:

Re: [lng-odp] [[RFCv2] 3/4] api: ipsec: change semantics of odp_ipsec_result function

On 28.04.2017 12:03, Peltonen, Janne (Nokia - FI/Espoo) wrote: > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill >> Fischofer >> Sent: Friday, April 28, 2017 4:06 AM >> To: Dmitry Eremin-Solenikov &

Re: [lng-odp] [[RFCv2] 3/4] api: ipsec: change semantics of odp_ipsec_result function

On 28.04.2017 01:46, Bill Fischofer wrote: > > > On Thu, Apr 27, 2017 at 6:51 AM, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org > <mailto:dmitry.ereminsoleni...@linaro.org>> wrote: > > - Move packets from the event instead of copying the

Re: [lng-odp] IPsec SA disabling

On 28.04.2017 15:32, Bala Manoharan wrote: > On 28 April 2017 at 15:41, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org> wrote: >> On 28.04.2017 12:27, Peltonen, Janne (Nokia - FI/Espoo) wrote: >>> Hi, >>> >>>> -Original Mess

Re: [lng-odp] [[RFCv2] 2/4] api: ipsec: add default queue for outbound events

On 28.04.2017 01:23, Bill Fischofer wrote: > > > On Thu, Apr 27, 2017 at 6:51 AM, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org > <mailto:dmitry.ereminsoleni...@linaro.org>> wrote: > > If an application has passed invalid SA in async mode

Re: [lng-odp] [[RFCv2] 4/4] linux-gen: ipsec: draft IPsec implementation

lso complains about a number of lines being > 80 chars. Yes, sure. I just hate that requirement, so I usually fix long lines during the last stages before actually submitting the patch. So that if I change smth in the 'split' line, I don't have to resplit/realign it. > > Othe

Re: [lng-odp] [[RFCv2] 2/4] api: ipsec: add default queue for outbound events

On 28.04.2017 03:33, Bill Fischofer wrote: > > > On Thu, Apr 27, 2017 at 6:19 PM, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org > <mailto:dmitry.ereminsoleni...@linaro.org>> wrote: > > On 28.04.2017 01:23, Bill Fischofer wrote: > &g

Re: [lng-odp] [[RFCv2] 3/4] api: ipsec: change semantics of odp_ipsec_result function

On 28.04.2017 03:45, Bill Fischofer wrote: > > > On Thu, Apr 27, 2017 at 5:49 PM, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org > <mailto:dmitry.ereminsoleni...@linaro.org>> wrote: > > On 28.04.2017 01:46, Bill Fischofer wrote: > &g

[lng-odp] IPsec SA disabling

Hello, While responding to Janne's email, I've come to an issue which warrants a separate discussion IMO. Consider the following scenario. Application with two thread. - First thread: gets outbound packet, finds SA through SPD, configures IPsec request, submits it. - Second thread: wants to

Re: [lng-odp] [PATCH API-NEXT v1 1/1] api:pktio: add MAC address and MTU set functions.

On 01/08/17 10:38, Vamsi Attunuru wrote: > Signed-off-by: Vamsi Attunuru > Signed-off-by: Shally Verma > Signed-off-by: Mahipal Challa I'd suggest to split this into two separate patches: one for MTU (seems simpler and will go in

Re: [lng-odp] [PATCH API-NEXT v1 1/1] api:pktio: add MAC address and MTU set functions.

On 01/08/17 21:42, Bill Fischofer wrote: > We discussed this patch during today's ODP public call. Notes from that > discussion: [skipped] > This should be a struct, not a union. If it's a union then all fields > are mapped on top of each other, which is clearly not what you intend > here.

Re: [lng-odp] IPsec SA disabling

Hi, On 28.04.2017 16:57, Peltonen, Janne (Nokia - FI/Espoo) wrote: > Hi, > > I believe the current API is complete in the sense that all necessary > things can be done safely. Maybe ODP could provide an easier-to-use > API but if the application and the API give fewer guarantees to the > ODP

[lng-odp] IPsec PIPELINE_CLS support

Hello, I have been looking through the missing pieces in my linux-generic implementation. One of the remaining pieces that I don't quite understand is the pipeline_cls capability. How should I behave wrt to it? Should I just send the event via odp_cos_queue(param->cos)? Or should I submit the

Re: [lng-odp] [PATCH 3/4] linux-generic: crypto: add SHA-1 authentication support

On 03.05.2017 17:17, Peltonen, Janne (Nokia - FI/Espoo) wrote: > Hi, > > I think there is a problem or ambiguity in the ODP API spec regarding > the truncation of the HMAC output. > > According to RFC 2104 the terminology goes so that HMAC-{hash-func} (e.g. > HMAC-SHA-512) means the HMAC with

Re: [lng-odp] [PATCH] api: ipsec: factor out IP protocol version parameter

On 03.05.2017 19:00, Github ODP bot wrote: > From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> > > Both tunnel and lookup parameters refer IP protocol version. Factor that > out as an IPsec enum used in both places. Subject prefixes are still not correct. --

Re: [lng-odp] [PATCH] api: ipsec: factor out IP protocol version parameter

On 03.05.2017 17:00, Github ODP bot wrote: > From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> > > Both tunnel and lookup parameters refer IP protocol version. Factor that > out as an IPsec enum used in both places. > > Signed-off-by: Dmitry Eremin-Soleni

[lng-odp] Packet validation question

Hello, Another generic question regarding ODP. If the package gets passed to IPsec API, should I trust e.g. IP header values? IOW, can I assume, that ip->tot_len + l3_offset is equal to odp_packet_len(), or is that an error? -- With best wishes Dmitry

Re: [lng-odp] odp_packet_free_multi with invalid packets

On 10.05.2017 20:13, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of >> Dmitry Eremin-Solenikov >> Sent: Wednesday, May 10, 2017 8:00 PM >> To: lng-o

Re: [lng-odp] odp_packet_free_multi with invalid packets

On 10.05.2017 20:57, Maxim Uvarov wrote: > On 05/10/2017 08:14 PM, Dmitry Eremin-Solenikov wrote: >> On 10.05.2017 20:13, Savolainen, Petri (Nokia - FI/Espoo) wrote: >>> >>>> -Original Message- >>>> From: lng-odp [mailto:lng-odp-boun...@lists.l

Re: [lng-odp] odp_packet_free_multi with invalid packets

On 10.05.2017 21:09, Maxim Uvarov wrote: > On 05/10/2017 09:00 PM, Dmitry Eremin-Solenikov wrote: >> On 10.05.2017 20:57, Maxim Uvarov wrote: >>> On 05/10/2017 08:14 PM, Dmitry Eremin-Solenikov wrote: >>>> On 10.05.2017 20:13, Savolainen, Petri (Nokia - FI/Espo

[lng-odp] IPsec: outgoing inline vs outer_hdr insertion

Hello, After the discussion yesterday, I'd like to clarify outer_hdr insertion in case of outbound inline packets. Should the implementation insert those headers at the beginning of odp_packet? Before l3 offset? Before l2 offset? -- With best wishes Dmitry

[lng-odp] odp_packet_free_multi with invalid packets

Hello, I was looking onto a shortcut code to free packets results from IPsec call. Initially I wanted to just call odp_packet_free_multi() on top of that array. However I noticed that the function segfaults if called with an array containing ODP_PACKET_INVALID. Is it correct to call

[lng-odp] [PATCH] api: ipsec: add explicit nonce/salt parameter

CTR/GCM/CCM algorithms require static IV part provided by control party. Usually it is a part of KEYMAT returned from IKE. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- include/odp/api/spec/ipsec.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)

[lng-odp] Crypto patchsets pileup

Hello colleagues, It seems, my crypto patchsets started piling up. Can we please look into reviewing/merging them? For now I would ask for the following order: 1) https://github.com/Linaro/odp/pull/23 is merged into master branch. It fixes a security issue in AES-GCM tag checking. 2)

Re: [lng-odp] [PATCH API-NEXT v4 2/10] api: ipsec: note that soft_exp bits are set only once

On 15.05.2017 15:21, Peltonen, Janne (Nokia - FI/Espoo) wrote: > > Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> wrote: >> >> Add an explicit note telling that soft_exp bits are set only once, for >> the packet actually crossing the boundary. They

Re: [lng-odp] [API-NEXT PATCH] api: crypto: change iv_len field to feature min-max len

On 15.05.2017 15:42, Balakrishna Garapati wrote: > This change is needed to support dpdk crypto pmd's Could you please be more specific, what are you trying to express. If you need, you can provide several entries, one for each IV len. > > Signed-off-by: Balakrishna Garapati

[lng-odp] IPsec crypto algorithms summary

Hello, For the sake of keeping all data in a single place, I've gather all crypto-related specs from RFCs in a single document. https://docs.google.com/document/d/1AK74bG9hcJs562FYZ9QIeCVXktdjarQ8eTyrqPm2ttg/edit?usp=sharing -- With best wishes Dmitry

Re: [lng-odp] [API-NEXT PATCHv3] api: crypto: change iv_len field to feature min-max len

Balakrishna, On 17.05.2017 13:49, Balakrishna Garapati wrote: > dpdk pmd's require to minatain min, max, inc fields for all > crypto capabilitites. By making iv_len to feature like dpdk pmd's > it is easier to create cipher entires in odp based on key_len. Unless you'd like to express something

Re: [lng-odp] IPsec crypto algorithms summary

standard is really ugly). > > On Wed, May 17, 2017 at 3:31 PM, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org > <mailto:dmitry.ereminsoleni...@linaro.org>> wrote: > > Hello, > > For the sake of keeping all data in a single place, I've ga

<    1   2   3   4   5   >