Re: [lng-odp] [PATCH 1/6] linux-gen: queue: reuse enq_ and deq_multi

> > Which config ? > >$ ./configure --with-platform=linux-generic > --prefix=/opt/Linaro/check-odp-v3.git/new-build --enable-test-perf > --enable-test-perf-proc --enable-test-helper --enable-test-example > --enable-test-vald --with-testdir=yes > > > Which pktio ? > > socket mmap > > pktio:

Re: [lng-odp] Suspected SPAM - [PATCH 1/3] test: l2fwd: lookup table for sched mode

Ping. This series optimizes l2fwd schedule mode performance by enabling lockless packet output (when possible) and corrects a bug in queue/plain mode forwarding. > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Petri > Savolainen > Sent: Thurs

Re: [lng-odp] RFC: packet interface to drivers

On 21 September 2016 at 17:55, Bill Fischofer wrote: > > > > On Tue, Sep 20, 2016 at 10:16 AM, Christophe Milard > wrote: >> >> >> >> On 20 September 2016 at 16:01, Bill Fischofer >> wrote: >>> >>> >>> >>> On Tue, Sep 20, 2016 at 8:30 AM, Christophe Milard >>> wrote: Hi,

Re: [lng-odp] [PATCH v2 1/5] example: l3fwd: add missing gitignores

Hi Matias, On what condition, *.log and *.trs will be generated? Other examples have no this. Thanks, Forrest On 16 September 2016 at 15:13, Matias Elo wrote: > Signed-off-by: Matias Elo > --- > example/l3fwd/.gitignore | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/example/l3fwd

Re: [lng-odp] [PATCH v2 3/5] example: l3fwd: make packet error check optional

Hi Matias, see comments inline. thanks, Forrest On 16 September 2016 at 15:13, Matias Elo wrote: > Make packet error check optional as it forces full packet parse. > > Signed-off-by: Matias Elo > --- > example/l3fwd/odp_l3fwd.c | 24 ++-- > 1 file changed, 18 insertions(

Re: [lng-odp] [PATCH v2 1/5] example: l3fwd: add missing gitignores

22.09.2016 11:51, Forrest Shi пишет: Hi Matias, On what condition, *.log and *.trs will be generated? Other examples have no this. Thanks, Forrest 'make check' creates this files. But if other examples do not have this in .gitignore then probably they exist in top level directory. Maxim.

[lng-odp] Query regarding odph_ipv4_csum_update

Hello Bala, I was looking into the issue related to IPv4 checksum update. Then After some browsing, I found that below patch. http://comments.gmane.org/gmane.network.opendataplane/6584 Within this patch, ip->chksum = 0; is done wherever applicable. So got a doubt that is this instruction can be

Re: [lng-odp] [PATCH v2 1/5] example: l3fwd: add missing gitignores

> 22.09.2016 11:51, Forrest Shi пишет: > > Hi Matias, > > > > On what condition, *.log and *.trs will be generated? Other examples have > > no this. > > > > Thanks, > > Forrest > 'make check' creates this files. But if other examples do not have this > in .gitignore then probably > they exist in to

Re: [lng-odp] [PATCH v2 3/5] example: l3fwd: make packet error check optional

On 22 Sep 2016, at 12.02, Forrest Shi mailto:forrest@linaro.org>> wrote: Hi Matias, see comments inline. thanks, Forrest On 16 September 2016 at 15:13, Matias Elo mailto:matias@nokia.com>> wrote: Make packet error check optional as it forces full packet parse. Signed-off-by: Matias

[lng-odp] [Bug 2510] ODP build system broken

https://bugs.linaro.org/show_bug.cgi?id=2510 Bill Fischofer changed: What|Removed |Added Severity|critical|normal --- Comment #4 from Bill Fischofer --

Re: [lng-odp] [PATCH] example: generator: actually use specified default

Reverted this patch due to have issues with performance/odp_l2fwd Maxim. On 09/14/16 05:50, Bill Fischofer wrote: On Tue, Sep 13, 2016 at 12:35 PM, Mike Holmes wrote: The help states default is 1000ms. 0 for flood mode, however the default was incorrectly set to zero. Signed-off-by: Mike Ho

Re: [lng-odp] [PATCH 1/6] linux-gen: queue: reuse enq_ and deq_multi

Merged, Maxim. On 09/22/16 10:28, Savolainen, Petri (Nokia - FI/Espoo) wrote: Which config ? $ ./configure --with-platform=linux-generic --prefix=/opt/Linaro/check-odp-v3.git/new-build --enable-test-perf --enable-test-perf-proc --enable-test-helper --enable-test-example --enable-test-vald -

Re: [lng-odp] [PATCH 1/6] linux-gen: queue: reuse enq_ and deq_multi

that was merged but doxygen needs refining: /opt/Linaro/odp3.git/platform/linux-generic/include/odp/api/plat/ticketlock_inlines.h:21: warning: Member _odp_ticketlock_lock(odp_ticketlock_t *ticketlock) (function) of file ticketlock_inlines.h is not documented. /opt/Linaro/odp3.git/platform/linux

Re: [lng-odp] [PATCH v2 1/2] test: perf: add new scheduling latency test

Merged, Maxim. On 09/22/16 01:11, Brian Brooks wrote: For series: Reviewed-and-tested-by: Brian Brooks On 09/14 11:53:06, Matias Elo wrote: Add new scheduling latency benchmark application. The application measures delays (avg, min, max) for high and low priority events. The test has a conf

[lng-odp] [PATCH] linux-generic: ticketlock: add missing doxygen for ticketlock_inlines.h

Add the missing internal doxygen documentation for the ticketlock_inlines functions used to accelerate odp-linux even when building with --enable-abi-compat=yes Signed-off-by: Bill Fischofer --- .../include/odp/api/plat/ticketlock_inlines.h | 26 ++ 1 file changed, 26 in

Re: [lng-odp] [PATCH 1/6] linux-gen: queue: reuse enq_ and deq_multi

I posted patch http://patches.opendataplane.org/patch/6991/ to address the doxygen issues with this patch. On Thu, Sep 22, 2016 at 12:00 PM, Maxim Uvarov wrote: > that was merged but doxygen needs refining: > > /opt/Linaro/odp3.git/platform/linux-generic/include/odp/api/plat/ticketlock_inlines.h

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

Actually, I have to withdraw my previous review of this patch. The problem is that the original works as part of autoconf to create the plat/inlines.h file from an inlines.h.in base while this one attempts to do this by specifying CFLAGs that #define ODP_ABI_COMPAT. That works fine if you're compi

Re: [lng-odp] Query regarding odph_ipv4_csum_update

Regards, Bala On 22 September 2016 at 02:43, Sunil Kumar Kori wrote: > Hello Bala, > > > > I was looking into the issue related to IPv4 checksum update. Then After > some browsing, I found that below patch. > > http://comments.gmane.org/gmane.network.opendataplane/6584 > > > > Within this patch,

Re: [lng-odp] [PATCH 1/1] validation: classification: fix TCP/UDP checksum update

Regards, Bala On 21 September 2016 at 19:46, Brian Brooks wrote: > On 09/09 19:49:09, Balasubramanian Manoharan wrote: >> Fixes https://bugs.linaro.org/show_bug.cgi?id=2512 >> >> Signed-off-by: Balasubramanian Manoharan >> --- >> .../validation/api/classification/odp_classification_common.c |

[lng-odp] [PATCH 2/2] config: share: use relocatable code if --enable-shared=no is specified

Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2510 by adding CFLAGS=-fPIC when --enable-shared=no is in effect to force generation of relocatable code. Signed-off-by: Bill Fischofer --- configure.ac | 8 1 file changed, 8 insertions(+) diff --git a/configure.ac b/configure.ac ind

[lng-odp] [PATCH 1/2] config: abi: add --enable-abi-compat option with default=yes

Suggested-by: Petri Savolainen Signed-off-by: Bill Fischofer --- Note that this patch supersedes patch http://patches.opendataplane.org/patch/6967/ configure.ac | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 982aff7..58c6a16 100644 ---

[lng-odp] [Bug 2510] ODP build system broken

https://bugs.linaro.org/show_bug.cgi?id=2510 Bill Fischofer changed: What|Removed |Added Status|CONFIRMED |IN_PROGRESS --- Comment #5 from Bill Fischofe

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

I've posted patch http://patches.opendataplane.org/patch/6993/ that performs the same function as this patch but does so by using the autoconf structure of the base code which means that it works either directly from the ODP repo or from an installed copy of the library. On Thu, Sep 22, 2016 at 5: