I can make a new fork and do the PR. There are still a few things
that I need to check though; I think I figured out why the original
code had the special log4cxx casting macros. Apparently the
dynamic_cast doesn't always work across shared library boundaries, so
that could cause a problem. Some
Guten Tag Robert Middleton,
am Freitag, 20. Januar 2017 um 03:41 schrieben Sie:
> git link:
> https://github.com/rm5248/log4cxx-testing/tree/smart_pointers
Now that we have a GIT repo, how do we deal with your branch? Are you
able to fork the new GitHub mirror and apply your changes easily again
Guten Tag Robert Middleton,
am Freitag, 20. Januar 2017 um 03:41 schrieben Sie:
> I'm not sure what the status is of log4cxx at the moment, but
> progress has been made on my branch since the last time I posted.
I'm still following, great work! Though I don't know when I will have
time to test it
I'm not sure what the status is of log4cxx at the moment, but progress has
been made on my branch since the last time I posted. I have fixed all of
the problems that the unit tests found once I converted everything over to
smart pointers. Fortunately, there are a large number of unit tests that
c
Success! log4cxx now compiles, but it almost certainly doesn't work yet.
I need to do some testing on it.
Things that need to be changed:
- Figure out what classes/methods used to take an ObjectPtr&. If they
should actually own this object in any way, change this to not pass by
refere
On Sun, Nov 20, 2016 at 9:39 AM, Thorsten Schöning
wrote:
> Guten Tag Robert Middleton,
> am Sonntag, 20. November 2016 um 03:31 schrieben Sie:
>
> > So I've started work on converting everything over to smart
> > pointers. You can check it out on my github here:
> > https://github.com/rm5248/lo
Guten Tag Robert Middleton,
am Sonntag, 20. November 2016 um 03:31 schrieben Sie:
> So I've started work on converting everything over to smart
> pointers. You can check it out on my github here:
> https://github.com/rm5248/log4cxx-testing/tree/smart_pointers
Great work. Any tips on how I could
