failed attempts to build log4cxx from svn

2008-02-09 Thread Jonathan Wakely
I've just checked log4cxx out from subversion but am unable to even build it: $ ./autogen.sh configure.in:40: installing `./missing' configure.in:40: installing `./install-sh' src/examples/cpp/Makefile.am: installing `./depcomp' configure.in:441: required file `src/performance/Makefile.in' not fou

Re: failed attempts to build log4cxx from svn

2008-02-09 Thread Curt Arnold
On Feb 9, 2008, at 8:12 AM, Jonathan Wakely wrote: I've just checked log4cxx out from subversion but am unable to even build it: $ ./autogen.sh configure.in:40: installing `./missing' configure.in:40: installing `./install-sh' src/examples/cpp/Makefile.am: installing `./depcomp' configure.in

Re: failed attempts to build log4cxx from svn

2008-02-09 Thread Jonathan Wakely
On 09/02/2008, Curt Arnold <[EMAIL PROTECTED]> wrote: > > > Am I just being stupid or is it as difficult as it seems to build > > the library? > > > > Jonathan > > > You just jumped in at the time that a whole lot of things were > changing in the SVN. Thanks for the quick reply, Curt. I've just u

svn commit: r620192 - in /logging/log4cxx/trunk: INSTALL configure.in src/test/resources/input/Makefile.am src/test/resources/input/performance/

2008-02-09 Thread carnold
Author: carnold Date: Sat Feb 9 12:32:38 2008 New Revision: 620192 URL: http://svn.apache.org/viewvc?rev=620192&view=rev Log: LOGCXX-232: Remove stray references to performance Removed: logging/log4cxx/trunk/src/test/resources/input/performance/ Modified: logging/log4cxx/trunk/INSTALL

ObjectPtrT comments

2008-02-09 Thread Jonathan Wakely
Hi log4cxx developers, now that I can build the library (thanks for the fix) I've been poking around and exploring the code. ObjectPtrT& operator=(const ObjectPtrT& p1) { T* newPtr = (T*) p1.p; if (newPtr != 0) { newPtr->addRef(); } T** pp = &p; void* oldPtr = O

Re: ObjectPtrT comments

2008-02-09 Thread Jonathan Wakely
On 09/02/2008, Curt Arnold <[EMAIL PROTECTED]> wrote: > > Had a recent issue with const on accessors: > https://issues.apache.org/jira/browse/LOGCXX-202 That looks unrelated (except for being on the same line of code). In the context of those const member functions the type of p is "const pointer

Re: ObjectPtrT comments

2008-02-09 Thread Curt Arnold
On Feb 9, 2008, at 4:03 PM, Jonathan Wakely wrote: Hi log4cxx developers, now that I can build the library (thanks for the fix) I've been poking around and exploring the code. ObjectPtrT& operator=(const ObjectPtrT& p1) { T* newPtr = (T*) p1.p; if (newPtr != 0) { newPtr->addRe

patches

2008-02-09 Thread Jonathan Wakely
Hi again, The first attached patch fixes some compiler errors with GCC 4.3 due to missing includes. See "Header Dependency Cleanup" in http://gcc.gnu.org/gcc-4.3/porting_to.html The second fixes warnings with any version of GCC, caused by initialising members in the wrong order in a constructor

Re: ObjectPtrT comments

2008-02-09 Thread Jonathan Wakely
On 09/02/2008, Curt Arnold <[EMAIL PROTECTED]> wrote: > > These functions don't need their casts either: > >T* operator->() const {return (T*) p; } > >T& operator*() const {return (T&) *p; } > >operator T*() const {return (T*) p; } > > (The last of these function

Re: patches

2008-02-09 Thread Curt Arnold
On Feb 9, 2008, at 4:30 PM, Jonathan Wakely wrote: Hi again, The first attached patch fixes some compiler errors with GCC 4.3 due to missing includes. See "Header Dependency Cleanup" in http://gcc.gnu.org/gcc-4.3/porting_to.html The second fixes warnings with any version of GCC, caused by in