On Fri, 2003-12-05 at 13:19, Raymond DeCampo wrote:
> Paul Smith wrote:
> >>The hashcode computation must be fast in itself, at least significantly
> >>faster than 'equals' method invocations which return false.
> >>
> >>I think that String.hashcode computation is kinda slow depending on the JDK
Paul Smith wrote:
The hashcode computation must be fast in itself, at least significantly
faster than 'equals' method invocations which return false.
I think that String.hashcode computation is kinda slow depending on the JDK
because it iterates on ALL the characters of the String.
M. Yes
> The hashcode computation must be fast in itself, at least significantly
> faster than 'equals' method invocations which return false.
>
> I think that String.hashcode computation is kinda slow depending on the JDK
> because it iterates on ALL the characters of the String.
M. Yes, I thin
At 08:02 AM 12/4/2003 +1100, Paul Smith wrote:
On Thu, 2003-12-04 at 07:54, Ceki Gülcü wrote:
> Yes. The general contact for the hashcode method says:
>
> 1 Two equal objects must have the same hashcode.
> 2 Two unequal objects can have the same hashcode.
>
> Item 1 does *not* mean that unequal o
ceki2003/12/03 13:03:03
Modified:src/java/org/apache/log4j/spi LoggingEvent.java
Log:
Added object equality check at the beginning of the equals method as suggested by
Paul.
Revision ChangesPath
1.43 +4 -1 jakarta-log4j/src/java/org/apache/log4j/spi/Logging
On Thu, 2003-12-04 at 07:54, Ceki GÃlcà wrote:
> Yes. The general contact for the hashcode method says:
>
> 1 Two equal objects must have the same hashcode.
> 2 Two unequal objects can have the same hashcode.
>
> Item 1 does *not* mean that unequal objects must have different hashcodes,
> which
At 07:46 AM 12/4/2003 +1100, you wrote:
We can add this as the first line as an optimization:
if( this == rObject) {
return true;
}
right! I'll add this now.
Also, will the hashCode based on the timestamp be enough to be
consistent with equals?
Yes. The general contact for the hashcode method
> +
> + public boolean equals(Object rObject) {
> +
> + if(!(rObject instanceof LoggingEvent)) {
> + return false;
> + }
We can add this as the first line as an optimization:
if( this == rObject) {
return true;
}
Also, will the hashCode based on the timestam
ceki2003/12/03 12:02:06
Modified:src/java/org/apache/log4j/spi LoggingEvent.java
Log:
Added equals and hashcode methods.
These are NOT tested.
Revision ChangesPath
1.42 +74 -0 jakarta-log4j/src/java/org/apache/log4j/spi/LoggingEvent.java
Index: Log
mwomack 2003/03/19 21:37:52
Modified:src/java/org/apache/log4j/spi LoggingEvent.java
Log:
Added getPropertyKeySet() method to return an unmodifiable set of the keys in the
event properties. If the properties is null, then an empty set is returned.
Revision ChangesPath
1
mwomack 2003/03/18 22:02:59
Modified:src/java/org/apache/log4j/spi LoggingEvent.java
Log:
Added getMDCKeySet() method to return an unmodifiable set of the keys in the MDC.
If the MDC is null, then an empty set is returned.
Revision ChangesPath
1.37 +22 -0 jakar
D]
> Subject: cvs commit:
> jakarta-log4j/src/java/org/apache/log4j/spi LoggingEvent.java
>
>
> ceki2003/02/18 11:58:10
>
> Modified:src/java/org/apache/log4j/spi LoggingEvent.java
> Log:
> Added a property map, similar to the one found in javax.jms.Me
ceki2003/02/18 11:58:10
Modified:src/java/org/apache/log4j/spi LoggingEvent.java
Log:
Added a property map, similar to the one found in javax.jms.Message.
The intention is to let appenders set properties and have layouts access them.
Revision ChangesPath
1.35
ceki2002/10/21 16:20:34
Modified:src/java/org/apache/log4j/spi LoggingEvent.java
Log:
Another formatting test. Tabs turned off this time.
Revision ChangesPath
1.34 +372 -372 jakarta-log4j/src/java/org/apache/log4j/spi/LoggingEvent.java
Index: LoggingEvent.j
ceki2002/10/21 16:02:48
Modified:src/java/org/apache/log4j/spi LoggingEvent.java
Log:
After formatting with Eclipse 2.0
Revision ChangesPath
1.33 +372 -380 jakarta-log4j/src/java/org/apache/log4j/spi/LoggingEvent.java
Index: LoggingEvent.java
ceki01/08/13 03:22:11
Modified:src/java/org/apache/log4j FileAppender.java MDC.java
src/java/org/apache/log4j/helpers Makefile
ThreadLocalMap.java
src/java/org/apache/log4j/spi LoggingEvent.java
Removed: src/java/org/apache
ceki01/08/07 15:23:59
Modified:src/java/org/apache/log4j MDC.java
src/java/org/apache/log4j/helpers Makefile
ThreadLocalMap.java
src/java/org/apache/log4j/net SocketNode.java
src/java/org/apache/log4j/spi LoggingEv
ceki01/04/11 15:01:19
Modified:src/java/org Makefile
src/java/org/apache Makefile
src/java/org/apache/log4j/spi LoggingEvent.java
Log:
Added missing getThrowableInformation method in LoggingEvent. Fixed a few Makefiles.
Revision ChangesPat
ceki01/03/22 10:37:53
Modified:src/java/org/apache/log4j/helpers OptionConverter.java
src/java/org/apache/log4j/spi LoggingEvent.java
Log:
OptionConverter.instantiateByKey method now performs variable substitution before
instantiation.
Revision Changes
19 matches
Mail list logo
