JNDISubstitution [was: LogLog Conversion: duplicate effort]

2004-11-22 Thread Ceki Gülcü
Yoav, If you are looking for something interesting to do, then I have a short and relatively instructive assignment. A user recently asked to perform substitution of variables from JNDI. This is really quite easy to do. 1) Create a JNDISubstitutionPropertyAction which looks up a jndi variable speci

RE: LogLog Conversion: duplicate effort

2004-11-22 Thread Shapira, Yoav
Hi, I spent about the same amount of time, and when I went to commit I saw all these conflicts. Looked at them, saw that you and Ceki had already covered all my work -- so that was a wasted 20 minutes on part ;) I suppose I should have replied to Ceki's assignment request earlier instead of j

Re: LogLog Conversion: duplicate effort

2004-11-22 Thread Paul Smith
No problems at all, I only spent 20 minutes or so to be honest. I had some changes done on Friday (not committed) but thought I'd wait till I read your response about one of my other postings before finalising it. I will go ahead and just take a fresh copy of the files from CVS, and see what e

Javadoc issues with chainsaw?

2004-11-22 Thread Ceki Gülcü
Hi Scott, Paul, Could you possibly fix the javadoc errors in the chainsaw package? javadoc: [javadoc] Generating Javadoc [javadoc] Javadoc execution [javadoc] Constructing Javadoc information... [javadoc] javadoc: Malformed URL: http://java.sun.com/products/j2se/1.3/docs/api/package-list

cvs commit: logging-log4j/src/java/org/apache/log4j/helpers UtilLoggingLevel.java

2004-11-22 Thread ceki
ceki2004/11/22 12:45:57 Modified:src/java/org/apache/log4j/xml UtilLoggingXMLDecoder.java docs HISTORY src/java/org/apache/log4j/rule LevelInequalityRule.java Added: src/java/org/apache/log4j/helpers UtilLoggingLevel.java Removed: src/j

cvs commit: logging-log4j/src/java/org/apache/log4j/joran/action ConfigurationAction.java

2004-11-22 Thread ceki
ceki2004/11/22 12:21:02 Modified:src/java/org/apache/log4j/rolling RollingFileAppender.java RollingPolicy.java TriggeringPolicy.java src/java/org/apache/log4j/config ConfiguratorBase.java src/java/org/apache/log4j/joran/util XMLUt

cvs commit: logging-log4j/src/xdocs index.xml

2004-11-22 Thread yoavs
yoavs 2004/11/22 10:22:11 Modified:docs index.html src/xdocs index.xml Log: Removed ApacheCon notice. Revision ChangesPath 1.26 +3 -14 logging-log4j/docs/index.html Index: index.html

cvs commit: logging-log4j/src/java/org/apache/log4j/joran JoranConfigurator.java

2004-11-22 Thread ceki
ceki2004/11/22 09:49:43 Modified:src/java/org/apache/log4j/joran/util XMLUtil.java src/java/org/apache/log4j/joran JoranConfigurator.java Log: Joran now checks to see if the XML document is well-forwed to avoid processing ill-formed documents. Revision Chang

cvs commit: logging-log4j/src/java/org/apache/log4j HTMLLayout.java

2004-11-22 Thread ceki
ceki2004/11/22 09:50:14 Removed: src/java/org/apache/log4j HTMLLayout.java Log: o.a.l.HTMLLayout was replaced by o.a.l.html.HTMLLayout - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail:

cvs commit: logging-log4j/src/java/org/apache/log4j/joran/action ConfigurationAction.java

2004-11-22 Thread ceki
ceki2004/11/22 09:07:09 Modified:tests/src/java/org/apache/log4j/rolling TimeBasedRollingTest.java src/java/org/apache/log4j/config ConfiguratorBase.java src/java/org/apache/log4j/rolling TimeBasedRollingPo

cvs commit: logging-log4j/tests/input/rolling time1.xml

2004-11-22 Thread ceki
ceki2004/11/22 09:08:35 Added: tests/input/rolling time1.xml Log: Testing o.a.l.rolling.RollingAppender+TimeRollingPolicy+Joran Revision ChangesPath 1.1 logging-log4j/tests/input/rolling/time1.xml Index: time1.xml

cvs commit: logging-log4j/src/java/org/apache/log4j/joran/util - New directory

2004-11-22 Thread ceki
ceki2004/11/22 09:07:02 logging-log4j/src/java/org/apache/log4j/joran/util - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: logging-log4j/src/java/org/apache/joran/action NestComponentIA.java Action.java

2004-11-22 Thread ceki
ceki2004/11/22 09:05:13 Modified:src/java/org/apache/joran Interpreter.java src/java/org/apache/joran/action NestComponentIA.java Action.java Log: Minor changes in o.a.joran Revision ChangesPath 1.19 +30 -12logging-log4j

cvs commit: logging-log4j/src/java/org/apache/log4j FileAppender.java Logger.java Category.java

2004-11-22 Thread ceki
ceki2004/11/22 08:43:39 Modified:src/java/org/apache/log4j FileAppender.java Logger.java Category.java Log: - Ensuring JDK 1.3 compile-time compatibility. - Moved trace() methods to Logger as these are new 1.3. Revision ChangesPath 1.44

World of trouble

2004-11-22 Thread Ceki Gülcü
Hi all, If you try to compile log4j sources using ant (I'm using ant version 1.5.1) you will get a bunch of compiler errors about ambiguous method signatures. For example, [javac] log4j-1.3\src\java\org\apache\log4j\net\XMLSocketNode.java:123: reference to error is ambiguous, both method e

changes in Chainsaw package and o.a.l.rule.RuleFactory

2004-11-22 Thread Ceki Gülcü
Scott, Thanks for these changes which more or less complete log4j's migration to self-reliant logging. I've noticed that you have not yet taken advantage of parameterizes messages. For example, in ChainsawCyclicBufferTableModel instead of writing: logger.debug("Adding col '" + key + "', columNam

Re: LogLog Conversion: duplicate effort

2004-11-22 Thread Ceki Gülcü
Hi Paul, Given that the changes are quite mechanical, I just went through them, especially because of the pressing need to verify that the unit tests continued to run successfully. At this time, I suggest that you override your local changes as they should be more as identical to mine. BTW, did