cvs commit: logging-log4j/src/java/org/apache/log4j/pattern CachedDateFormat.java

2004-12-23 Thread ceki
ceki2004/12/23 14:50:48 Modified:src/java/org/apache/log4j/pattern CachedDateFormat.java Log: Commented out System.out println statements Revision ChangesPath 1.12 +8 -8 logging-log4j/src/java/org/apache/log4j/pattern/CachedDateFormat.java Index: Cache

cvs commit: logging-log4j/tests/src/java/org/apache/log4j/pattern CacheUtilTest.java CachedDateFormatTest.java

2004-12-23 Thread ceki
ceki2004/12/23 14:49:11 Modified:src/java/org/apache/log4j/pattern DatePatternConverter.java CachedDateFormat.java CacheUtil.java tests/src/java/org/apache/log4j/pattern CacheUtilTest.java CachedDateFormatTest.java Log:

cvs commit: logging-log4j/src/java/org/apache/log4j/pattern CachedDateFormat.java

2004-12-23 Thread ceki
ceki2004/12/23 13:33:18 Modified:src/java/org/apache/log4j/pattern CachedDateFormat.java Log: comment change Revision ChangesPath 1.10 +1 -2 logging-log4j/src/java/org/apache/log4j/pattern/CachedDateFormat.java Index: CachedDateFormat.java ==

Re: cvs commit: logging-log4j/tests/src/java/org/apache/log4j/pattern CachedDateFormatTest.java

2004-12-23 Thread Ceki Gülcü
BTW, regardless of the constructor change of CachedDateFormat, lines 165 to 180 of version 1.8 are preferable to lines 115 to 135 in version 1.8. You could revert the constructor to CachedDateFormat(DateFormat) and still keep lines 165 to 180. You could also take out String cleanedPattern = Cac

cvs commit: logging-log4j/src/java/org/apache/log4j/pattern DatePatternConverter.java

2004-12-23 Thread ceki
ceki2004/12/23 12:37:45 Modified:src/java/org/apache/log4j/pattern DatePatternConverter.java Log: Added a small cache lasting 1 millisecond Revision ChangesPath 1.13 +24 -13 logging-log4j/src/java/org/apache/log4j/pattern/DatePatternConverter.java Index:

cvs commit: logging-log4j/tests/src/java/org/apache/log4j/pattern CacheUtilTest.java

2004-12-23 Thread ceki
ceki2004/12/23 12:37:17 Modified:src/java/org/apache/log4j/pattern CachedDateFormat.java CacheUtil.java tests/src/java/org/apache/log4j/pattern CacheUtilTest.java Log: Typo fixes, other corrections. Revision ChangesPath 1.9

cvs commit: logging-log4j/tests build.xml

2004-12-23 Thread ceki
ceki2004/12/23 12:33:33 Modified:testsbuild.xml Log: typo fix Revision ChangesPath 1.80 +12 -3 logging-log4j/tests/build.xml Index: build.xml === RCS file: /home/cvs/logging-log4j/te

cvs commit: logging-log4j/src/java/org/apache/log4j/pattern CachedDateFormat.java

2004-12-23 Thread ceki
ceki2004/12/23 12:13:33 Modified:src/java/org/apache/log4j/pattern CachedDateFormat.java Log: Removal off some cruft. Revision ChangesPath 1.8 +5 -15 logging-log4j/src/java/org/apache/log4j/pattern/CachedDateFormat.java Index: CachedDateFormat.java =

Re: cvs commit: logging-log4j/tests/src/java/org/apache/log4j/pattern CachedDateFormatTest.java

2004-12-23 Thread Ceki Gülcü
At 06:59 PM 12/23/2004, Curt Arnold wrote: Also, the slot stuff also seemed to up the complexity. I was trying to make it simpler at some trival cost (an extra dateformat per second or so) and still avoid the migrating millisecond field problem, I thought that I had adequately addressed that w

Re: cvs commit: logging-log4j/tests/src/java/org/apache/log4j/pattern CachedDateFormatTest.java

2004-12-23 Thread Curt Arnold
On Dec 23, 2004, at 12:24 PM, Ceki Gülcü wrote: Hi Curt, At 07:15 PM 12/23/2004, Ceki Gülcü wrote: At 06:59 PM 12/23/2004, you wrote: That seems to be substantially upping the complexity of CachedDateFormat. It seemed a lot simpler to protect against that weakness by checking for it DatePatternC

Re: cvs commit: logging-log4j/tests/src/java/org/apache/log4j/pattern CachedDateFormatTest.java

2004-12-23 Thread Ceki Gülcü
Hi Curt, At 07:15 PM 12/23/2004, Ceki Gülcü wrote: At 06:59 PM 12/23/2004, you wrote: That seems to be substantially upping the complexity of CachedDateFormat. It seemed a lot simpler to protect against that weakness by checking for it DatePatternConverter. Something like: try { if (p

cvs commit: logging-log4j/src/java/org/apache/log4j/pattern DatePatternConverter.java

2004-12-23 Thread ceki
ceki2004/12/23 10:10:09 Modified:src/java/org/apache/log4j/pattern DatePatternConverter.java Log: Switched to CachedDateFormat in DatePatternConverter Revision ChangesPath 1.12 +5 -6 logging-log4j/src/java/org/apache/log4j/pattern/DatePatternConverter.java

cvs commit: logging-log4j/tests/src/java/org/apache/log4j/pattern CachedDateFormatTest.java

2004-12-23 Thread ceki
ceki2004/12/23 10:07:52 Modified:tests/src/java/org/apache/log4j/pattern CachedDateFormatTest.java Log: It doen't make sense to use the machinery of CacheDateFormat for caching values returned by RelativeTimePatternConverter Revision ChangesPat

cvs commit: logging-log4j/src/java/org/apache/log4j/pattern RelativeTimePatternConverter.java

2004-12-23 Thread ceki
ceki2004/12/23 10:04:46 Modified:src/java/org/apache/log4j/pattern RelativeTimePatternConverter.java Log: Added a very simple caching mechanism to RelativeTimePatternConverter Revision ChangesPath 1.7 +13 -3 logging-log4j/src/java/or

Re: cvs commit: logging-log4j/tests/src/java/org/apache/log4j/pattern CachedDateFormatTest.java

2004-12-23 Thread Curt Arnold
That seems to be substantially upping the complexity of CachedDateFormat. It seemed a lot simpler to protect against that weakness by checking for it DatePatternConverter. Something like: try { if (pattern.indexOf("S") == -1 || pattern.indexOf("SSS") != -1) { df = new Cached

cvs commit: logging-log4j/src/java/org/apache/log4j/pattern CachedDateFormat.java

2004-12-23 Thread ceki
ceki2004/12/23 09:56:07 Modified:src/java/org/apache/log4j/pattern CachedDateFormat.java Log: Slighty clearer code Revision ChangesPath 1.7 +9 -6 logging-log4j/src/java/org/apache/log4j/pattern/CachedDateFormat.java Index: CachedDateFormat.java

cvs commit: logging-log4j/tests/src/java/org/apache/log4j/pattern CachedDateFormatTest.java

2004-12-23 Thread ceki
ceki2004/12/23 09:50:30 Modified:src/java/org/apache/log4j/pattern CachedDateFormat.java CacheUtil.java tests/src/java/org/apache/log4j/pattern CachedDateFormatTest.java Log: CacheDateFormat gives up on caching for un

cvs commit: logging-log4j/tests/src/java/org/apache/log4j/pattern CachedDateFormatTest.java

2004-12-23 Thread ceki
ceki2004/12/23 09:39:18 Modified:src/java/org/apache/log4j/pattern CachedDateFormat.java tests/src/java/org/apache/log4j/pattern CachedDateFormatTest.java Log: Caching does not work for patterns containing 1 or two 2 'S'. However, it works

RE: New VFS-enabled version of LogFilePatternReceiver

2004-12-23 Thread Scott Deboy
Sounds good. I'll take care of it along with the varia->filter move Scott -Original Message- From: Ceki Gülcü [mailto:[EMAIL PROTECTED] Sent: Thu 12/23/2004 4:21 AM To: Log4J Developers List Cc: Subject:Re: New VFS-enabled version of LogFilePatternReceiver Scott, Do

cvs commit: logging-log4j/tests/src/java/org/apache/log4j/pattern CachedDateFormatTest.java

2004-12-23 Thread ceki
ceki2004/12/23 07:30:40 Modified:src/java/org/apache/log4j/pattern CachedDateFormat.java tests/src/java/org/apache/log4j/pattern CachedDateFormatTest.java Log: Work in progress Revision ChangesPath 1.4 +33 -22 logging-l

cvs commit: logging-log4j/tests/src/java/org/apache/log4j/pattern CachedDateFormatTest.java

2004-12-23 Thread ceki
ceki2004/12/23 06:07:58 Modified:src/java/org/apache/log4j/helpers AbsoluteTimeDateFormat.java src/java/org/apache/log4j/pattern CachedDateFormat.java tests/src/java/org/apache/log4j/pattern CachedDateForma

cvs commit: logging-log4j/tests/src/java/org/apache/log4j/pattern CacheUtilTest.java

2004-12-23 Thread ceki
ceki2004/12/23 05:00:59 Modified:src/java/org/apache/log4j/pattern CachedDateFormat.java CacheUtil.java Added: tests/src/java/org/apache/log4j/pattern CacheUtilTest.java Log: CacheUtil debugged Revision ChangesPath 1.2 +0 -4

cvs commit: logging-log4j/tests/src/java/org/apache/log4j/pattern PatternParserTest.java

2004-12-23 Thread ceki
ceki2004/12/23 04:30:38 Modified:tests/src/java/org/apache/log4j/pattern PatternParserTest.java Log: The line separator varies from system to system. Harcoding it to \n fails on Windows. Revision ChangesPath 1.7 +2 -2 logging-log4j

Re: New VFS-enabled version of LogFilePatternReceiver

2004-12-23 Thread Ceki Gülcü
Scott, Do you think we could move the chainsaw related build targets in build.xml, to their own build file, say chainsaw.xml? The current build file is a little too big imho. We could continue to build chainsaw from build.xml by invoking targets found in chainsaw.xml. At 11:50 AM 12/23/2004, y

cvs commit: logging-log4j/tests/src/java/org/apache/log4j/pattern CachedDateFormatTest.java

2004-12-23 Thread ceki
ceki2004/12/23 04:16:22 Modified:testsbuild.xml Added: src/java/org/apache/log4j/pattern CachedDateFormat.java CacheUtil.java tests/src/java/org/apache/log4j/pattern CachedDateFormatTest.java Removed: sr

Re: cvs commit: logging-log4j/tests/x - New directory

2004-12-23 Thread Ceki Gülcü
Directories added by mistake. Will remove them from CVS repository. At 12:09 PM 12/23/2004, you wrote: ceki2004/12/23 03:09:35 logging-log4j/tests/x - New directory -- Ceki Gülcü The complete log4j manual: http://qos.ch/log4j/ ---

cvs commit: logging-log4j/tests/x/tests/input/performance telnet.xml

2004-12-23 Thread ceki
ceki2004/12/23 03:09:38 Added: tests/x/tests/input/performance telnet.xml Log: recent addition by Curt Revision ChangesPath 1.1 logging-log4j/tests/x/tests/input/performance/telnet.xml Index: telnet.xml ===

cvs commit: logging-log4j/tests/x/tests/input - New directory

2004-12-23 Thread ceki
ceki2004/12/23 03:09:35 logging-log4j/tests/x/tests/input - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: logging-log4j/tests/x - New directory

2004-12-23 Thread ceki
ceki2004/12/23 03:09:35 logging-log4j/tests/x - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: logging-log4j/tests/x/tests - New directory

2004-12-23 Thread ceki
ceki2004/12/23 03:09:35 logging-log4j/tests/x/tests - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: logging-log4j/tests/x/tests/input/performance - New directory

2004-12-23 Thread ceki
ceki2004/12/23 03:09:35 logging-log4j/tests/x/tests/input/performance - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: logging-log4j/docs TODO

2004-12-23 Thread ceki
ceki2004/12/23 03:06:53 Removed: docs TODO Log: Removed very out dated TODO file - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [EMAIL PROTECTED]: Project log4j-tests (in module logging-log4j) failed

2004-12-23 Thread Ceki Gülcü
Once again, Gump runs our tests automatically. It also caught the NullPointerException caused my recent changes. At 10:52 AM 12/23/2004, you wrote: To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.ht

cvs commit: logging-log4j/src/java/org/apache/log4j/pattern DatePatternConverter.java

2004-12-23 Thread ceki
ceki2004/12/23 02:53:50 Modified:src/java/org/apache/log4j/pattern DatePatternConverter.java Log: Fixed silly NullPointerException bug. Revision ChangesPath 1.11 +9 -3 logging-log4j/src/java/org/apache/log4j/pattern/DatePatternConverter.java Index: Dat

New VFS-enabled version of LogFilePatternReceiver

2004-12-23 Thread Scott Deboy
A heads-up - I added a receiver that supports VFS. I think there is value in providing access to data that could not otherwise be accessed programmatically (webdav/ssh/ftp/etc). Here's a complete list of the protocols VFS supports: http://jakarta.apache.org/commons/sandbox/vfs/filesystems.html

cvs commit: logging-log4j/src/java/org/apache/log4j/chainsaw/vfs VFSLogFilePatternReceiver.java

2004-12-23 Thread sdeboy
sdeboy 2004/12/23 02:47:04 Modified:src/java/org/apache/log4j/chainsaw/vfs VFSLogFilePatternReceiver.java Log: Removed unnecessary cast. Revision ChangesPath 1.2 +1 -2 logging-log4j/src/java/org/apache/log4j/chainsaw/vfs/VFSLogFilePatt

cvs commit: logging-log4j/src/java/org/apache/log4j/varia LogFilePatternReceiver.java

2004-12-23 Thread sdeboy
sdeboy 2004/12/23 02:40:53 Modified:src/java/org/apache/log4j/varia LogFilePatternReceiver.java Added: src/java/org/apache/log4j/chainsaw/vfs VFSLogFilePatternReceiver.java Log: Adding new VFSLogFilePatternReceiver (supports VFS and extends LogFilePa

RE: Latest HEAD of DatePatternConverter fails with %d

2004-12-23 Thread Ceki Gülcü
Thanks. Our unit tests fail too. I'll look into it. At 11:29 AM 12/23/2004, you wrote: Error occured while converting date java.lang.NullPointerException at org.apache.log4j.pattern.DatePatternConverter.convert(DatePatternConverter.java:108) at org.apache.log4j.pattern.PatternConv

RE: Latest HEAD of DatePatternConverter fails with %d

2004-12-23 Thread Scott Deboy
Error occured while converting date java.lang.NullPointerException at org.apache.log4j.pattern.DatePatternConverter.convert(DatePatternConverter.java:108) at org.apache.log4j.pattern.PatternConverter.format(PatternConverter.java:82) at org.apache.log4j.PatternLayout.forma

Re: Latest HEAD of DatePatternConverter fails with %d

2004-12-23 Thread Ceki Gülcü
Hi Scott, Do you have the stack trace? At 10:00 AM 12/23/2004, Scott Deboy wrote: FYI: In Chainsaw, the detail panel uses %d to format the timestamp. This throws null pointer exceptions - I had to change our layout to use %d{ISO8601} to prevent the exceptions. I haven't been following the patte

[EMAIL PROTECTED]: Project log4j-tests (in module logging-log4j) failed

2004-12-23 Thread noreply
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project log4j-tests has an issue affecting its community integration. This issue affects

Latest HEAD of DatePatternConverter fails with %d

2004-12-23 Thread Scott Deboy
FYI: In Chainsaw, the detail panel uses %d to format the timestamp. This throws null pointer exceptions - I had to change our layout to use %d{ISO8601} to prevent the exceptions. I haven't been following the patternconverter discussion too closely but it looks like a recent commit may have br