Doh! Brain lock on my part.
Here are the contents:
---
Test set: org.apache.logging.log4j.flume.appender.FlumeEmbeddedAgentTest
---
Tests run: 3,
Yup. That is what I would expect. However, it probably requires a Message that
has a constructor that accepts a Throwable and an object array, which means we
would probably want a new interface as a marker.
Ralph
Sent from my iPad
On Oct 4, 2012, at 7:18 PM, Paul Benedict wrote:
> Ooops. I
This is standards maven.
flume-ng/target/surefire-reports/org.apache.logging.log4j.flume.appender.FlumeEmbeddedAgentTest.txt
Sent from my iPad
On Oct 4, 2012, at 5:19 PM, Gary Gregory wrote:
> Sure, but what output? Where do I get it?
>
> G
>
> On Thu, Oct 4, 2012 at 8:17 PM, Ralph Goers
Ooops. I meant this:
logger.debug(Class m, Throwable t, Object...
messageParams);
The point was to pass in the Class of the Message so it doesn't get
instantiated unless logging is going to occur.
Paul
On Thu, Oct 4, 2012 at 9:12 PM, Gary Gregory wrote:
> On Thu, Oct 4, 2012 at 10:06 PM, Paul
On Thu, Oct 4, 2012 at 10:06 PM, Paul Benedict wrote:
> On Thu, Oct 4, 2012 at 7:24 PM, Gary Gregory wrote:
>
>> On Thu, Oct 4, 2012 at 5:55 PM, Paul Benedict wrote:
>>
>>> Ralph,
>>>
>>> This is actually a discussion you and I had a while back when I was
>>> trying to figure out how to use Strin
On Thu, Oct 4, 2012 at 7:24 PM, Gary Gregory wrote:
> On Thu, Oct 4, 2012 at 5:55 PM, Paul Benedict wrote:
>
>> Ralph,
>>
>> This is actually a discussion you and I had a while back when I was
>> trying to figure out how to use String.format(). I like the model now of
>> specifying the message cl
On Thu, Oct 4, 2012 at 5:55 PM, Paul Benedict wrote:
> Ralph,
>
> This is actually a discussion you and I had a while back when I was trying
> to figure out how to use String.format(). I like the model now of
> specifying the message class... however...
>
> It does seem a bit unseemly to instanti
Sure, but what output? Where do I get it?
G
On Thu, Oct 4, 2012 at 8:17 PM, Ralph Goers wrote:
> Can you post the output from the test? I occasionally have gotten
> failures in the two Flume embedded appenders (interestingly, one always
> seems to work when the other fails) from Gump but it is
Can you post the output from the test? I occasionally have gotten failures in
the two Flume embedded appenders (interestingly, one always seems to work when
the other fails) from Gump but it is impossible to debug those. The
SocketAppender sometimes fails in Gump as well - again, I have no ide
R:
OK, I cleaned a that fixed the two failures, now I get a new one!
---
T E S T S
---
Running org.apache.logging.log4j.flume.appender.FlumeAppenderTest
Tests run: 5, Failures: 0, Errors: 0, S
I'm not. I haven't tried on Windows though. But
ExtendedThrowablePatternConverter and RootThrowablePatternConverter only have
one newInstance method so I have no idea why you would see that. Have you run
mvn clean? The method signature did change in one of my recent commits.
FWIW - that er
I've taken to building local snapshots for now but the tests do not always
pass... as we experienced recently.
Gary
On Thu, Oct 4, 2012 at 6:03 PM, Ralph Goers wrote:
> No big deal for me at all, although there were a few minor things brought
> up during the beta1 vote that should be looked at.
On Thu, Oct 4, 2012 at 5:55 PM, Paul Benedict wrote:
> Ralph,
>
> This is actually a discussion you and I had a while back when I was trying
> to figure out how to use String.format(). I like the model now of
> specifying the message class... however...
>
> It does seem a bit unseemly to instanti
I think that is a great idea. Do you want to take a stab at implementing it in
AbstractLogger?
Ralph
On Oct 4, 2012, at 2:55 PM, Paul Benedict wrote:
> Ralph,
>
> This is actually a discussion you and I had a while back when I was trying to
> figure out how to use String.format(). I like th
Ralph,
This is actually a discussion you and I had a while back when I was trying
to figure out how to use String.format(). I like the model now of
specifying the message class... however...
It does seem a bit unseemly to instantiate an xxxMessage object that may
never get used. I'd rather just p
Yeah - the downside of that wrapper is that it is going to record the file,
method and line as that of the error method, not of the caller of the error
method. That is actually why so many methods are already in AbstractLogger
(and the Logger interface). I have no problem with adding more if t
On Thu, Oct 4, 2012 at 5:10 PM, Ralph Goers wrote:
> One other thing. I would recommend changing your code below to
>
> public void error(final Throwable t, final String format, final Object...
> values) {
> this.logger.error(new StringFormattedMessage(format, values), t);
> }
>
Cool! OK, now
There's one for the FAQ! Thanks.
Gary
On Oct 4, 2012, at 17:05, Ralph Goers wrote:
Logback automatically includes %ex at the end of the pattern if you don't
explicitly and you have to specify %noEx to turn it off.
In Log4j 2 you have to explicitly specify one of %ex, %xEx or %rEx to the
end of
One other thing. I would recommend changing your code below to
public void error(final Throwable t, final String format, final Object...
values) {
this.logger.error(new StringFormattedMessage(format, values), t);
}
This way String.format() isn't called unless the event is going to be logged.
Logback automatically includes %ex at the end of the pattern if you don't
explicitly and you have to specify %noEx to turn it off.
In Log4j 2 you have to explicitly specify one of %ex, %xEx or %rEx to the end
of the pattern. There is no equivalent to %noEx since you have to explicitly
include
[
https://issues.apache.org/jira/browse/LOG4J2-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ralph Goers resolved LOG4J2-35.
---
Resolution: Fixed
Fix Version/s: 2.0-beta2
Assignee: Ralph Goers
I added the interval
21 matches
Mail list logo
