Review away! ;-)
Gary
On Fri, Oct 2, 2015 at 8:55 AM, Ralph Goers
wrote:
> Mikael, we generally only create code branches when we have things that we
> would like feedback on before we commit them to master. Frankly, I do my
> code reviews using the emails from git. At least 80% of Gary’s comm
[
https://issues.apache.org/jira/browse/LOG4J2-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Gregory closed LOG4J2-1146.
Resolution: Fixed
In Git master.
> Add %notEmpty to PatternLayout to avoid output of patterns wher
Mikael, we generally only create code branches when we have things that we
would like feedback on before we commit them to master. Frankly, I do my code
reviews using the emails from git. At least 80% of Gary’s commits are just
code “cleanups” so are easy to look at - he is pretty good at separ
I think it will be easier to do code review if you make a branch in Git,
rather than uploading a diff.
On Fri, Oct 2, 2015 at 1:05 AM, Gary Gregory wrote:
> Feedback please: https://issues.apache.org/jira/browse/LOG4J2-1146
>
> Note the addition of the isVariable() method.
>
> Gary
>
> On Wed, S
[
https://issues.apache.org/jira/browse/LOG4J2-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pollentier updated LOG4J2-1148:
---
Description:
The documentation states the PluginManager looks at packages specified by
system proper
Pollentier created LOG4J2-1148:
--
Summary: log4j.plugin.packages no taken into account
Key: LOG4J2-1148
URL: https://issues.apache.org/jira/browse/LOG4J2-1148
Project: Log4j 2
Issue Type: Bug
