[jira] [Commented] (LOG4J2-599) Support lambda functions (or similar) for log message parameters

2015-08-09 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14679377#comment-14679377 ] Bruce Brouwer commented on LOG4J2-599: -- I wonder how well that would work using

[jira] [Commented] (LOG4J2-599) Support lambda functions (or similar) for log message parameters

2015-08-09 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14679435#comment-14679435 ] Bruce Brouwer commented on LOG4J2-599: -- My test showed that implementors of the old

[jira] [Comment Edited] (LOG4J2-599) Support lambda functions (or similar) for log message parameters

2015-08-09 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14679435#comment-14679435 ] Bruce Brouwer edited comment on LOG4J2-599 at 8/10/15 12:42 AM

[jira] [Commented] (LOG4J2-599) Support lambda functions (or similar) for log message parameters

2015-08-06 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661006#comment-14661006 ] Bruce Brouwer commented on LOG4J2-599: -- Could we avoid the whole api change thing

Re: Next release

2014-07-15 Thread Bruce Brouwer
PM, Bruce Brouwer bruce.brou...@gmail.com wrote: In the latest stuff in my branch, the biggest change in api is StatusConsoleListener moved to -core On Jul 14, 2014 1:23 PM, Ralph Goers ralph.go...@dslextreme.com wrote: StatusLogger is public in the sense that user written components will use

Re: [VOTE] Log4j 2.0 candidate 1

2014-07-15 Thread Bruce Brouwer
://www.manning.com/tahchiev/ Spring Batch in Action http://www.manning.com/templier/ Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory -- Bruce Brouwer about.me/bruce.brouwer [image: Bruce Brouwer on about.me] http://about.me/bruce.brouwer

[jira] [Assigned] (LOG4J2-514) ConsoleAppender closing System.out on Windows

2014-07-15 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer reassigned LOG4J2-514: Assignee: Bruce Brouwer ConsoleAppender closing System.out on Windows

Re: [VOTE] Log4j 2.0 candidate 1

2014-07-15 Thread Bruce Brouwer
in a 2.0.1 or 2.1 release without any problem. We are just making excuses. If we postpone this release then I'm sure somebody will come up with a reason why we would need an rc4 etc... On Tue, Jul 15, 2014 at 9:53 PM, Bruce Brouwer bruce.brou...@gmail.com wrote: I can see that, Ralph. I too

[jira] [Commented] (LOG4J2-609) StatusConfiguration doesn't close files

2014-07-15 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14062201#comment-14062201 ] Bruce Brouwer commented on LOG4J2-609: -- Why should the {{StatusData}} constructor

[jira] [Commented] (LOG4J2-609) StatusConfiguration doesn't close files

2014-07-15 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14062219#comment-14062219 ] Bruce Brouwer commented on LOG4J2-609: -- You know, since this would be the majority

[jira] [Commented] (LOG4J2-609) StatusConfiguration doesn't close files

2014-07-15 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14062503#comment-14062503 ] Bruce Brouwer commented on LOG4J2-609: -- I will relent on the public constructor

[jira] [Commented] (LOG4J2-609) StatusConfiguration doesn't close files

2014-07-15 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14063016#comment-14063016 ] Bruce Brouwer commented on LOG4J2-609: -- I had to revert most of that last

Re: [VOTE] Log4j 2.0 candidate 1

2014-07-15 Thread Bruce Brouwer
-- Bruce Brouwer about.me/bruce.brouwer [image: Bruce Brouwer on about.me] http://about.me/bruce.brouwer

Re: Next release

2014-07-14 Thread Bruce Brouwer
is that an RC is released, some time goes by without new bug reports and then the next RC becomes a release. As things are now, we've fixed plenty since rc2. But hey that's just me ;-) Gary Original message From: Bruce Brouwer Date:07/13/2014 22:35 (GMT-05:00) To: Log4J Developers

[jira] [Commented] (LOG4J2-609) StatusConfiguration doesn't close files

2014-07-14 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14060930#comment-14060930 ] Bruce Brouwer commented on LOG4J2-609: -- # You're right. .getStatusLevel() can remain

[jira] [Comment Edited] (LOG4J2-609) StatusConfiguration doesn't close files

2014-07-14 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14060930#comment-14060930 ] Bruce Brouwer edited comment on LOG4J2-609 at 7/14/14 5:50 PM

Re: Next release

2014-07-14 Thread Bruce Brouwer
message From: Bruce Brouwer Date:07/13/2014 22:35 (GMT-05:00) To: Log4J Developers List Subject: Re: Next release Ok, the only test that didn't pass was the one testing for StatusLogger writing to a file. I removed that test on the branch. If you review that and think it worthy to go

Re: Next release

2014-07-13 Thread Bruce Brouwer
on the stuff in ...log4j.status that clearly states this is for internal use only and may change in a breaking way in the future. On Sun, Jul 13, 2014 at 8:41 AM, Remko Popma remko.po...@gmail.com wrote: On Sunday, July 13, 2014, Bruce Brouwer bruce.brou...@gmail.com wrote: Here is what I am

Re: Next release

2014-07-13 Thread Bruce Brouwer
packages from public APIs. That way you can make it extra obvious that if the internal API changes, too bad. On 13 July 2014 13:44, Bruce Brouwer bruce.brou...@gmail.com wrote: Rats! It's not so simple as what I wrote. The crux of the problem is that the various Configuration classes need

Re: Next release

2014-07-13 Thread Bruce Brouwer
this simple. Sent from my iPhone On 2014/07/14, at 8:19, Bruce Brouwer bruce.brou...@gmail.com wrote: I'm all for making this more like a simple on/off switch. But the way things are setup right now, once you turn on the console logging, it can never be turned off. That is because once

Re: Next release

2014-07-13 Thread Bruce Brouwer
The listener can be removed, but nothing ever does. Right now it can never know if it should be removed. And also, all that level checking is cached in StatusLogger. If all you do is change the status level of the listener it has no effect on the cached value in StatusLogger. It may end up having

Re: Next release

2014-07-13 Thread Bruce Brouwer
logger from a configuration file. Shouldn't this just be a system property or something? On 13 July 2014 18:57, Bruce Brouwer bruce.brou...@gmail.com wrote: The listener can be removed, but nothing ever does. Right now it can never know if it should be removed. And also, all that level checking

Re: Next release

2014-07-13 Thread Bruce Brouwer
, 2014 at 9:29 PM, Bruce Brouwer bruce.brou...@gmail.com wrote: Ok, this is starting to be simpler, as I'm sure you would all prefer. You can look at the branch LOG4J-609 again if you like. Here are the simplifications that I have made. 1) The listeners no longer report their level. They can

Re: Next release

2014-07-12 Thread Bruce Brouwer
case, someone will hit it. Unfortunately I have no time this weekend. Gary Original message From: Bruce Brouwer Date:07/11/2014 23:11 (GMT-05:00) To: Log4J Developers List Subject: Re: Next release I know I haven't had time to spend on this project lately, but I never

Re: Next release

2014-07-12 Thread Bruce Brouwer
. (And of course creating a branch is always fine.) On Sat, Jul 12, 2014 at 8:28 PM, Bruce Brouwer bruce.brou...@gmail.com wrote: Shall I make a branch for this and check in what I have? If we really want to push to get this out soon maybe someone else could help out on the branch. On Jul 11, 2014 11:30

Re: Next release

2014-07-12 Thread Bruce Brouwer
Here is what I am thinking. I will make the branch tomorrow and put just the minimal changes in place with the modified StatusLogger api. This way when I fix things completely we won't have a breaking api change after 2.0 release. If you like it, we can put just that in trunk and release. On Jul

Re: Next release

2014-07-11 Thread Bruce Brouwer
: log4j-dev-h...@logging.apache.org -- Bruce Brouwer about.me/bruce.brouwer [image: Bruce Brouwer on about.me] http://about.me/bruce.brouwer

Re: [VOTE Results] Log4j 2 logo

2014-06-07 Thread Bruce Brouwer
://www.manning.com/bauer3/ JUnit in Action, Second Edition http://www.manning.com/tahchiev/ Spring Batch in Action http://www.manning.com/templier/ Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory -- Bruce Brouwer about.me/bruce.brouwer

[jira] [Commented] (LOG4J2-609) StatusConfiguration doesn't close files

2014-06-06 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14019805#comment-14019805 ] Bruce Brouwer commented on LOG4J2-609: -- I forgot one other point: 5. I removed

Re: Clean up org.apache.logging.log4j.Marker.getParent()

2014-06-06 Thread Bruce Brouwer
: Is this still on your ti-do list? Gary On Sat, May 31, 2014 at 12:08 AM, Bruce Brouwer bruce.brou...@gmail.com wrote: Oh yeah. I've been having too much fun lately with the kids and the beautiful spring weather. I need to get back to this. On Sun, May 25, 2014 at 1:08 AM, Matt Sicker boa

Re: [VOTE Results] Log4j 2 logo

2014-06-06 Thread Bruce Brouwer
And I'm not trying to suggest A is a mediocre choice. Maybe moderate would be a better word. A was actually my first choice, so take anything I say with a grain of salt. On Fri, Jun 6, 2014 at 8:05 PM, Bruce Brouwer bruce.brou...@gmail.com wrote: I always thought I liked STV, but here I see

Re: [VOTE Results] Log4j 2 logo

2014-06-06 Thread Bruce Brouwer
Edition http://www.manning.com/tahchiev/ Spring Batch in Action http://www.manning.com/templier/ Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory -- Bruce Brouwer about.me/bruce.brouwer [image: Bruce Brouwer on about.me] http

Re: Clean up org.apache.logging.log4j.Marker.getParent()

2014-06-06 Thread Bruce Brouwer
garydgreg...@gmail.com wrote: Hi Bruce: Is this still on your ti-do list? Gary On Sat, May 31, 2014 at 12:08 AM, Bruce Brouwer bruce.brou...@gmail.com wrote: Oh yeah. I've been having too much fun lately with the kids and the beautiful spring weather. I need to get back to this. On Sun

[jira] [Updated] (LOG4J2-609) StatusConfiguration doesn't close files

2014-06-05 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer updated LOG4J2-609: - Attachment: LOG4J2-609.unfinished.patch Here is my second attempt. It's going to require some

Re: [jira] [Updated] (LOG4J2-609) StatusConfiguration doesn't close files

2014-06-05 Thread Bruce Brouwer
more in line with what Ralph was talking about. On Thu, Jun 5, 2014 at 9:58 PM, Bruce Brouwer (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer updated LOG4J2-609

[jira] [Commented] (LOG4J2-609) StatusConfiguration doesn't close files

2014-06-05 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14019537#comment-14019537 ] Bruce Brouwer commented on LOG4J2-609: -- I don't think there is anything

Re: [VOTE] Log4j 2 logo

2014-06-04 Thread Bruce Brouwer
...@logging.apache.org -- Bruce Brouwer about.me/bruce.brouwer [image: Bruce Brouwer on about.me] http://about.me/bruce.brouwer

Re: Clean up org.apache.logging.log4j.Marker.getParent()

2014-05-30 Thread Bruce Brouwer
Oh yeah. I've been having too much fun lately with the kids and the beautiful spring weather. I need to get back to this. On Sun, May 25, 2014 at 1:08 AM, Matt Sicker boa...@gmail.com wrote: Looking forward to the new work! ;) On 19 May 2014 22:40, Bruce Brouwer bruce.brou...@gmail.com

Re: Scheduler

2014-05-21 Thread Bruce Brouwer
/templier/ Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory -- Matt Sicker boa...@gmail.com -- Matt Sicker boa...@gmail.com -- Bruce Brouwer about.me/bruce.brouwer [image: Bruce Brouwer on about.me] http://about.me

Re: [proposal] import guidelines

2014-05-19 Thread Bruce Brouwer
://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory -- Bruce Brouwer about.me/bruce.brouwer [image: Bruce Brouwer on about.me] http://about.me/bruce.brouwer

Re: [jira] [Commented] (LOG4J2-609) StatusConfiguration doesn't close files

2014-05-19 Thread Bruce Brouwer
messages to the StatusLogger. This isn't all 100% clear in my mind, but I wanted to get some feedback before I spent a ton of time trying to do this. Maybe this proposal is just too big of a change. On Thu, May 1, 2014 at 10:04 AM, Bruce Brouwer (JIRA) j...@apache.orgwrote: [ https

Re: Clean up org.apache.logging.log4j.Marker.getParent()

2014-05-19 Thread Bruce Brouwer
/GaryGregory -- Bruce Brouwer about.me/bruce.brouwer [image: Bruce Brouwer on about.me] http://about.me/bruce.brouwer

Re: [proposal] import guidelines

2014-05-17 Thread Bruce Brouwer
Brouwer about.me/bruce.brouwer [image: Bruce Brouwer on about.me] http://about.me/bruce.brouwer

Re: Log4J-2.0 New Logo

2014-05-15 Thread Bruce Brouwer
I don't know if my vote counts, but I would go with ACBG On May 13, 2014 5:36 PM, Ralph Goers ralph.go...@dslextreme.com wrote: I don’t recall that we had “rules”. Just that we were going to vote. Ralph On May 13, 2014, at 1:18 PM, Gary Gregory garydgreg...@gmail.com wrote: STV: ABEF (I

Re: Broken build

2014-05-04 Thread Bruce Brouwer
-mail: log4j-dev-h...@logging.apache.org -- Matt Sicker boa...@gmail.com -- Matt Sicker boa...@gmail.com -- Matt Sicker boa...@gmail.com -- Matt Sicker boa...@gmail.com -- Matt Sicker boa...@gmail.com -- Bruce Brouwer

[jira] [Closed] (LOG4J2-242) Make Messages more fluent

2014-05-04 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer closed LOG4J2-242. Make Messages more fluent - Key: LOG4J2-242

[jira] [Closed] (LOG4J2-439) Create a LogEventPatternConverter to escape newlines and HTML special characters

2014-05-04 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer closed LOG4J2-439. Create a LogEventPatternConverter to escape newlines and HTML special characters

[jira] [Closed] (LOG4J2-558) Create a log4j-bom

2014-05-04 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer closed LOG4J2-558. Create a log4j-bom -- Key: LOG4J2-558 URL: https

[jira] [Closed] (LOG4J2-585) Markers not as powerful as slf4j

2014-05-04 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer closed LOG4J2-585. Markers not as powerful as slf4j Key: LOG4J2-585

Re: Broken build

2014-05-04 Thread Bruce Brouwer
Edit: Because of the way these shared *listeners* are found... On Sun, May 4, 2014 at 9:38 AM, Bruce Brouwer bruce.brou...@gmail.comwrote: This is what I was starting to investigate with LOG4J2-609. I don't think this is quite there yet. For one, in StatusConsoleListener.close(), System.out

Re: Broken build

2014-05-04 Thread Bruce Brouwer
if it could be made to work properly. Ralph On May 4, 2014, at 6:38 AM, Bruce Brouwer bruce.brou...@gmail.com wrote: This is what I was starting to investigate with LOG4J2-609. I don't think this is quite there yet. For one, in StatusConsoleListener.close(), System.out and System.err can change

Re: Working on splitting off log4j-web.

2014-05-04 Thread Bruce Brouwer
Don't forget to update the bom with all of these pom changes. On May 4, 2014 1:18 PM, Matt Sicker boa...@gmail.com wrote: This will take a bit longer than the nosql split. I need to update some poms as well in this case. -- Matt Sicker boa...@gmail.com

Re: Broken build

2014-05-04 Thread Bruce Brouwer
I was hoping to hear from Ralph as it sounds like he already started something. On May 4, 2014 3:22 PM, Matt Sicker boa...@gmail.com wrote: If you've got a good idea on how to do it, sure. On 4 May 2014 14:04, Bruce Brouwer bruce.brou...@gmail.com wrote: I haven't spent much time

Re: Broken build

2014-05-04 Thread Bruce Brouwer
am not sure yet which would be the best option. Ralph On May 4, 2014, at 4:30 PM, Matt Sicker boa...@gmail.com wrote: Could you summarize how you'd implement this? Idea sharing could help reduce the overall effort required to elegantly fix this. On 4 May 2014 16:00, Bruce Brouwer

Re: Broken build

2014-05-04 Thread Bruce Brouwer
, at 6:06 PM, Bruce Brouwer bruce.brou...@gmail.com wrote: I was thinking of something along these lines (since Matt was asking me for my ideas): First off, make StatusConsoleListener a base class for StatusSystemOutListener and StatusSystemErrListener (maybe inner classes). These would no longer

Re: Rename Marker.add(Marker)

2014-05-02 Thread Bruce Brouwer
that is needed is to rename add(M...) to addParents(M...) Gary On Thu, May 1, 2014 at 11:37 PM, Bruce Brouwer bruce.brou...@gmail.comwrote: I would be in favor of renaming .add(Marker parent) to .addParents(Marker... parents). If people think it's a big deal, we could have .addParent(Marker parent

[jira] [Commented] (LOG4J2-609) StatusConfiguration doesn't close files

2014-05-01 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13986527#comment-13986527 ] Bruce Brouwer commented on LOG4J2-609: -- It seemed odd to me that a configuration

[jira] [Commented] (LOG4J2-609) StatusConfiguration doesn't close files

2014-05-01 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13986604#comment-13986604 ] Bruce Brouwer commented on LOG4J2-609: -- Ah yes, I wasn't thinking about that. I'll

Re: Rename Marker.add(Marker)

2014-05-01 Thread Bruce Brouwer
://www.manning.com/tahchiev/ Spring Batch in Action http://www.manning.com/templier/ Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory -- Matt Sicker boa...@gmail.com -- Bruce Brouwer

Re: New log4j-streams Module

2014-04-30 Thread Bruce Brouwer
(along with a log4j-camel module I was working on). On 29 April 2014 18:18, Bruce Brouwer bruce.brou...@gmail.com wrote: Was there any support in creating any of these new modules? On Fri, Apr 18, 2014 at 5:59 PM, Bruce Brouwer bruce.brou...@gmail.comwrote: I'll put together a list

[jira] [Updated] (LOG4J2-609) StatusConfiguration doesn't close files

2014-04-30 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer updated LOG4J2-609: - Attachment: log4j2-609.patch With log4j2-609.patch, now all tests pass with a clean install

Re: New log4j-streams Module

2014-04-29 Thread Bruce Brouwer
Was there any support in creating any of these new modules? On Fri, Apr 18, 2014 at 5:59 PM, Bruce Brouwer bruce.brou...@gmail.comwrote: I'll put together a list of things that I think could be pulled out of log4j-core because they are integrations with other tools. Go ahead and throw darts

Re: Quick note about Marker construction and null.

2014-04-24 Thread Bruce Brouwer
this. -- Matt Sicker boa...@gmail.com -- Bruce Brouwer

Re: Some things I noticed with the Marker implementation

2014-04-24 Thread Bruce Brouwer
:30 PM, Matt Sicker boa...@gmail.com wrote: On Tuesday, 22 April 2014, Bruce Brouwer bruce.brou...@gmail.com wrote: I don't think performance is a real concern on this method. Style is what I am concerned about. My vote would be to change the add method to accept varargs. We could include

Re: Some things I noticed with the Marker implementation

2014-04-22 Thread Bruce Brouwer
to. Ralph On Apr 21, 2014, at 7:20 PM, Matt Sicker boa...@gmail.com wrote: Using Marker... or Marker[] compile to the same bytecode. It should only affect compile-time stuff unless I'm mistaken. On 21 April 2014 20:17, Bruce Brouwer bruce.brou...@gmail.com wrote: Yes, I did. The arrays

Re: Some things I noticed with the Marker implementation

2014-04-22 Thread Bruce Brouwer
that it sort of goes against the builder pattern. However, I am sure it would perform better. Ralph On Apr 22, 2014, at 5:18 AM, Bruce Brouwer bruce.brou...@gmail.com wrote: Don't worry about the part of my comment that you were confused about. I see now that varargs are not slower than

Some things I noticed with the Marker implementation

2014-04-21 Thread Bruce Brouwer
) isInstanceOf(String markerName) Instead of throwing an IllegalArgumentException when a marker of name markerName doesn't exist, why don't we simply return false? I don't want an IllegalArgumentException to happen because I'm testing a markerName. -- Bruce Brouwer

[jira] [Created] (LOG4J2-609) StatusConfiguration doesn't close files

2014-04-21 Thread Bruce Brouwer (JIRA)
Bruce Brouwer created LOG4J2-609: Summary: StatusConfiguration doesn't close files Key: LOG4J2-609 URL: https://issues.apache.org/jira/browse/LOG4J2-609 Project: Log4j 2 Issue Type: Bug

[jira] [Updated] (LOG4J2-609) StatusConfiguration doesn't close files

2014-04-21 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer updated LOG4J2-609: - Description: {{org.apache.logging.log4j.core.config.status.StatusConfiguration}} allows you

[jira] [Commented] (LOG4J2-609) StatusConfiguration doesn't close files

2014-04-21 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13976289#comment-13976289 ] Bruce Brouwer commented on LOG4J2-609: -- It is also not clear to me why

[jira] [Commented] (LOG4J2-609) StatusConfiguration doesn't close files

2014-04-21 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13976301#comment-13976301 ] Bruce Brouwer commented on LOG4J2-609: -- Why

[jira] [Comment Edited] (LOG4J2-609) StatusConfiguration doesn't close files

2014-04-21 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13976301#comment-13976301 ] Bruce Brouwer edited comment on LOG4J2-609 at 4/22/14 2:13 AM

Re: Some things I noticed with the Marker implementation

2014-04-21 Thread Bruce Brouwer
in those cases. I'll revert that and comment. 2) that makes more sense than the exception On 21 April 2014 18:46, Bruce Brouwer bruce.brou...@gmail.com wrote: I saw that some small changes were being made to the Markers. I had a few thoughts regarding them: 1) Use of array iterator

Re: svn commit: r1589014 - /logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java

2014-04-21 Thread Bruce Brouwer
://www.manning.com/tahchiev/ Spring Batch in Action http://www.manning.com/templier/ Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory -- Matt Sicker boa...@gmail.com -- Bruce Brouwer

Re: New log4j-streams Module

2014-04-18 Thread Bruce Brouwer
you have specifically identified are where I would start. Are there more? Ralph On Apr 17, 2014, at 3:21 PM, Bruce Brouwer bruce.brou...@gmail.com wrote: This discussion about having modules or not having modules keeps coming up and I see different opinions here on the log4j team. Generally

[jira] [Updated] (LOG4J2-547) Update LoggerStream API

2014-04-17 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer updated LOG4J2-547: - Attachment: (was: log4j2-547-builders-and-more.patch) Update LoggerStream API

[jira] [Comment Edited] (LOG4J2-547) Update LoggerStream API

2014-04-17 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972262#comment-13972262 ] Bruce Brouwer edited comment on LOG4J2-547 at 4/17/14 12:13 PM

[jira] [Updated] (LOG4J2-547) Update LoggerStream API

2014-04-17 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer updated LOG4J2-547: - Attachment: log4j2-547-builders.patch Update LoggerStream API

Re: New log4j-streams Module

2014-04-17 Thread Bruce Brouwer
:45 PM, mattsic...@apache.org wrote: Author: mattsicker Date: Tue Apr 15 03:44:59 2014 New Revision: 1587396 URL: http://svn.apache.org/r1587396 Log: Add log4j-streams module. - See LOG4J2-547 - Thanks to Bruce Brouwer for the patch! - Added finals everywhere to said

[jira] [Updated] (LOG4J2-547) Update LoggerStream API

2014-04-16 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer updated LOG4J2-547: - Attachment: log4j2-547-builders-and-more.patch I like the builder idea too. I was just following

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-04-13 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967953#comment-13967953 ] Bruce Brouwer commented on LOG4J2-585: -- * I like the new fluent API. * Do you think

[jira] [Resolved] (LOG4J2-585) Markers not as powerful as slf4j

2014-04-13 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer resolved LOG4J2-585. -- Resolution: Fixed Fix Version/s: 2.0-rc2 Markers not as powerful as slf4j

[jira] [Updated] (LOG4J2-547) Update LoggerStream API

2014-04-13 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer updated LOG4J2-547: - Attachment: log4j2-547-new-module.patch I've added log4j2-547-new-module.patch. It makes a new

Re: Proposed change to MarkerManager API

2014-04-07 Thread Bruce Brouwer
(com.foo.bar.MyMarker). Gary Gary Original message From: Bruce Brouwer Date:04/06/2014 22:35 (GMT-05:00) To: Log4J Developers List Subject: Proposed change to MarkerManager API I hate changing API as much as the next guy, but there is an API in MarkerManager

Re: Proposed change to MarkerManager API

2014-04-07 Thread Bruce Brouwer
, a directed graph, rather than a parent child relationship. But my guess is that will be seen as too big of a change. On Mon, Apr 7, 2014 at 7:46 AM, Bruce Brouwer bruce.brou...@gmail.comwrote: I would be happy with a solution that looked like this: private static final Marker m

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-04-06 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961566#comment-13961566 ] Bruce Brouwer commented on LOG4J2-585: -- So, here are my thoughts. Maybe some

[jira] [Comment Edited] (LOG4J2-585) Markers not as powerful as slf4j

2014-04-06 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961566#comment-13961566 ] Bruce Brouwer edited comment on LOG4J2-585 at 4/6/14 11:44 PM

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-04-06 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961593#comment-13961593 ] Bruce Brouwer commented on LOG4J2-585: -- * Well, my recommendation in using define

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-04-06 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961604#comment-13961604 ] Bruce Brouwer commented on LOG4J2-585: -- * But we've made other breaking changes since

Proposed change to MarkerManager API

2014-04-06 Thread Bruce Brouwer
. Then, a distinction between get and define could be helpful. Does this sound like an acceptable change that we could get into log4j-api before GA? -- Bruce Brouwer

[jira] [Updated] (LOG4J2-585) Markers not as powerful as slf4j

2014-04-05 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer updated LOG4J2-585: - Attachment: CurrentMarkerBenchmark.java ConceptMarkerBenchmark.java Here

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-04-05 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961148#comment-13961148 ] Bruce Brouwer commented on LOG4J2-585: -- Why make that rule that parents added during

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-04-05 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961199#comment-13961199 ] Bruce Brouwer commented on LOG4J2-585: -- So, are you saying that the only benefit

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-04-05 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961223#comment-13961223 ] Bruce Brouwer commented on LOG4J2-585: -- {{java -jar target/microbenchmark.jar -t 8

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-04-04 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960867#comment-13960867 ] Bruce Brouwer commented on LOG4J2-585: -- So another idea I had is along the lines

[jira] [Updated] (LOG4J2-585) Markers not as powerful as slf4j

2014-04-03 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer updated LOG4J2-585: - Attachment: log4j2-585-concept.patch Here is a log4j2-585-concept.patch that outlines my ideas

[jira] [Comment Edited] (LOG4J2-585) Markers not as powerful as slf4j

2014-04-03 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13958801#comment-13958801 ] Bruce Brouwer edited comment on LOG4J2-585 at 4/3/14 1:24 PM

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

2014-04-03 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959213#comment-13959213 ] Bruce Brouwer commented on LOG4J2-585: -- The problem with creating all new immutable

[jira] [Comment Edited] (LOG4J2-585) Markers not as powerful as slf4j

2014-04-03 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959213#comment-13959213 ] Bruce Brouwer edited comment on LOG4J2-585 at 4/3/14 9:04 PM

[jira] [Created] (LOG4J2-585) Markers not as powerful as slf4j

2014-03-30 Thread Bruce Brouwer (JIRA)
Bruce Brouwer created LOG4J2-585: Summary: Markers not as powerful as slf4j Key: LOG4J2-585 URL: https://issues.apache.org/jira/browse/LOG4J2-585 Project: Log4j 2 Issue Type: Improvement

  1   2   >