Re: Advice on package for Encoder and ByteBufferDestination

2016-04-04 Thread Matt Sicker
I would imagine most people extend from AbstractLayout or AbstractStringLayout if they even make custom layouts. On 4 April 2016 at 12:31, Gary Gregory wrote: > And I imagine that _moving_ Layout is too much of a BC break even though > it is in Core? > > Gary > > On Sun, Apr 3, 2016 at 10:40 AM,

Re: Advice on package for Encoder and ByteBufferDestination

2016-04-04 Thread Gary Gregory
And I imagine that _moving_ Layout is too much of a BC break even though it is in Core? Gary On Sun, Apr 3, 2016 at 10:40 AM, Gary Gregory wrote: > IMO, the oddness is that Layout is NOT in the layout package. So I would > leave all layout items in layout... > > Gary > > On Sun, Apr 3, 2016 at

Re: Advice on package for Encoder and ByteBufferDestination

2016-04-03 Thread Gary Gregory
IMO, the oddness is that Layout is NOT in the layout package. So I would leave all layout items in layout... Gary On Sun, Apr 3, 2016 at 8:00 AM, Remko Popma wrote: > What package should the Encoder and ByteBufferDestination interfaces live > in? > > Currently they are both in org.apache.loggin

Advice on package for Encoder and ByteBufferDestination

2016-04-03 Thread Remko Popma
What package should the Encoder and ByteBufferDestination interfaces live in? Currently they are both in org.apache.logging.log4j.core.layout, but o.a.l.l.core.Layout extends Encoder and it seems a bit strange to have Layout's super interface live in a subpackage. I think there are pros and cons