Done in Git master.
Note that we had this already specified in javastyle.xml but we did not say
it checkstyle.xml!
Gary
On Mon, Sep 14, 2015 at 2:18 AM, Remko Popma wrote:
> No objections here either.
>
>
> On Monday, September 14, 2015, Ralph Goers
> wrote:
>
>> Seems reasonable.
>>
>> Ralph
No objections here either.
On Monday, September 14, 2015, Ralph Goers
wrote:
> Seems reasonable.
>
> Ralph
>
> On Sep 14, 2015, at 12:35 AM, Gary Gregory > wrote:
>
> OK, I updated checkstyle with HidddenFields.
>
> Next, I'd like LineLength to be ignored for import statements.
>
> Thoughts?
>
Seems reasonable.
Ralph
> On Sep 14, 2015, at 12:35 AM, Gary Gregory wrote:
>
> OK, I updated checkstyle with HidddenFields.
>
> Next, I'd like LineLength to be ignored for import statements.
>
> Thoughts?
>
> Gary
>
>> On Fri, Sep 11, 2015 at 5:36 PM, Ralph Goers
>> wrote:
>> Actually, I
OK, I updated checkstyle with HidddenFields.
Next, I'd like LineLength to be ignored for import statements.
Thoughts?
Gary
On Fri, Sep 11, 2015 at 5:36 PM, Ralph Goers
wrote:
> Actually, I am fine with setters that do that as well. Both can be
> configured to be OK with the HiddenField elemen
Actually, I am fine with setters that do that as well. Both can be configured
to be OK with the HiddenField element.
Ralph
> On Sep 11, 2015, at 5:22 PM, Gary Gregory wrote:
>
> Checkstyle complains about code like this:
>
> private final int foo;
> Ctor(int foo) {
> this.foo = foo;
> }
>
Definitely a +1 on the checkstyle comments thing. I've seen that before in
other projects.
On 22 June 2014 08:26, Remko Popma wrote:
> There are certainly a lot of checkstyle errors/warnings.
> I occasionally see Eclipse warning about an unused import or an unused
> private field, but checkstyl
There are certainly a lot of checkstyle errors/warnings.
I occasionally see Eclipse warning about an unused import or an unused
private field, but checkstyle seems a lot stricter...
I'll try to spend some time cleaning this up after rc2 is out.
I noticed that we occasionally break the checkstyle
Probably a combination of both.
On 19 June 2014 22:43, Ralph Goers wrote:
> Either our the checkstyle rules must not match the IDE rules as we have
> hundreds of checkstyle errors in the reports.
>
> Ralph
> -
> To unsubscribe,
All right Nick!
Gary
On Jul 7, 2013, at 17:17, Nick Williams wrote:
> At the beginning of this weekend there were about 400-500 Checkstyle errors.
> I have done a lot of cleanup over the weekend. Most Checkstyle errors have
> been resolved in all modules except Core. There are a handful that
