Re: org.apache.logging.log4j.core.layout.GelfLayout.Builder.additionalFields

2017-01-07 Thread Gary Gregory
What would this new class be called? On Jan 7, 2017 12:47 PM, "Mikael Ståldal" wrote: > It doesn't feel right to put it in AbstractStringLayout.Builder since it > does not make sense for all AbstractStringLayout:s. > > It doesn't make sense for PatternLayout. > (BTW, why doesn't PatternLayout.Bu

Re: org.apache.logging.log4j.core.layout.GelfLayout.Builder.additionalFields

2017-01-07 Thread Mikael Ståldal
It doesn't feel right to put it in AbstractStringLayout.Builder since it does not make sense for all AbstractStringLayout:s. It doesn't make sense for PatternLayout. (BTW, why doesn't PatternLayout.Builder extend AbstractStringLayout.Builder?) I would prefer another abstract class in between if w

Re: org.apache.logging.log4j.core.layout.GelfLayout.Builder.additionalFields

2017-01-05 Thread Matt Sicker
Can some sort of generic plugin similar to the ColumnMapping one I just added be used here? Allow layouts within markup layouts. Seems kind of meta, so it might require some more design. On 5 January 2017 at 17:10, Remko Popma wrote: > There is an outstanding request for the JSON layout to show

Re: org.apache.logging.log4j.core.layout.GelfLayout.Builder.additionalFields

2017-01-05 Thread Remko Popma
t;>> On Jan 6, 2017, at 4:08, Gary Gregory wrote: >>> >>> I think we should pull up >>> org.apache.logging.log4j.core.layout.GelfLayout.Builder.additionalFields to >>> the superclass so it can be used in any layout (that allows for extra >>> fields). >>> >>> Thoughts? >>> >&

Re: org.apache.logging.log4j.core.layout.GelfLayout.Builder.additionalFields

2017-01-05 Thread Gary Gregory
Popma wrote: > Which Layouts actually support additional fields? I wouldn't pull it up > until there's a need. > > Sent from my iPhone > > On Jan 6, 2017, at 4:08, Gary Gregory wrote: > > I think we should pull up > org.apache.logging.log4j.core.layout.GelfLay

Re: org.apache.logging.log4j.core.layout.GelfLayout.Builder.additionalFields

2017-01-05 Thread Remko Popma
Which Layouts actually support additional fields? I wouldn't pull it up until there's a need. Sent from my iPhone > On Jan 6, 2017, at 4:08, Gary Gregory wrote: > > I think we should pull up > org.apache.logging.log4j.core.layout.GelfLayout.Builder.additionalFields t

org.apache.logging.log4j.core.layout.GelfLayout.Builder.additionalFields

2017-01-05 Thread Gary Gregory
I think we should pull up org.apache.logging.log4j.core.layout.GelfLayout.Builder.additionalFields to the superclass so it can be used in any layout (that allows for extra fields). Thoughts? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second