svn commit: r948664 - in /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-core/src/main/java/org/apache/logging/log4j/core: ./ appender/ filter/

2010-05-26 Thread carnold
Author: carnold Date: Thu May 27 03:26:31 2010 New Revision: 948664 URL: http://svn.apache.org/viewvc?rev=948664&view=rev Log: Additional code review comments Modified: logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-core/src/main/java/org/apache/logging/log4j/core/ErrorHandler.

Re: svn commit: r948664 - in /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-core/src/main/java/org/apache/logging/log4j/core: ./ appender/ filter/

2010-05-26 Thread Ralph Goers
I'm not sure what the appropriate way to respond to all the comments is going to be. Some of them I agree with and will make changes when I get the chance. Many of them just need an explanation or I disagree with the comment - not sure what to do about those. For example, in Logger - @doubt Al

Re: svn commit: r948664 - in /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-core/src/main/java/org/apache/logging/log4j/core: ./ appender/ filter/

2010-05-26 Thread Curt Arnold
On May 26, 2010, at 11:01 PM, Ralph Goers wrote: > I'm not sure what the appropriate way to respond to all the comments is going > to be. Some of them I agree with and will make changes when I get the chance. > Many of them just need an explanation or I disagree with the comment - not > sure w