Hi,
my first OSS patch ever ;-)
Tomek
SyslogWrapLayout.java.patch
Description: Binary data
-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.
Hello Tomek,
Thank you for the patch and welcome to OSS!
The way to submit a contribution is to add your patch file to the JIRA you
created for the issue.
Adding unit tests to the patch is a best practice. It will increase the
odds one of us will take the time to review it.
Thank you!
Gary
[
https://issues.apache.org/jira/browse/LOG4J2-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomek Kaczyński updated LOG4J2-256:
---
Attachment: SyslogWrapLayout.java.patch
> SyslogWrapAppender - embed layout format in Sys
https://issues.apache.org/bugzilla/show_bug.cgi?id=41006
--- Comment #6 from Thomas Raddatz ---
I am sorry, but I do not have any unit tests for it. Are there any unit test
for the SocketHubReceicer that could be taken as a starting point?
--
You are receiving this mail because:
You are on the
https://issues.apache.org/bugzilla/show_bug.cgi?id=41006
--- Comment #7 from Scott Deboy ---
There are probably no receiver unit tests..I think it would be ok to confirm it
works via Chainsaw.
Can you add a comment here describing how you test it?
I can't believe this has been sitting here so l
[
https://issues.apache.org/jira/browse/LOG4J2-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661251#comment-13661251
]
Nick Williams commented on LOG4J2-229:
--
I have significantly improved the documentati
The roles are still there in the pom. Do we still need them? I don't mind
removing them.
From: Nick Williams
To: Log4J Developers List
Sent: Tuesday, May 14, 2013 9:38 AM
Subject: Re: Site Ideas
Item #4 is now done as well.
Nick
On May 12, 2013, at 6:1
[
https://issues.apache.org/jira/browse/LOG4J2-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma closed LOG4J2-255.
--
> Multi-byte character strings are scrambled in log output
> --
Per Gary and Ralph, the roles have been changed to "PMC Member," "Committer,"
etc.
Nick
On May 17, 2013, at 10:44 PM, Remko Popma wrote:
> The roles are still there in the pom. Do we still need them? I don't mind
> removing them.
>
> From: Nick Williams
> To: Log4J Developers List
> Sent:
I have verified that this is fixed in 2.0-beta7-SNAPSHOT. Thanks!
Nick
On May 15, 2013, at 11:29 AM, Ralph Goers wrote:
> Nick,
>
> Have you verified the fix I made to avoid the exception below? I have looked
> at the Java 8 source but I can't find the source for the sun classes - I'm
> not
[
https://issues.apache.org/jira/browse/LOG4J2-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661262#comment-13661262
]
Nick Williams commented on LOG4J2-223:
--
In the latest 2.0-beta7-SNAPSHOT, this is sti
[
https://issues.apache.org/jira/browse/LOG4J2-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661261#comment-13661261
]
Remko Popma commented on LOG4J2-232:
Did you get a chance to run the stand-alone test
[
https://issues.apache.org/jira/browse/LOG4J2-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661262#comment-13661262
]
Nick Williams edited comment on LOG4J2-223 at 5/18/13 3:59 AM:
-
[
https://issues.apache.org/jira/browse/LOG4J2-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661262#comment-13661262
]
Nick Williams edited comment on LOG4J2-223 at 5/18/13 4:01 AM:
-
Scott, is there a particular page on the Wiki you want me to add them to? I'm
not finding a whole lot just looking around. :-/
Nick
On May 16, 2013, at 5:28 PM, Scott Deboy wrote:
> Sure, add them to the wiki please.
>
> On 5/16/13, Nick Williams wrote:
>> CheckStyle ImportOrder changes commi
[
https://issues.apache.org/jira/browse/LOG4J2-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661266#comment-13661266
]
Remko Popma commented on LOG4J2-223:
Haven't had a chance. Have been making long hours
[
https://issues.apache.org/jira/browse/LOG4J2-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661268#comment-13661268
]
Nick Williams commented on LOG4J2-223:
--
Java 1.8.0-ea-b88
Tomcat 8.0-SNAPSHOT (r14789
[
https://issues.apache.org/jira/browse/LOG4J2-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661289#comment-13661289
]
Remko Popma commented on LOG4J2-223:
Thanks.
Unexpected family circumstances just cam
Great, thank you.
Gary
On May 17, 2013, at 23:54, Nick Williams
wrote:
Per Gary and Ralph, the roles have been changed to "PMC Member,"
"Committer," etc.
Nick
On May 17, 2013, at 10:44 PM, Remko Popma wrote:
The roles are still there in the pom. Do we still need them? I don't mind
removing t
[
https://issues.apache.org/jira/browse/LOG4J2-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661310#comment-13661310
]
Ralph Goers commented on LOG4J2-10:
---
I'm prepared to commit the patch (with a few modific
20 matches
Mail list logo
