Re: org.apache.log4j.Category.setResourceBundle(ResourceBundle)

2014-01-31 Thread Remko Popma
I should have looked this up... l7dlog() methods replace the user-supplied key by its localized version from the resource bundle. So this is about the log message text, not the level names. Please disregard my previous email. One of my colleagues raised an interesting point: We have some systems

[jira] [Commented] (LOG4J2-323) ThreadLocal-leak on tomcat shutdown when using async logging

2014-01-31 Thread Mickael Hemri (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887571#comment-13887571 ] Mickael Hemri commented on LOG4J2-323: -- No it's a compilation error (r1563090): [ERRO

[jira] [Comment Edited] (LOG4J2-323) ThreadLocal-leak on tomcat shutdown when using async logging

2014-01-31 Thread Mickael Hemri (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887571#comment-13887571 ] Mickael Hemri edited comment on LOG4J2-323 at 1/31/14 8:58 AM: -

[jira] [Commented] (LOG4J2-323) ThreadLocal-leak on tomcat shutdown when using async logging

2014-01-31 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887578#comment-13887578 ] Remko Popma commented on LOG4J2-323: Ah, I see it now... That method actually has a c

JDK 8 Build 126 & JDK 7 Update 60 build 04 are available on java.net

2014-01-31 Thread Rory O'Donnell Oracle, Dublin Ireland
Hi Nick, JDK 8 Build b126 Early Access Build is now available for download & test. JDK 7u60 b04 Early Access Build is also available for download & test. Please log all show stopper issues as soon as possible. Thanks f

[jira] [Commented] (LOG4J2-323) ThreadLocal-leak on tomcat shutdown when using async logging

2014-01-31 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887681#comment-13887681 ] Remko Popma commented on LOG4J2-323: Removed the @Override to fix the compilation prob

[jira] [Commented] (LOG4J2-323) ThreadLocal-leak on tomcat shutdown when using async logging

2014-01-31 Thread Mickael Hemri (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887700#comment-13887700 ] Mickael Hemri commented on LOG4J2-323: -- It's ok now, thanks :) > ThreadLocal-leak on

[jira] [Closed] (LOG4J2-323) ThreadLocal-leak on tomcat shutdown when using async logging

2014-01-31 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma closed LOG4J2-323. -- Closing this issue. > ThreadLocal-leak on tomcat shutdown when using async logging > -

[jira] [Resolved] (LOG4J2-385) Unable to roll log files monthly

2014-01-31 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-385. Resolution: Fixed Fix Version/s: 2.0-rc1 Fixed the above issues with monthly, weekly, hourly

[jira] [Commented] (LOG4J2-323) ThreadLocal-leak on tomcat shutdown when using async logging

2014-01-31 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887754#comment-13887754 ] Gary Gregory commented on LOG4J2-323: - oops, my bad on the override. > ThreadLocal-l

[jira] [Commented] (LOG4J2-323) ThreadLocal-leak on tomcat shutdown when using async logging

2014-01-31 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887758#comment-13887758 ] Remko Popma commented on LOG4J2-323: No problem! :-) > ThreadLocal-leak on tomcat shu

Re: ApacheCon CFP

2014-01-31 Thread Matt Sicker
Yeah that would work. Nashville huh? My co-worker is from there too, neat. In regard to the async and such, I think that'd be a great idea. One of the selling points of log4j over logback is performance, right? Matt Sicker > On Jan 31, 2014, at 0:52, Nick Williams wrote: > > >> On Jan 30, 20

Re: org.apache.log4j.Category.setResourceBundle(ResourceBundle)

2014-01-31 Thread Gary Gregory
On Fri, Jan 31, 2014 at 2:13 AM, Remko Popma wrote: > I asked a number of Japanese and Chinese colleagues, but nobody seemed to > want the level names translated in the log output. They were all happy > with the English names. About half advised against translating, half was > indifferent, and on

Re: org.apache.log4j.Category.setResourceBundle(ResourceBundle)

2014-01-31 Thread Gary Gregory
On Fri, Jan 31, 2014 at 3:06 AM, Remko Popma wrote: > I should have looked this up... > l7dlog() methods replace the user-supplied key by its localized version > from the resource bundle. > > So this is about the log message text, not the level names. Please > disregard my previous email. > Now

Re: org.apache.log4j.Category.setResourceBundle(ResourceBundle)

2014-01-31 Thread Remko Popma
Yes sorry. I understood that later, so in the email that followed I said "I should have looked this up... " and "Please disregard my previous email". On Sat, Feb 1, 2014 at 12:05 AM, Gary Gregory wrote: > On Fri, Jan 31, 2014 at 2:13 AM, Remko Popma wrote: > >> I asked a number of Japanese and C

Re: org.apache.log4j.Category.setResourceBundle(ResourceBundle)

2014-01-31 Thread Remko Popma
Hm... I should have looked it up sooner... :-( On Sat, Feb 1, 2014 at 12:07 AM, Gary Gregory wrote: > On Fri, Jan 31, 2014 at 3:06 AM, Remko Popma wrote: > >> I should have looked this up... >> l7dlog() methods replace the user-supplied key by its localized version >> from the resource bundle. >

Re: org.apache.log4j.Category.setResourceBundle(ResourceBundle)

2014-01-31 Thread Gary Gregory
On Fri, Jan 31, 2014 at 10:08 AM, Remko Popma wrote: > Hm... I should have looked it up sooner... :-( > We're all sync'd up now :) Gary > > > On Sat, Feb 1, 2014 at 12:07 AM, Gary Gregory wrote: > >> On Fri, Jan 31, 2014 at 3:06 AM, Remko Popma wrote: >> >>> I should have looked this up... >>

Re: org.apache.log4j.Category.setResourceBundle(ResourceBundle)

2014-01-31 Thread Remko Popma
Anyway, what are we going to do with this? Team, do we want to support this functionality (localized log message lookup in ResourceBundles) in Log4J2? If so, where do we put the #setResourceBundle() method? On LogManager? And I guess the #l7dlog() methods would need to be added to the Logger inter

Re: org.apache.log4j.Category.setResourceBundle(ResourceBundle)

2014-01-31 Thread Gary Gregory
On Fri, Jan 31, 2014 at 10:16 AM, Remko Popma wrote: > Anyway, what are we going to do with this? > Team, do we want to support this functionality (localized log message > lookup in ResourceBundles) in Log4J2? > > If so, where do we put the #setResourceBundle() method? On LogManager? > And I gues

Re: org.apache.log4j.Category.setResourceBundle(ResourceBundle)

2014-01-31 Thread Remko Popma
Thanks for the pointer. Looks like LocalizedMessage already covers this functionality. Also, if I'm not mistaken, in LocalizedMessage the key is the message if the bundle does not contain the key, so same behaviour as in v1. So, false alarm then? No need to do anything, right? On Sat, Feb 1, 201

[jira] [Commented] (LOG4J2-500) Unloading one webapp unloads JMX MBeans for all webapps

2014-01-31 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887867#comment-13887867 ] Remko Popma commented on LOG4J2-500: This is not as straight-forward as I thought: it

Re: ApacheCon CFP

2014-01-31 Thread Christian Grobmeier
On 31 Jan 2014, at 14:49, Matt Sicker wrote: Yeah that would work. Nashville huh? My co-worker is from there too, neat. In regard to the async and such, I think that'd be a great idea. One of the selling points of log4j over logback is performance, right? I always add the reconfiguration th

Re: ApacheCon CFP

2014-01-31 Thread Remko Popma
On Saturday, February 1, 2014, Christian Grobmeier wrote: > On 31 Jan 2014, at 14:49, Matt Sicker wrote: > > Yeah that would work. Nashville huh? My co-worker is from there too, neat. >> >> In regard to the async and such, I think that'd be a great idea. One of >> the selling points of log4j ove

Logger setLevel?

2014-01-31 Thread Gary Gregory
Porting from v1... We do not have Logger setLevel(Level) because it is not in the LCD API (Slf4j no, Logback yes, JUL yes). This sure makes it a pain to port from v1. What are the choices? - I hard code everything to the Core Logger API, possible if inflexible. - I add a util method that checks

Re: Logger setLevel?

2014-01-31 Thread Scott Deboy
Add setlevel. I also think appender belongs in Api. Yes? On Jan 31, 2014 10:01 AM, "Gary Gregory" wrote: > Porting from v1... > > We do not have Logger setLevel(Level) because it is not in the LCD API > (Slf4j no, Logback yes, JUL yes). > > This sure makes it a pain to port from v1. > > What are

Re: Logger setLevel?

2014-01-31 Thread Gary Gregory
On Fri, Jan 31, 2014 at 1:05 PM, Scott Deboy wrote: > Add setlevel. I also think appender belongs in Api. Yes? > Appenders are in the Core. That would be a big change. Another surprise: There is no Logger.getLevel(). Gary > On Jan 31, 2014 10:01 AM, "Gary Gregory" wrote: > >> Porting from v

Re: Logger setLevel?

2014-01-31 Thread Scott Deboy
Re: appenders, I was thinking about Remko's response here: http://stackoverflow.com/questions/21303746/migrating-from-log4j-1-2-to-log4j-2-how-to-get-list-of-all-appenders-and-rolli On 1/31/14, Gary Gregory wrote: > On Fri, Jan 31, 2014 at 1:05 PM, Scott Deboy wrote: > >> Add setlevel. I also

Re: Logger setLevel?

2014-01-31 Thread Gary Gregory
On Fri, Jan 31, 2014 at 1:13 PM, Scott Deboy wrote: > Re: appenders, I was thinking about Remko's response here: > > > http://stackoverflow.com/questions/21303746/migrating-from-log4j-1-2-to-log4j-2-how-to-get-list-of-all-appenders-and-rolli > I've picked the low-hanging fruits and given minInde

Re: Logger setLevel?

2014-01-31 Thread Nick Williams
I do not think appenders should be in the API. Appenders are pretty much the definition of an implementation detail. As for setLevel, I absolutely think it's a problem point when migrating from Log4j 1 to Log4j 2. In my Log4j 1 apps, I offer a simple admin console for changing the log levels of

[jira] [Commented] (LOG4J2-500) Unloading one webapp unloads JMX MBeans for all webapps

2014-01-31 Thread Nick Williams (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888026#comment-13888026 ] Nick Williams commented on LOG4J2-500: -- It can be both. If a web application has the

Re: [jira] [Commented] (LOG4J2-323) ThreadLocal-leak on tomcat shutdown when using async logging

2014-01-31 Thread Nick Williams
Tsk tsk. Using auto-refactor again without checking the output. :-P N On Jan 31, 2014, at 7:40 AM, Gary Gregory (JIRA) wrote: > >[ > https://issues.apache.org/jira/browse/LOG4J2-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887754#comment-1388

Re: Logger setLevel?

2014-01-31 Thread Ralph Goers
Setting the level on a Logger is almost pointless. You really want to set the level on a LoggerConfig. When the level on the LoggerConfig is changed you have to call updateLoggers so that all the relevant Loggers will notice the change. FWIW, there are several missing methods to allow better pr

Re: org.apache.log4j.Category.setResourceBundle(ResourceBundle)

2014-01-31 Thread Ralph Goers
Did you look at how we emulate the localization in the Log4j 1.x bridge? I wrote a LocalizedMessage to handle that. Personally, I don’t like the class because it was implemented solely to make Log4j 1.x work more or less the way it always did. We people talk to me about localization I would

Re: Logger setLevel?

2014-01-31 Thread Ralph Goers
Setting the level only for a single logger is called “additivity”. Set the appropriate value on the LoggerConfig for what you want to have happen. Ralph On Jan 31, 2014, at 11:00 AM, Nick Williams wrote: > I do not think appenders should be in the API. Appenders are pretty much the > definit

Re: [jira] [Commented] (LOG4J2-323) ThreadLocal-leak on tomcat shutdown when using async logging

2014-01-31 Thread Gary Gregory
That and every time I update a JDK, Eclipse uses the default JDK I have set up, which is Java 7 of course. So we could just switch to Java 7... :) Gary On Fri, Jan 31, 2014 at 2:11 PM, Nick Williams < nicho...@nicholaswilliams.net> wrote: > Tsk tsk. Using auto-refactor again without checking th

Re: org.apache.log4j.Category.setResourceBundle(ResourceBundle)

2014-01-31 Thread Gary Gregory
On Fri, Jan 31, 2014 at 2:38 PM, Ralph Goers wrote: > Did you look at how we emulate the localization in the Log4j 1.x bridge? > I wrote a LocalizedMessage to handle that. Personally, I don’t like the > class because it was implemented solely to make Log4j 1.x work more or less > the way it alwa

Re: Logger setLevel?

2014-01-31 Thread Gary Gregory
On Fri, Jan 31, 2014 at 2:00 PM, Nick Williams < nicho...@nicholaswilliams.net> wrote: > I do not think appenders should be in the API. Appenders are pretty much > the definition of an implementation detail. > Agreed. Gary > > As for setLevel, I absolutely think it's a problem point when migra

Re: Logger setLevel?

2014-01-31 Thread Gary Gregory
On Fri, Jan 31, 2014 at 2:00 PM, Nick Williams < nicho...@nicholaswilliams.net> wrote: > I do not think appenders should be in the API. Appenders are pretty much > the definition of an implementation detail. > > As for setLevel, I absolutely think it's a problem point when migrating > from Log4j 1

Re: Logger setLevel?

2014-01-31 Thread Nick Williams
On Jan 31, 2014, at 3:29 PM, Gary Gregory wrote: > On Fri, Jan 31, 2014 at 2:00 PM, Nick Williams > wrote: > I do not think appenders should be in the API. Appenders are pretty much the > definition of an implementation detail. > > As for setLevel, I absolutely think it's a problem point when

Re: Logger setLevel?

2014-01-31 Thread Gary Gregory
On Fri, Jan 31, 2014 at 2:33 PM, Ralph Goers wrote: > Setting the level on a Logger is almost pointless. You really want to set > the level on a LoggerConfig. When the level on the LoggerConfig is changed > you have to call updateLoggers so that all the relevant Loggers will notice > the change.

Re: Logger setLevel?

2014-01-31 Thread Gary Gregory
On Fri, Jan 31, 2014 at 4:33 PM, Nick Williams < nicho...@nicholaswilliams.net> wrote: > > On Jan 31, 2014, at 3:29 PM, Gary Gregory wrote: > > On Fri, Jan 31, 2014 at 2:00 PM, Nick Williams < > nicho...@nicholaswilliams.net> wrote: > >> I do not think appenders should be in the API. Appenders are

Re: Logger setLevel?

2014-01-31 Thread Ralph Goers
Did you miss my earlier email where I said the boolean attribute you are trying to set is the LoggerConfig’s additivity flag? All you have to do is loggerConfig.setAdditive(true|flase). I don’t understand why the additivity flag would be a boolean on setLevel(). Ralph On Jan 31, 2014, at 1:4

Re: Logger setLevel?

2014-01-31 Thread Gary Gregory
On Fri, Jan 31, 2014 at 1:13 PM, Scott Deboy wrote: > Re: appenders, I was thinking about Remko's response here: > > > http://stackoverflow.com/questions/21303746/migrating-from-log4j-1-2-to-log4j-2-how-to-get-list-of-all-appenders-and-rolli > I've done a bit more in this area to make it less pa

Re: org.apache.log4j.Category.setResourceBundle(ResourceBundle)

2014-01-31 Thread Gary Gregory
On Fri, Jan 31, 2014 at 3:16 PM, Gary Gregory wrote: > On Fri, Jan 31, 2014 at 2:38 PM, Ralph Goers > wrote: > >> Did you look at how we emulate the localization in the Log4j 1.x bridge? >> I wrote a LocalizedMessage to handle that. Personally, I don’t like the >> class because it was implement

[jira] [Created] (LOG4J2-523) LocalizedMessage serialization is broken

2014-01-31 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-523: --- Summary: LocalizedMessage serialization is broken Key: LOG4J2-523 URL: https://issues.apache.org/jira/browse/LOG4J2-523 Project: Log4j 2 Issue Type: Bug

[jira] [Resolved] (LOG4J2-523) LocalizedMessage serialization is broken

2014-01-31 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-523. - Resolution: Fixed Committed revision 1563331. > LocalizedMessage serialization is broken > -

[jira] [Created] (LOG4J2-524) Rollover does not delete older archives

2014-01-31 Thread Remko Popma (JIRA)
Remko Popma created LOG4J2-524: -- Summary: Rollover does not delete older archives Key: LOG4J2-524 URL: https://issues.apache.org/jira/browse/LOG4J2-524 Project: Log4j 2 Issue Type: Bug

[jira] [Updated] (LOG4J2-524) Rollover does not delete older archives

2014-01-31 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-524: --- Description: This issue was raised by Kireet on the log4j-user mailing list: I am trying to use the

[jira] [Updated] (LOG4J2-524) Rollover does not delete older rolled over files

2014-01-31 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-524: --- Fix Version/s: 2.0-beta9 Summary: Rollover does not delete older rolled over files (was: R

[jira] [Commented] (LOG4J2-524) Rollover does not delete older archives

2014-01-31 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888459#comment-13888459 ] Remko Popma commented on LOG4J2-524: I thought this might be a bug but it seems like e

[jira] [Closed] (LOG4J2-524) Rollover does not delete older rolled over files

2014-01-31 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma closed LOG4J2-524. -- > Rollover does not delete older rolled over files > > >

[jira] [Comment Edited] (LOG4J2-524) Rollover does not delete older rolled over files

2014-01-31 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888459#comment-13888459 ] Remko Popma edited comment on LOG4J2-524 at 2/1/14 5:15 AM: I

[jira] [Reopened] (LOG4J2-524) Rollover does not delete older rolled over files

2014-01-31 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reopened LOG4J2-524: > Rollover does not delete older rolled over files > >

[jira] [Closed] (LOG4J2-524) Rollover does not delete older rolled over files

2014-01-31 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma closed LOG4J2-524. -- Resolution: Not A Problem > Rollover does not delete older rolled over files >

[jira] [Resolved] (LOG4J2-524) Rollover does not delete older rolled over files

2014-01-31 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-524. Resolution: Not A Problem I'm closing this issue as "not a problem". Please feel free to re-open if

Re: ApacheCon CFP

2014-01-31 Thread Nick Williams
Matt, sorry for the delay. I've had a bad cold today. Ick. Anyway, my proposals are below. I haven't submitted them yet. Haven't seen your proposals yet--can you get them to me ASAP? If you decide you're uncomfortable committing to two presentations, I'm prepared to also take on "Extending Log4j