[jira] [Commented] (LOG4J2-618) Solr Appender

2014-05-02 Thread Markus Klose (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987624#comment-13987624 ] Markus Klose commented on LOG4J2-618: - Do you need a new path or are you going to migr

Re: Rename Marker.add(Marker)

2014-05-02 Thread Gary Gregory
I think all that is needed is to rename add(M...) to addParents(M...) Gary On Thu, May 1, 2014 at 11:37 PM, Bruce Brouwer wrote: > I would be in favor of renaming .add(Marker parent) to > .addParents(Marker... parents). If people think it's a big deal, we could > have .addParent(Marker parent)

Re: Use log4j.Clock for timestamping all log events?

2014-05-02 Thread Gary Gregory
On Thu, May 1, 2014 at 7:27 PM, Remko Popma wrote: > ASAIKS, there are currently only two places that use > System.currentTimeMillis() for creating the log event timestamp: > * one of the Log4jLogEvent constructors > * PatternProcessor#formatFileName - the log event created here is a > temporary

Re: Rename Marker.add(Marker)

2014-05-02 Thread Ralph Goers
I started the work on that. Should have it finished tonight. Ralph On May 2, 2014, at 6:51 AM, Gary Gregory wrote: > I think all that is needed is to rename add(M...) to addParents(M...) > > Gary > > > On Thu, May 1, 2014 at 11:37 PM, Bruce Brouwer > wrote: > I would be in favor of renami

Re: Rename Marker.add(Marker)

2014-05-02 Thread Matt Sicker
Wait a minute. Extends sounds like a great method name! On 2 May 2014 11:04, Ralph Goers wrote: > I started the work on that. Should have it finished tonight. > > Ralph > > On May 2, 2014, at 6:51 AM, Gary Gregory wrote: > > I think all that is needed is to rename add(M...) to addParents(M...

[jira] [Commented] (LOG4J2-618) Solr Appender

2014-05-02 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988112#comment-13988112 ] Matt Sicker commented on LOG4J2-618: It's all in log4j-nosql now, so yeah, it would be

Re: Rename Marker.add(Marker)

2014-05-02 Thread Bruce Brouwer
I realized that after I sent that that we cannot call the method extends(...) as it is a reserved word. We could call it setExtends(...) and addExtends(...). My first vote is for set/addExtends(...). My second choice is set/addParents(...). On May 2, 2014 3:16 PM, "Matt Sicker" wrote: > Wait a m

Re: Rename Marker.add(Marker)

2014-05-02 Thread Ralph Goers
What is an “Extends”? I’m implementing addParents. I’m getting tired of “arguments” about names. I’m still having trouble figuring out what a LoggerProvider is if it isn’t a Factory and is, in fact, a Logger. Ralph On May 2, 2014, at 12:51 PM, Bruce Brouwer wrote: > I realized that after I

Re: Rename Marker.add(Marker)

2014-05-02 Thread Matt Sicker
AddParents it is then! Speaking of arguments, how do we vote on the new logo? On 2 May 2014 15:04, Ralph Goers wrote: > What is an “Extends”? I’m implementing addParents. I’m getting tired of > “arguments” about names. I’m still having trouble figuring out what a > LoggerProvider is if it isn

Re: Rename Marker.add(Marker)

2014-05-02 Thread Ralph Goers
If you have time can you see how to do a vote with Apache Steve? That is the tool the ASF uses to vote on the board of directors and new members. Ralph On May 2, 2014, at 1:30 PM, Matt Sicker wrote: > AddParents it is then! Speaking of arguments, how do we vote on the new logo? > > > On 2

Re: Rename Marker.add(Marker)

2014-05-02 Thread Matt Sicker
I'll take a look at the project. On 2 May 2014 16:13, Ralph Goers wrote: > If you have time can you see how to do a vote with Apache Steve? That is > the tool the ASF uses to vote on the board of directors and new members. > > Ralph > > > On May 2, 2014, at 1:30 PM, Matt Sicker wrote: > > Add

[jira] [Assigned] (LOG4J2-628) Cannot set log4j.Clock with Async appender

2014-05-02 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-628: -- Assignee: Remko Popma > Cannot set log4j.Clock with Async appender > --

[jira] [Commented] (LOG4J2-628) Cannot set log4j.Clock with Async appender

2014-05-02 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988426#comment-13988426 ] Remko Popma commented on LOG4J2-628: Understood. We are thinking about modifying log4j

[jira] [Commented] (LOG4J2-628) Cannot set log4j.Clock with Async appender

2014-05-02 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988510#comment-13988510 ] Ralph Goers commented on LOG4J2-628: I don't think using a fictional clock will work o

Re: Rename Marker.add(Marker)

2014-05-02 Thread Matt Sicker
Holy crap, this is the biggest mix of programming languages I've seen since Git! Perl, C, Python, Bash, Ruby, Makefiles, setup.py, the works. I'll see what I can figure out. On 2 May 2014 17:17, Matt Sicker wrote: > I'll take a look at the project. > > > On 2 May 2014 16:13, Ralph Goers wrote:

[jira] [Commented] (LOG4J2-628) Cannot set log4j.Clock with Async appender

2014-05-02 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988580#comment-13988580 ] Remko Popma commented on LOG4J2-628: I agree. Also, using the Clock interface for roll

Re: Use log4j.Clock for timestamping all log events?

2014-05-02 Thread Remko Popma
Currently the documentation for the {{log4j.Clock}} system property is in the Async Logger page. If we make this a general, log4j-wide, system property then the documentation for this property should be in a more central location. If nobody objects, I will add a "System Properties" section to the

[jira] [Commented] (LOG4J2-628) Cannot set log4j.Clock with Async appender

2014-05-02 Thread Bryan Hsueh (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988595#comment-13988595 ] Bryan Hsueh commented on LOG4J2-628: Sorry, I don't use the RolloverAppender, so I'll