[
https://issues.apache.org/jira/browse/LOG4J2-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma resolved LOG4J2-763.
Resolution: Fixed
Improved FormattedMessage, StringFormattedMessage, LocalizedMessage,
[
https://issues.apache.org/jira/browse/LOG4J2-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma reassigned LOG4J2-769:
--
Assignee: Remko Popma
Startup takes a long time if you have empty packages attribute
[
https://issues.apache.org/jira/browse/LOG4J2-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma resolved LOG4J2-769.
Resolution: Fixed
Prevented registration of empty package strings in revision 1617053.
Please
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned
[
https://issues.apache.org/jira/browse/LOG4J2-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092053#comment-14092053
]
Remko Popma commented on LOG4J2-726:
Interestingly, this does not happen if the
[
https://issues.apache.org/jira/browse/LOG4J2-726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma resolved LOG4J2-726.
Resolution: Fixed
Fixed in revision 1617062.
Please verify and close.
logging hang when
[
https://issues.apache.org/jira/browse/LOG4J2-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092060#comment-14092060
]
Remko Popma commented on LOG4J2-770:
We don't really want to modify the Logger
[
https://issues.apache.org/jira/browse/LOG4J2-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092070#comment-14092070
]
Remko Popma commented on LOG4J2-747:
Does this problem happen only with web
Instead of calling getFormattedMessage(), how about refactoring it and call an
initSomething method. This will make the call sites less smelly of programming
by side effect.
Gary
div Original message /divdivFrom: rpo...@apache.org
/divdivDate:08/10/2014 02:40 (GMT-05:00)
IIRC our Strings utility class has an isEmpty method for this pattern.
Gary
div Original message /divdivFrom: rpo...@apache.org
/divdivDate:08/10/2014 03:09 (GMT-05:00) /divdivTo:
comm...@logging.apache.org /divdivSubject: svn commit: r1617053 - in
One of the points of getFormattedMessage was to defer the expense of formatting
until it is actually required. This change eliminates that savings. I would
have preferred having the async component call getFormattedMessage when it
needed to, thus not impacting synchronous configurations.
Sent
True. Until now getFormattedMessage() used lazy initialization in many
messages. The LOG4J2-763 changes mean initialization always happens in the
constructor so the code can be simplified. I won't have time for this tonight
though.
Sent from my iPhone
On 2014/08/10, at 21:12, Gary Gregory
Well darn, you're right!
I completely missed that.
I wish you'd told me a few days ago though. That kind of feedback was exactly
was I was hoping for when I attached the patch to the Jira ticket.
Sent from my iPhone
On 2014/08/10, at 21:49, Ralph Goers rgo...@apache.org wrote:
One of
Does that mean more fields can be made final?
Gary
div Original message /divdivFrom: Remko Popma
remko.po...@gmail.com /divdivDate:08/10/2014 08:55 (GMT-05:00)
/divdivTo: Log4J Developers List log4j-dev@logging.apache.org
/divdivSubject: Re: svn commit: r1617051 - in
I'll take a look at fixing it the way Ralph suggested later this week.
On Sunday, August 10, 2014, Remko Popma remko.po...@gmail.com wrote:
Well darn, you're right!
I completely missed that.
I wish you'd told me a few days ago though. That kind of feedback was
exactly was I was hoping for
Ralph is saying that lazy initialization is better because the message may
be filtered out and end up not being logged. In that case we don't need to
pay the cost of constructing the formatted string unnecessarily.
I'll take a look at it again later next week.
(ParameterizedMessage was not lazy
-0
Coolness is not actually a good reason to change infrastructures. :-)
On 9 Aug 2014 15:48, Gary Gregory garydgreg...@gmail.com wrote:
The person who called the VOTE should tally it and reply with a
[RESULT][VOTE] subject.
Gary
On Sat, Aug 9, 2014 at 9:23 AM, Remko Popma
We're considering Git because it makes branching and merging easier. This
is in the context of recent discussions on how to work on bugfix releases
and new features in parallel without too much busywork of syncing multiple
branches.
On Sunday, August 10, 2014, Dominik Psenner dpsen...@gmail.com
I think there was a reason ParameterizedMessage got the strings up front, but I
don't know what it is. If it is possible to defer that I think that would be
great.
Sent from my iPad
On Aug 10, 2014, at 6:19 AM, Remko Popma remko.po...@gmail.com wrote:
Ralph is saying that lazy
Matt called the vote. He should tally the result.
Sent from my iPad
On Aug 9, 2014, at 6:47 AM, Gary Gregory garydgreg...@gmail.com wrote:
The person who called the VOTE should tally it and reply with a
[RESULT][VOTE] subject.
Gary
On Sat, Aug 9, 2014 at 9:23 AM, Remko Popma
Votes cast:
+1 Matt Sicker
+1 Scott Deboy
+1 Remko Popma
+0 Ralph Goers
-0 Gary Gregory
+1 Bruno Mahe
-0 Dominik Psenner
There are no guidelines I found about which process this would follow, so
let's say it used the Lazy Consensus method. Then we have:
+1 Scott
+1 Remko
+0 Ralph
-0 Gary
Based
My guess is that the values to ParameterizedMessage could be mutable and
would change by the time they were logged. I thought I remembered reading a
similar issue with ThreadContext or something elsewhere, but I can't find
it right now.
On 10 August 2014 09:56, Ralph Goers rgo...@apache.org
I'd be happy to RM again. Unless said otherwise, I'll begin the release
candidate process next weekend. Good luck, Ralph!
On 9 August 2014 19:54, Remko Popma remko.po...@gmail.com wrote:
Ralph, great to hear you are recovering so fast from surgery. Good luck
with the move!
Gary, the Jira
[
https://issues.apache.org/jira/browse/LOG4J2-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092106#comment-14092106
]
Matt Sicker commented on LOG4J2-608:
It would be easier to require setting the system
[
https://issues.apache.org/jira/browse/LOG4J2-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092109#comment-14092109
]
Matt Sicker commented on LOG4J2-715:
I had an idea on how {{AbstractLifeCycle}} could
I think it is good to spread RM experience around a bit so I am happy to
see Matt step up again :-)
Gary
On Sun, Aug 10, 2014 at 11:36 AM, Matt Sicker boa...@gmail.com wrote:
I'd be happy to RM again. Unless said otherwise, I'll begin the release
candidate process next weekend. Good luck,
I still need to think about this. I'll have time tomorrow...
Gary
On Fri, Aug 8, 2014 at 10:05 PM, Matt Sicker boa...@gmail.com wrote:
Skip to the bottom if you don't like my essay emails and just care about
the questions. ;)
There are currently five states: initialized, starting, started,
[
https://issues.apache.org/jira/browse/LOG4J2-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092121#comment-14092121
]
A B commented on LOG4J2-747:
I will try to answer for both the comments above
I could not get
[
https://issues.apache.org/jira/browse/LOG4J2-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092121#comment-14092121
]
A B edited comment on LOG4J2-747 at 8/10/14 4:40 PM:
-
I will try to
[
https://issues.apache.org/jira/browse/LOG4J2-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092121#comment-14092121
]
A B edited comment on LOG4J2-747 at 8/10/14 5:19 PM:
-
I will try to
[
https://issues.apache.org/jira/browse/LOG4J2-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092121#comment-14092121
]
A B edited comment on LOG4J2-747 at 8/10/14 5:20 PM:
-
I will try to
Does this really require 3 + 1 votes from PMC members?
Sent from my iPad
On Aug 10, 2014, at 8:27 AM, Matt Sicker boa...@gmail.com wrote:
Votes cast:
+1 Matt Sicker
+1 Scott Deboy
+1 Remko Popma
+0 Ralph Goers
-0 Gary Gregory
+1 Bruno Mahe
-0 Dominik Psenner
There are no
Matt, after reading our own guidelines I think your vote should count since you
initiated the vote.
Sent from my iPad
On Aug 10, 2014, at 12:41 PM, Ralph Goers rgo...@apache.org wrote:
Does this really require 3 + 1 votes from PMC members?
Sent from my iPad
On Aug 10, 2014, at 8:27
Oh, I didn't find that part. Also, I wasn't sure which voting method this
sort of vote might require. If that makes it +3 to switch to Git, then it
looks like we can ask INFRA to help us out?
On 10 August 2014 14:51, Ralph Goers rgo...@apache.org wrote:
Matt, after reading our own guidelines I
I'm not sure what the process is.
Sent from my iPad
On Aug 10, 2014, at 1:25 PM, Matt Sicker boa...@gmail.com wrote:
Oh, I didn't find that part. Also, I wasn't sure which voting method this
sort of vote might require. If that makes it +3 to switch to Git, then it
looks like we can ask
Here's the ticket from back when Ant migrated:
https://issues.apache.org/jira/browse/INFRA-7759
Looks like we can do the same. It'll be easier, too, since we' don't have
like six subprojects to work with as well.
On 10 August 2014 15:56, Ralph Goers rgo...@apache.org wrote:
I'm not sure what
I filed a ticket with infra here:
https://issues.apache.org/jira/browse/INFRA-8169
On 10 August 2014 16:09, Matt Sicker boa...@gmail.com wrote:
Here's the ticket from back when Ant migrated:
https://issues.apache.org/jira/browse/INFRA-7759
Looks like we can do the same. It'll be easier,
For what it's worth, moving to Git helps increase contributions from places
like GitHub. Once we're migrated, we can have pull requests sent to the
mailing list. These emails contain instructions on how to pull them locally
as well as merge them to our own official repo in such a way to
[
https://issues.apache.org/jira/browse/LOG4J2-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092217#comment-14092217
]
Matt Sicker commented on LOG4J2-745:
Alright, here's the rundown on the patch:
# This
[
https://issues.apache.org/jira/browse/LOG4J2-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092261#comment-14092261
]
Remko Popma commented on LOG4J2-608:
Okay, then I propose we start with requiring
[
https://issues.apache.org/jira/browse/LOG4J2-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092272#comment-14092272
]
Matt Sicker commented on LOG4J2-608:
That would work better as an initial
[
https://issues.apache.org/jira/browse/LOG4J2-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092273#comment-14092273
]
Remko Popma commented on LOG4J2-760:
How about this?
We already have a manually
[
https://issues.apache.org/jira/browse/LOG4J2-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092273#comment-14092273
]
Remko Popma edited comment on LOG4J2-760 at 8/10/14 11:23 PM:
--
[
https://issues.apache.org/jira/browse/LOG4J2-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma reassigned LOG4J2-679:
--
Assignee: Remko Popma
Log rotation partly failed with error: Unable to create directory ...
[
https://issues.apache.org/jira/browse/LOG4J2-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma updated LOG4J2-679:
---
Fix Version/s: 2.0.2
Log rotation partly failed with error: Unable to create directory ...
[
https://issues.apache.org/jira/browse/LOG4J2-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092343#comment-14092343
]
Remko Popma commented on LOG4J2-747:
Formatting tips:
# Multi-line code or
[
https://issues.apache.org/jira/browse/LOG4J2-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Scott Harrington updated LOG4J2-745:
Attachment: LOG4J2-745-patch-r1617171.txt
Hi Matt, thanks for taking a look.
1. I've
[
https://issues.apache.org/jira/browse/LOG4J2-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma reopened LOG4J2-763:
Re-opening: the current implementation solves the problem but may have some
performance impact. It is
[
https://issues.apache.org/jira/browse/LOG4J2-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092343#comment-14092343
]
Remko Popma edited comment on LOG4J2-747 at 8/11/14 2:20 AM:
-
[
https://issues.apache.org/jira/browse/LOG4J2-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092360#comment-14092360
]
Matt Sicker commented on LOG4J2-745:
Much better! I'm going to look over this some
[
https://issues.apache.org/jira/browse/LOG4J2-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Sicker updated LOG4J2-745:
---
Attachment: Safer_PluginManager.patch
Here's a slightly updated version of your patch. However, I
[
https://issues.apache.org/jira/browse/LOG4J2-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092375#comment-14092375
]
Matt Sicker commented on LOG4J2-745:
Hmm, it appears that error message is unrelated
[
https://issues.apache.org/jira/browse/LOG4J2-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma reopened LOG4J2-769:
Re-opening for regression in revision 1617171:
{{PluginManager.addPackages(CollectionString
[
https://issues.apache.org/jira/browse/LOG4J2-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092397#comment-14092397
]
Remko Popma commented on LOG4J2-745:
Those error messages were introduced (by design)
[
https://issues.apache.org/jira/browse/LOG4J2-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092399#comment-14092399
]
Gary Gregory commented on LOG4J2-760:
-
Good idea.
XMLLayout's dependence on
[
https://issues.apache.org/jira/browse/LOG4J2-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092401#comment-14092401
]
Scott Harrington commented on LOG4J2-745:
-
Sorry Dave, I can't let you do that it
[
https://issues.apache.org/jira/browse/LOG4J2-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092403#comment-14092403
]
Scott Harrington commented on LOG4J2-745:
-
{code}
private static class Holder
[
https://issues.apache.org/jira/browse/LOG4J2-768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Scott Harrington updated LOG4J2-768:
Comment: was deleted
(was: {code}
private static class Holder {
// the usual
[
https://issues.apache.org/jira/browse/LOG4J2-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092402#comment-14092402
]
Scott Harrington commented on LOG4J2-768:
-
{code}
private static class Holder
59 matches
Mail list logo
