[jira] [Closed] (LOG4J2-997) removeFilter() in AbstractFilterable does not remove filter

2016-06-05 Thread Maytee Chinavanichkit (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maytee Chinavanichkit closed LOG4J2-997. > removeFilter() in AbstractFilterable does not remove filter >

[jira] [Commented] (LOG4J2-997) removeFilter() in AbstractFilterable does not remove filter

2016-06-05 Thread Maytee Chinavanichkit (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315837#comment-15315837 ] Maytee Chinavanichkit commented on LOG4J2-997: -- The change LGTM. Thanks for g

[jira] [Commented] (LOG4J2-1385) (GC) CSV layouts should not create a new CSVPrinter for each log event

2016-06-05 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315846#comment-15315846 ] Remko Popma commented on LOG4J2-1385: - [~garydgregory], do the CsvLayout and CsvParam

Re: Garbage-free Log4j docs preview

2016-06-05 Thread Remko Popma
On Sunday, June 5, 2016 at 7:39:25 PM UTC+9, Philippe Marschall wrote: > > > > On Friday, June 3, 2016 at 5:50:36 PM UTC+2, Remko Popma wrote: >> >> >> >> On Friday, June 3, 2016 at 4:42:51 PM UTC+9, Philippe Marschall wrote: >>> >>> >>> >>> On Tuesday, May 17, 2016 at 7:13:09 PM UTC+2, Remko Pop

Re: Log4j 2.6.1

2016-06-05 Thread Remko Popma
Is the footer being written twice in LOG4J2-1405 a showstopper for 2.6.1? If this is an easy fix I'd say go for it, but otherwise perhaps it makes sense to release what's in master now. Especially LOG4J2-1409

Jenkins build is back to stable : Log4j 2.x #2000

2016-06-05 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: Log4j 2.6.1

2016-06-05 Thread Ralph Goers
I created the fix and tested it. The test works when I run it standalone but fails when I run all tests. I am not sure why. One way or another I plan to create the release today. Ralph > On Jun 5, 2016, at 4:23 AM, Remko Popma wrote: > > Is the footer being written twice in LOG4J2-1405 a show

Re: Log4j 2.6.1

2016-06-05 Thread Gary Gregory
+1 to release 2.6.1 ASAP to pick up the message factory fixes. Gary On Jun 5, 2016 7:47 AM, "Ralph Goers" wrote: > I created the fix and tested it. The test works when I run it standalone > but fails when I run all tests. I am not sure why. One way or another I > plan to create the release today

Re: Log4j 2.6.1

2016-06-05 Thread Ralph Goers
Actually, my fix broke a different unit test. Fixing that one. Sent from my iPhone > On Jun 5, 2016, at 8:53 AM, Gary Gregory wrote: > > +1 to release 2.6.1 ASAP to pick up the message factory fixes. > > Gary > >> On Jun 5, 2016 7:47 AM, "Ralph Goers" wrote: >> I created the fix and tested i

[jira] [Commented] (LOG4J2-1385) (GC) CSV layouts should not create a new CSVPrinter for each log event

2016-06-05 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315993#comment-15315993 ] Gary Gregory commented on LOG4J2-1385: -- Yes, Apache Commons CSV 1.4 is now required.

[jira] [Commented] (LOG4J2-1385) (GC) CSV layouts should not create a new CSVPrinter for each log event

2016-06-05 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316069#comment-15316069 ] Remko Popma commented on LOG4J2-1385: - Levels is probably not a problem since the Str

[jira] [Commented] (LOG4J2-1385) (GC) CSV layouts should not create a new CSVPrinter for each log event

2016-06-05 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316072#comment-15316072 ] Remko Popma commented on LOG4J2-1385: - Actually, perhaps we should create an internal

[jira] [Created] (LOG4J2-1412) Unbox ringbuffer size should be configurable

2016-06-05 Thread Remko Popma (JIRA)
Remko Popma created LOG4J2-1412: --- Summary: Unbox ringbuffer size should be configurable Key: LOG4J2-1412 URL: https://issues.apache.org/jira/browse/LOG4J2-1412 Project: Log4j 2 Issue Type: Impr

[jira] [Created] (LOG4J2-1413) Reduce temporary objects when rendering ThrowableProxy to text

2016-06-05 Thread Remko Popma (JIRA)
Remko Popma created LOG4J2-1413: --- Summary: Reduce temporary objects when rendering ThrowableProxy to text Key: LOG4J2-1413 URL: https://issues.apache.org/jira/browse/LOG4J2-1413 Project: Log4j 2

[jira] [Commented] (LOG4J2-1385) (GC) CSV layouts should not create a new CSVPrinter for each log event

2016-06-05 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316083#comment-15316083 ] Gary Gregory commented on LOG4J2-1385: -- Yes, the CSV layouts should be redone to wor

MessageFactory2 missing @since tag

2016-06-05 Thread Gary Gregory
The type MessageFactory2 is missing its @since tag. When was this added? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition Spring Batch i

[jira] [Commented] (LOG4J2-1385) (GC) CSV layouts should not create a new CSVPrinter for each log event

2016-06-05 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316084#comment-15316084 ] Gary Gregory commented on LOG4J2-1385: -- Hm... it does not look obvious to me how to

[jira] [Commented] (LOG4J2-1385) (GC) CSV layouts should not create a new CSVPrinter for each log event

2016-06-05 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316085#comment-15316085 ] Gary Gregory commented on LOG4J2-1385: -- I think the box calls might mess up null pro

Re: MessageFactory2 missing @since tag

2016-06-05 Thread Remko Popma
2.6 Sent from my iPhone > On 2016/06/06, at 8:57, Gary Gregory wrote: > > The type MessageFactory2 is missing its @since tag. When was this added? > > Gary > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second Edition > JUnit in Action, Seco

Re: Log4j 2.6.1

2016-06-05 Thread Ralph Goers
The release is in progress. Ralph > On Jun 5, 2016, at 10:09 AM, Ralph Goers wrote: > > Actually, my fix broke a different unit test. Fixing that one. > > Sent from my iPhone > > On Jun 5, 2016, at 8:53 AM, Gary Gregory > wrote: > >> +1 to release 2.6.1 ASAP

[jira] [Commented] (LOG4J2-1385) (GC) CSV layouts should not create a new CSVPrinter for each log event

2016-06-05 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316092#comment-15316092 ] Remko Popma commented on LOG4J2-1385: - I would subclass {{org.apache.commons.csv.CSVF

[jira] [Commented] (LOG4J2-1385) (GC) CSV layouts should not create a new CSVPrinter for each log event

2016-06-05 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316095#comment-15316095 ] Remko Popma commented on LOG4J2-1385: - Not sure I follow your comment on null process

Re: MessageFactory2 missing @since tag

2016-06-05 Thread Gary Gregory
Thanks, fixed. Gary On Sun, Jun 5, 2016 at 5:31 PM, Remko Popma wrote: > 2.6 > > Sent from my iPhone > > On 2016/06/06, at 8:57, Gary Gregory wrote: > > The type MessageFactory2 is missing its @since tag. When was this added? > > Gary > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.o

Re: Log4j 2.6.1

2016-06-05 Thread Remko Popma
That's great. Thanks, Ralph! Sent from my iPhone > On 2016/06/06, at 9:34, Ralph Goers wrote: > > The release is in progress. > > Ralph > >> On Jun 5, 2016, at 10:09 AM, Ralph Goers wrote: >> >> Actually, my fix broke a different unit test. Fixing that one. >> >> Sent from my iPhone >> >

[jira] [Commented] (LOG4J2-1385) (GC) CSV layouts should not create a new CSVPrinter for each log event

2016-06-05 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316097#comment-15316097 ] Gary Gregory commented on LOG4J2-1385: -- [~rem...@yahoo.com]: Do you feel like writin

Re: MessageFactory2 missing @since tag

2016-06-05 Thread Ralph Goers
Didn’t make 2.6.1 Ralph > On Jun 5, 2016, at 5:43 PM, Gary Gregory wrote: > > Thanks, fixed. > > Gary > > On Sun, Jun 5, 2016 at 5:31 PM, Remko Popma > wrote: > 2.6 > > Sent from my iPhone > > On 2016/06/06, at 8:57, Gary Gregory

[jira] [Commented] (LOG4J2-1385) (GC) CSV layouts should not create a new CSVPrinter for each log event

2016-06-05 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316099#comment-15316099 ] Gary Gregory commented on LOG4J2-1385: -- They are not but won't a null Object (or box

Re: MessageFactory2 missing @since tag

2016-06-05 Thread Remko Popma
No biggie. Sent from my iPhone > On 2016/06/06, at 9:51, Ralph Goers wrote: > > Didn’t make 2.6.1 > > Ralph > >> On Jun 5, 2016, at 5:43 PM, Gary Gregory wrote: >> >> Thanks, fixed. >> >> Gary >> >>> On Sun, Jun 5, 2016 at 5:31 PM, Remko Popma wrote: >>> 2.6 >>> >>> Sent from my iPhone

[VOTE] Log4j 2.6.1 rc1

2016-06-05 Thread Ralph Goers
This is a vote to release Log4j 2.6.1, the next version of the Log4j 2 project. Please download, test, and cast your votes on the log4j developers list. [] +1, release the artifacts [] -1, don't release because... The vote will remain open for 72 hours (or more if required). All votes are welcom

[jira] [Resolved] (LOG4J2-1405) 2.6 html format - "" inserted in the middle of when restart tomcat

2016-06-05 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-1405. - Resolution: Fixed Assignee: Ralph Goers Fix Version/s: 2.6.1 Please add the {{OnS

[jira] [Created] (LOG4J2-1414) Minor issues with the 2.6.1 web site

2016-06-05 Thread Remko Popma (JIRA)
Remko Popma created LOG4J2-1414: --- Summary: Minor issues with the 2.6.1 web site Key: LOG4J2-1414 URL: https://issues.apache.org/jira/browse/LOG4J2-1414 Project: Log4j 2 Issue Type: Bug

[jira] [Updated] (LOG4J2-1414) Minor issues with the 2.6.1 web site

2016-06-05 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1414: Affects Version/s: (was: 2.6) 2.6.1 Fix Version/s: (was: 2.6.

[jira] [Resolved] (LOG4J2-1394) Minor issues with the 2.6 web site

2016-06-05 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-1394. - Resolution: Fixed Various items were fixed in time for the 2.6.1 release. Marked this ticket as

[jira] [Closed] (LOG4J2-1394) Minor issues with the 2.6 web site

2016-06-05 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma closed LOG4J2-1394. --- > Minor issues with the 2.6 web site > -- > > Key: LOG4J2

[jira] [Updated] (LOG4J2-1414) Minor issues with the 2.6.1 web site

2016-06-05 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1414: Description: 2.6 (-) Project Information -> Dependencies, does not exist (I believe there's alread

2.6.1 web site

2016-06-05 Thread Ralph Goers
It seems I forgot to update changes.xml and put in the date before running the release. This should manually be corrected on the web site. If you guys want to update the site before it is released I think you should be able to clone my repo and do pull requests. Ralph

Re: 2.6.1 web site

2016-06-05 Thread Ralph Goers
Oh - the repo is at https://github.com/rgoers/rgoers.github.io. Ralph > On Jun 5, 2016, at 8:15 PM, Ralph Goers wrote: > > It seems I forgot to update changes.xml and put in the date before running > the release. This should manually be corrected on the web site. If you guys > want to update

Re: 2.6.1 web site

2016-06-05 Thread Ralph Goers
I added Gary and Matt as collaborators. Gary, I don’t know your github id. Ralph > On Jun 5, 2016, at 8:26 PM, Ralph Goers wrote: > > Oh - the repo is at https://github.com/rgoers/rgoers.github.io. > > Ralph > >> On Jun 5, 2016, at 8:15 PM, Ralph Goers wrote: >> >> It seems I forgot to upd

Re: 2.6.1 web site

2016-06-05 Thread Ralph Goers
Also note that this repo is just temporary. The real fixes need to be committed to the real git repo. I will completely delete the site in git when I do the next release. Ralph > On Jun 5, 2016, at 8:30 PM, Ralph Goers wrote: > > > I added Gary and Matt as collaborators. Gary, I don’t know y

Re: 2.6.1 web site

2016-06-05 Thread Ralph Goers
Never mind. I found your account Gary. Ralph > On Jun 5, 2016, at 8:30 PM, Ralph Goers wrote: > > > I added Gary and Matt as collaborators. Gary, I don’t know your github id. > > Ralph > >> On Jun 5, 2016, at 8:26 PM, Ralph Goers wrote: >> >> Oh - the repo is at https://github.com/rgoers/r

Re: Log4j 2.6.1

2016-06-05 Thread Gary Gregory
On Jun 5, 2016 5:45 PM, "Remko Popma" wrote: > > That's great. Thanks, Ralph! +1 Gary > > Sent from my iPhone > > On 2016/06/06, at 9:34, Ralph Goers wrote: > >> The release is in progress. >> >> Ralph >> >>> On Jun 5, 2016, at 10:09 AM, Ralph Goers wrote: >>> >>> Actually, my fix broke a diff

Re: MessageFactory2 missing @since tag

2016-06-05 Thread Gary Gregory
On Jun 5, 2016 6:03 PM, "Remko Popma" wrote: > > No biggie. Agreed! Gary > > Sent from my iPhone > > On 2016/06/06, at 9:51, Ralph Goers wrote: > >> Didn’t make 2.6.1 >> >> Ralph >> >>> On Jun 5, 2016, at 5:43 PM, Gary Gregory wrote: >>> >>> Thanks, fixed. >>> >>> Gary >>> >>> On Sun, Jun 5, 2

Re: 2.6.1 web site

2016-06-05 Thread Gary Gregory
Looks like you found me ;-) on GitHub, for the others: garydgregory Gary On Sun, Jun 5, 2016 at 8:30 PM, Ralph Goers wrote: > > I added Gary and Matt as collaborators. Gary, I don’t know your github id. > > Ralph > > > On Jun 5, 2016, at 8:26 PM, Ralph Goers > wrote: > > > > Oh - the repo is a