[jira] [Comment Edited] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725622#comment-15725622 ] Johno Crawford edited comment on LOG4J2-1642 at 12/6/16 2:50 PM: - I

[jira] [Commented] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725622#comment-15725622 ] Johno Crawford commented on LOG4J2-1642: I wonder if in some circumstances during JVM shutdown

[jira] [Commented] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725616#comment-15725616 ] Johno Crawford commented on LOG4J2-1642: To verify I wrapped the executors shutdown calls and

[jira] [Comment Edited] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725622#comment-15725622 ] Johno Crawford edited comment on LOG4J2-1642 at 12/6/16 3:03 PM: - -I

[jira] [Comment Edited] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725622#comment-15725622 ] Johno Crawford edited comment on LOG4J2-1642 at 12/6/16 2:55 PM: - I

[jira] [Resolved] (LOG4J2-1687) NPE in ThrowableProxy when resolving stack in Java EE/OSGi environment

2016-12-06 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-1687. -- Resolution: Fixed Assignee: Gary Gregory Fix Version/s: 2.8 In git master.

[jira] [Commented] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726209#comment-15726209 ] Johno Crawford commented on LOG4J2-1642: Please find attached patch proposal. >

[jira] [Updated] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated LOG4J2-1642: --- Flags: Patch > DefaultShutdownCallbackRegistry throws NoClassDefFoundError >

[jira] [Updated] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated LOG4J2-1642: --- Attachment: LOG4J2_1642.patch > DefaultShutdownCallbackRegistry throws NoClassDefFoundError

[jira] [Commented] (LOG4J2-1713) Allow for more general serialization of Log4j2 configurations

2016-12-06 Thread Steve Cohen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726263#comment-15726263 ] Steve Cohen commented on LOG4J2-1713: - I no longer believe in this solution. It is incorrect and I

[jira] [Commented] (LOG4J2-1725) RollingFileAppender's filePattern not reloaded when using monitorInterval

2016-12-06 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727857#comment-15727857 ] Ralph Goers commented on LOG4J2-1725: - This happens because the pattern is managed by the

[jira] [Commented] (LOG4J2-1725) RollingFileAppender's filePattern not reloaded when using monitorInterval

2016-12-06 Thread Benjamin Jaton (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727239#comment-15727239 ] Benjamin Jaton commented on LOG4J2-1725: Yes, that's correct. > RollingFileAppender's

[jira] [Resolved] (LOG4J2-1474) CronTriggeringPolicy raise exception and fail to rollover log file when evaluateOnStartup is true.

2016-12-06 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-1474. -- Resolution: Fixed Assignee: Gary Gregory In git master. All tests pass (added new tests

Re: Fwd: logging-log4j2 git commit: [LOG4J2-1642]

2016-12-06 Thread Gary Gregory
On Tue, Dec 6, 2016 at 9:08 PM, Matt Sicker wrote: > Also, for some context: all classes in log4-core.jar share the same > ClassLoader in OSGi, so using one from class A can be used to load class B. > LoaderUtil tends to rely on getting whatever ClassLoader is in the current >

[jira] [Updated] (LOG4J2-1724) Using variables in GelfLayout's additional fields at runtime

2016-12-06 Thread Alexander K. (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander K. updated LOG4J2-1724: - Attachment: patchfile.txt The patch is attached. > Using variables in GelfLayout's additional

[jira] [Comment Edited] (LOG4J2-1724) Using variables in GelfLayout's additional fields at runtime

2016-12-06 Thread Alexander K. (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727931#comment-15727931 ] Alexander K. edited comment on LOG4J2-1724 at 12/7/16 6:58 AM: --- The patch

[jira] [Updated] (LOG4J2-1642) DefaultShutdownCallbackRegistry can throws NoClassDefFoundError

2016-12-06 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1642: - Summary: DefaultShutdownCallbackRegistry can throws NoClassDefFoundError (was:

[jira] [Updated] (LOG4J2-1642) DefaultShutdownCallbackRegistry can throw a NoClassDefFoundError

2016-12-06 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1642: - Summary: DefaultShutdownCallbackRegistry can throw a NoClassDefFoundError (was:

[jira] [Commented] (LOG4J2-1725) RollingFileAppender's filePattern not reloaded when using monitorInterval

2016-12-06 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727165#comment-15727165 ] Gary Gregory commented on LOG4J2-1725: -- Instead of {{app.log.1.zip}}, {{app.log.2.zip}}, and so on?

[jira] [Resolved] (LOG4J2-1642) DefaultShutdownCallbackRegistry can throw a NoClassDefFoundError

2016-12-06 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-1642. -- Resolution: Fixed Assignee: Gary Gregory Fix Version/s: 2.8 Patch applied.

Fwd: logging-log4j2 git commit: [LOG4J2-1642]

2016-12-06 Thread Matt Sicker
I'm not sure if that LoaderUtil line will work properly everywhere. You already implicitly load the class by referencing the class's .class property I think. Either way, a more amusing and surefire way to make it load would be:

Re: Fwd: logging-log4j2 git commit: [LOG4J2-1642]

2016-12-06 Thread Matt Sicker
Also, for some context: all classes in log4-core.jar share the same ClassLoader in OSGi, so using one from class A can be used to load class B. LoaderUtil tends to rely on getting whatever ClassLoader is in the current Thread's context ClassLoader which by default is whatever ClassLoader was used

[jira] [Updated] (LOG4J2-1474) CronTriggeringPolicy raise exception and fail to rollover log file when evaluateOnStartup is true.

2016-12-06 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1474: - Summary: CronTriggeringPolicy raise exception and fail to rollover log file when

Jenkins build is back to stable : Log4j 2.x #2522

2016-12-06 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Commented] (LOG4J2-1725) RollingFileAppender's filePattern not reloaded when using monitorInterval

2016-12-06 Thread Benjamin Jaton (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727118#comment-15727118 ] Benjamin Jaton commented on LOG4J2-1725: (I corrected the description.) Adding the .zip extension

[jira] [Updated] (LOG4J2-1725) RollingFileAppender's filePattern not reloaded when using monitorInterval

2016-12-06 Thread Benjamin Jaton (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jaton updated LOG4J2-1725: --- Description: Using the configuration below: {code} %d %p %c{1.}

[jira] [Commented] (LOG4J2-1725) RollingFileAppender's filePattern not reloaded when using monitorInterval

2016-12-06 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727112#comment-15727112 ] Gary Gregory commented on LOG4J2-1725: -- Benjamin, Can you be more specific please? Are you not

Jenkins build became unstable: Log4j 2.x #2521

2016-12-06 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: Fwd: logging-log4j2 git commit: [LOG4J2-1642]

2016-12-06 Thread Gary Gregory
I think one of the points here is that a class is loaded from a specific class loader. This is not clear from the code or comments. I am not sure this 100% correct either but if that fixes at least the null class loader NPE then that is a good thing. Especially if the fix is less hacky than

Re: Fwd: logging-log4j2 git commit: [LOG4J2-1642]

2016-12-06 Thread Matt Sicker
In an OSGi environment, the best ClassLoader to use for something in log4j-core is one obtained from a class in log4j-core. Come to think of it, it'd be better to do something like this: LoggerContext.class.getClassLoader().loadClass(...); On 6 December 2016 at 22:39, Gary Gregory

[jira] [Updated] (LOG4J2-1687) NPE in ThrowableProxy when resolving stack in Java EE/OSGi environment

2016-12-06 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1687: - Summary: NPE in ThrowableProxy when resolving stack in Java EE/OSGi environment (was: NPE in

Jenkins build is back to stable : Log4j 2.x #2519

2016-12-06 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Comment Edited] (LOG4J2-1713) Allow for more general serialization of Log4j2 configurations

2016-12-06 Thread Steve Cohen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675006#comment-15675006 ] Steve Cohen edited comment on LOG4J2-1713 at 12/6/16 7:06 PM: -- -@PreDestroy

[jira] [Comment Edited] (LOG4J2-1713) Allow for more general serialization of Log4j2 configurations

2016-12-06 Thread Steve Cohen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675006#comment-15675006 ] Steve Cohen edited comment on LOG4J2-1713 at 12/6/16 7:09 PM: -- -@PreDestroy

[jira] [Created] (LOG4J2-1725) RollingFileAppender's filePattern not reloaded when using monitorInterval

2016-12-06 Thread Benjamin Jaton (JIRA)
Benjamin Jaton created LOG4J2-1725: -- Summary: RollingFileAppender's filePattern not reloaded when using monitorInterval Key: LOG4J2-1725 URL: https://issues.apache.org/jira/browse/LOG4J2-1725

[jira] [Updated] (LOG4J2-1725) RollingFileAppender's filePattern not reloaded when using monitorInterval

2016-12-06 Thread Benjamin Jaton (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jaton updated LOG4J2-1725: --- Affects Version/s: 2.7 > RollingFileAppender's filePattern not reloaded when using

[jira] [Updated] (LOG4J2-1724) Using variables in GelfLayout's additional fields at runtime

2016-12-06 Thread Alexander K. (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander K. updated LOG4J2-1724: - Description: Hello, I would like to suggest the following improvements for GelfLayout: 1. Using

Re: Modules for SQL and MOM/JMS

2016-12-06 Thread Mikael Ståldal
>From my POV it's primarily about reducing/managing dependencies. If we can save A LOT in terms of size, that's relevant too, but not only to save a little. If you are counting KBs of jar size, you should probably use *ProGuard* or something like that. On Mon, Dec 5, 2016 at 6:23 PM, Gary

[jira] [Updated] (LOG4J2-1687) NPE in ThrowableProxy when resolving stack

2016-12-06 Thread Robert Christiansen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Christiansen updated LOG4J2-1687: Attachment: LOG4J2-1687.patch Patch with test. > NPE in ThrowableProxy when

[jira] [Created] (LOG4J2-1724) Using variables in GelfLayout's additional fields at runtime

2016-12-06 Thread Alexander K. (JIRA)
Alexander K. created LOG4J2-1724: Summary: Using variables in GelfLayout's additional fields at runtime Key: LOG4J2-1724 URL: https://issues.apache.org/jira/browse/LOG4J2-1724 Project: Log4j 2

[jira] [Issue Comment Deleted] (LOG4J2-1687) NPE in ThrowableProxy when resolving stack

2016-12-06 Thread Robert Christiansen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Christiansen updated LOG4J2-1687: Comment: was deleted (was: Patch with test.) > NPE in ThrowableProxy when

[jira] [Updated] (LOG4J2-1687) NPE in ThrowableProxy when resolving stack

2016-12-06 Thread Robert Christiansen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Christiansen updated LOG4J2-1687: Attachment: (was: LOG4J2-1687.patch) > NPE in ThrowableProxy when resolving

[jira] [Assigned] (LOG4J2-1724) Using variables in GelfLayout's additional fields at runtime

2016-12-06 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal reassigned LOG4J2-1724: -- Assignee: Mikael Ståldal > Using variables in GelfLayout's additional fields at

[jira] [Updated] (LOG4J2-1687) NPE in ThrowableProxy when resolving stack

2016-12-06 Thread Robert Christiansen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Christiansen updated LOG4J2-1687: Attachment: LOG4J2-1687.patch Hi [~garydgregory], I've attached a possible patch

[jira] [Commented] (LOG4J2-1724) Using variables in GelfLayout's additional fields at runtime

2016-12-06 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724910#comment-15724910 ] Mikael Ståldal commented on LOG4J2-1724: Patches are welcome. > Using variables in GelfLayout's

[jira] [Comment Edited] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725355#comment-15725355 ] Johno Crawford edited comment on LOG4J2-1642 at 12/6/16 12:38 PM: -- The

[jira] [Commented] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725465#comment-15725465 ] Johno Crawford commented on LOG4J2-1642: [~garydgregory] I believe this to be a regression with

[jira] [Commented] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725412#comment-15725412 ] Johno Crawford commented on LOG4J2-1642: java.lang.NoClassDefFoundError:

[jira] [Comment Edited] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725355#comment-15725355 ] Johno Crawford edited comment on LOG4J2-1642 at 12/6/16 12:51 PM: -- The

[jira] [Issue Comment Deleted] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated LOG4J2-1642: --- Comment: was deleted (was: java.lang.NoClassDefFoundError:

[jira] [Comment Edited] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725355#comment-15725355 ] Johno Crawford edited comment on LOG4J2-1642 at 12/6/16 1:22 PM: - The

[jira] [Comment Edited] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725355#comment-15725355 ] Johno Crawford edited comment on LOG4J2-1642 at 12/6/16 1:22 PM: - The

[jira] [Commented] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725355#comment-15725355 ] Johno Crawford commented on LOG4J2-1642: The fact LOGGER.error is used in a try catch Throwable

[jira] [Commented] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725454#comment-15725454 ] Johno Crawford commented on LOG4J2-1642: java.lang.NoClassDefFoundError:

[jira] [Comment Edited] (LOG4J2-1642) DefaultShutdownCallbackRegistry throws NoClassDefFoundError

2016-12-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725454#comment-15725454 ] Johno Crawford edited comment on LOG4J2-1642 at 12/6/16 1:18 PM: - here is