Re: Improving log4j so it can easily be used with servlet logging

2010-05-31 Thread Ralph Goers
On May 31, 2010, at 10:31 PM, Jacob Kjome wrote: > I thought it might be useful to interject with some history about Log4j and > ServletContext logging. Please see this recent thread on the slf4j-user list > for > some pertinent details explaining how this is actually possible today with > Log

Re: Improving log4j so it can easily be used with servlet logging

2010-05-31 Thread Jacob Kjome
I thought it might be useful to interject with some history about Log4j and ServletContext logging. Please see this recent thread on the slf4j-user list for some pertinent details explaining how this is actually possible today with Log4j 1.2... http://marc.info/?t=12735918324&r=1&w=2 Now t

svn commit: r949925 - in /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL: carnold/log4j2-api/src/main/java/org/apache/logging/core/ rgoers/log4j2-core/

2010-05-31 Thread carnold
Author: carnold Date: Tue Jun 1 04:30:40 2010 New Revision: 949925 URL: http://svn.apache.org/viewvc?rev=949925&view=rev Log: Replace Filter.getLowerLimit/Upper with getThreshold Added: logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/carnold/log4j2-api/src/main/java/org/apache/logging/core/U

Re: Improving log4j so it can easily be used with servlet logging

2010-05-31 Thread Curt Arnold
On May 31, 2010, at 6:56 PM, Ralph Goers wrote: > > On May 31, 2010, at 3:53 PM, Curt Arnold wrote: > >> >> On May 31, 2010, at 3:28 PM, Thorbjørn Ravn Andersen wrote: >> >>> Den 30/05/10 23.12, Curt Arnold skrev: I don't have this in code or in the JIRA, but I have mentioned in recent >

svn commit: r949908 - /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/test/java/org/apache/logging/log4j/SimpleLoggerContext.java

2010-05-31 Thread rgoers
Author: rgoers Date: Tue Jun 1 00:18:53 2010 New Revision: 949908 URL: http://svn.apache.org/viewvc?rev=949908&view=rev Log: Update test class with getExternalContext. Modified: logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/test/java/org/apache/logging/log4j/SimpleLog

svn commit: r949907 - in /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers: log4j2-api/src/main/java/org/apache/logging/log4j/ log4j2-api/src/main/java/org/apache/logging/log4j/spi/ log4j2-core/

2010-05-31 Thread rgoers
Author: rgoers Date: Tue Jun 1 00:13:35 2010 New Revision: 949907 URL: http://svn.apache.org/viewvc?rev=949907&view=rev Log: Add support for external contexts. Added: logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/LogLevel.java l

Re: Improving log4j so it can easily be used with servlet logging

2010-05-31 Thread Ralph Goers
On May 31, 2010, at 3:53 PM, Curt Arnold wrote: > > On May 31, 2010, at 3:28 PM, Thorbjørn Ravn Andersen wrote: > >> Den 30/05/10 23.12, Curt Arnold skrev: >>> I don't have this in code or in the JIRA, but I have mentioned in recent >>> threads the idea of a user-supplied context object in log

Re: Improving log4j so it can easily be used with servlet logging

2010-05-31 Thread Curt Arnold
On May 31, 2010, at 3:28 PM, Thorbjørn Ravn Andersen wrote: > Den 30/05/10 23.12, Curt Arnold skrev: >> I don't have this in code or in the JIRA, but I have mentioned in recent >> threads the idea of a user-supplied context object in logging calls. >> Currently log4j has a thread associated con

Re: svn commit: r949590 - in /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers: log4j2-api/src/main/java/org/apache/logging/log4j/ log4j2-core/ log4j2-core/src/main/java/org/apache/logging/log4j/

2010-05-31 Thread Ralph Goers
On May 31, 2010, at 1:23 PM, Curt Arnold wrote: > > On May 31, 2010, at 1:57 PM, Ralph Goers wrote: > >> >> On May 30, 2010, at 2:53 PM, carn...@apache.org wrote: >> >>> Author: carnold >>> Date: Sun May 30 21:53:24 2010 >>> New Revision: 949590 >>> >>> URL: http://svn.apache.org/viewvc?rev=

Re: Improving log4j so it can easily be used with servlet logging

2010-05-31 Thread Ralph Goers
On May 31, 2010, at 1:43 PM, Thorbjørn Ravn Andersen wrote: > Den 30/05/10 21.34, Ralph Goers skrev: >> Wouldn't it make more sense for the LoggerContext to have a reference to the >> ServletContext? The Appender could then do >> >> if (getContext().getServletContext() != null) { >> getContex

Re: Improving log4j so it can easily be used with servlet logging

2010-05-31 Thread Thorbjørn Ravn Andersen
Den 30/05/10 21.34, Ralph Goers skrev: Wouldn't it make more sense for the LoggerContext to have a reference to the ServletContext? The Appender could then do if (getContext().getServletContext() != null) { getContext().getServletContext().log(event.getFormattedMessage()); } I do not kn

Re: Improving log4j so it can easily be used with servlet logging

2010-05-31 Thread Thorbjørn Ravn Andersen
Den 30/05/10 23.12, Curt Arnold skrev: I don't have this in code or in the JIRA, but I have mentioned in recent threads the idea of a user-supplied context object in logging calls. Currently log4j has a thread associated context (the MDC and NDC) and there are JVM level context (line ending sep

[jira] Created: (LOG4J2-41) Extensible Log Level

2010-05-31 Thread Ralph Goers (JIRA)
Extensible Log Level Key: LOG4J2-41 URL: https://issues.apache.org/jira/browse/LOG4J2-41 Project: Log4j 2 Issue Type: Improvement Components: API Reporter: Ralph Goers It is desirable to have the

Re: svn commit: r949590 - in /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers: log4j2-api/src/main/java/org/apache/logging/log4j/ log4j2-core/ log4j2-core/src/main/java/org/apache/logging/log4j/

2010-05-31 Thread Curt Arnold
On May 31, 2010, at 1:57 PM, Ralph Goers wrote: > > On May 30, 2010, at 2:53 PM, carn...@apache.org wrote: > >> Author: carnold >> Date: Sun May 30 21:53:24 2010 >> New Revision: 949590 >> >> URL: http://svn.apache.org/viewvc?rev=949590&view=rev >> Log: >> Code review comments >> >> Added: >>

svn commit: r949854 - /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/Level.java

2010-05-31 Thread rgoers
Author: rgoers Date: Mon May 31 20:16:01 2010 New Revision: 949854 URL: http://svn.apache.org/viewvc?rev=949854&view=rev Log: Add @doubt comments Modified: logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/Level.java Modified: logging/l

svn commit: r949837 - in /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-core/src/main/java/org/apache/logging/log4j/core: Log4jLogEvent.java Logger.java

2010-05-31 Thread rgoers
Author: rgoers Date: Mon May 31 19:24:10 2010 New Revision: 949837 URL: http://svn.apache.org/viewvc?rev=949837&view=rev Log: Fix bug getting proper StackTraceElement. Make PrivateLoggerConfig immutable and make members private. Change comments on updateConfiguration to make sense. Modified:

Re: svn commit: r949590 - in /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers: log4j2-api/src/main/java/org/apache/logging/log4j/ log4j2-core/ log4j2-core/src/main/java/org/apache/logging/log4j/

2010-05-31 Thread Ralph Goers
On May 30, 2010, at 2:53 PM, carn...@apache.org wrote: > Author: carnold > Date: Sun May 30 21:53:24 2010 > New Revision: 949590 > > URL: http://svn.apache.org/viewvc?rev=949590&view=rev > Log: > Code review comments > > Added: > > logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j

Re: log4j2 sandbox

2010-05-31 Thread Ralph Goers
From that description our approaches have indeed been complimentary. I saw problems in the fundamental core of Log4j and SLF4J/Logback that are in the API, configuration and filtering. I've always considered the Appender and Layout concepts to be more or less OK, except how they were infringed

Re: log4j2 sandbox

2010-05-31 Thread Curt Arnold
On May 31, 2010, at 7:41 AM, Christian Grobmeier wrote: > I just digged a little bit around the code. Besides the projects > mentioned below there is ralphs stuff. How is it planned to put it all > together? > You think we have a plan? Ralph and I are going in two different, but hopefully even

Re: log4j2 sandbox

2010-05-31 Thread Ralph Goers
I plan to keep on editing my version based on feedback. I suspect Curt is planning on doing the same. I think the hope is that by having alternative code bases that work that they will a) naturally converge on a common set of ideas or b) contributors will weigh in on which codebase they find mo

Re: log4j2 sandbox

2010-05-31 Thread Christian Grobmeier
I just digged a little bit around the code. Besides the projects mentioned below there is ralphs stuff. How is it planned to put it all together? On Sun, May 30, 2010 at 5:23 AM, Curt Arnold wrote: > Moved some stuff around in the log4j2 sandbox at > http://svn.apache.org/repos/asf/logging/log