A new annotation to do what? To specify which category the plugin belongs to?
What is wrong with the way it is now? What problem are we trying to solve?
Sent from my iPad
On Jun 2, 2014, at 8:30 PM, Gary Gregory garydgreg...@gmail.com wrote:
A new annotation seems simpler to me but that
What? This is essentially the same syntax logback users have happily been using
for years and I believe it is very similar to the log4j 1 syntax. To my
knowledge no one has ever complained.
Sent from my iPad
On Jun 2, 2014, at 9:20 PM, Matt Sicker boa...@gmail.com wrote:
On 2 June 2014
We are never going to release 2.0. A few of you keep wanting to continually
refactor and rename stuff is making things worse in my opinion. As I have
said before, a good example is that I find AbstractLogger to be a much better
name than AbstractLoggerProvider and think it was a mistake to
The current config syntax is one of the big reasons why I want to use
log4j2 in production ASAP. I hate the old log4j configuration format, and
there's no way I'm going to use logback or JUL.
The builder stuff isn't a blocker for 2.0 as it's not really API related.
On 3 June 2014 01:38, Ralph
Well, what categories are we supposed to use? Is there a set list, or can
we just use whatever? It's not that clear other than looking at current
usage (most things are in the Core category).
On 3 June 2014 01:31, Ralph Goers rgo...@apache.org wrote:
A new annotation to do what? To specify
Well, let's talk about it! I find some of these typs names confusing and the
javadocs could be better. Better names will help us. Names are important to
communicate clearly what our _intentions_ are.
Gary
div Original message /divdivFrom: Ralph Goers
rgo...@apache.org
Exactly, an enum would help know what is legal. It could just be used for
documentation for all I know. A set of constants would be better if we need
something extensible.
Gary
div Original message /divdivFrom: Matt Sicker
boa...@gmail.com /divdivDate:06/03/2014 02:48
Perhaps we should put a message on the site we're unable to select a new logo,
so log4j-2.0 will not be G.A. for the foreseeable future. :-P
(Just kidding.)
About LoggerProvider, I liked having the extra methods to be able to
extend/wrap Loggers, but I also don't like the name very much.
I
sivan created LOG4J2-659:
Summary: Log files not properly rolled over to the folder.
Key: LOG4J2-659
URL: https://issues.apache.org/jira/browse/LOG4J2-659
Project: Log4j 2
Issue Type: Bug
[
https://issues.apache.org/jira/browse/LOG4J2-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sivan updated LOG4J2-659:
-
Description:
This is happening in our production environment. My application is using
rolling file appender. In
[
https://issues.apache.org/jira/browse/LOG4J2-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sivan updated LOG4J2-659:
-
Attachment: 2014-06.png
2014-05.png
log4j.png
In the screen shots file name are
[
https://issues.apache.org/jira/browse/LOG4J2-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sivan updated LOG4J2-659:
-
Description:
This is happening in our production environment. My application is using
rolling file appender. In
[
https://issues.apache.org/jira/browse/LOG4J2-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14016462#comment-14016462
]
James Hutton commented on LOG4J2-656:
-
Honestly this is a big item. There are a lot
[
https://issues.apache.org/jira/browse/LOG4J2-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sivan updated LOG4J2-659:
-
Description:
This is happening in our production environment. My application is using
rolling file appender. In
This sounds like an optimization, not something that requires spending a lot of
time on.
Sent from my iPad
On Jun 3, 2014, at 12:15 AM, Gary Gregory garydgreg...@gmail.com wrote:
Exactly, an enum would help know what is legal. It could just be used for
documentation for all I know. A set
[
https://issues.apache.org/jira/browse/LOG4J2-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14016539#comment-14016539
]
Ralph Goers commented on LOG4J2-659:
Here is what I suspect what is happening.
1.
[
https://issues.apache.org/jira/browse/LOG4J2-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14016539#comment-14016539
]
Ralph Goers edited comment on LOG4J2-659 at 6/3/14 2:08 PM:
[
https://issues.apache.org/jira/browse/LOG4J2-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14016539#comment-14016539
]
Ralph Goers edited comment on LOG4J2-659 at 6/3/14 2:14 PM:
It's probably a simple change. In the meantime, should I use the Core
category, or should I use a new one?
On 3 June 2014 08:51, Ralph Goers rgo...@apache.org wrote:
This sounds like an optimization, not something that requires spending a
lot of time on.
Sent from my iPad
On Jun 3, 2014,
1. I liked AbstractLogger better, too.
2. Let's do that single transferable vote thing over the ML instead of
STEVE.
3. I was saying that log4j2's configuration file formats are far superior
to any others I've seen out there.
4. If there's any way to improve the config file format, it might be in
Use for what? Most main components that are part of the main configuration use
core. The key to the category is what will be processing the plugin.
Sent from my iPhone
On Jun 3, 2014, at 9:12 AM, Matt Sicker boa...@gmail.com wrote:
It's probably a simple change. In the meantime, should I
Alright, so it would make sense to use a different category name for the
type converters?
On 3 June 2014 11:43, Ralph Goers ralph.go...@dslextreme.com wrote:
Use for what? Most main components that are part of the main configuration
use core. The key to the category is what will be processing
Yes. I would imagine that the code that would be calling pluginmanager would be
different and is only interested in the type converters. Likewise, nothing else
is interested in the type converters.
Sent from my iPhone
On Jun 3, 2014, at 9:52 AM, Matt Sicker boa...@gmail.com wrote:
Alright,
The JSON format supports two formats similar to how the XML does. The format
you prefer is supported
Sent from my iPhone
On Jun 3, 2014, at 9:16 AM, Matt Sicker boa...@gmail.com wrote:
1. I liked AbstractLogger better, too.
2. Let's do that single transferable vote thing over the ML
Alright, sounds good then.
On 3 June 2014 12:05, Ralph Goers ralph.go...@dslextreme.com wrote:
Yes. I would imagine that the code that would be calling pluginmanager
would be different and is only interested in the type converters. Likewise,
nothing else is interested in the type converters.
Golden!
On 3 June 2014 12:20, Ralph Goers ralph.go...@dslextreme.com wrote:
The JSON format supports two formats similar to how the XML does. The
format you prefer is supported
Sent from my iPhone
On Jun 3, 2014, at 9:16 AM, Matt Sicker boa...@gmail.com wrote:
1. I liked AbstractLogger
It is time to select a logo. The list of candidates can be found at
https://wiki.apache.org/logging/Log4jLogoNominations as those having at least
two supporters and are arbitrarily identified as A through I.
This vote will use STV to calculate the results. This means your vote should
consist
In case it is not clear, the names (Aragorn, etc) below are for some other
fictional vote to illustrate how to vote
Here is my vote:
DABIEFHGC
Ralph
On Jun 3, 2014, at 1:08 PM, Ralph Goers ralph.go...@dslextreme.com wrote:
It is time to select a logo. The list of candidates can be found at
And mine:
DBAHCIEFG
On 6/3/14, Ralph Goers ralph.go...@dslextreme.com wrote:
In case it is not clear, the names (Aragorn, etc) below are for some other
fictional vote to illustrate how to vote
Here is my vote:
DABIEFHGC
Ralph
On Jun 3, 2014, at 1:08 PM, Ralph Goers
Nonbinding vote:
ABGFDECHI
Cheers,
Paul
On Tue, Jun 3, 2014 at 3:08 PM, Ralph Goers ralph.go...@dslextreme.com
wrote:
It is time to select a logo. The list of candidates can be found at
https://wiki.apache.org/logging/Log4jLogoNominations as those having at
least two supporters and are
HEFABCIGD
Gary
On Tue, Jun 3, 2014 at 4:08 PM, Ralph Goers ralph.go...@dslextreme.com
wrote:
It is time to select a logo. The list of candidates can be found at
https://wiki.apache.org/logging/Log4jLogoNominations as those having at
least two supporters and are arbitrarily identified as A
GCDIHFABE
On 3 June 2014 15:55, Gary Gregory garydgreg...@gmail.com wrote:
HEFABCIGD
Gary
On Tue, Jun 3, 2014 at 4:08 PM, Ralph Goers ralph.go...@dslextreme.com
wrote:
It is time to select a logo. The list of candidates can be found at
HGIAEFBDC
On Wed, Jun 4, 2014 at 5:08 AM, Ralph Goers ralph.go...@dslextreme.com
wrote:
It is time to select a logo. The list of candidates can be found at
https://wiki.apache.org/logging/Log4jLogoNominations as those having at
least two supporters and are arbitrarily identified as A through
As briefly mentioned on another thread, several people don't like the name
LoggerProvider and AbstractLoggerProvider.
These classes are in the api module, so if we want to rename them I think
we should do it soon, before we release rc2.
If nobody objects, I would like to rename
LoggerProvider -
I like those new names you suggested.
On 3 June 2014 18:17, Remko Popma remko.po...@gmail.com wrote:
As briefly mentioned on another thread, several people don't like the name
LoggerProvider and AbstractLoggerProvider.
These classes are in the api module, so if we want to rename them I
Why would you add a class attribute when the annotation is annotating the class
and you can get it from that?
Ralph
On Jun 3, 2014, at 4:50 PM, mattsic...@apache.org wrote:
Author: mattsicker
Date: Tue Jun 3 23:50:29 2014
New Revision: 1599839
URL: http://svn.apache.org/r1599839
Log:
I changed my mind on that and am adding a @ConvertType annotation that will
be scanned at runtime. No changes to @Plugin or the annotation processor
this way, too.
On 3 June 2014 19:05, Ralph Goers ralph.go...@dslextreme.com wrote:
Why would you add a class attribute when the annotation is
+1 and we haven’t done a release since they were renamed so this will minimize
the impact.
Ralph
On Jun 3, 2014, at 4:17 PM, Remko Popma remko.po...@gmail.com wrote:
As briefly mentioned on another thread, several people don't like the name
LoggerProvider and AbstractLoggerProvider.
Similar to why I created @ConverterKeys for pattern converters I guess? That
sounds correct.
Ralph
On Jun 3, 2014, at 5:07 PM, Matt Sicker boa...@gmail.com wrote:
I changed my mind on that and am adding a @ConvertType annotation that will
be scanned at runtime. No changes to @Plugin or the
Go for it. Should the Javadocs be improved as well?
Gary
On Tue, Jun 3, 2014 at 7:17 PM, Remko Popma remko.po...@gmail.com wrote:
As briefly mentioned on another thread, several people don't like the name
LoggerProvider and AbstractLoggerProvider.
These classes are in the api module, so if
Thank you everybody for your quick replies. I'll try to get this done within
the next day or two.
Gary, thank you for the reminder to also review the Javadoc. I'll take a look
at that as well. Please let me know if there's anything in particular that may
need improvement.
Regards,
Remko
I can't say there is any one thing specific but I found the whole pile
confusing, so better names will help.
I found the class diagram on the site unhelpful as well, I'm sure that's
just me.
Someplace, we need a good explanation of how the whole thing hangs.
Gary
On Tue, Jun 3, 2014 at 8:42
The class diagram was helpful in understanding the general architecture of
log4j-core.
On 3 June 2014 19:45, Gary Gregory garydgreg...@gmail.com wrote:
I can't say there is any one thing specific but I found the whole pile
confusing, so better names will help.
I found the class diagram on
Indeed.
On 3 June 2014 19:18, Ralph Goers ralph.go...@dslextreme.com wrote:
Similar to why I created @ConverterKeys for pattern converters I guess?
That sounds correct.
Ralph
On Jun 3, 2014, at 5:07 PM, Matt Sicker boa...@gmail.com wrote:
I changed my mind on that and am adding a
At runtime just for the core or the whole CP? Performance?
Gary
div Original message /divdivFrom: Matt Sicker
boa...@gmail.com /divdivDate:06/03/2014 23:31 (GMT-05:00)
/divdivTo: Log4J Developers List log4j-dev@logging.apache.org
/divdivSubject: Re: svn commit: r1599839 -
If I understand what Matt is doing the new converters will be annotated with
the data type that they support, similar to how the pattern converters are
annotated with the pattern tokens used to identify them.
Ralph
On Jun 3, 2014, at 9:42 PM, Gary Gregory garydgreg...@gmail.com wrote:
At
Yeah pretty much. The type converters will be @Plugins (in the
TypeConverters category; I've got a string constant), and they'll also have
a @ConvertType annotation that lists the class(es) it supports converting
to.
On 3 June 2014 23:52, Ralph Goers ralph.go...@dslextreme.com wrote:
If I
On Wed, Jun 4, 2014 at 1:00 AM, Matt Sicker boa...@gmail.com wrote:
Yeah pretty much. The type converters will be @Plugins (in the
TypeConverters category; I've got a string constant), and they'll also have
a @ConvertType annotation that lists the class(es) it supports converting
to.
Sounds
48 matches
Mail list logo
