[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15604617#comment-15604617
]
Mikael Ståldal commented on LOG4J2-1010:
It is not a generic Scala implementation (which would
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15604584#comment-15604584
]
Remko Popma commented on LOG4J2-1010:
-
I believe Mikael is working on a Scala implementation. Not
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603873#comment-15603873
]
Adrian Cole commented on LOG4J2-1010:
-
aloha. I understand this is only recently released, but I was
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512912#comment-15512912
]
Remko Popma commented on LOG4J2-1010:
-
I have some ideas on how to improve the performance of
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508383#comment-15508383
]
Remko Popma commented on LOG4J2-1010:
-
I was unable to work on this yesterday but I will try to
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508223#comment-15508223
]
Ralph Goers commented on LOG4J2-1010:
-
If it is immutable then I would think you could just always
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496055#comment-15496055
]
Remko Popma commented on LOG4J2-1010:
-
Mikael, now I see what you mean.
Yes, I agree that is a good
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493867#comment-15493867
]
Gary Gregory commented on LOG4J2-1010:
--
I wonder if we start to talk about a 3.0 roadmap which would
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493187#comment-15493187
]
Mikael Ståldal commented on LOG4J2-1010:
I suggest that {{ContextDataInjector}} is moved to the
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493145#comment-15493145
]
Remko Popma commented on LOG4J2-1010:
-
What do you suggest and why?
> Injectable context properties
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492969#comment-15492969
]
Mikael Ståldal commented on LOG4J2-1010:
Should the {{ContextDataInjector}} interface really be
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451555#comment-15451555
]
Mikael Ståldal commented on LOG4J2-1010:
I am OK with 1010 & 1447. I still have some questions
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448964#comment-15448964
]
Remko Popma commented on LOG4J2-1010:
-
I see what you mean now. That's a good example implementation
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448838#comment-15448838
]
Mikael Ståldal commented on LOG4J2-1010:
The design of the ContextDataInjector makes sense from a
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448649#comment-15448649
]
Remko Popma commented on LOG4J2-1010:
-
Thank you for the suggestion. I added javadoc to the
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448643#comment-15448643
]
Remko Popma commented on LOG4J2-1010:
-
This is to prepare for the
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448630#comment-15448630
]
Remko Popma commented on LOG4J2-1010:
-
To facilitate code reuse I made
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448619#comment-15448619
]
Remko Popma commented on LOG4J2-1010:
-
The {{rawContextData()}} method is intended to be used by
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448605#comment-15448605
]
Remko Popma commented on LOG4J2-1010:
-
Different thread safety semantics: one method's return value
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448592#comment-15448592
]
Mikael Ståldal commented on LOG4J2-1010:
Makes sense, but why do we then need the extra method?
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448586#comment-15448586
]
Remko Popma commented on LOG4J2-1010:
-
This gives the injector implementation the freedom to either
*
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448542#comment-15448542
]
Mikael Ståldal commented on LOG4J2-1010:
Now it will be more work to make a custom implementation
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448534#comment-15448534
]
Mikael Ståldal commented on LOG4J2-1010:
Should the {{ContextDataInjector.rawContextData()}}
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448527#comment-15448527
]
Mikael Ståldal commented on LOG4J2-1010:
Why do the {{ContextDataInjector.injectContextData()}}
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448513#comment-15448513
]
Mikael Ståldal commented on LOG4J2-1010:
Why do we have three implementations of
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447531#comment-15447531
]
Remko Popma commented on LOG4J2-1010:
-
The performance concerns Ralph raised regarding global Filters
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15443634#comment-15443634
]
Remko Popma commented on LOG4J2-1010:
-
[~ralph.go...@dslextreme.com] {{ContextDataInjector}} now has
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15443428#comment-15443428
]
Remko Popma commented on LOG4J2-1010:
-
Thanks for the tip. I find that links in the text tend to pull
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15443390#comment-15443390
]
Remko Popma commented on LOG4J2-1010:
-
That would not solve the problem and would add a new one:
*
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15443340#comment-15443340
]
Mikael Ståldal commented on LOG4J2-1010:
Maybe consider my proposal of moving the static
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15442708#comment-15442708
]
Remko Popma commented on LOG4J2-1010:
-
Makes sense. I will add a method to ContextDataInjector to
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15442251#comment-15442251
]
Ralph Goers commented on LOG4J2-1010:
-
Finally started looking at the branch. I do have a concern
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15441344#comment-15441344
]
Mikael Ståldal commented on LOG4J2-1010:
I think that this needs to be documented, implementers
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15441200#comment-15441200
]
Remko Popma commented on LOG4J2-1010:
-
Yes, depending on whether filters etc use context data,
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15441186#comment-15441186
]
Remko Popma commented on LOG4J2-1010:
-
Thanks, I need to fix that.
> Injectable context properties
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15441096#comment-15441096
]
Mikael Ståldal commented on LOG4J2-1010:
If I (as a user of Log4j) specify a custom
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15441089#comment-15441089
]
Mikael Ståldal commented on LOG4J2-1010:
Java doc for {{ContextDataInjector}} says:
{code}
By
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15441087#comment-15441087
]
Mikael Ståldal commented on LOG4J2-1010:
You can use the @link Javadoc tag when referring to
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434846#comment-15434846
]
Ralph Goers commented on LOG4J2-1010:
-
Yes please. I will try to do it today.
> Injectable context
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434686#comment-15434686
]
Remko Popma commented on LOG4J2-1010:
-
Ralph, do you want to review before I merge branch
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434436#comment-15434436
]
Mikael Ståldal commented on LOG4J2-1010:
Great!
Then I am fine with this one.
> Injectable
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433104#comment-15433104
]
Remko Popma commented on LOG4J2-1010:
-
Done in commit ca90bc1: ThreadContextMapFilter now gets
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432795#comment-15432795
]
Ralph Goers commented on LOG4J2-1010:
-
Now that is confusing. How is a user supposed to know when to
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432644#comment-15432644
]
Mikael Ståldal commented on LOG4J2-1010:
I would go for the second option, leave the existing
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430998#comment-15430998
]
Remko Popma commented on LOG4J2-1010:
-
I've modified DynamicThresholdFilter and ContextMapLookup to
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401904#comment-15401904
]
Mikael Ståldal commented on LOG4J2-1010:
I would prefer if {{ContextMapLookup}} uses the current
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401896#comment-15401896
]
Mikael Ståldal commented on LOG4J2-1010:
Yes, now when ContextMapLookup uses the new ContextData
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401775#comment-15401775
]
Remko Popma commented on LOG4J2-1010:
-
I guess we need to make a choice here. If a configuration uses
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401738#comment-15401738
]
Mikael Ståldal commented on LOG4J2-1010:
Well, {{ContextMapLookup}} actually takes the data
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399866#comment-15399866
]
Ralph Goers commented on LOG4J2-1010:
-
What difference does that make? The lookup has always gotten
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399526#comment-15399526
]
Mikael Ståldal commented on LOG4J2-1010:
It is not clear that {{ContextMapLookup}} get its data
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399507#comment-15399507
]
Ralph Goers commented on LOG4J2-1010:
-
That is unnecessary. The ContextMapLookup should be getting
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399501#comment-15399501
]
Ralph Goers commented on LOG4J2-1010:
-
As you stated, when a LogEvent has not been created a Filter
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399174#comment-15399174
]
Mikael Ståldal commented on LOG4J2-1010:
Should we add a {{ContextDataLookup}} which looks up
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399172#comment-15399172
]
Mikael Ståldal commented on LOG4J2-1010:
Maybe {{ContextMapLookup}} should be renamed into
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399011#comment-15399011
]
Remko Popma commented on LOG4J2-1010:
-
About avoiding interaction with ThreadContext, note that
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398972#comment-15398972
]
Mikael Ståldal commented on LOG4J2-1010:
Yes. And in general, we should avoid interacting with
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398682#comment-15398682
]
Remko Popma commented on LOG4J2-1010:
-
As Mikael commented
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394071#comment-15394071
]
Remko Popma commented on LOG4J2-1010:
-
This is now available in branch
{{LOG4J2-1010}}.
Please
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350212#comment-15350212
]
Mikael Ståldal commented on LOG4J2-1010:
Another injection possibility
> Injectable context
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349634#comment-15349634
]
Mikael Ståldal commented on LOG4J2-1010:
I think we should go through all current uses of
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349624#comment-15349624
]
Mikael Ståldal commented on LOG4J2-1010:
A system property would work, but it would also be
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349607#comment-15349607
]
Remko Popma commented on LOG4J2-1010:
-
Good point that authors of async frameworks may not bother.
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349583#comment-15349583
]
Mikael Ståldal commented on LOG4J2-1010:
* I think that most (if not all) custom injectors will
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349081#comment-15349081
]
Remko Popma commented on LOG4J2-1010:
-
Good questions.
* I like to see the ContextDataInjector as
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348005#comment-15348005
]
Mikael Ståldal commented on LOG4J2-1010:
OK, let's go for Core, and an interface which adds
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347633#comment-15347633
]
Ralph Goers commented on LOG4J2-1010:
-
OK - I've read this whole thing:
1. I never really like the
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346789#comment-15346789
]
Ralph Goers commented on LOG4J2-1010:
-
I just saw my name mentioned here. I definitely will want to
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346781#comment-15346781
]
Mikael Ståldal commented on LOG4J2-1010:
Don't get me wrong. I like this injector approach in
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346749#comment-15346749
]
Remko Popma commented on LOG4J2-1010:
-
The beauty of this approach is that it would provide a generic
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346716#comment-15346716
]
Mikael Ståldal commented on LOG4J2-1010:
BTW, it is Finagle, not Finacle.
> Injectable context
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346714#comment-15346714
]
Mikael Ståldal commented on LOG4J2-1010:
Yes, this would work.
However, currently the Scala
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346691#comment-15346691
]
Remko Popma commented on LOG4J2-1010:
-
I think there is still some confusion on how to use this.
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346681#comment-15346681
]
Remko Popma commented on LOG4J2-1010:
-
Why? The whole point is to decouple LogEvent context data from
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346677#comment-15346677
]
Mikael Ståldal commented on LOG4J2-1010:
I think it's better to put this in log4j-api.
>
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346670#comment-15346670
]
Remko Popma commented on LOG4J2-1010:
-
Ah! No, what I had in mind is to put this interface in the
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346655#comment-15346655
]
Mikael Ståldal commented on LOG4J2-1010:
{{LogEvent}} is in log4j-core, and I guess we want to
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346651#comment-15346651
]
Matt Sicker commented on LOG4J2-1010:
-
Here's an example of an asynchronous library and how they
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346636#comment-15346636
]
Remko Popma commented on LOG4J2-1010:
-
Actually the {{List}} parameter is coming from the
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346594#comment-15346594
]
Mikael Ståldal commented on LOG4J2-1010:
I think this is putting the abstraction level wrong. I
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346564#comment-15346564
]
Remko Popma commented on LOG4J2-1010:
-
In the Scala module, you would define a class, let's call it
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346517#comment-15346517
]
Mikael Ståldal commented on LOG4J2-1010:
Can you give an example of how I am supposed to use
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346419#comment-15346419
]
Remko Popma commented on LOG4J2-1010:
-
The best place to inject context map data into the LogEvent is
[
https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346359#comment-15346359
]
Mikael Ståldal commented on LOG4J2-1010:
OK, I have changed the title and description of the
84 matches
Mail list logo
