Re: org.apache.logging.log4j.web.appender.ServletAppender.append(LogEvent)

On Thu, Sep 22, 2016 at 3:01 PM, Ralph Goers wrote: > OK - Thanks for doing that. > You bet. Gary > > Ralph > > On Sep 22, 2016, at 2:26 PM, Gary Gregory wrote: > > On Thu, Sep 22, 2016 at 2:07 PM, Ralph Goers

Re: org.apache.logging.log4j.web.appender.ServletAppender.append(LogEvent)

OK - Thanks for doing that. Ralph > On Sep 22, 2016, at 2:26 PM, Gary Gregory wrote: > > On Thu, Sep 22, 2016 at 2:07 PM, Ralph Goers > wrote: > Is the default to keep the existing behavior? > > Yes, it

[jira] [Created] (LOG4J2-1610) Add targetNamespace to log4j-config.xsd

Gary Gregory created LOG4J2-1610: Summary: Add targetNamespace to log4j-config.xsd Key: LOG4J2-1610 URL: https://issues.apache.org/jira/browse/LOG4J2-1610 Project: Log4j 2 Issue Type: Bug

[jira] [Closed] (LOG4J2-1610) Add targetNamespace to log4j-config.xsd

[ https://issues.apache.org/jira/browse/LOG4J2-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1610. Resolution: Fixed Closes #43 on GitHub. > Add targetNamespace to log4j-config.xsd >

[jira] [Commented] (LOG4J2-1610) Add targetNamespace to log4j-config.xsd

[ https://issues.apache.org/jira/browse/LOG4J2-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515510#comment-15515510 ] Remko Popma commented on LOG4J2-1610: - Gary, I think you need to make a commit with "fixes #43" or

Re: org.apache.logging.log4j.web.appender.ServletAppender.append(LogEvent)

Is the default to keep the existing behavior? Ralph > On Sep 22, 2016, at 1:54 PM, Gary Gregory wrote: > > On Thu, Sep 22, 2016 at 1:07 PM, Gary Gregory > wrote: > On Thu, Sep 22, 2016 at 12:52 PM, Ralph Goers

Re: org.apache.logging.log4j.web.appender.ServletAppender.append(LogEvent)

On Thu, Sep 22, 2016 at 2:07 PM, Ralph Goers wrote: > Is the default to keep the existing behavior? > Yes, it is. Gary > > Ralph > > On Sep 22, 2016, at 1:54 PM, Gary Gregory wrote: > > On Thu, Sep 22, 2016 at 1:07 PM, Gary Gregory

Jenkins build became unstable: Log4j 2.x #2359

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Commented] (LOG4J2-1607) Improve performance of SortedStringArrayMap data structure

[ https://issues.apache.org/jira/browse/LOG4J2-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513427#comment-15513427 ] Remko Popma commented on LOG4J2-1607: - I haven't pushed the improvement yet. Still work in progress.

[jira] [Updated] (LOG4J2-1523) Log4j 1 appenders

[ https://issues.apache.org/jira/browse/LOG4J2-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1523: - Description: Support all appenders in Log4j 1 to the extent possible and reasonable. All

[jira] [Updated] (LOG4J2-1523) Log4j 1 appenders

[ https://issues.apache.org/jira/browse/LOG4J2-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1523: - Description: Support all appenders in Log4j 1 to the extent possible and reasonable. All

org.apache.logging.log4j.web.appender.ServletAppender.append(LogEvent)

Hi All, The method org.apache.logging.log4j.web.appender.ServletAppender.append(LogEvent) is defined as: @Override public void append(final LogEvent event) { servletContext.log(((AbstractStringLayout) getLayout()).toSerializable(event)); } Instead of: @Override

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512912#comment-15512912 ] Remko Popma commented on LOG4J2-1010: - I have some ideas on how to improve the performance of

[jira] [Commented] (LOG4J2-1607) Improve performance of SortedStringArrayMap data structure

[ https://issues.apache.org/jira/browse/LOG4J2-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513921#comment-15513921 ] Remko Popma commented on LOG4J2-1607: - I can add tests for the non-empty ThreadContext scenarios to

[jira] [Updated] (LOG4J2-1607) Improve performance of SortedArrayStringMap data structure

[ https://issues.apache.org/jira/browse/LOG4J2-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1607: Summary: Improve performance of SortedArrayStringMap data structure (was: Improve performance of

[jira] [Commented] (LOG4J2-1607) Improve performance of SortedArrayStringMap data structure

[ https://issues.apache.org/jira/browse/LOG4J2-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514041#comment-15514041 ] Remko Popma commented on LOG4J2-1607: - Test updated. I haven't run against 2.6.2 yet but results look

[jira] [Commented] (LOG4J2-1607) Improve performance of SortedArrayStringMap data structure

[ https://issues.apache.org/jira/browse/LOG4J2-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514092#comment-15514092 ] Ralph Goers commented on LOG4J2-1607: - Thanks, those results look very good. > Improve performance

[jira] [Commented] (LOG4J2-1607) Improve performance of SortedStringArrayMap data structure

[ https://issues.apache.org/jira/browse/LOG4J2-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513962#comment-15513962 ] Ralph Goers commented on LOG4J2-1607: - Thanks, I would appreciate that if you have the time. If you

[jira] [Comment Edited] (LOG4J2-1607) Improve performance of SortedStringArrayMap data structure

[ https://issues.apache.org/jira/browse/LOG4J2-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513921#comment-15513921 ] Remko Popma edited comment on LOG4J2-1607 at 9/22/16 6:05 PM: -- I added tests

Jenkins build became unstable: Log4j 2.x #2357

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: org.apache.logging.log4j.web.appender.ServletAppender.append(LogEvent)

Since ServletContext is an interface, who knows what interesting work an implementation will do with the Throwables. Another way to look at it is: Why should we hide the actual Throwable from the ServletContext? Gary On Thu, Sep 22, 2016 at 10:23 AM, Ralph Goers

[jira] [Created] (LOG4J2-1606) log4j-web deinitalizes the Logger too early if listeners defined in web.xml use it

Lukas Vogel created LOG4J2-1606: --- Summary: log4j-web deinitalizes the Logger too early if listeners defined in web.xml use it Key: LOG4J2-1606 URL: https://issues.apache.org/jira/browse/LOG4J2-1606

[jira] [Commented] (LOG4J2-1606) log4j-web deinitalizes the Logger too early if listeners defined in web.xml use it

[ https://issues.apache.org/jira/browse/LOG4J2-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513184#comment-15513184 ] Ralph Goers commented on LOG4J2-1606: - Log4j's listener is supposed to be first. Doesn't the

Re: org.apache.logging.log4j.web.appender.ServletAppender.append(LogEvent)

Oh that explains it, thanks for the info! On 22 September 2016 at 10:21, Ralph Goers wrote: > PatternLayout defaults to implicitly add %ex or one of its variations to > your pattern if you don’t specify it. To disable exception logging you have > to use %noex. > >

[jira] [Commented] (LOG4J2-1607) Improve performance of SortedStringArrayMap data structure

[ https://issues.apache.org/jira/browse/LOG4J2-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513558#comment-15513558 ] Ralph Goers commented on LOG4J2-1607: - Yes, I want to do the release but I want to be sure that the

Re: org.apache.logging.log4j.web.appender.ServletAppender.append(LogEvent)

PatternLayout defaults to implicitly add %ex or one of its variations to your pattern if you don’t specify it. To disable exception logging you have to use %noex. Ralph > On Sep 22, 2016, at 6:55 AM, Matt Sicker wrote: > > I usually don't even include %exception in my

Jenkins build is back to stable : Log4j 2.x #2358

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: org.apache.logging.log4j.web.appender.ServletAppender.append(LogEvent)

Because Log4j users are far more inclined to want to use the formatting we provide? What your change does is effectively disallow users from using our exception formatting when logging to the servletContext. Also, this breaks the current behavior. You really need to rethink this and provide

Re: org.apache.logging.log4j.web.appender.ServletAppender.append(LogEvent)

On Thu, Sep 22, 2016 at 12:52 PM, Ralph Goers wrote: > Because Log4j users are far more inclined to want to use the formatting we > provide? What your change does is effectively disallow users from using > our exception formatting when logging to the servletContext.

[jira] [Created] (LOG4J2-1609) Add a Builder to ServletAppender and deprecate factory method

Gary Gregory created LOG4J2-1609: Summary: Add a Builder to ServletAppender and deprecate factory method Key: LOG4J2-1609 URL: https://issues.apache.org/jira/browse/LOG4J2-1609 Project: Log4j 2

[jira] [Closed] (LOG4J2-1609) Add a Builder to ServletAppender and deprecate factory method

[ https://issues.apache.org/jira/browse/LOG4J2-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1609. Resolution: Fixed In Git master. > Add a Builder to ServletAppender and deprecate factory method

Re: org.apache.logging.log4j.web.appender.ServletAppender.append(LogEvent)

On Thu, Sep 22, 2016 at 1:07 PM, Gary Gregory wrote: > On Thu, Sep 22, 2016 at 12:52 PM, Ralph Goers > wrote: > >> Because Log4j users are far more inclined to want to use the formatting >> we provide? What your change does is effectively

[jira] [Commented] (LOG4J2-1607) Improve performance of SortedStringArrayMap data structure

[ https://issues.apache.org/jira/browse/LOG4J2-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513370#comment-15513370 ] Ralph Goers commented on LOG4J2-1607: - Do you tests for this? I was thinking of modifying the

[jira] [Commented] (LOG4J2-1606) log4j-web deinitalizes the Logger too early if listeners defined in web.xml use it

[ https://issues.apache.org/jira/browse/LOG4J2-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513283#comment-15513283 ] Lukas Vogel commented on LOG4J2-1606: - I'm not sure I understand what you mean. The documentation

[jira] [Updated] (LOG4J2-1608) ServletAppender does not provide throwable object to ServletContext

[ https://issues.apache.org/jira/browse/LOG4J2-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1608: - Description: The method

Re: org.apache.logging.log4j.web.appender.ServletAppender.append(LogEvent)

I created https://issues.apache.org/jira/browse/LOG4J2-1608 Gary On Thu, Sep 22, 2016 at 8:22 AM, Matt Sicker wrote: > Oh that explains it, thanks for the info! > > On 22 September 2016 at 10:21, Ralph Goers > wrote: > >> PatternLayout defaults to

[jira] [Created] (LOG4J2-1608) ServletAppender does not provide throwable object to ServletContext

Gary Gregory created LOG4J2-1608: Summary: ServletAppender does not provide throwable object to ServletContext Key: LOG4J2-1608 URL: https://issues.apache.org/jira/browse/LOG4J2-1608 Project: Log4j 2

API module warnings

I am wondering if we should address these now: [WARN] E:\vcs\git\apache\logging\logging-log4j2\log4j-api\src\main\java\org\apache\logging\log4j\message\ParameterizedNoReferenceMessageFactory.java:[48,11] [serial] serializable class StatusMessage has no definition of serialVersionUID [WARN]

[jira] [Updated] (LOG4J2-1608) ServletAppender does not provide throwable object to ServletContext

[ https://issues.apache.org/jira/browse/LOG4J2-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1608: - Description: The method

[jira] [Updated] (LOG4J2-1608) ServletAppender does not provide throwable object to ServletContext

[ https://issues.apache.org/jira/browse/LOG4J2-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1608: - Description: The method

[jira] [Created] (LOG4J2-1607) Improve performance of SortedStringArrayMap data structure

Remko Popma created LOG4J2-1607: --- Summary: Improve performance of SortedStringArrayMap data structure Key: LOG4J2-1607 URL: https://issues.apache.org/jira/browse/LOG4J2-1607 Project: Log4j 2

Re: org.apache.logging.log4j.web.appender.ServletAppender.append(LogEvent)

I usually don't even include %exception in my pattern layouts for some reason, probably because of the double logging. So I'd go with (1) as well. On 22 September 2016 at 02:59, Gary Gregory wrote: > Hi All, > > The method >

[jira] [Closed] (LOG4J2-1608) ServletAppender does not provide throwable object to ServletContext

[ https://issues.apache.org/jira/browse/LOG4J2-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1608. Resolution: Fixed Assignee: Gary Gregory Fix Version/s: 2.7 In Git master. >

Re: org.apache.logging.log4j.web.appender.ServletAppender.append(LogEvent)

Yes, and them immediately committed it. I am -1 on this commit until I get an explanation as to why what we currently do isn’t better. Ralph > On Sep 22, 2016, at 9:29 AM, Gary Gregory wrote: > > I created https://issues.apache.org/jira/browse/LOG4J2-1608 >

[jira] [Reopened] (LOG4J2-1608) ServletAppender does not provide throwable object to ServletContext

[ https://issues.apache.org/jira/browse/LOG4J2-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers reopened LOG4J2-1608: - I don't believe I agree with this. I don't understand why it is better to pass the exception to the