Re: [Patch review please] Further work for Receivers backport to 1.2

2007-04-19 Thread Paul Smith
On 19/04/2007, at 2:57 PM, Curt Arnold wrote: On Apr 18, 2007, at 10:31 PM, Paul Smith wrote: Maybe you could fake out the getLogger() calls like private static final class LogLogger { public void debug(final String msg) { LogLog.debug(msg); }

Re: [Patch review please] Further work for Receivers backport to 1.2

2007-04-18 Thread Paul Smith
On 18/04/2007, at 2:46 PM, Scott Deboy wrote: In DBAppender: insertStatement.setLong(0, 0); should be insertStatement.setLong(1, 0); done, well spotted. Also, in CustomSQLDBReceiver: Should LoggingEvent event = new LoggingEvent(null, eventLogger, timeStamp, levelImpl, message, threadName,

Re: [Patch review please] Further work for Receivers backport to 1.2

2007-04-18 Thread Paul Smith
Maybe you could fake out the getLogger() calls like private static final class LogLogger { public void debug(final String msg) { LogLog.debug(msg); } public void warn(final String msg) { LogLog.warn(msg); }

Re: [Patch review please] Further work for Receivers backport to 1.2

2007-04-18 Thread Curt Arnold
On Apr 18, 2007, at 10:31 PM, Paul Smith wrote: Maybe you could fake out the getLogger() calls like private static final class LogLogger { public void debug(final String msg) { LogLog.debug(msg); } public void warn(final String msg) {

Re: [Patch review please] Further work for Receivers backport to 1.2

2007-04-17 Thread Curt Arnold
On Apr 17, 2007, at 10:42 PM, Paul Smith wrote: Hi all, I've completed porting the remaining Receiver classes to the sandbox area. The below patch is what I have locally, and taking the generated jar and adding it as a dependency to Chainsaw makes everything compile nicely. I am not

Re: [Patch review please] Further work for Receivers backport to 1.2

2007-04-17 Thread Curt Arnold
On Apr 17, 2007, at 11:27 PM, Curt Arnold wrote: On Apr 17, 2007, at 10:42 PM, Paul Smith wrote: Hi all, I've completed porting the remaining Receiver classes to the sandbox area. The below patch is what I have locally, and taking the generated jar and adding it as a dependency to

RE: [Patch review please] Further work for Receivers backport to 1.2

2007-04-17 Thread Scott Deboy
] Further work for Receivers backport to 1.2 On Apr 17, 2007, at 11:27 PM, Curt Arnold wrote: On Apr 17, 2007, at 10:42 PM, Paul Smith wrote: Hi all, I've completed porting the remaining Receiver classes to the sandbox area. The below patch is what I have locally, and taking