[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470852#comment-15470852
]
John Cairns commented on LOG4J2-1430:
-
I'll look into adding a classifier for a future release.
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469444#comment-15469444
]
Matt Sicker commented on LOG4J2-1430:
-
I was not aware of that feature. I'll try it out.
> Add
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469059#comment-15469059
]
Ralph Goers commented on LOG4J2-1430:
-
Thanks for doing this. I hate to nitpick though, but shouldn't
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468740#comment-15468740
]
Matt Sicker commented on LOG4J2-1430:
-
Thanks, I've upgraded the dependency.
> Add optional support
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468568#comment-15468568
]
John Cairns commented on LOG4J2-1430:
-
I just uploaded a Java 7 repo to Nexus. Please try it with
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468238#comment-15468238
]
Ralph Goers commented on LOG4J2-1430:
-
As I mentioned on the mailing list, we can't do a release
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468215#comment-15468215
]
Matt Sicker commented on LOG4J2-1430:
-
That would be helpful, yeah.
> Add optional support for
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468176#comment-15468176
]
John Cairns commented on LOG4J2-1430:
-
[~jvz] If it comes to that I could do a one-off Java 7 build.
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404290#comment-15404290
]
John Cairns commented on LOG4J2-1430:
-
For the sake of curiosity here is the result on a dual core,
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397718#comment-15397718
]
Anthony Maire commented on LOG4J2-1430:
---
Running up to 10 more spinning threads than available core
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397704#comment-15397704
]
Anthony Maire commented on LOG4J2-1430:
---
Hi Remko
I had a look on the performance page, the tests
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388027#comment-15388027
]
Remko Popma commented on LOG4J2-1430:
-
John, Anthony, please take a look at the Log4j 2 [performance
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387914#comment-15387914
]
John Cairns commented on LOG4J2-1430:
-
Yes, SpinPolicy.WAITING is the correct choice for Conversant
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387906#comment-15387906
]
Matt Sicker commented on LOG4J2-1430:
-
Could you compare these with the LMAX implementation as well?
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387874#comment-15387874
]
John Cairns commented on LOG4J2-1430:
-
Anthony, I'm afraid these benchmarks are perfectly relevant.
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387844#comment-15387844
]
Remko Popma commented on LOG4J2-1430:
-
It would be good if we can end up with a recommendation to
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387588#comment-15387588
]
Anthony Maire commented on LOG4J2-1430:
---
Hello John
Thank you for all these benchmark, but I'm
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384675#comment-15384675
]
John Cairns commented on LOG4J2-1430:
-
All of the above benchmarks have been posted.
> Add optional
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384669#comment-15384669
]
John Cairns commented on LOG4J2-1430:
-
Here you go.There does appear to be a difference in
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378558#comment-15378558
]
Matt Sicker commented on LOG4J2-1430:
-
Could you include AsyncLogger in the comparison?
> Add
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376524#comment-15376524
]
Anthony Maire commented on LOG4J2-1430:
---
LinkedBlockingQueue should be considered I think, it has
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376500#comment-15376500
]
Anthony Maire commented on LOG4J2-1430:
---
If you have enough time (I don't have access for a while
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375953#comment-15375953
]
Matt Sicker commented on LOG4J2-1430:
-
That would be great, thanks! We might devise some other
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375899#comment-15375899
]
John Cairns commented on LOG4J2-1430:
-
[~jvz] what do you need? All four implementations in 1-20
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375659#comment-15375659
]
Matt Sicker commented on LOG4J2-1430:
-
I'm going to need help pulling together benchmark data for all
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375593#comment-15375593
]
John Cairns commented on LOG4J2-1430:
-
[~rem...@yahoo.com], I agree wholeheartedly. I want to make
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374967#comment-15374967
]
Remko Popma commented on LOG4J2-1430:
-
Matt, to avoid misunderstanding, this is your initiative and I
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374950#comment-15374950
]
Remko Popma commented on LOG4J2-1430:
-
Usually there is no absolute better or worse, there is a set
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373594#comment-15373594
]
John Cairns commented on LOG4J2-1430:
-
Here is the actual data I collected:
Intel(R) Xeon(R) CPU
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356953#comment-15356953
]
Anthony Maire commented on LOG4J2-1430:
---
the patch has been attached to LOG4J2-1439
> Add optional
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351217#comment-15351217
]
Matt Sicker commented on LOG4J2-1430:
-
Ok, thank you for all the help!
> Add optional support for
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351150#comment-15351150
]
Anthony Maire commented on LOG4J2-1430:
---
I will finish the JCTools wrapper implementation (since
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351087#comment-15351087
]
Matt Sicker commented on LOG4J2-1430:
-
Do you a patch or PR for these tests?
> Add optional support
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350921#comment-15350921
]
Anthony Maire commented on LOG4J2-1430:
---
I made some additional tests on a dual xeon server (with
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346328#comment-15346328
]
Anthony Maire commented on LOG4J2-1430:
---
I had a look on the ResponseTimeTest, it's exactly what I
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345566#comment-15345566
]
Remko Popma commented on LOG4J2-1430:
-
We try to standardize on JMH for benchmarking. Generally this
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345564#comment-15345564
]
Remko Popma commented on LOG4J2-1430:
-
We try to standardize on JMH for benchmarking. Generally this
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345224#comment-15345224
]
Matt Sicker commented on LOG4J2-1430:
-
[~rem...@yahoo.com]: you developed these benchmarks, care to
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345211#comment-15345211
]
Anthony Maire commented on LOG4J2-1430:
---
The approch of using a NoOp appender for testing
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345196#comment-15345196
]
Matt Sicker commented on LOG4J2-1430:
-
Here is the simple test benchmarked with 32 threads on a
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345170#comment-15345170
]
John Cairns commented on LOG4J2-1430:
-
These park and yield strategies require a lot of tuning and
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345166#comment-15345166
]
John Cairns commented on LOG4J2-1430:
-
All of the Disruptor approaches will have the same Achilles
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345163#comment-15345163
]
Matt Sicker commented on LOG4J2-1430:
-
I haven't run the benchmarks with a large number of threads
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345157#comment-15345157
]
John Cairns commented on LOG4J2-1430:
-
There is no way for a queue of this nature to have constant
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344767#comment-15344767
]
Matt Sicker commented on LOG4J2-1430:
-
So what would you suggest for making another benchmark? I was
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344294#comment-15344294
]
Anthony Maire commented on LOG4J2-1430:
---
A made another test with the JCTools queue with the "yield
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340369#comment-15340369
]
Anthony Maire commented on LOG4J2-1430:
---
I made further tests today, and while I still believe that
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339770#comment-15339770
]
Matt Sicker commented on LOG4J2-1430:
-
I've rerun the AsyncAppender benchmarks. Specs: 4 threads,
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339745#comment-15339745
]
Remko Popma commented on LOG4J2-1430:
-
Bear in mind that Log4j is just the logging library used in
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339717#comment-15339717
]
John Cairns commented on LOG4J2-1430:
-
Most of the blocking queue strategies discussed here will not
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339697#comment-15339697
]
Matt Sicker commented on LOG4J2-1430:
-
As for overthreading producers, my main app at work has over a
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339692#comment-15339692
]
Matt Sicker commented on LOG4J2-1430:
-
I've updated the two AsyncAppender (no location and with
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339685#comment-15339685
]
John Cairns commented on LOG4J2-1430:
-
For this test you should set SpinPolicy.SPINNING.It
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339681#comment-15339681
]
John Cairns commented on LOG4J2-1430:
-
[~jvz] There is a branch of Conversant Disruptor that
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338841#comment-15338841
]
Matt Sicker commented on LOG4J2-1430:
-
OSGi provides some fun issues regarding the use of internal
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338834#comment-15338834
]
Anthony Maire commented on LOG4J2-1430:
---
In theory you are perfectly right, but
- Most of the JVM
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338827#comment-15338827
]
Matt Sicker commented on LOG4J2-1430:
-
JCTools does provide the same problem that LMAX Disruptor has:
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338818#comment-15338818
]
Matt Sicker commented on LOG4J2-1430:
-
Thank you for the patch! I'm working on adapting it to the
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338648#comment-15338648
]
Anthony Maire commented on LOG4J2-1430:
---
I will attach my patch right after posting this comment.
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338494#comment-15338494
]
Remko Popma commented on LOG4J2-1430:
-
Anthony, thanks a lot for the analysis. I think it is great
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338491#comment-15338491
]
Remko Popma commented on LOG4J2-1430:
-
I edited your comments (sorry :-) ) to use \{\{noformat\}\}
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338427#comment-15338427
]
Anthony Maire commented on LOG4J2-1430:
---
I made some tests with the branch to compare Conversant
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338129#comment-15338129
]
Matt Sicker commented on LOG4J2-1430:
-
Upon benchmarking, it appears the implementation of
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338115#comment-15338115
]
Matt Sicker commented on LOG4J2-1430:
-
Well now, I've gone and done an {{instanceof}} check for
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338095#comment-15338095
]
Matt Sicker commented on LOG4J2-1430:
-
The 64-bit requirements of the code is a known issue. The
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338089#comment-15338089
]
Matt Sicker commented on LOG4J2-1430:
-
There is a disadvantage to using {{TransferQueue}} over
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338072#comment-15338072
]
Matt Sicker commented on LOG4J2-1430:
-
4 threads on a Core 2 Duo. In this benchmark, I just did a
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338073#comment-15338073
]
Matt Sicker commented on LOG4J2-1430:
-
This is the same test as in the OP, but now with all three
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337649#comment-15337649
]
Anthony Maire commented on LOG4J2-1430:
---
There was a thread on the mechanical sympathy group on
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337600#comment-15337600
]
Remko Popma commented on LOG4J2-1430:
-
What is the thread count for this test?
Also, I haven't had a
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337572#comment-15337572
]
Ralph Goers commented on LOG4J2-1430:
-
Honestly, there are so many numbers here that I can't really
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337553#comment-15337553
]
Matt Sicker commented on LOG4J2-1430:
-
Some updated AsyncAppender benchmarks from a different
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337344#comment-15337344
]
Matt Sicker commented on LOG4J2-1430:
-
Updates on configurability:
* Converted BlockingQueueFactory
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337239#comment-15337239
]
Matt Sicker commented on LOG4J2-1430:
-
Alright, I've converted BlockingQueueFactory into a plugin
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333096#comment-15333096
]
Matt Sicker commented on LOG4J2-1430:
-
Sounds good. I'll convert this into a plugin.
> Add optional
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333085#comment-15333085
]
Ralph Goers commented on LOG4J2-1430:
-
Matt, despite while I can agree with Gary that making this
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333036#comment-15333036
]
Matt Sicker commented on LOG4J2-1430:
-
I've updated the branch to be configurable instead of magical
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332714#comment-15332714
]
Gary Gregory commented on LOG4J2-1430:
--
WRT
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332370#comment-15332370
]
Matt Sicker commented on LOG4J2-1430:
-
Alright, I have code available in the branch called
[
https://issues.apache.org/jira/browse/LOG4J2-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332361#comment-15332361
]
Matt Sicker commented on LOG4J2-1430:
-
One note about automatic use of Conversant: this makes all our
80 matches
Mail list logo
