[jira] Assigned: (LOG4PHP-21) Incorrect params passed in set_include_path

2009-04-27 Thread Knut Urdalen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Knut Urdalen reassigned LOG4PHP-21: --- Assignee: Knut Urdalen > Incorrect params passed in set_include_path > --

[jira] Updated: (LOG4PHP-21) Incorrect params passed in set_include_path

2009-04-27 Thread Knut Urdalen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Knut Urdalen updated LOG4PHP-21: Component/s: Tests > Incorrect params passed in set_include_path >

[jira] Updated: (LOG4PHP-24) LoggerAppenderRollingFile unable to rollover

2009-04-27 Thread Knut Urdalen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Knut Urdalen updated LOG4PHP-24: Component/s: Code > LoggerAppenderRollingFile unable to rollover >

[jira] Updated: (LOG4PHP-23) Mixed PHP4 and PHP5 syntax

2009-04-27 Thread Knut Urdalen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Knut Urdalen updated LOG4PHP-23: Component/s: Code > Mixed PHP4 and PHP5 syntax > -- > > Key

svn commit: r769264 - /incubator/log4php/trunk/src/main/php/xml/log4php.dtd

2009-04-27 Thread kurdalen
Author: kurdalen Date: Tue Apr 28 06:50:33 2009 New Revision: 769264 URL: http://svn.apache.org/viewvc?rev=769264&view=rev Log: corrected a minor typo Modified: incubator/log4php/trunk/src/main/php/xml/log4php.dtd Modified: incubator/log4php/trunk/src/main/php/xml/log4php.dtd URL: http://sv

Re: New committers

2009-04-27 Thread Knut Urdalen
Gavin wrote: I have created versions 2.0, 2.1 and 2.2 in Jira. All current issues (open/closed/resolved) have all been added to the 2.0 version. As new issues arrive we can decide as and when what issue they belong to. Nice :) I have created 'Documentation', 'Website' and 'Tests' Components.

[jira] Resolved: (LOG4PHP-22) log4php.dtd invalid

2009-04-27 Thread Christian Grobmeier (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Grobmeier resolved LOG4PHP-22. Resolution: Fixed removed elements - patch applied :-) > log4php.dtd invalid > ---

Re: Unit test updates

2009-04-27 Thread Knut Urdalen
Christian Grobmeier wrote: ups, Xdebug isn't so easily installed on OSX. Will try that later. $ pecl install xdebug should do. I work on OS X myself. Just remember to load it as a zend_extension with absolute path [xdebug] zend_extension="/opt/local/lib/php/extensions/no-debug-non-zts-2006

Re: Unit test updates

2009-04-27 Thread Christian Grobmeier
Hi Knut, glad you are back! I even have the tests running with PHPUnit with PHPUnit 3.1.16. > To create code coverage [3] you need Xdebug [4] installed and run: ups, Xdebug isn't so easily installed on OSX. Will try that later. > I currently use PHPUnit 3.3.14. While working with tickets for l

RE: New committers

2009-04-27 Thread Gavin
Hi Knut, I have created versions 2.0, 2.1 and 2.2 in Jira. All current issues (open/closed/resolved) have all been added to the 2.0 version. As new issues arrive we can decide as and when what issue they belong to. I have created 'Documentation', 'Website' and 'Tests' Components. It would be grea

[jira] Updated: (LOG4PHP-10) Update INSTALL

2009-04-27 Thread Gavin (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gavin updated LOG4PHP-10: - Component/s: Documentation > Update INSTALL > -- > > Key: LOG4PHP-10 >

Unit test updates

2009-04-27 Thread Knut Urdalen
Hi all, Just did some quick housekeeping of our unit test suite [1]. The unit test suite uses PHPUnit [2]. You can now run the entire suite simply by doing this: $ cd src/test/php $ phpunit To create code coverage [3] you need Xdebug [4] installed and run: $ phpunit --report=coverage I cur

svn commit: r769194 - in /incubator/log4php/trunk/src/test/php: ./ appenders/ or/ spi/

2009-04-27 Thread kurdalen
Author: kurdalen Date: Mon Apr 27 23:00:02 2009 New Revision: 769194 URL: http://svn.apache.org/viewvc?rev=769194&view=rev Log: housekeeping unit test suite Added: incubator/log4php/trunk/src/test/php/bootstrap.php incubator/log4php/trunk/src/test/php/phpunit.xml Removed: incubator/lo

Re: New committers

2009-04-27 Thread Knut Urdalen
Gavin wrote: Thanks Knut, glad your still around. I've been around all the time ;) Due to many reasons things stall a bit some times (like raising a child i.e.). However I'm would really like to get some stable releases of log4php out the door soon, and having you guys on board helps on mo

RE: New committers

2009-04-27 Thread Gavin
> -Original Message- > From: Knut Urdalen [mailto:[email protected]] > Sent: Tuesday, 28 April 2009 8:01 AM > To: Log4PHP Dev > Cc: [email protected] > Subject: Re: New committers > > Gavin wrote: > > Christian Grobmeier and myself have been added as committers to the > log4php >

Re: New committers

2009-04-27 Thread Knut Urdalen
Gavin wrote: Christian Grobmeier and myself have been added as committers to the log4php project. Great! Welcome to the team Christian and Gavin :) Hopefully soon we'll get our act together and start looking at those patches that some of you have attached to our issue tracker [1] Very nice!

Re: Getting rid of author tags:

2009-04-27 Thread Knut Urdalen
Christian Grobmeier wrote: However, after this dicussion I decided to search the mailinglists. there was already atempt to remove the author tags: http://www.mailinglistarchive.com/[email protected]/msg00068.html I think this lead to the issue. Yes, Curt mentioned this decision fr

Re: Tasks to be done at Log4PHP

2009-04-27 Thread Knut Urdalen
Christian Grobmeier wrote: I have found a todo list in the source code, but i am unsure which of these tasks are completed or still open, since the last modification has been done before 14 months. Hi Christian, Yes, I wrote a TODO-list [1] with some initial thought on the way forward when

Re: Getting rid of author tags:

2009-04-27 Thread Ceki Gulcu
Christian Grobmeier wrote: What does "painting yourself into a corner" mean? I am sorry for asking dumb. "Painting oneself into a corner" is an idiom based on the image of a person painting the floor, being careful not to step on wet paint. This often leads to a situation where the painter ge

Re: Getting rid of author tags:

2009-04-27 Thread Christian Grobmeier
Hi > There is no legal obligation to do this. As your intentions are good, > allow me to say that you are painting yourself into a corner. Asking > for unanimous agreement is too much work. And there will always be the > nagging suspicion that you forgot someone. there are allready contributors m

Re: Getting rid of author tags:

2009-04-27 Thread Ceki Gulcu
Christian Grobmeier wrote: However, I am afraid before that bureaucracy in sourcecode. It never came to my mind that one could feel that it is "unfair" that his lines of code are exactly noted. Furthermore, if one contributes 3 lines of code an a comment makes clear who did that, what is if on

Re: Getting rid of author tags:

2009-04-27 Thread Dennis Korbar
Hello, I'm just a user, but I feel the urge to add my two cents. Having followed and used the log4php project for the last couple of month, I was really happy to see that things are going forward again. I think the solution Ceki suggested is just fine, why shouldn't you just do both? Author tags

[jira] Commented: (LOG4PHP-1) Remove @author tags in code and document credits in README and website

2009-04-27 Thread Christian Grobmeier (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703152#action_12703152 ] Christian Grobmeier commented on LOG4PHP-1: --- An contributors.xml file allready exi

[jira] Commented: (LOG4PHP-1) Remove @author tags in code and document credits in README and website

2009-04-27 Thread Christian Grobmeier (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703147#action_12703147 ] Christian Grobmeier commented on LOG4PHP-1: --- I emailed all guys who are named in t

Re: Getting rid of author tags:

2009-04-27 Thread Christian Grobmeier
Sorry for my delay. First: Sorry Ceki for not knowing who you are! I am thankful for all the work you put in logging! Topic: Gavin speaks out of my heart. I prepared an e-mail before I got Gavins and now discarded mine. However, I am afraid before that bureaucracy in sourcecode. It never came to

RE: Getting rid of author tags:

2009-04-27 Thread Gavin
> -Original Message- > From: Ceki Gulcu [mailto:[email protected]] > Sent: Monday, 27 April 2009 10:04 PM > To: Log4PHP Dev > Subject: Re: Getting rid of author tags: > > Hello Gavin, > > It looks like you have considered the issue and made up your mind. Nope not yet :) It is the way that it

Re: Getting rid of author tags:

2009-04-27 Thread Ceki Gulcu
Hello Gavin, It looks like you have considered the issue and made up your mind. It is not hard to establish a authorship tag policy for contributors. Any contribution of over 10 lines (just an indication) merits mention as an author with an author tag. It is a very easy policy to follow. Mor

RE: Getting rid of author tags:

2009-04-27 Thread Gavin
> -Original Message- > From: Ceki Gulcu [mailto:[email protected]] > Sent: Monday, 27 April 2009 7:45 PM > To: Log4PHP Dev > Subject: Re: Getting rid of author tags: > > > Hi Christian, > > Author tags have been debated many times in the past. There is no > consensus on > the subject. Given

Re: Getting rid of author tags:

2009-04-27 Thread Ceki Gulcu
Gavin wrote: -Original Message- From: Christian Grobmeier [mailto:[email protected]] Sent: Monday, 27 April 2009 6:54 PM To: Log4PHP Dev Subject: Re: Getting rid of author tags: OK. So we agree that contributions via patches become credits in svn commit messages and in the changes

[jira] Commented: (LOG4PHP-1) Remove @author tags in code and document credits in README and website

2009-04-27 Thread Ceki Gulcu (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703050#action_12703050 ] Ceki Gulcu commented on LOG4PHP-1: -- Indeed, projects can choose their own path in this rega

RE: Getting rid of author tags:

2009-04-27 Thread Gavin
> -Original Message- > From: Christian Grobmeier [mailto:[email protected]] > Sent: Monday, 27 April 2009 6:54 PM > To: Log4PHP Dev > Subject: Re: Getting rid of author tags: > > OK. So we agree that contributions via patches become credits in svn > commit messages and in the changes f

Re: Getting rid of author tags:

2009-04-27 Thread Ceki Gulcu
Hi Christian, Author tags have been debated many times in the past. There is no consensus on the subject. Given that for many contributors the only reward for their work is recognition, I actually think that removing author tags is tantamount to daylight robbery. The fact that the board has a

[jira] Commented: (LOG4PHP-1) Remove @author tags in code and document credits in README and website

2009-04-27 Thread Gavin (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703044#action_12703044 ] Gavin commented on LOG4PHP-1: - Hi Ceki, Yes each project is free to choose their own path in t

[jira] Commented: (LOG4PHP-1) Remove @author tags in code and document credits in README and website

2009-04-27 Thread Ceki Gulcu (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703033#action_12703033 ] Ceki Gulcu commented on LOG4PHP-1: -- My point is that it removing author tags is not good pr

Re: Getting rid of author tags:

2009-04-27 Thread Christian Grobmeier
OK. So we agree that contributions via patches become credits in svn commit messages and in the changes file. What should we do with the currently existing authors? Most of the tags name Apache members, these are not a problem. But some of them came into code with the initial import. I don't have

RE: Getting rid of author tags:

2009-04-27 Thread Gavin
> -Original Message- > From: Christian Grobmeier [mailto:[email protected]] > Sent: Monday, 27 April 2009 5:01 PM > To: Log4PHP Dev > Subject: Getting rid of author tags: > > Hi, > > I have a commit ready for getting rid of the author tags and would > like to apply. Since a user compl

Getting rid of author tags:

2009-04-27 Thread Christian Grobmeier
Hi, I have a commit ready for getting rid of the author tags and would like to apply. Since a user complained about this and I am unsure about all this legal stuff, I would like to have your "go"s for this commit. (Please don't check the patch applied to the bug, I have re-created it) In my opini