Awesome Christian! Thank you too! :)
Knut
Have anyone here tried Scribe [1,2,3]?
Knut
[1] http://developers.facebook.com/scribe/
[2] http://sourceforge.net/projects/scribeserver/
[3] http://www.ruturaj.net/scribe-php-logging
hp in my eyes. That
middleware should fetch new log messages and put them onto the
respective messages streams.
Disc is faster than network and if we start supporting all kinds of
different services out there we'll start creating a lot of unnecessary
work for us. Let's keep it simple :)
Knut
ogger. These are the
lines users will have to change in their code when upgrading to 2.0.
Knut
er it and
fix the target.
For the record here's my /projects/log4php/build.xml file:
output="${basedir}/build/logs/checkstyle.xml"
error="/tmp/checkstyle.error.log">
failonerror="on">
typical Maven project layout?)
I'm not familiar with the current website publishing setup so if you
have other preferences I'm totally fine with a switch to something
better?. I mostly use Phing (or Ant) as my build tool.
Knut
[1] Building log4php with Maven
http://mail-archives.
.
I wrote an article about log4php way back for php|architect. Personally
I don't feel there has been that many changes that a new article is
worth it - so let's focus on online content.
Any takers for updating the website?
Knut
Sorry, I've not watched after phpUnderControl lately. I just found out
that CruiseControl was not running on my server anymore, just restarted
it and it should be available again now:
http://www.substring.no:8080/cruisecontrol/buildresults/log4php
Knut
[
https://issues.apache.org/jira/browse/LOG4PHP-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729415#action_12729415
]
Knut Urdalen commented on LOG4PHP-53:
-
Just a note from me: Normally it'
Christian Grobmeier wrote:
Knut, you created the PHP Configurator - just wrote a test for it.
There is an issue existing:
https://issues.apache.org/jira/browse/LOG4PHP-36
Can this be closed? Or is there some todo left?
It's just an initial implementation so far. I have some more todo&#
which classes can be instantiated (only instanceof
LoggerAppender) which is logic that resides in a
LoggerAppender::factory() method.
Just some thoughts around this :)
Knut
pened? I can reproduce this behaviour on two
different macs, one with 10.4 and one with 10.5
I have no idea why this is/was inconsistent for you. To me I got it when
running the whole test suite with simply typing "phpunit" in src/test/php.
Knut
Christian Grobmeier wrote:
what is the expected default Level of the RootLogger?
It should be ALL :)
Knut
this extension is not
available in the current environment. I will have to install it later so
this test case is also executed.
Remember to add markTestSkipped() in other similar cases in order to not
"break the build" ;)
Knut
e the settings according to our
rules here)
- output the logs of PMD (Project Mess Detection) from PHPUnit [6]
- output some nice svg graphs to look at [7]
Knut
[1] http://www.substring.no:8080/cruisecontrol/buildresults/log4php
[2]
http://www.substring.no:8080/cruisecontrol/buildresults/log4ph
[
https://issues.apache.org/jira/browse/LOG4PHP-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen resolved LOG4PHP-44.
-
Resolution: Fixed
> PEAR package
>
>
> Key
t success.
If you know how to fix this please help me out :)
Knut
[1] http://pear.php.net/package/PEAR_PackageFileManager2
[2] http://svn.apache.org/repos/asf/incubator/log4php/trunk/package.php
[3]
http://svn.apache.org/repos/asf/incubator/log4php/trunk/package-config.php
PEAR package
Key: LOG4PHP-44
URL: https://issues.apache.org/jira/browse/LOG4PHP-44
Project: Log4php
Issue Type: Improvement
Components: Code
Affects Versions: 2.0
Reporter: Knut Urdalen
Christian Grobmeier wrote:
whats going on with those classes?
LoggerDefaultCategoryFactory
LoggeFactory
Be aware that this is currently used in
LoggerHierarchy::getLoggerByFactory().
Knut
[
https://issues.apache.org/jira/browse/LOG4PHP-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706743#action_12706743
]
Knut Urdalen commented on LOG4PHP-30:
-
The PDO ctor throws a PDOExceptio
up the syslog on the machine?
Remember to write any temporary data into target/test (not within)
src/test/php (I just saw that the LoggerAppenderPDOTest is writing and
deleting a temporary sqlite database inside src/test/php/appenders).
Hope this helps! :)
Knut
[1] http://www.phpunit.de/
Curt Arnold wrote:
mvn test (Mac OS/X) currently fails with the current message:
test:
[exec]
[exec] Warning: require_once(PHPUnit/Util/Filter.php): failed to
open stream: Not a directory in /usr/bin/phpunit on line 40
You need a recent version of PHPUnit installed [1].
Knut
[1
list yesterday...
Knut
[
https://issues.apache.org/jira/browse/LOG4PHP-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen updated LOG4PHP-43:
Attachment: 43-LoggerMDC.patch
> Remove size restriction of MDC table in Logger
Reporter: Knut Urdalen
Assignee: Knut Urdalen
Priority: Minor
Fix For: 2.0
The mapped diagnostic context is currently allowed to only store 7 context
variables. Even though this should be enough in most cases, why should we do a
hard limit here
channel for apache packages is solved
we can add PEAR packaging as a build task.
Knut
before we restarted all the recent work
initiated April 28th 2009. Or pick another revision if you want.
Knut
fix LOG4PHP-41).
Now I'm over to cleaning up the unit test suite according to new names
and directory structure.
I've already called for help [1] when it comes to improving our unit
test suite, hope that we can get someone else on board as well for QA,
that would be great!
Knut
r update the website before you make the changes
Some of the changes today will break because I have to change a few
things over more than 1-2 commits. Sorry, but that's how trunk works. It
will be a bit unstable from time to time, but the cleanup is always
around the corner :)
Knut
cific to
what context it resolves to. I'll just use LoggerException for
simplicity, I like it :)
Knut
of others. In general we should only throw
exceptions during setup and not during the rest of the execution.
Knut
Christian Grobmeier wrote:
please let me know when you are doing these changes (or if) since I
would like to avoid merge conflicts :-)
It's going to happen soon (today or tomorrow).
If I've assigned the task to myself, it means that I will do it ;)
Knut
15889.html#a23315889
If you have Xdebug installed you'll have a code coverage report
available in target/test/report/index.html
I can set up other things as well, but I don't know the possibilities in
Buildbot. Only used CruiseControl with phpUnderControl.
Knut
[1] http://phpundercontrol.org
Reporter: Knut Urdalen
Assignee: Knut Urdalen
Priority: Minor
Fix For: 2.0
We have agreed on changing a few class names:
LoggerPatternLayout -> LoggerLayoutPattern
LoggerXmlLayout -> LoggerLayoutXml
LoggerDefaultRenderer -> LoggerRendererDefault
LoggerObjec
php? If so where do we need it and
what kinds of exceptions can you think of? I think it's useful to have a
shared overview of where we want to throw exceptions.
Knut
y not have all core classes in the "root" folder src/main/php/* ?
Yes, let's have all these classes in "root"-folder.
Knut
-> configurators (and move all configurators here)
The "spi" folder only contains one interface. We could rename this
folder to "core" i.e. and put all abstract classes, base classes and
interfaces here.
Let me know what you think! Is it ok for you? Any objections? If you
don't disagree I can apply this soon.
Knut
Reporter: Knut Urdalen
Priority: Trivial
Fix For: 2.0
As discussed on the mailing list today we should merge LoggerAppender and
LoggerAppenderSkeleton into LoggerAppender.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment
[
https://issues.apache.org/jira/browse/LOG4PHP-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen updated LOG4PHP-39:
Summary: Remove deprecated methods (was: Remove deprecated setPriority()
in Logger and LoggerRoot
[
https://issues.apache.org/jira/browse/LOG4PHP-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen resolved LOG4PHP-39.
-
Resolution: Fixed
> Remove deprecated setPriority() in Logger and LoggerR
: Knut Urdalen
Assignee: Knut Urdalen
Fix For: 2.0
The method setPriority() in Logger and LoggerRoot is deprecated and should be
removed from the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[
https://issues.apache.org/jira/browse/LOG4PHP-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen updated LOG4PHP-39:
Component/s: Code
Priority: Minor (was: Major)
> Remove deprecated setPriority() in Log
LoggerAppender?
Yes, everything in LoggerAppenderSkeleton can be moved to
LoggerAppender. Both are abstract classes and
LoggerAppender::singleton() is just used in configurator's
(LoggerPropertyConfigurator, LoggerDOMConfigurator and the upcoming
LoggerPhpConfigurator).
Knut
other ticket.
@Curt: can you check this out?
Knut
[
https://issues.apache.org/jira/browse/LOG4PHP-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen resolved LOG4PHP-38.
-
Resolution: Fixed
> Replace is_a() with instanc
[
https://issues.apache.org/jira/browse/LOG4PHP-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen resolved LOG4PHP-35.
-
Resolution: Fixed
> Replace LOG4PHP_LINE_SEP with PHP_
Replace is_a() with instanceof
--
Key: LOG4PHP-38
URL: https://issues.apache.org/jira/browse/LOG4PHP-38
Project: Log4php
Issue Type: Improvement
Components: Code
Reporter: Knut Urdalen
Remove LoggerAppenderDb
---
Key: LOG4PHP-37
URL: https://issues.apache.org/jira/browse/LOG4PHP-37
Project: Log4php
Issue Type: Task
Components: Code
Reporter: Knut Urdalen
Assignee: Knut
Implement a LoggerPhpConfigurator
-
Key: LOG4PHP-36
URL: https://issues.apache.org/jira/browse/LOG4PHP-36
Project: Log4php
Issue Type: New Feature
Components: Code
Reporter: Knut Urdalen
Replace LOG4PHP_LINE_SEP with PHP_EOL
-
Key: LOG4PHP-35
URL: https://issues.apache.org/jira/browse/LOG4PHP-35
Project: Log4php
Issue Type: Improvement
Components: Code
Reporter: Knut
text files, database rows etc). If you
want HTML reports or even RSS feeds for specific categories that should
be outside the scope of the actual logging process.
Because of this reason I also prefer that the LoggerLayoutHtml should be
removed since it breaks with this approach.
Knut
Remove all internal debugging
-
Key: LOG4PHP-34
URL: https://issues.apache.org/jira/browse/LOG4PHP-34
Project: Log4php
Issue Type: Improvement
Components: Code
Reporter: Knut Urdalen
Ok, I'll fix the code style this weekend. We only have 54 source files.
Not hard to fix manually since I have "Convert spaces to tabs" in
TextMate :)
Knut
Curt Arnold wrote:
If you do formatting changes, I'd suggest doing it as an independent
commit not intermixed with an
new tool for
me an most PHP developers don't know it either) so I will use quite some
time fixing this, I guess you have better understanding on how to do
such a change on a complete code base.
Knut
Curt Arnold wrote:
If you do formatting changes, I'd suggest doing it as an independ
Christian Grobmeier wrote:
I saw that newer methods hold brackets in the same line as method
signature, while older doesnt.
I am a fan of
method {
}
like Knut seems to be, so can we agree on that codestyle?
Yes, let's use the traditional Unix policy.
I also saw _blub for private vari
; [1] June 2007.
Feel free to create new pages and document things like this.
Knut
[1] http://wiki.apache.org/logging/Log4PHP/Proposal
Xml to be able to add the logic
needed for creating and updating a valid output.
So my final question would be:
Does it make sense to create a LoggerAppenderHtml in this case and
modify the DOM upon appending messages? Any other suggestions on how to
resolve this?
Knut
Xcode, but most
of what you need is also available in MacPorts.
Knut
[1] http://www.macports.org
[2] http://2tbsp.com/content/install_apache_2_and_php_5_macports
[
https://issues.apache.org/jira/browse/LOG4PHP-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen resolved LOG4PHP-33.
-
Resolution: Fixed
> Appenders is not properly closed upon destruct
Reporter: Knut Urdalen
Assignee: Knut Urdalen
Priority: Critical
Fix For: 2.0
Appenders doesn't seem to be properly closed. The
LoggerAppenderSkeleton::finalize() is only used in __sleep() and __wakeup(),
but the normal situation would at least be to
w test cases
when it runs fine and cover new code.
If you don't have commit access simply do:
$ svn diff > something.patch
and hand that file over to this mailing list so one of the committers
can review and commit it.
Knut
[1] http://www.phpunit.de
[2] http://www.xdebug.org
if you run the examples if they need to write something to disc.
Unit tests currently don't have any output, but we'll stuff that into
target as well for sure :)
Knut
rd to work with other tools on
top of it actually. Just my personal preference and lazy not learning
other tools when command line does a great job ;)
Knut
not commit this file even
with a totally clean checkout.
That's strange... I fixed the change log for you anyway now.
svn up
Maybe a "svn cleanup" would help here?
Knut
. svn diff (select files if needed)
3. svn ci (select files if needed)
Knut
unit tests before commit just to make
sure I didn't break something that at least should have been working before.
Knut
on here if we can to skip support
for a "u" modifier in our date format.
Knut
[
https://issues.apache.org/jira/browse/LOG4PHP-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen reopened LOG4PHP-17:
-
> %l Pattern layout raises a protected property access er
[
https://issues.apache.org/jira/browse/LOG4PHP-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen resolved LOG4PHP-17.
-
Resolution: Fixed
Fix Version/s: 2.0
> %l Pattern layout raises a protected prope
[
https://issues.apache.org/jira/browse/LOG4PHP-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen resolved LOG4PHP-19.
-
Resolution: Fixed
> Logger location info is invalid in log outputs of Logger's su
[
https://issues.apache.org/jira/browse/LOG4PHP-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen reopened LOG4PHP-19:
-
> Logger location info is invalid in log outputs of Logger's su
[
https://issues.apache.org/jira/browse/LOG4PHP-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen updated LOG4PHP-19:
Affects Version/s: (was: 2.0)
Fix Version/s: 2.0
> Logger location info is invalid
[
https://issues.apache.org/jira/browse/LOG4PHP-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen resolved LOG4PHP-18.
-
Resolution: Fixed
> Date pattern %d conversion is inva
[
https://issues.apache.org/jira/browse/LOG4PHP-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen reopened LOG4PHP-18:
-
Assignee: Knut Urdalen
> Date pattern %d conversion is inva
[
https://issues.apache.org/jira/browse/LOG4PHP-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen resolved LOG4PHP-16.
-
Resolution: Fixed
Assignee: Knut Urdalen
Marshall has a good point about size limits for
[
https://issues.apache.org/jira/browse/LOG4PHP-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen resolved LOG4PHP-12.
-
Resolution: Fixed
Missing directories is now created automatically (even recursive
[
https://issues.apache.org/jira/browse/LOG4PHP-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen resolved LOG4PHP-20.
-
Resolution: Fixed
Assignee: Knut Urdalen
Thanks! Modified patch applied. The suggestion
in the change log file now. Whenever you resolve a ticket
you should also add a comment to the CHANGELOG.
Knut
[
https://issues.apache.org/jira/browse/LOG4PHP-31?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen resolved LOG4PHP-31.
-
Resolution: Fixed
> Removing unnecessary use of LOG4PHP_
een two or more PHP
processes logging to the same file at the same time.
It should be fine to log to the same file from different PHP processes
(we don't want to limit that possibility).
Knut
Reporter: Knut Urdalen
Priority: Minor
Fix For: 2.0
There is many places in the code where we can use class constants instead of
define()'s. This will both improve readability and usage in my eyes in addition
to a tiny speed improvement since defines are evaluat
: Knut Urdalen
Assignee: Knut Urdalen
Priority: Trivial
Fix For: 2.0
LOG4PHP_DIR is no longer required for any other code than
LoggerManager::autoload(). We should keep LOG4PHP_DIR here to set it
automatically if not set from user land code. All other
08.2.2 requires PHP >= 5.2.1
Please add your comments and suggestions if you have any.
Knut
o the main class in that particular file.
I think we have more important stuff to work on than moving classes
around ;)
Knut
Implement LoggerAppenderPDO
---
Key: LOG4PHP-30
URL: https://issues.apache.org/jira/browse/LOG4PHP-30
Project: Log4php
Issue Type: New Feature
Components: Code
Reporter: Knut Urdalen
rsion of log4php we now have PDO [3] which would be
a more natural choice for us.
Initially I would suggest to at least create a LoggerAppenderPDO and
maybe remove LoggerAppenderAdodb and LoggerAppenderDb. Any opinions?
Knut
[1] http://adodb.sourceforge.net
[2] http://pear.php.net/package/
t (I
see the change Maven Changes Plugin let you use a variety of attributes
I'm unsure of how we should use).
We should also attribute past developers/contributors and the initial
creator of log4php for sure :)
Knut
[
https://issues.apache.org/jira/browse/LOG4PHP-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703698#action_12703698
]
Knut Urdalen commented on LOG4PHP-26:
-
We have raised this discussion as par
it's very easy to also copy and paste all issues related to
each release together with the release announcement and use it on our
website.
I'm not 100% sure about what format we should use on our changelog, but
we should keep it as simple as this and try to update it together with
our commits.
Knut
toload_register(), __autoload() is kind of the
last way out if you need complete control and know what you are doing
since you can only declare one __autoload() method ;)
In library code like log4php you should provide an autoload-method (like
LoggerManager::autoload()) which does the job for you.
Knut
[
https://issues.apache.org/jira/browse/LOG4PHP-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen resolved LOG4PHP-29.
-
Resolution: Fixed
> Load classes through autoload instead of explicitly include t
hen you include LoggerManager.php.
Knut
[1] http://svn.apache.org/viewvc?view=rev&revision=769408
Christian Grobmeier wrote:
i figured out that not every class in log4php has it's own file.
Can we agree on that convention?
Fine, which files do you think of? I'm working on the autoload
implementation and would like to know ;)
Knut
Components: Code
Reporter: Knut Urdalen
Assignee: Knut Urdalen
Fix For: 2.0
We should use PHP's autoload mechanism to load classes instead of explicitly
include them. This will both simplify the code and only load the needed classes
at ru
ation deadline" was on March 13th for GSoC 2009.
Knut
[
https://issues.apache.org/jira/browse/LOG4PHP-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen resolved LOG4PHP-25.
-
Resolution: Fixed
> Allow to set environment variables in LoggerOptionConver
[
https://issues.apache.org/jira/browse/LOG4PHP-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen resolved LOG4PHP-28.
-
Resolution: Fixed
Fix Version/s: 2.0
Assignee: Knut Urdalen
Thanks Michael
: Code
Reporter: Knut Urdalen
Priority: Minor
Fix For: 2.0
Christian Hammers has proposed to add the option of defining log file
permissions as part of configuration:
http://www.nabble.com/Adding-umask-chmod-to-FileAppender--tt11748228.html#a11748228
--
This
Add file locking to file appenders
--
Key: LOG4PHP-26
URL: https://issues.apache.org/jira/browse/LOG4PHP-26
Project: Log4php
Issue Type: New Feature
Components: Code
Reporter: Knut
Components: Code
Reporter: Knut Urdalen
Assignee: Knut Urdalen
Priority: Minor
Fix For: 2.0
Christian Hammers proposed the following on the mailinglist:
"Allow to set environment variables using Apaches
SetEnv or mod_rewrite or PHPs putenv()
1 - 100 of 152 matches
Mail list logo
