Re: [Lsr] AD Review for draft-ietf-ospf-yang-21

2019-07-02 Thread Acee Lindem (acee)
Thank Alvaro! From: Lsr on behalf of Alvaro Retana Date: Tuesday, July 2, 2019 at 10:33 AM To: Acee Lindem , "draft-ietf-ospf-y...@ietf.org" Cc: "lsr@ietf.org" , "lsr-cha...@ietf.org" , Stephane Litkowski Subject: Re: [Lsr] AD Review for draft-ietf-ospf-yang-

Re: [Lsr] AD Review for draft-ietf-ospf-yang-21

2019-07-02 Thread Alvaro Retana
On July 1, 2019 at 6:58:43 PM, Acee Lindem (acee) (a...@cisco.com) wrote: I believe version -23 addresses your comments. It does! I’m starting the IETF LC. Thanks! Alvaro. ___ Lsr mailing list Lsr@ietf.org https://www.ietf.org/mailman/listinfo/lsr

Re: [Lsr] AD Review for draft-ietf-ospf-yang-21

2019-07-01 Thread Acee Lindem (acee)
Hi Jeff, On 7/1/19, 4:06 PM, "Jeffrey Haas" wrote: On Thu, Jun 27, 2019 at 03:11:21PM +, Les Ginsberg (ginsberg) wrote: > I am firmly on the side of Acee on this one – and I think more attention needs to be paid to his initial answer: “B-F-D”. > > The implications of

Re: [Lsr] AD Review for draft-ietf-ospf-yang-21

2019-07-01 Thread Acee Lindem (acee)
Hi Alvaro, I believe version -23 addresses your comments. For “config true” timers leaves, I couldn’t use the ietf-routing-types.yang types since the union included “infinity” and “not-set” which aren’t really applicable. I did use the RFC8294 types for “config false” timers.

Re: [Lsr] AD Review for draft-ietf-ospf-yang-21

2019-07-01 Thread Jeffrey Haas
On Thu, Jun 27, 2019 at 03:11:21PM +, Les Ginsberg (ginsberg) wrote: > I am firmly on the side of Acee on this one – and I think more attention > needs to be paid to his initial answer: “B-F-D”. > > The implications of this are that we do not expect control plane to have > finer granularity

Re: [Lsr] AD Review for draft-ietf-ospf-yang-21

2019-06-27 Thread Les Ginsberg (ginsberg)
; stephane.litkow...@orange.com Subject: Re: [Lsr] AD Review for draft-ietf-ospf-yang-21 On June 26, 2019 at 9:31:05 PM, Acee Lindem (acee) (a...@cisco.com<mailto:a...@cisco.com>) wrote: ... ... 3936 leaf dead-timer { 3937 type uint32; 3938 units "seco

Re: [Lsr] AD Review for draft-ietf-ospf-yang-21

2019-06-27 Thread Alvaro Retana
On June 26, 2019 at 9:31:05 PM, Acee Lindem (acee) (a...@cisco.com) wrote: 3936 leaf dead-timer { 3937 type uint32; 3938 units "seconds"; 3939 config false; 3940 description "This timer tracks the remaining time before 3941

Re: [Lsr] AD Review for draft-ietf-ospf-yang-21

2019-06-26 Thread Acee Lindem (acee)
Hi Alvaro, From: Alvaro Retana Date: Wednesday, June 26, 2019 at 3:26 PM To: Acee Lindem , "draft-ietf-ospf-y...@ietf.org" Cc: "lsr@ietf.org" , Stephane Litkowski , "lsr-cha...@ietf.org" Subject: Re: AD Review for draft-ietf-ospf-yang-21 On June 26, 2019 at 11:53:28 AM, Acee Lindem (acee)

Re: [Lsr] AD Review for draft-ietf-ospf-yang-21

2019-06-26 Thread Alvaro Retana
On June 26, 2019 at 11:53:28 AM, Acee Lindem (acee) (a...@cisco.com) wrote: Acee: Hi! This may take a couple iterations. See inline. I only have one response. :-) 3936 leaf dead-timer { 3937 type uint32; 3938 units "seconds"; 3939 config false;

Re: [Lsr] AD Review for draft-ietf-ospf-yang-21

2019-06-26 Thread Acee Lindem (acee)
Hi Alvaro, This may take a couple iterations. See inline. From: Alvaro Retana Date: Monday, June 24, 2019 at 4:52 PM To: Acee Lindem , "draft-ietf-ospf-y...@ietf.org" Cc: "lsr@ietf.org" , Stephane Litkowski , "lsr-cha...@ietf.org" Subject: Re: AD Review for draft-ietf-ospf-yang-21 On June

Re: [Lsr] AD Review for draft-ietf-ospf-yang-21

2019-06-24 Thread Alvaro Retana
On June 22, 2019 at 7:03:58 PM, Acee Lindem (acee) (a...@cisco.com) wrote: Acee: Hi! Thanks for the review - we will address your comments in the -22 version. See inline. I have a couple of replies. Please take a look at the bottom because it looks like you didn’t get (or missed) part of the

Re: [Lsr] AD Review for draft-ietf-ospf-yang-21

2019-06-22 Thread Acee Lindem (acee)
Hey Alvaro, Thanks for the review - we will address your comments in the -22 version. See inline. On 6/5/19, 6:26 PM, "Alvaro Retana" wrote: Dear authors: I just finished reading this document. I have some comments in-line, including a couple that I consider major --

[Lsr] AD Review for draft-ietf-ospf-yang-21

2019-06-05 Thread Alvaro Retana
Dear authors: I just finished reading this document. I have some comments in-line, including a couple that I consider major -- I'll wait for whose to be addressed before moving forward. The datatracker reports 4 errors in the model, mostly related to ietf-bfd-types. Please take a look.