Re: [LTP] Lachesis Linux tests

2015-08-11 Thread $rik@nth
Thank you Cyril. My intention about asking Lachesis, They claimed the test framework is well enough to catch real time kernel issues. So though of having first hand on it. On Tue, Aug 11, 2015 at 1:52 PM, Cyril Hrubis chru...@suse.cz wrote: Hi! Does the Lachesis is part of LTP? or Its a

Re: [LTP] [PATCH V2] container: new testcase pidns32

2015-08-11 Thread Cyril Hrubis
Hi! Hi, I'm still not entirely convinced about this test. So am I. What about checking that we can do at least MAXNEST levels? -- Cyril Hrubis chru...@suse.cz -- ___

Re: [LTP] [PATCH] container: use tst_record_childstatus() in userns

2015-08-11 Thread Yuan Sun
Thank you, Jan. Yuan On 2015/8/11 15:43, Jan Stancek wrote: - Original Message - From: Yuan Sun sunyu...@huawei.com To: jstan...@redhat.com Cc: ltp-list@lists.sourceforge.net Sent: Friday, 7 August, 2015 7:04:00 AM Subject: [PATCH] container: use tst_record_childstatus() in

Re: [LTP] Lachesis Linux tests

2015-08-11 Thread Cyril Hrubis
Hi! Does the Lachesis is part of LTP? or Its a standalone linux test framework available in opensource. Never heard of it. There is an pdf on lwn net about it but the links to repository are dead. I'm afraid that the project does not exist anymore. -- Cyril Hrubis chru...@suse.cz

Re: [LTP] [PATCH V2] container: new testcase pidns32

2015-08-11 Thread Yuan Sun
Hi Jan, See in-line comments. On 2015/8/11 16:05, Jan Stancek wrote: - Original Message - From: Yuan Sun sunyu...@huawei.com To: jstan...@redhat.com Cc: ltp-list@lists.sourceforge.net Sent: Friday, 7 August, 2015 6:55:08 AM Subject: [PATCH V2] container: new testcase pidns32

Re: [LTP] [PATCH] container: use tst_record_childstatus() in userns

2015-08-11 Thread Jan Stancek
- Original Message - From: Yuan Sun sunyu...@huawei.com To: jstan...@redhat.com Cc: ltp-list@lists.sourceforge.net Sent: Friday, 7 August, 2015 7:04:00 AM Subject: [PATCH] container: use tst_record_childstatus() in userns Signed-off-by: Yuan Sun sunyu...@huawei.com Hi, Pushed

Re: [LTP] [PATCH V2] container: new testcase pidns32

2015-08-11 Thread Jan Stancek
- Original Message - From: Yuan Sun sunyu...@huawei.com To: jstan...@redhat.com Cc: ltp-list@lists.sourceforge.net Sent: Friday, 7 August, 2015 6:55:08 AM Subject: [PATCH V2] container: new testcase pidns32 Kernel imposes a limit of 32 nested levels of pid namespaces.

Re: [LTP] [PATCH V2] container: new testcase pidns32

2015-08-11 Thread Yuan Sun
Hi Jan and Cyril, I have send a message in reply. What is your opinion? If you convinced about this test, I will update the code. Or it is unnecessary to update the code. Thanks. Yuan On 2015/8/11 16:33, Cyril Hrubis wrote: Hi! Hi, I'm still not entirely convinced about

Re: [LTP] [PATCH] Add tst_wait_record_childstatus function.

2015-08-11 Thread Cyril Hrubis
Hi! Yes. You are right. I agree with you. tst_record_childstatus(NULL, -1); can be used in userns01. FYI: I've just pushed a patch that adds note to the test-writing-guidelines documentation about this. Have a look at the note at the end of this paragraph:

Re: [LTP] [PATCH V2] container: new testcase pidns32

2015-08-11 Thread Jan Stancek
- Original Message - From: Yuan Sun sunyu...@huawei.com To: Jan Stancek jstan...@redhat.com Cc: ltp-list@lists.sourceforge.net Sent: Tuesday, 11 August, 2015 10:43:02 AM Subject: Re: [PATCH V2] container: new testcase pidns32 Hi Jan, See in-line comments. On 2015/8/11

Re: [LTP] [PATCH v2] inotify: Add test for inotify mark destruction race

2015-08-11 Thread Jan Kara
Hi, On Tue 11-08-15 16:14:32, Cyril Hrubis wrote: Pushed with following changes: * Added GPL header at the start of the file * Removed cleanup parameter from SAFE calls in child because if one of the calls in child fails the temporary directory would be deleted, then parent would

Re: [LTP] [PATCH v2] inotify: Add test for inotify mark destruction race

2015-08-11 Thread Cyril Hrubis
Hi! Pushed with following changes: * Added GPL header at the start of the file * Removed cleanup parameter from SAFE calls in child because if one of the calls in child fails the temporary directory would be deleted, then parent would attempt to remove the directory and that will fail

Re: [LTP] [PATCH 09/23] network/virt/vlan03: add new test-case

2015-08-11 Thread Cyril Hrubis
Hi! +tst_resm TINFO networks with the same VLAN ID must work + +res=TPASS + +virt_setup id 4094 id 4094 +virt_compare_netperf || res=TFAIL + +tst_resm $res done + +tst_resm TINFO different VLAN ID shall not work together +res=TPASS +virt_setup id 4093 id 4094 +virt_compare_netperf

Re: [LTP] [PATCH 16/23] network/virt: add macvtap01 test

2015-08-11 Thread Cyril Hrubis
+for m in $modes; do + tst_resm TINFO add $virt_type with mode '$m' + + virt_add ltp_v0 mode $m /dev/null 21 + if [ $? -ne 0 ]; then + tst_resm TCONF iproute or kernel doesn't support mode '$m' shouldn't we rather call continue here, since we issued

Re: [LTP] [PATCH 17/23] network/virt: add test-case 01 to virt_lib.sh

2015-08-11 Thread Cyril Hrubis
Hi! +# Check if we can create then delete virtual interface n times. +# virt_test_01 [OPTIONS] +# OPTIONS - different options separated by comma. +virt_test_01() +{ + start_id=1 + virt_count=500 + + local opts=${1:-} + local n=0 + + while ((1)); do This does not

Re: [LTP] [PATCH 04/23] network/virt_lib.sh: use ROD_SILENT in cleanup

2015-08-11 Thread Cyril Hrubis
Hi! --- a/testcases/network/virt/virt_lib.sh +++ b/testcases/network/virt/virt_lib.sh @@ -90,7 +90,8 @@ cleanup_vifaces() tst_resm TINFO cleanup virtual interfaces... local viface=`ip link | sed -nE 's/^[0-9]+: (ltp_v[0-9]+):.+/\1/p'` for vx in $viface; do - ip

Re: [LTP] [PATCH 18/23] network/virt: move checking for command support to virt_lib.sh

2015-08-11 Thread Cyril Hrubis
Hi! Add new function virt_check_cmd. Change TCONF to TINFO so that we just skip not supported options and don't return TCONF as a end test result. I would rather see the test doing TCONF for unsupported options and skipping the actual test. And I know that getting TCONF for testcases that only

Re: [LTP] [PATCH 19/23] network/virt: add test-case 02 to virt_lib.sh

2015-08-11 Thread Cyril Hrubis
Hi! diff --git a/testcases/network/virt/ipvlan01.sh b/testcases/network/virt/ipvlan01.sh index 706c1d8..156de78 100755 --- a/testcases/network/virt/ipvlan01.sh +++ b/testcases/network/virt/ipvlan01.sh @@ -16,8 +16,8 @@ # # Author: Alexey Kodanev alexey.koda...@oracle.com # -#

Re: [LTP] [PATCH 00/23] Add vlan, ipvlan, gre, macvlan interfaces

2015-08-11 Thread Cyril Hrubis
Hi! Most interfaces share the same ip command syntax and the same test scenarious can be applied to them. So rename vxlan directory to more general 'virt' directory and add those interfaces to it. Apart from the minor nitpicks this patchset looks good to me. -- Cyril Hrubis chru...@suse.cz

Re: [LTP] [PATCH V2] container: new testcase pidns32

2015-08-11 Thread Yuan Sun
On 2015/8/11 21:58, Jan Stancek wrote: - Original Message - From: Yuan Sun sunyu...@huawei.com To: Jan Stancek jstan...@redhat.com Cc: ltp-list@lists.sourceforge.net Sent: Tuesday, 11 August, 2015 10:43:02 AM Subject: Re: [PATCH V2] container: new testcase pidns32 Hi Jan,

[LTP] [PATCH] containers: fix dev name in create_veth()

2015-08-11 Thread Hangbin Liu
The new version of iproute2 will show veth device like veth0@veth1, but we won't get a dev proc entry like this. Fix the dev name to avoid error like /proc/sys/net/ipv4/conf/veth0@veth1/proxy_arp: No such file or directory Signed-off-by: Hangbin Liu liuhang...@gmail.com ---

Re: [LTP] [PATCH] Add tst_wait_record_childstatus function.

2015-08-11 Thread Yuan Sun
Thank you, Cyril. Yuan On 2015/8/11 20:44, Cyril Hrubis wrote: Hi! Yes. You are right. I agree with you. tst_record_childstatus(NULL, -1); can be used in userns01. FYI: I've just pushed a patch that adds note to the test-writing-guidelines documentation about this. Have a look at