On Wed, Jun 26, 2013 at 8:47 PM, Garrett Cooper wrote:
> On Wed, Jun 26, 2013 at 8:43 PM, Wanlong Gao wrote:
>
>> PROCESS_CPUTIME_ID and THREAD_CPUTIME_ID are not supported before
>> kernel 2.6.12, and changed back since 2.6.38. And they are
>> thought improper suppor
On Wed, Jun 26, 2013 at 8:43 PM, Wanlong Gao wrote:
> PROCESS_CPUTIME_ID and THREAD_CPUTIME_ID are not supported before
> kernel 2.6.12, and changed back since 2.6.38. And they are
> thought improper supported on Linux, so we just remove them
> from the test of clock_settime and remain them be unt
On May 16, 2013, at 2:41 AM, "Jungsoo Son" wrote:
> Hello,
>
> My name is jungsoo son who is in charge of kernel development on my company.
> I want to send my patch to upstream of Linux Test Project.
> Could you give me some information about how to push git commit ?
Hi jungsoo son!
I rec
Error code printing would be helpful...
Thanks,
-Garrett
Sent from my iPhone
On Jan 25, 2013, at 4:15 AM, Jan Stancek wrote:
> This is same issue as:
> commit 4558bfae923a715ac78b5b3d3ecdfa16f9424808
> Author: Jan Stancek
> Date: Wed Dec 5 12:49:47 2012 +0100
> aio_read/7-1.c: fix ra
On Jan 16, 2013, at 5:43 AM, Sedat Dilek wrote:
> Hi,
>
> why do you name your BZ2-tarballs with the right and common
> file-extensions ".tar.bz2"?
>
> $ file ltp-full-20130109.bz2
> ltp-full-20130109.bz2: bzip2 compressed data, block size = 900k
>
> $ bunzip2 ltp-full-20130109.bz2
>
> $ file
On Mon, Jan 7, 2013 at 5:23 PM, wrote:
> Hello Cyril,
>
>>> What about physically plugging the output cable to the capture input?
>
> Hardware changes are required to perform this plugging. not sure if this
> changes
> can be done in our setup.
>
>>> Exact matching would be really hard, but if
On Jan 3, 2013, at 3:23 AM, chru...@suse.cz wrote:
> Hi!
>> I am using LTP drop released on ltp-full-20120104 version.
>> I have written a testcase to get user input data and call that testcase
>> using "runltp", the command I use to get user input data is "read -t 10
>> response"
>> But, when e
; +++ b/testcases/open_posix_testsuite/conformance/interfaces/sigset/7-1.c
> @@ -56,9 +56,8 @@ int main(void)
>return PTS_UNRESOLVED;
>}
>
> -rc = sigset(SIGCHLD, SIG_HOLD);
> -if (rc < 0) {
> -ERR_MSG("sigset()", rc);
> +if (sigse
On Thu, Nov 22, 2012 at 5:43 PM, Wanlong Gao wrote:
> On 11/23/2012 12:28 AM, chru...@suse.cz wrote:
>> Hi!
> Currently, -s option only can run the test case in alltests by
> the PATTERN, but I think it's worth to be able to run all of
> the test cases under runtest/ by the PATTERN.
>>
On Sat, Sep 1, 2012 at 10:30 PM, gchen wrote:
> Hello ltp-list@lists.sourceforge.net
>
>
> Question:
>
> Use ltp stress test (/opt/ltp/ltpstress.sh) with ltp-full-20100331.gz
> to test RHEL5 (kernel-2.6.18-308.4.1.el5) for 72 hours.
>
> Not give any more configurations for NFS (using default confi
On Aug 8, 2012, at 2:29 AM, Caspar Zhang wrote:
> On 07/31/2012 11:57 AM, Garrett Cooper wrote:
>> On Mon, Jul 30, 2012 at 7:53 PM, Caspar Zhang wrote:
>>>
>>> some NUMA related syscalls: mbind, get_mempolicy are not supported on
>>> some arches (e.g. i386),
On Tue, Aug 7, 2012 at 10:32 PM, Caspar Zhang wrote:
> On 08/03/2012 12:22 AM, Simon Xu wrote:
>> Capability testcases fail to compile with sys/capability.h of libcap-devel in
>> RHEL5-like distros:
>>
>> In file included from /usr/include/sys/capability.h:34, from
>> cap_bounds_r.c:30:
>> /usr/i
4/ltp-2nHcAjcGKr/chd2Y4XkO/object
>
> Use readlink to get absolute path.
>
> Signed-off-by: Simon Xu
Reviewed-by: Garrett Cooper
Pushed to the repo.
Thanks!
-Garrett
--
Live Security Virtual Conference
Excl
On Wed, Aug 1, 2012 at 1:47 PM, Mike Frysinger wrote:
> On Monday 02 July 2012 11:27:45 Vanni Genua wrote:
>> anybody know if LTP support ARMv7 and not only x86 architecture?
>
> LTP doesn't really care about the architecture. it works on any CPU.
- You may run into ARM bugs (in which case, patc
On Mon, Jul 30, 2012 at 7:57 PM, Caspar Zhang wrote:
>
> This patch makes the tests in mem/ dir use numa_helper in libkerntest.
>
> Signed-off-by: Caspar Zhang
Inline patches are easier to review...
>- tst_brkm(TCONF, NULL, "required a NUMA system.");
>+ tst_brkm(TCONF
On Mon, Jul 30, 2012 at 7:53 PM, Caspar Zhang wrote:
>
> some NUMA related syscalls: mbind, get_mempolicy are not supported on
> some arches (e.g. i386), I use TEST macro to test the syscall in setup()
> function, if the syscall is not implemented on the system, a TCONF
> message will given like t
On Wed, Jul 25, 2012 at 8:03 PM, Wanlong Gao wrote:
> Use grep -q option instead, as Cooper suggested.
>
> Signed-off-by: Wanlong Gao
Reviewed-by: Garrett Cooper
--
Live Security Virtual Conference
Exclu
Sent from my iPhone
On Jul 23, 2012, at 9:02 PM, Wanlong Gao wrote:
> On 07/24/2012 11:49 AM, Caspar Zhang wrote:
>> On 07/24/2012 10:58 AM, Wanlong Gao wrote:
>>> Wait for aio_write() completion.
>>> If aio_fsync() sync the fd without the previous aio_write()
>>> completion, it will cause Segme
On Tue, Jun 26, 2012 at 1:26 AM, Wanlong Gao wrote:
> On 06/22/2012 10:35 AM, Wanlong Gao wrote:
>> Maybe a typo when replacing DEVICE_FS_TYPE.
>
> Objections, Cooper?
> There isn't any other places have this odd statement in this file
> like here.
LGTM.
R
On Thu, Jun 21, 2012 at 12:27 AM, Li, Jin wrote:
> Hi,
>
> When I use runltp with the option [-b DEVICE], notice the typo as follows:
>
> sed -i "" -e "s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|" ${TMP}/alltests
>
> The runltp will hit error and exit.
>
> Is it a typo or I miss something else ?
It wa
On Mon, May 28, 2012 at 4:39 AM, Jan Stancek wrote:
>
> Signed-off-by: Jan Stancek
My comment about TERRNO from the other patch applies to this as well,
but this looks ok.
-Garrett
--
Live Security Virtual Conference
Ex
On Mon, May 28, 2012 at 4:39 AM, Jan Stancek wrote:
>
> Signed-off-by: Jan Stancek
> ---
> testcases/kernel/syscalls/mbind/Makefile | 3 +--
> testcases/kernel/syscalls/mbind/mbind01.c | 10 --
> 2 files changed, 9 insertions(+), 4 deletions(-)
+ if ((ret = get_allowed_nodes
On Mon, May 28, 2012 at 4:39 AM, Jan Stancek wrote:
>
> A library to share NUMA helper functions shared by
> multiple testcases.
>
> Signed-off-by: Jan Stancek
One comment...
+ tst_resm(TFAIL, "get_allowed_nodes, i >=
num_allowed_nodes: "
+ "%d >
On Sun, May 27, 2012 at 2:06 AM, Wanlong Gao wrote:
> On 05/27/2012 04:23 PM, Garrett Cooper wrote:
>
>> On Sun, May 27, 2012 at 1:14 AM, Wanlong Gao
>> wrote:
>>> On 05/27/2012 04:00 PM, Garrett Cooper wrote:
>>>
>>>> On Sun, May 27, 2012 at 12
On Sun, May 27, 2012 at 1:14 AM, Wanlong Gao wrote:
> On 05/27/2012 04:00 PM, Garrett Cooper wrote:
>
>> On Sun, May 27, 2012 at 12:33 AM, Wanlong Gao
>> wrote:
>>> On 05/26/2012 10:15 PM, Garrett Cooper wrote:
>>>
>>>> The testcase te
On Sun, May 27, 2012 at 12:33 AM, Wanlong Gao wrote:
> On 05/26/2012 10:15 PM, Garrett Cooper wrote:
>
>> The testcase tests to see whether or not locks are successfully
>> inherited across forking processes, as the requirements for fork state
>> that they should not be.
1. The threshold was too low; setting it to 10 seconds and adding an
overlap of 5 seconds ensures that the SIGALRM handler fires.
2. Add a perror call when clock_settime fails.
3. Remove spurious newlines in perror calls.
Signed-off-by: Garrett Cooper
---
.../conformance/interfaces
failure as OUTPUT goes to /dev/stdout and the test
hangs.
Signed-off-by: Garrett Cooper
diff --git a/testcases/open_posix_testsuite/conformance/interfaces/fork/11-1.c
b/testcases/open_posix_testsuite/conformance/interfaces/fork/11-1.c
index 125..632b0db 100644
--- a/testcases
On Fri, May 25, 2012 at 2:12 AM, Jan Stancek wrote:
>
> Some setups can lack memory on arbitrary nodes, use only nodes
> returned by get_mempolicy(..., MPOL_F_MEMS_ALLOWED).
>
> Signed-off-by: Jan Stancek
> ---
> .../syscalls/move_pages/move_pages_support.c | 74
>
>
In order to get LTP more up to date and expand breadth of syscall
requirements testing, I'm going to be working on adding more syscall
tests to LTP over the next couple weeks. I started out with
inotify(7), but I want to move on to newer syscalls that exercise MI
(machine independent) functiona
On May 21, 2012, at 2:01 AM, Wanlong Gao wrote:
> On 05/21/2012 04:55 PM, Garrett Cooper wrote:
>
>> On May 21, 2012, at 1:38 AM, Wanlong Gao wrote:
>>
>>> Now, kernel version up to 3.x, check for 2.6.x is useless.
>>
>> I don't agree with this state
On May 21, 2012, at 1:38 AM, Wanlong Gao wrote:
> Now, kernel version up to 3.x, check for 2.6.x is useless.
I don't agree with this statement. LTP needs to be usable on 2.6.x for at least
2 years after 3.x's inception.
> Additionally, we already checked the kernel version in the
> program itse
On May 18, 2012, at 5:59 AM, Cyril Hrubis wrote:
> Hi!
>> +/
>> + * NAME
>> + * inotify04
>> + *
>> + * DESCRIPTION
>> + * verify that IN_DELETE_SELF functions as expected
>> + *
>> + * ALGORITHM
>> + * Create
On May 3, 2012, at 5:46 AM, Cyril Hrubis wrote:
> Hi!
>
> Yeah... let me get back to you on that...
Any update on this?
>>>
>>> I'm moving from CA to WA, but I'll try to get back to you sometime mid next
>>> week once I get settled in.
>>
>>
>> That's great! I wonder
On Wed, May 16, 2012 at 10:04 PM, Peng Haitao wrote:
>
> Garrett Cooper said the following on 2012-5-17 12:39:
>>> <<>>
>>> tag=exit_quickly stime=1337251363
>>> cmdline="exit 1"
>>> contacts=""
>>> analy
On Wed, May 16, 2012 at 7:47 PM, Peng Haitao wrote:
>
> Garrett Cooper said the following on 2012-5-17 10:40:
>>> You can easily trigger this problem with the following spoofed runtest
>>> scenario:
>>>
>>> aok echo "hello"
>>>
On Wed, May 16, 2012 at 7:39 PM, Garrett Cooper wrote:
> On Wed, May 16, 2012 at 7:33 PM, Wanlong Gao
> wrote:
>> On 05/17/2012 10:31 AM, Garrett Cooper wrote:
>>
>>> On Wed, May 16, 2012 at 7:12 PM, Wanlong Gao
>>> wrote:
>>>> On 05/17/2012 09:
On Wed, May 16, 2012 at 7:33 PM, Wanlong Gao wrote:
> On 05/17/2012 10:31 AM, Garrett Cooper wrote:
>
>> On Wed, May 16, 2012 at 7:12 PM, Wanlong Gao
>> wrote:
>>> On 05/17/2012 09:59 AM, Peng Haitao wrote:
>>>
>>>> When execvp() fails,
On Wed, May 16, 2012 at 7:12 PM, Wanlong Gao wrote:
> On 05/17/2012 09:59 AM, Peng Haitao wrote:
>
>> When execvp() fails, the testcases is counted in Total Tests, but not
>> added in logfile. In fact the testcases result should be added in logfile.
>
> I prefer adding this for matching the Total
On Thu, May 3, 2012 at 6:12 AM, Cyril Hrubis wrote:
> Hi!
> Sorry I'm not aware of any tests directly for futex systcall in LTP. I
> guess that these are covered indirectly by glibc mutex and lock tests.
But it would be good to have tests that cover the individual requirements...
-Garrett
PS
On Wed, May 2, 2012 at 7:42 AM, Cyril Hrubis wrote:
> Hi!
>> We have ported LTP open source (Version: ltp-full-20110228) on Android
>> 2.2 Froyo. It will validate the reliability, robustness, and stability
>> of Android. We want to submit the same to open source community. PFA
>> patch for the sa
On Apr 28, 2012, at 12:48 AM, Zhouping Liu wrote:
> HAS_NUMA_H should be HAVE_NUMA_H, and most functions are defined
> in numa.h and numaif.h, so added the include headers into
> move_pages_support.h
>
> Signed-off-by: Zhouping Liu
Reviewed-by: Garrett Cooper http://www.acc
On Apr 10, 2012, at 7:53 PM, Wanlong Gao wrote:
> On 04/05/2012 10:10 AM, Garrett Cooper wrote:
>
>> On Wed, Apr 4, 2012 at 6:39 PM, Wanlong Gao
>> wrote:
>>> On 04/05/2012 08:42 AM, Garrett Cooper wrote:
>>>
>>>> Replace struct event_t with st
Not enough context was provided to determine why linking failed.
On Apr 2, 2012, at 2:33 AM, Rejish Rajagopala
wrote:
> Hi Maxin,
>
> I could resolve the configuration issue and I could cross compile on of the
> LTP modules (pty) for Android. Now I am trying to cross compile another
> modul
On Apr 10, 2012, at 7:52 PM, Wanlong Gao wrote:
> On 04/05/2012 09:52 AM, Mike Frysinger wrote:
>
>> On Wednesday 04 April 2012 20:38:31 Garrett Cooper wrote:
>>> +/*
>>> + * ``junk`` is needed to make the macro function like a void argument
>>&
On Wed, Apr 4, 2012 at 6:49 PM, Mike Frysinger wrote:
> On Wednesday 04 April 2012 20:33:40 Garrett Cooper wrote:
>> On Wed, 4 Apr 2012, Mike Frysinger wrote:
>> > On Wednesday 04 April 2012 15:18:53 Garrett Cooper wrote:
>> >> On Wed, Apr 4, 2012 at 10:54 AM, M
On Wed, Apr 4, 2012 at 6:39 PM, Wanlong Gao wrote:
> On 04/05/2012 08:42 AM, Garrett Cooper wrote:
>
>> Replace struct event_t with struct inotify_event
>>
>> Also do some minor whitespace cleanup while I'm
>> in the neighborhood.
>
> there's somethin
Add a functional test for the IN_DELETE_SELF event
This tests that IN_DELETE_SELF functions for both files and directories by
creating a temporary file and directory, ensuring the inotify(7) events
are relayed properly, watchpoints are removed, etc.
Signed-off-by: Garrett Cooper
On Wed, Apr 4, 2012 at 6:02 PM, Peng Haitao wrote:
> /etc/init.d/atd is nonexistent in fedora16, so should use systemctl.
>
> Signed-off-by: Peng Haitao
Reviewed-by: Garrett Cooper
--
Better than sec? N
Replace struct event_t with struct inotify_event
Also do some minor whitespace cleanup while I'm
in the neighborhood.
Signed-off-by: Garrett Cooper
---
testcases/kernel/syscalls/inotify/inotify02.c | 13 -
1 files changed, 4 insertions(+), 9 deletions(-)
--1.
Clean up inotify(7) wrappers
As a side-effect this also fixes the return code passed back
by the wrappers as the value should be an integer, not longs
[this fixes compile errors on platforms where
sizeof(int) != sizeof(long)].
Signed-off-by: Garrett Cooper
---
testcases/kernel/syscalls
The attached changes consolidate some duplicated wrapper APIs and
remove a homegrown struct for dealing with inotify events.
Garrett Cooper (2):
Clean up inotify(7) wrappers
Replace struct event_t with struct inotify_event
testcases/kernel/syscalls/inotify/inotify.h | 45
Install .awk files
The previous patch would have globbed all files that ended in ``awk``.
Signed-off-by: Garrett Cooper
---
tools/Makefile |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--1.7.2.5
Content-Type: text/x-patch; name="0001-Install-.awk-files.
On Wed, Apr 4, 2012 at 10:22 AM, Mike Frysinger wrote:
> On Wednesday 04 April 2012 01:23:43 Garrett Cooper wrote:
>> The intent behind these changes are to remove unnecessary perl
>> dependencies in LTP by using awk in its stead. It was something that was
>> discussed a
On Wed, Apr 4, 2012 at 10:20 AM, Mike Frysinger wrote:
> On Wednesday 04 April 2012 01:22:25 Garrett Cooper wrote:
>> --- a/tools/Makefile
>> +++ b/tools/Makefile
>>
>> -INSTALL_TARGETS := *.pl *.sh html_report_header.txt
>> +INSTALL_TARGE
On Tue, Apr 3, 2012 at 10:27 PM, Garrett Cooper wrote:
> Replace create_kernel_faults_in_loops_and_probability.pl with an awk
> equivalent
>
> Signed-off-by: Garrett Cooper
> ---
> runltp
Replace create_kernel_faults_in_loops_and_probability.pl with an awk equivalent
Signed-off-by: Garrett Cooper
---
runltp | 24 +++--
...eate_kernel_faults_in_loops_and_probability.awk | 40
Replace create_dmesg_entries_for_each_test.pl with an awk equivalent
Signed-off-by: Garrett Cooper
---
runltp |4 +-
tools/create_dmesg_entries_for_each_test.awk | 32 +++
tools/create_dmesg_entries_for_each_test.pl | 74
The intent behind these changes are to remove unnecessary perl
dependencies in LTP by using awk in its stead. It was something that was
discussed a while ago on ltp-list@.
Garrett Cooper (4):
Replace create_valgrind_check.pl with an awk equivalent
Install .awk files
Replace
Install .awk files
Signed-off-by: Garrett Cooper
---
tools/Makefile |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--1.7.9.4
Content-Type: text/x-patch; name="0002-Install-.awk-files.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment; file
Replace create_valgrind_check.pl with an awk equivalent
Signed-off-by: Garrett Cooper
---
runltp | 22
tools/create_valgrind_check.awk | 42
tools/create_valgrind_check.pl | 106 ---
3 files changed
On Mon, Apr 2, 2012 at 1:40 AM, Caspar Zhang wrote:
> On 04/02/2012 04:34 PM, Wanlong Gao wrote:
>> make sure we can do lib-clean in hugetlb.
>>
>> Signed-off-by: Wanlong Gao
>
> Acked-by: Caspar Zhang
if systemctl is-enabled $crond.service >/dev/null
> 2>&1; then
> + systemctl restart $crond.service
> + break
> + fi
> +
On Thu, Mar 29, 2012 at 2:58 AM, Peng Haitao wrote:
> /etc/init.d/crond is nonexistent in fedora16, so should be replaced with
> systemctl.
>
> Signed-off-by: Peng Haitao
> ---
> testcases/commands/cron/cron02 | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/testcases/c
On Mar 16, 2012, at 12:27 AM, Caspar Zhang wrote:
> Hi all, I'll merge this change to master if I don't hear any objections
> from you by today.
>
>
> On 03/09/2012 08:25 AM, Wanlong Gao wrote:
>> On 03/09/2012 12:50 AM, Caspar Zhang wrote:
>>
>>> Hi Garrett, Andi, and all:
>>>
>>> When I loo
On Mar 16, 2012, at 1:04 AM, Wanlong Gao wrote:
> On 03/16/2012 03:58 PM, Peng Haitao wrote:
>
>> There are 2 changes in this patch.
>> 1. Initialize the aiocb struct before using it.
>> 2. If Prioritized Input and Output option is supported, submit the
>>aiocb with invalid aio_reqprio, else
On Mar 8, 2012, at 9:28 PM, Caspar Zhang wrote:
>
> in negative case:
>
>QUICK_TEST(sched_getaffinity(getpid()+1, len, mask));
>
> sometimes getpid()+1 will exist if there're other processes running.
> This patch uses a different way to make sure the required pid doesn't
> exist by forking
."
> + Done executing testcases.
> LTP Version: $version_date
> - ###"
> + ###########
>
> EOF
> }
Reviewed-by: Garre
On Feb 20, 2012, at 7:58 AM, Samuja wrote:
> Hi,
>
> i am new on this,
> is there a book about linux test project ?
>
> i am trying to manage it, but HOWTO is a bit to old,
> and there is no good book on amazon...
>
> or is there some other good systemtest automated tool for linux?
Ltp is a
On Mon, Jan 9, 2012 at 9:19 AM, Mike Frysinger wrote:
> On Monday 09 January 2012 06:08:48 Markos Chandras wrote:
>> Right now the use of UCLINUX implies the use of __UCLIBC__ as well. Even
>> though this is true from UCLINUX's perspective, it is not valid from the
>> uclibc's one. A non-uclinux s
On Mon, Jan 9, 2012 at 9:23 AM, Mike Frysinger wrote:
> On Monday 09 January 2012 12:11:50 Garrett Cooper wrote:
>> On Mon, Jan 9, 2012 at 2:51 AM, Eryu Guan wrote:
>> > On Mon, Jan 09, 2012 at 05:44:35PM +0800, Caspar Zhang wrote:
>> >> if doesn't exis
On Mon, Jan 9, 2012 at 2:51 AM, Eryu Guan wrote:
> On Mon, Jan 09, 2012 at 05:44:35PM +0800, Caspar Zhang wrote:
>>
>> if doesn't exist, compliation will fail. Fix it in
>> autotools level.
>
> Tested on system without xattr.h and everything worked fine.
>
> Thanks for fixing this!
>
> Eryu Guan
On Mon, Jan 9, 2012 at 1:54 AM, Markos Chandras
wrote:
> On 01/09/2012 09:44 AM, Caspar Zhang wrote:
>>
>> if doesn't exist, compliation will fail. Fix it in
>> autotools level.
>>
>> Signed-off-by: Caspar Zhang
>> ---
>> configure.ac | 1 +
>> testcases/k
On Jan 8, 2012, at 6:58 PM, Peng Haitao wrote:
>
> ChangeLog is deleted, so ChangeLog should be replaced with VERSION.
>
> Signed-off-by: Peng Haitao
Good catch -- cheers!
Reviewed-by: Ga
On Wed, Jan 4, 2012 at 7:13 AM, Cyril Hrubis wrote:
> Hi!
>> > > since this patch is against the open_posix_testsuite, we need to stick to
>> > > POSIX APIs (although, the forking of open_posix_testsuite in ltp is
>> > > pretty awful in general). if it were against a different tree, then not
>> >
On Wed, Jan 4, 2012 at 5:46 AM, Cyril Hrubis wrote:
> Hi!
>> the tst_brk() API has gotten annoying. it is designed to not return to the
>> original caller which is why it had the "noreturn" attribute. but Garret re-
>> rewrote it to be re-entrant presumably so the cleanup() func could itself
>>
On Wed, Jan 4, 2012 at 3:20 AM, Markos Chandras
wrote:
> On 01/03/2012 07:24 PM, Garrett Cooper wrote:
>>
>> On Tue, Jan 3, 2012 at 3:08 AM, Markos Chandras
>> wrote:
>>>
>>> Hi, please review the attached patch
>>
>>
>> No -- this brea
On Tue, Jan 3, 2012 at 3:34 PM, Mike Frysinger wrote:
> On Tuesday 03 January 2012 17:19:25 Garrett Cooper wrote:
>> The 'solution' for the issues with
>> format strings and long integers is generally cast to [u]intmax_t,
>> then use %zd or %zu.
>
> eek,
On Tue, Jan 3, 2012 at 12:29 PM, Mike Frysinger wrote:
> On Tuesday 03 January 2012 04:41:10 Markos Chandras wrote:
>> Hi, please review the attached patch
>
> using %zu for size_t is good
+1.
Thanks,
-Garrett
--
Write o
On Tue, Jan 3, 2012 at 12:57 PM, Mike Frysinger wrote:
> On Tuesday 03 January 2012 15:51:52 Garrett Cooper wrote:
>> On Tue, Jan 3, 2012 at 12:37 PM, Mike Frysinger wrote:
>> > On Tuesday 03 January 2012 05:42:55 Markos Chandras wrote:
>> >> Hi, pl
On Tue, Jan 3, 2012 at 12:28 PM, Mike Frysinger wrote:
> please use `git send-email` to properly post patches. attaching them like
> this makes it a pita to review.
+1. Or just use what's noted in the style guide as well for submitting
patches if you really want to go down this path of creating
On Tue, Jan 3, 2012 at 12:37 PM, Mike Frysinger wrote:
> On Tuesday 03 January 2012 05:42:55 Markos Chandras wrote:
>> Hi, please review the attached patch
>
> casting to a (long) would be better
Or uintmax_t...
-Garrett
---
On Tue, Jan 3, 2012 at 12:21 PM, Mike Frysinger wrote:
> On Tuesday 03 January 2012 06:18:56 Markos Chandras wrote:
>> Hi, please review the attached patch
>
> the test.h header should be after all system includes. moving it before them
> is not a good idea. so NAK this patch.
Good point. Resci
On Tue, Jan 3, 2012 at 3:22 AM, Markos Chandras
wrote:
> Hi, please review the attached patch
I'm going to think about this proposed change for a while because
it might break certain scenarios. Please test this change and other
build changes via the testscripts/build/test_* scripts before sen
On Tue, Jan 3, 2012 at 3:18 AM, Markos Chandras
wrote:
> Hi, please review the attached patch
Reviewed-by: Garrett Cooper
--
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app developm
On Tue, Jan 3, 2012 at 3:12 AM, Markos Chandras
wrote:
> Hi, please review the attached patch
Reviewed-by: Garrett Cooper
--
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app developm
On Tue, Jan 3, 2012 at 5:22 AM, Markos Chandras
wrote:
> Hi, please review the attached patch
"%p" is better.
Thanks,
-Garrett
--
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app develop
On Tue, Jan 3, 2012 at 3:10 AM, Markos Chandras
wrote:
> Hi, please review the attached patch
Reviewed-by: Garrett Cooper
--
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app developm
On Tue, Jan 3, 2012 at 2:44 AM, Markos Chandras
wrote:
> Hi, please review the attached patch
Reviewed-by: Garrett Cooper
--
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app developm
On Tue, Jan 3, 2012 at 3:04 AM, Markos Chandras
wrote:
> Hi, please review the attached patch
Reviewed-by: Garrett Cooper
--
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app developm
On Tue, Jan 3, 2012 at 2:42 AM, Markos Chandras
wrote:
> Hi, please review the attached patch
Too bad it is a longtype, unlike BSD. Maybe you want to make this
into a zu format string qualifier instead?
Thanks!
-Garrett
ons.
Thanks,
-Garrett
Reviewed-by: Garrett Cooper
--
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create
new or port existing apps to sell to consumers worldwide. Explore
On Tue, Jan 3, 2012 at 5:24 AM, Markos Chandras
wrote:
> Hi, please review the attached patch
Reviewed-by: Garrett Cooper
--
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app developm
On Tue, Jan 3, 2012 at 5:25 AM, Markos Chandras
wrote:
> Hi, please review the attached patch
It would be better if it was strtoll, but this works for now.
Thanks!
-Garrett
Reviewed-by: Garrett Cooper
--
Wr
On Tue, Jan 3, 2012 at 3:02 AM, Markos Chandras
wrote:
> Hi, please review the attached patch. It is a trivial fix for slightly old
> GCC versions.
It would be better to set it below the declarations. Although this
isn't part of check_patch.pl, it's a BSD style(9)'ism that makes
things a lot
On Tue, Jan 3, 2012 at 5:26 AM, Markos Chandras
wrote:
> Hi, please review the attached patch
You could always just do it like:
execl(..., { 0 }, ...);
Thanks,
-Garrett
--
Write once. Port to many.
Get the SDK and tool
On Tue, Jan 3, 2012 at 3:08 AM, Markos Chandras
wrote:
> Hi, please review the attached patch
No -- this breaks out-of-tree compiles.
-Garrett
--
Write once. Port to many.
Get the SDK and tools to simplify cross-platform
On Tue, Jan 3, 2012 at 2:40 AM, Markos Chandras
wrote:
> On 01/03/2012 09:57 AM, Markos Chandras wrote:
>>
>> On 01/03/2012 09:50 AM, Garrett Cooper wrote:
>>>
>>> On Tue, Jan 3, 2012 at 1:35 AM, Markos Chandras
>>> wrote:
>
On Tue, Jan 3, 2012 at 1:35 AM, Markos Chandras
wrote:
> Hi, please review the attached patch
Converting the function to tst_brkm and removing the tst_exit call
below it would be better.
Thanks!
-Garrett
--
Write onc
On Dec 22, 2011, at 2:11 AM, Cyril Hrubis wrote:
> Hi!
testcase create NCPU=4 threads running with a high priority with the same
sched
policy and one with a low-priority. The low-priority thread should not run
until the other threads stop running, unless the machine has more t
1 - 100 of 1543 matches
Mail list logo
