Re: [LTP] [PATCH] fs/ext4-new-features: Fix

2014-07-22 Thread Xiaoguang Wang
Hi, On 07/23/2014 09:34 AM, Zeng Linggang wrote: > $? is not the expected value. > Add test_ret to store the expected value of $?, fix it. > > TMPDIR=mnt_point; fallocate0${i} | grep -q "CONF" > + test_ret=$? > TMPDIR=$temp_tmpdir > > -

Re: [LTP] [PATCH] fs/ext4-new-features: fix wrong test point when running ext4-persist-prealloc

2014-06-24 Thread Xiaoguang Wang
Hi, On 06/24/2014 12:18 AM, chru...@suse.cz wrote: > Hi! ret=1 + temp_tmpdir=$TMPDIR + export TMPDIR=mnt_point for ((i = 1; i <= 3; i++)) { if ! command -v fallocate0${i} > /dev/null 2>&1; then @@ -63,6 +65,7 @@ ext4_test_persist_prea

Re: [LTP] [PATCH] fs/ext4-new-features: fix wrong test point when running ext4-persist-prealloc

2014-06-23 Thread chrubis
Hi! > >>ret=1 > >> > >> + temp_tmpdir=$TMPDIR > >> + export TMPDIR=mnt_point > >>for ((i = 1; i <= 3; i++)) > >>{ > >>if ! command -v fallocate0${i} > /dev/null 2>&1; then > >> @@ -63,6 +65,7 @@ ext4_test_persist_prealloc() > >>return > >>

Re: [LTP] [PATCH] fs/ext4-new-features: fix wrong test point when running ext4-persist-prealloc

2014-06-17 Thread Xiaoguang Wang
Hi, On 06/17/2014 09:03 PM, chru...@suse.cz wrote: > >> ret=1 >> >> +temp_tmpdir=$TMPDIR >> +export TMPDIR=mnt_point >> for ((i = 1; i <= 3; i++)) >> { >> if ! command -v fallocate0${i} > /dev/null 2>&1; then >> @@ -63,6 +65,7 @@ ext4_test_persist_prealloc()

Re: [LTP] [PATCH] fs/ext4-new-features: fix wrong test point when running ext4-persist-prealloc

2014-06-17 Thread chrubis
Hi! > ext4-persist-prealloc test will call test cases under > 'testcases/kernel/syscalls > /fallocate' to have persist prealloc test for ext4 filesystem. But currently > fallocate[0-3] cases will have tests in a different filesystem, which the > directory > created by tst_tmpdir() is in. This is