Re: [LTP] [RFC][PATCH] partrt_nohz_full: Introducing a new test case

2014-04-24 Thread Mats Liljegren
On Tue, 22 Apr 2014 17:47:11 +0200 wrote: > > +/* > > + * Wait for a command with given pid to finish, and assert that > > the command > > + * returned success (0). > > + */ > > +static void > > +pid_wait(pid_t pid) > > +{ > > + int status; > > + char prefix[64]; > > + > > + snprintf(prefix

Re: [LTP] [RFC][PATCH] partrt_nohz_full: Introducing a new test case

2014-04-24 Thread chrubis
Hi! > > > +/* > > > + * Wait for a command with given pid to finish, and assert that > > > the command > > > + * returned success (0). > > > + */ > > > +static void > > > +pid_wait(pid_t pid) > > > +{ > > > + int status; > > > + char prefix[64]; > > > + > > > + snprintf(prefix, sizeof (prefix), "Pi

[LTP] [PATCH] MAINTAINERS: update maintainership of LTP

2014-04-24 Thread Cyril Hrubis
This patch updates Linux kernel MAINTAINERS file to reflect current state. Add your signed-of-by if you are OK with the changes. If nobody objects I will send it to kernel devs next week. Signed-off-by: Cyril Hrubis Signed-off-by: Caspar Zhang --- MAINTAINERS | 8 1 file changed, 4

Re: [LTP] [PATCH] MAINTAINERS: update maintainership of LTP

2014-04-24 Thread Wanlong Gao
On 04/24/2014 05:36 PM, Cyril Hrubis wrote: > This patch updates Linux kernel MAINTAINERS file to reflect current > state. > > Add your signed-of-by if you are OK with the changes. > > If nobody objects I will send it to kernel devs next week. > > Signed-off-by: Cyril Hrubis > Signed-off-by: Ca

Re: [LTP] [PATCH] MAINTAINERS: update maintainership of LTP

2014-04-24 Thread Jan Stancek
- Original Message - > From: "Cyril Hrubis" > To: ltp-list@lists.sourceforge.net > Sent: Thursday, 24 April, 2014 11:36:38 AM > Subject: [LTP] [PATCH] MAINTAINERS: update maintainership of LTP > > This patch updates Linux kernel MAINTAINERS file to reflect current > state. > > Add your

[LTP] [PATCH] syscalls/fstatfs:using temporary file description to test the system call

2014-04-24 Thread shuang . qiu
From: Shuang Qiu It does not make sense to use stdout as the file description to test the system call fstatfs().We may get unexpected result(i.e. erron38:Function not implemented) if redirect stdout when running ltp. Using ltp temporary file instead. Signed-off-by: Shuang Qiu --- testcases/ker

[LTP] [PATCH 1/3] safe_macros: Add SAFE_GETRESUID and SAFE_GETRESGID

2014-04-24 Thread Zeng Linggang
Signed-off-by: Zeng Linggang --- include/safe_macros.h | 10 ++ lib/safe_macros.c | 32 2 files changed, 42 insertions(+) diff --git a/include/safe_macros.h b/include/safe_macros.h index 25846f4..e9fc485 100644 --- a/include/safe_macros.h +++ b/includ

[LTP] [PATCH 2/3] setegid/setegid01.c: cleanup

2014-04-24 Thread Zeng Linggang
* Delete some useless commtents. * Move the test body from main() to setegid_verify(). * Remove verbose, options global variables and help funtion. * Use safe macros. * Some cleanup. Signed-off-by: Zeng Linggang --- testcases/kernel/syscalls/setegid/setegid01.c | 137 +---

[LTP] [PATCH 3/3] setegid/setegid02.c: add EPERM errno test

2014-04-24 Thread Zeng Linggang
Add EPERM errno test for setegid(2). Signed-off-by: Zeng Linggang --- runtest/ltplite | 1 + runtest/stress.part3 | 1 + runtest/syscalls | 1 + testcases/kernel/syscalls/.gitignore | 1 + testcases/

Re: [LTP] [PATCH V2 08/14] rpc-tirpc: implemented a wrapper

2014-04-24 Thread Stanislav Kholmanskikh
On 23.04.2014 20:11, chru...@suse.cz wrote: > Hi! Hi! >> +RHOST=${RHOST:-`hostname`} > > So the test defaults to local machine if RHOST is not set, but still > needs rsh installed to run the testcases. > > Can we do it without the need for rsh in this case? Yes, we can. I'll fix it. > >> +SERV

Re: [LTP] [PATCH V2] numa01.sh: numademo fixes

2014-04-24 Thread Stanislav Kholmanskikh
On 23.04.2014 19:29, chru...@suse.cz wrote: > Hi! >> 1) numademo does not accept a 'msize' argument. I think it was an initial >> typo mistake that numanode was invoked as >>numanode -c msize >> instead of >>numanode -c ${msize}k >> >> 2) I think test07 should return TPASS if $x is 0 (not

Re: [LTP] [RFC][PATCH] partrt_nohz_full: Introducing a new test case

2014-04-24 Thread Mats Liljegren
On Thu, 24 Apr 2014 11:06:05 +0200 wrote: > > I couldn't find that function in include directory. Did I search in > > the wrong place? > > Ah, you are right, that one is missing, sorry. > > I will add it. Ok. > > That would loose a lot of information useful for figuring out what > > the error

Re: [LTP] [RFC][PATCH] partrt_nohz_full: Introducing a new test case

2014-04-24 Thread chrubis
Hi! > > > I couldn't find that function in include directory. Did I search in > > > the wrong place? > > > > Ah, you are right, that one is missing, sorry. > > > > I will add it. > > Ok. I've pushed the changes. -- Cyril Hrubis chru...@suse.cz

Re: [LTP] [PATCH 1/3] safe_macros: Add SAFE_GETRESUID and SAFE_GETRESGID

2014-04-24 Thread chrubis
Hi! > +int safe_getresuid(const char *file, const int lineno, void > (*cleanup_fn)(void), > +uid_t *ruid, uid_t *euid, uid_t *suid) > +{ > + int rval; > + > + rval = getresuid(ruid, euid, suid); > + if (rval == -1) { > + tst_brkm(TBROK | TERRNO, cleanup_fn,

Re: [LTP] [PATCH] MAINTAINERS: update maintainership of LTP

2014-04-24 Thread Alexey Kodanev
On 24.04.2014 13:36, Cyril Hrubis wrote: > This patch updates Linux kernel MAINTAINERS file to reflect current > state. > > Add your signed-of-by if you are OK with the changes. > > If nobody objects I will send it to kernel devs next week. > > Signed-off-by: Cyril Hrubis > Signed-off-by: Caspar Z

Re: [LTP] [PATCH] ip_tests.sh: don't use hardcoded eth0

2014-04-24 Thread Simon Xu
Could anyone help to review this? Thanks Simon On 2014/3/28 9:44, Simon Xu wrote: > The script uses hardcoded 'eth0' which used to work on most systems. > This fix tries to find a 'working' network interface using the hostname. > > Signed-off-by: Simon Xu > --- > testcases/network/iproute/ip_t

Re: [LTP] [PATCH 1/3] safe_macros: Add SAFE_GETRESUID and SAFE_GETRESGID

2014-04-24 Thread Zeng Linggang
On Thu, 2014-04-24 at 16:06 +0200, chru...@suse.cz wrote: > Hi! > > +int safe_getresuid(const char *file, const int lineno, void > > (*cleanup_fn)(void), > > + uid_t *ruid, uid_t *euid, uid_t *suid) > > +{ > > + int rval; > > + > > + rval = getresuid(ruid, euid, suid); > > + if

[LTP] [PATCH v3 1/2] lib/tst_fs_has_free.c: add tst_fs_has_free() to determine filesystem's free space

2014-04-24 Thread Xiaoguang Wang
The existing lib/tst_cwd_has_free.c only determines the filesystem, which the current directory is in. And I think tst_cwd_has_free() is not entirely correct. See this code in tst_cwd_has_free(): return ((float)sf.f_bfree) / (1024 / sf.f_bsize) >= required_kib ? 1 : 0; if s

[LTP] [PATCH v3 2/2] tools/apicmd: add tst_fs_has_free

2014-04-24 Thread Xiaoguang Wang
Signed-off-by: Xiaoguang Wang --- tools/apicmds/.gitignore | 1 + tools/apicmds/Makefile| 2 +- tools/apicmds/ltpapicmd.c | 31 +++ 3 files changed, 33 insertions(+), 1 deletion(-) diff --git a/tools/apicmds/.gitignore b/tools/apicmds/.gitignore index 0c1a896..

[LTP] [PATCH v2 1/3] safe_macros: Add SAFE_GETRESUID and SAFE_GETRESGID

2014-04-24 Thread Zeng Linggang
Signed-off-by: Zeng Linggang --- include/safe_macros.h | 10 ++ lib/safe_macros.c | 30 ++ 2 files changed, 40 insertions(+) diff --git a/include/safe_macros.h b/include/safe_macros.h index 25846f4..e9fc485 100644 --- a/include/safe_macros.h +++ b/include/

[LTP] [PATCH v2 2/3] setegid/setegid01.c: cleanup

2014-04-24 Thread Zeng Linggang
* Delete some useless commtents. * Add setup() and cleanup(). * Move the test body from main() to setegid_verify(). * Remove verbose, options global variables and help() function. * Use safe macros. * Some cleanup. Signed-off-by: Zeng Linggang --- testcases/kernel/syscalls/setegid/setegid01

[LTP] [PATCH v2 3/3] setegid/setegid02.c: add EPERM errno test

2014-04-24 Thread Zeng Linggang
Add EPERM errno test for setegid(2). Signed-off-by: Zeng Linggang --- runtest/ltplite | 1 + runtest/stress.part3 | 1 + runtest/syscalls | 1 + testcases/kernel/syscalls/.gitignore | 1 + testcases/