Re: [LTP] [PATCH 2/3] tbio: fixes

2015-01-13 Thread Stanislav Kholmanskikh
Hi! On 01/06/2015 01:18 PM, Cyril Hrubis wrote: > Hi! >> +/* >> + * Wait until udev creates the device node. >> + * If the node is not created, we will create it manually, >> + * see below. >> + */ >> +sleep(5); > > As usually I do not like adding long sleep() into testcase

Re: [LTP] [PATCH] recvmsg01: fix select() nfds for UNIX socket

2015-01-13 Thread Cyril Hrubis
Hi! > commit 7855d094bbeb9b8ce43dd698ec82e400eb91e709 did this > for accept() on INET socket, but missed UNIX one. Good catch, acked. Please push this ASAP. -- Cyril Hrubis chru...@suse.cz -- New Year. New Location. Ne

Re: [LTP] [PATCH] skip MSG_ERRQUEUE+tcp test on kernels < 3.17

2015-01-13 Thread Jan Stancek
- Original Message - > From: "Cyril Hrubis" > To: "Jan Stancek" > Cc: ltp-list@lists.sourceforge.net > Sent: Tuesday, 13 January, 2015 10:30:24 AM > Subject: Re: [LTP] [PATCH] skip MSG_ERRQUEUE+tcp test on kernels < 3.17 > > Hi! > > + if ((tst_kvercmp(3, 17, 0) < 0)

Re: [LTP] LTP release

2015-01-13 Thread Cyril Hrubis
Hi! > > I'm back at work as promised and so we should start with the release > > preparations. Let's start with the list of patches that should go in > > before we start pre-release testing. I've looked around and good > > candidates for what should be merged are: > > > > 1. timeouts for nets tests

Re: [LTP] [PATCH v4] ltp-networking/tcp_cmds/finger: fix finger bad user and host test

2015-01-13 Thread Cyril Hrubis
Hi! > Finger always return 0 with bad user and host test. And it also return > different error message on different distros. So let's only check stderr > message and decide whether the test pass or fail. Okay, so the test passes if anything was written into stderr. Sounds good to me. > Signed-off

[LTP] [PATCH V2 2/2] tbio: fixes

2015-01-13 Thread Stanislav Kholmanskikh
* Wait until udev creates /dev/tbio. If udev can not create the node file in a defined timeout, create it manually. * Clean /dev/tbio after test execution, if /dev/tbio was created manually. Signed-off-by: Stanislav Kholmanskikh --- Changes since V1: * implemented a more active waiting * f

Re: [LTP] [PATCH v4] ltp-networking/tcp_cmds/finger: fix finger bad user and host test

2015-01-13 Thread Alexey Kodanev
Hi! On 01/13/2015 01:24 PM, Cyril Hrubis wrote: > Hi! >> Finger always return 0 with bad user and host test. And it also return >> different error message on different distros. So let's only check stderr >> message and decide whether the test pass or fail. > Okay, so the test passes if anything was

Re: [LTP] HWaddress for infiniband.

2015-01-13 Thread Alexey Kodanev
Hi! On 12/19/2014 02:30 AM, C Nandi wrote: > Hi, > > > Will LTP supports infiniband hardware address and its length? > > ib1 Link encap:UNSPEC HWaddr > 80-00-00-49-FE-80-00-00-00-00-00-00-00-00-00-00 > inet addr:192.168.9.85 Bcast:192.168.9.255 Mask:255.255.255.0 > inet6 addr: 2001:1890:1