Re: [lttng-dev] [PATCH lttng-tools] Fix: mi test: possible race between listing UST events and testapp start

2014-10-27 Thread Nathan Lynch
On 10/26/2014 08:21 PM, Jonathan Rajotte wrote: Signed-off-by: Jonathan Rajotte jonathan.r.jul...@gmail.com More description of the change is needed IMO. --- tests/regression/tools/mi/test_mi | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/regression/tools/mi/test_mi

[lttng-dev] [PATCH lttng-tools 01/24] Fix : wait.h should be sys/wait.h according to posix and android doesn't redirect wait.h to sys/wait.h

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Signed-off-by: Charles Briere c.bri...@samsung.com --- src/common/daemonize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/daemonize.c b/src/common/daemonize.c index a8e2906..5d8f10f 100644 --- a/src/common/daemonize.c

[lttng-dev] Fixes for Android

2014-10-27 Thread Charles Briere
The following patch set allows compilation of lttng-tools for Android. This have been tested with AOSP and may not work if compiling with Android's NDK toolchain. The patch concerning the shm compatibility layer is there in preparation for patches around lttng-ust which will follow soon.

[lttng-dev] [PATCH lttng-tools 05/24] Fix : Do not use gLibc specific macros

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Signed-off-by: Charles Briere c.bri...@samsung.com --- src/common/compat/poll.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/common/compat/poll.h b/src/common/compat/poll.h index f892c83..64ff618 100644 ---

[lttng-dev] [PATCH lttng-tools 06/24] Fix : Do not redeclare gettid if found

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Signed-off-by: Charles Briere c.bri...@samsung.com --- configure.ac| 2 ++ src/common/compat/tid.h | 11 +++ 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 8703284..3460f98 100644 ---

[lttng-dev] [PATCH lttng-tools 18/24] Add : Compatibility layer for shm.h

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Linking libcutils for Android that uses ashmem Signed-off-by: Charles Briere c.bri...@samsung.com --- configure.ac | 14 ++ src/bin/lttng-sessiond/shm.c | 5 +++-- src/common/compat/shm.h | 37

[lttng-dev] [PATCH lttng-tools 03/24] Fix : Wrap variable with URCU_TLS for sizeof

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Signed-off-by: Charles Briere c.bri...@samsung.com --- src/common/error.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/error.c b/src/common/error.c index 55d56e6..577070e 100644 --- a/src/common/error.c +++

[lttng-dev] [PATCH lttng-tools 07/24] Fix : need to include config.h if using it's definitions

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Signed-off-by: Charles Briere c.bri...@samsung.com --- src/common/compat/tid.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/common/compat/tid.h b/src/common/compat/tid.h index b420914..7645b90 100644 ---

[lttng-dev] [PATCH lttng-tools 08/24] Fix : Don't compile ust functions when not enabled

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Signed-off-by: Charles Briere c.bri...@samsung.com --- src/bin/lttng-sessiond/shm.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/bin/lttng-sessiond/shm.c b/src/bin/lttng-sessiond/shm.c index a5caa8b..fa3867c 100644 ---

[lttng-dev] [PATCH lttng-tools 02/24] Fix : Include sys/stat.h where needed

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Some definitions from sys/stat.h are used but not included Signed-off-by: Charles Briere c.bri...@samsung.com --- src/bin/lttng-sessiond/save.c | 1 + src/bin/lttng-sessiond/ust-consumer.c | 1 + 2 files changed, 2 insertions(+) diff --git

[lttng-dev] [PATCH lttng-tools 09/24] Add : Compatibility layer for syscall.h

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Signed-off-by: Charles Briere c.bri...@samsung.com --- configure.ac| 6 -- src/common/compat/syscall.h | 36 src/common/compat/tid.h | 1 + src/common/futex.c | 2 +- 4 files

[lttng-dev] [PATCH lttng-tools 21/24] Android : Adding bswap defintions

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Mapping of bswap functions based on what's available on Android's NDK Signed-off-by: Charles Briere c.bri...@samsung.com --- configure.ac | 2 ++ src/common/compat/endian.h | 11 ++- 2 files changed, 12 insertions(+), 1

[lttng-dev] [PATCH lttng-tools 10/24] Add : Compatibility layer for netinet/in.h

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Add definition for in_port_t Signed-off-by: Charles Briere c.bri...@samsung.com --- configure.ac | 2 ++ src/common/compat/Makefile.am | 3 ++- src/common/compat/netinet/in.h | 35 +++

[lttng-dev] [PATCH lttng-tools 12/24] Add : Compatibility layer for ulimit.h

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Signed-off-by: Charles Briere c.bri...@samsung.com --- configure.ac | 1 + src/bin/lttng-consumerd/health-consumerd.c | 2 +- src/bin/lttng-consumerd/lttng-consumerd.c | 2 +- src/bin/lttng-relayd/health-relayd.c |

[lttng-dev] [PATCH lttng-tools 14/24] Add : Compatibility layer for signal.h

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Provide an implementation of sigwaitinfo() if nonexistant Signed-off-by: Charles Briere c.bri...@samsung.com --- configure.ac | 2 ++ extras/core-handler/crash.c | 2 +-

[lttng-dev] [PATCH lttng-tools 13/24] Add : Compatibility layer for un.h

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Signed-off-by: Charles Briere c.bri...@samsung.com --- src/common/compat/un.h | 37 + 1 file changed, 37 insertions(+) create mode 100644 src/common/compat/un.h diff --git a/src/common/compat/un.h

[lttng-dev] [PATCH lttng-tools 22/24] Android : Missing defintion in fcntl.h

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Add includes for the missing declarations Signed-off-by: Charles Briere c.bri...@samsung.com --- src/common/compat/fcntl.h | 8 1 file changed, 8 insertions(+) diff --git a/src/common/compat/fcntl.h b/src/common/compat/fcntl.h index

[lttng-dev] [PATCH lttng-tools 24/24] Android : Add splice compatibility to fcntl layer

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Define splice() as __NR_splice() when not available directly (happens with BIONIC) Define SPLICE_*_* values Signed-off-by: Charles Briere c.bri...@samsung.com --- configure.ac | 2 +- src/common/compat/fcntl.h | 26

[lttng-dev] [PATCH lttng-tools 16/24] Add : Compatibility layer for pwd.h

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com getpwuid_r() is not implemented in BIONIC ( Android's ) libc As it is only used to get home directtory, only implemented that part. Signed-off-by: Charles Briere c.bri...@samsung.com --- configure.ac | 1 +

[lttng-dev] [PATCH lttng-tools 11/24] Add : Compatibility layer for limit.h

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Define the following values if not already defined : * HOST_NAME_MAX to 64 * NAME_MAX to 255 * PATH_MAX to 4096 Signed-off-by: Charles Briere c.bri...@samsung.com --- include/lttng/constant.h | 2 +-

[lttng-dev] [PATCH lttng-tools 19/24] Android : Looking for pthread in libc

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Pthread in included in BIONIC libc Signed-off-by: Charles Briere c.bri...@samsung.com --- configure.ac | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 16852b1..45c6b30 100644 --- a/configure.ac

[lttng-dev] [PATCH lttng-tools 15/24] Add : Compatibility layer for stat.h

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com This is required when building from Android NDK, but not necessary when building from AOSP tree. Signed-off-by: Charles Briere c.bri...@samsung.com --- src/bin/lttng-consumerd/health-consumerd.c | 2 +- src/bin/lttng-consumerd/lttng-consumerd.c

[lttng-dev] [PATCH lttng-tools 20/24] Android : %m[^] not supported in fscanf

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Replacing %m[^] and char* by %[^] and char[LTTNG_SYMBOL_NAME_LEN] Signed-off-by: Charles Briere c.bri...@samsung.com --- src/bin/lttng-sessiond/kernel.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[lttng-dev] [PATCH lttng-tools 23/24] Android : Define posix_fadvise

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com Mapping from __NR_arm_fadvise64_64 to posix_fadvise is not done within BIONIC Signed-off-by: Charles Briere c.bri...@samsung.com --- configure.ac | 1 + src/common/compat/fcntl.h | 6 ++ 2 files changed, 7 insertions(+) diff --git

[lttng-dev] [PATCH lttng-tools 17/24] Add : Compatibility layer for pthread

2014-10-27 Thread Charles Briere
From: Charles Briere c.bri...@samsung.com pthread_cond_timedwait: As pthread_cond_timedwait is only used with MONOTONIC and that Android provides pthread_cond_timedwait_monotonic_np, use that one in the compatibility layer for now. pthread_cancel: pthread_kill

Re: [lttng-dev] Fixes for Android

2014-10-27 Thread Karim Yaghmour
On 14-10-27 04:49 PM, Charles Briere wrote: The following patch set allows compilation of lttng-tools for Android. This have been tested with AOSP and may not work if compiling with Android's NDK toolchain. The patch concerning the shm compatibility layer is there in preparation for

Re: [lttng-dev] [PATCH lttng-tools] Fix: mi test: possible race between listing UST events and testapp start

2014-10-27 Thread Jonathan Rajotte
Hey On Mon, Oct 27, 2014 at 4:48 PM, Nathan Lynch nathan_ly...@mentor.com wrote: On 10/26/2014 08:21 PM, Jonathan Rajotte wrote: Signed-off-by: Jonathan Rajotte jonathan.r.jul...@gmail.com More description of the change is needed IMO. --- tests/regression/tools/mi/test_mi | 5 +

[lttng-dev] [PATCH] lttng-tools: remove bogus argument from prove invocation

2014-10-27 Thread Nathan Lynch
An argument of $2 was added to the prove command line in tests/run.sh by 68270f0f604e Mi test: Basic test structure. This is harmless since run.sh is never called with more than one argument, but it is confusing, and it breaks patches in OE that add support for running tests on the target.

Re: [lttng-dev] [PATCH] lttng-tools: remove bogus argument from prove invocation

2014-10-27 Thread Jonathan Rajotte
Hey On Mon, Oct 27, 2014 at 10:00 PM, Nathan Lynch nathan_ly...@mentor.com wrote: An argument of $2 was added to the prove command line in tests/run.sh by 68270f0f604e Mi test: Basic test structure. This is harmless since run.sh is never called with more than one argument, but The multiple

Re: [lttng-dev] Progress on system crash traces with LTTng using DAX and pmem

2014-10-27 Thread Matthew Wilcox
On Sat, Oct 25, 2014 at 12:51:25PM +, Mathieu Desnoyers wrote: A quick follow up on my progress on using DAX and pmem with LTTng. I've been able to successfully gather a user-space trace into buffers mmap'd into an ext4 filesystem within a pmem block device mounted with -o dax to bypass

Re: [lttng-dev] [PATCH] lttng-tools: remove bogus argument from prove invocation

2014-10-27 Thread Nathan Lynch
On 10/27/2014 09:38 PM, Jonathan Rajotte wrote: Hey On Mon, Oct 27, 2014 at 10:00 PM, Nathan Lynch nathan_ly...@mentor.com mailto:nathan_ly...@mentor.com wrote: An argument of $2 was added to the prove command line in tests/run.sh by 68270f0f604e Mi test: Basic test structure.

Re: [lttng-dev] [PATCH] lttng-tools: remove bogus argument from prove invocation

2014-10-27 Thread Jonathan Rajotte
On Tue, Oct 28, 2014 at 12:02 AM, Nathan Lynch nathan_ly...@mentor.com wrote: On 10/27/2014 09:38 PM, Jonathan Rajotte wrote: Hey On Mon, Oct 27, 2014 at 10:00 PM, Nathan Lynch nathan_ly...@mentor.com mailto:nathan_ly...@mentor.com wrote: An argument of $2 was added to the prove