Re: [lttng-dev] Question about lock in synchronize_rcu implementation of URCU

2016-04-28 Thread Mathieu Desnoyers
- On Apr 28, 2016, at 9:47 AM, Yuxin Ren r...@gwmail.gwu.edu wrote: > Hi Boqun and Paul, > > Thank you so much for your help. > > I found one reason to use that lock. > In the slow path, a thread will move all waiters to a local queue. >

Re: [lttng-dev] Question about lock in synchronize_rcu implementation of URCU

2016-04-28 Thread Paul E. McKenney
On Thu, Apr 28, 2016 at 02:38:40PM +, Mathieu Desnoyers wrote: > - On Apr 28, 2016, at 9:47 AM, Yuxin Ren r...@gwmail.gwu.edu wrote: > > > Hi Boqun and Paul, > > > > Thank you so much for your help. > > > > I found one reason to use that lock. > > In the slow path, a thread will move

Re: [lttng-dev] Question about lock in synchronize_rcu implementation of URCU

2016-04-28 Thread Boqun Feng
Hi Paul and Yuxin, On Wed, Apr 27, 2016 at 09:23:27PM -0700, Paul E. McKenney wrote: > Try building without it and see what happens when you run the tests. > I've run a 'regtest' with the following modification out of curiousity: diff --git a/urcu.c b/urcu.c index a5568bdbd075..9dc3c9feae56

Re: [lttng-dev] Question about lock in synchronize_rcu implementation of URCU

2016-04-28 Thread Paul E. McKenney
On Thu, Apr 28, 2016 at 08:44:01PM +0800, Boqun Feng wrote: > Hi Paul and Yuxin, > > On Wed, Apr 27, 2016 at 09:23:27PM -0700, Paul E. McKenney wrote: > > Try building without it and see what happens when you run the tests. > > > > I've run a 'regtest' with the following modification out of

Re: [lttng-dev] Question about lock in synchronize_rcu implementation of URCU

2016-04-28 Thread Paul E. McKenney
On Thu, Apr 28, 2016 at 09:47:23AM -0400, Yuxin Ren wrote: > Hi Boqun and Paul, > > Thank you so much for your help. > > I found one reason to use that lock. > In the slow path, a thread will move all waiters to a local queue. > https://github.com/urcu/userspace-rcu/blob/master/urcu.c#L406 >

Re: [lttng-dev] Question about lock in synchronize_rcu implementation of URCU

2016-04-28 Thread Yuxin Ren
Hi Boqun and Paul, Thank you so much for your help. I found one reason to use that lock. In the slow path, a thread will move all waiters to a local queue. https://github.com/urcu/userspace-rcu/blob/master/urcu.c#L406 After this, following thread can also perform grace period, as the global

Re: [lttng-dev] Question about lock in synchronize_rcu implementation of URCU

2016-04-28 Thread Mathieu Desnoyers
- On Apr 28, 2016, at 9:47 AM, Yuxin Ren r...@gwmail.gwu.edu wrote: > Hi Boqun and Paul, > > Thank you so much for your help. > > I found one reason to use that lock. > In the slow path, a thread will move all waiters to a local queue. >

Re: [lttng-dev] [PATCH 1/3] tests/lib/Makefile.am: Remove test_seek_empty_packet and test_seek_big_trace from SCRIPT_LIST

2016-04-28 Thread Simon Marchi
On 2016-04-28 12:16, Michael Jeanson wrote: - On Apr 27, 2016, at 11:04 PM, Simon Marchi simon.mar...@polymtl.ca wrote: On 2016-04-27 22:52, Simon Marchi wrote: Since these files are generated by autoconf, they shouldn't be included in SCRIPT_LIST, which is the list of scripts to copy

Re: [lttng-dev] [PATCH 1/3] tests/lib/Makefile.am: Remove test_seek_empty_packet and test_seek_big_trace from SCRIPT_LIST

2016-04-28 Thread Michael Jeanson
- On Apr 27, 2016, at 11:04 PM, Simon Marchi simon.mar...@polymtl.ca wrote: > On 2016-04-27 22:52, Simon Marchi wrote: >> Since these files are generated by autoconf, they shouldn't be included >> in SCRIPT_LIST, which is the list of scripts to copy from the source >> directory to the build

Re: [lttng-dev] [PATCH 1/3] tests/lib/Makefile.am: Remove test_seek_empty_packet and test_seek_big_trace from SCRIPT_LIST

2016-04-28 Thread Michael Jeanson
- On Apr 28, 2016, at 12:44 PM, Simon Marchi simon.mar...@polymtl.ca wrote: > > Ok thanks. > > Just an idea: I find it quite cumbersome to add a new entry in > configure.ac for each test script that we want autoconf to process (such > as in patch 3/3). I think it could be easier to have a

Re: [lttng-dev] [PATCH 1/3] tests/lib/Makefile.am: Remove test_seek_empty_packet and test_seek_big_trace from SCRIPT_LIST

2016-04-28 Thread Simon Marchi
On 2016-04-28 14:28, Michael Jeanson wrote: - On Apr 28, 2016, at 12:44 PM, Simon Marchi simon.mar...@polymtl.ca wrote: Ok thanks. Just an idea: I find it quite cumbersome to add a new entry in configure.ac for each test script that we want autoconf to process (such as in patch 3/3). I