Re: [Lucene.Net] [jira] [Commented] (LUCENENET-412) Replacing ArrayLists, Hashtables etc. with appropriate Generics.

2011-05-20 Thread Andy Pook
It'd be useful if There was a StopAnalyzer ctor overload that took an IEnumerable and maybe the current one that takes List should be ICollection (same as internal stopWords member). Just gives a little flexibility on the types that can be used. Also there is a little confusion around the treatmen

Re: [Lucene.Net] 2.9.4g binary

2012-04-04 Thread Andy Pook
at is in dist is the release. > I > > will check out the tag tonight > > > > Sent from my Windows Phone > > > > From: Andy Pook > > Sent: 2/27/2012 5:09 AM > > To: lucene-net-...@incubator.apache.org > > Subject:

Re: [Lucene.Net] [jira] [Created] (LUCENENET-469) Convert Java Iterator classes to implement IEnumerable

2012-06-08 Thread Andy Pook
If we don't want to add IEnumerable (though it seems that IEnumerable could be added in parallel with the existing pattern) could we add a bunch of extension methods? Something like the following... {noformat} public static class LuceneExtensions { public static IEnumerable GetEnumerable(this Term

Compiler warnings to worry about?

2010-02-18 Thread Andy Pook
4 "hides inherited member" This can lead to some weird consequences esp. if polymorphism is used. Added 'override' is almost always the right solution. I would consider these as fairly serious smells.I can't see any reason why we should not fix these at this stage. I can provide patches if the committers are interested. --Andy Pook

Re: Compiler warnings to worry about?

2010-02-19 Thread Andy Pook
ailing list to send mails. Otherwise I'll have to do a allow/deny confirmation (as a moderator) with every mail you send and it can get lost among spams. DIGY On 18 February 2010 10:35, Andy Pook wrote: > > We get a lot of compiler warnings. This has been discussed before and the &g

Retrieving Attributes

2010-02-26 Thread Andy Pook
Attributes are a great thing from the indexing side of things. What I'd really like to be able to do is find a document. Then be able to retrieve the attributes for each field. We are considering storing some custom attributes against some of the "tokens" in a field. But we would like to be able to

Re: Retrieving Attributes

2010-02-26 Thread Andy Pook
ignore the "word"s. I hope this is more coherent :) Thanks. On 26 February 2010 18:40, Michael Garski wrote: > Andy, > > Can you give a bit more information on what you are looking to do?  I > don't quite understand what you are looking to do. > > Michael > &g

Re: Retrieving Attributes

2010-02-28 Thread Andy Pook
Oops, my bad. I'll continue there On 27 February 2010 18:26, Michael Garski wrote: > Andy, > > FYI - I moved this thread to the user list as it applies to the use rather > than development of Lucene.Net. > > Michael > > > -----Original Message- > From: An

More compiler warnings.

2010-03-08 Thread Andy Pook
I've noticed another compiler warning that can be easier avoided... Search\Function\CustomScoreQuery.cs(207,25): warning CS0108: 'Lucene.Net.Sear ch.Function.CustomScoreQuery.AnonymousCustomScoreProvider.reader' hides inherit ed member 'Lucene.Net.Search.Function.CustomScoreProvider.reader'. Use

How do you open Contrib.net?

2010-03-10 Thread Andy Pook
Sounds like a dumb question... Windows Explorer does not recognise it as a VS solutions file. The icon has the VS symbol (lower right) but not the version number (usually top right). Using File|Open in VS shows the Conversion wizard. The report at the end says that it has converted Lucene.Net.cspr

Re: More compiler warnings.

2010-03-10 Thread Andy Pook
email (one for the CustomScoreProvider & > one for the .bat files). > > Michael > > -Original Message- > From: Andy Pook [mailto:andy.p...@gmail.com] > Sent: Monday, March 08, 2010 9:20 AM > To: lucene-net-dev@lucene.apache.org > Subject: More compiler warnings. &

Re: How do you open Contrib.net?

2010-03-10 Thread Andy Pook
the Lucene.Net project in the solution as > opposed to an assembly reference, and it will convert the Lucene.Net > project to a VS2008 project when it opens. > > Michael > > -Original Message- > From: Andy Pook [mailto:andy.p...@gmail.com] > Sent: Wednesday, March 10

Re: More compiler warnings.

2010-03-10 Thread Andy Pook
rate pain that George has done previously? Is that still the plan? 2010/3/10 Digy : > There was a disccusion on these warnings previously. > https://issues.apache.org/jira/browse/LUCENENET-202 . > > DIGY. > > -Original Message- > From: Andy Pook [mailto:andy.p...@gmai

2.9.2 done?

2010-04-08 Thread Andy Pook
Is 2.9.2 done? Should there be a new 2.9.2 tag? Is there anything left to do? Is there anything we non-committers can help with? We're using trunk r930561 without issues (though we're fairly unsophisticated). What's the current thinking for what's next? Cheers, Andy

Re: Lucene.Net 2.9.3

2010-05-06 Thread Andy Pook
+1 On 4 May 2010 20:43, Leonardo Azize Martins wrote: > Hi DIGY, > > I think it is a good choice. > I do not know how can I help, but I would like. > > Regards, > Leo > > > > 2010/5/4 Digy > > > Hi All, > > > > Issues related with lucene.Java 2.9.3 > > (https://issues.apache.org/jira/browse/LUC

[jira] Created: (LUCENENET-390) Align visibility of LogMergePolicy.IsOptimized with Java version

2011-02-05 Thread Andy Pook (JIRA)
: Bug Reporter: Andy Pook Priority: Minor Making these two methods protected (as per Java version) allows a port of the BalancedSegmentMergePolicy from the Zoie project -- This message is automatically generated by JIRA. - For more information on JIRA, see: http

[jira] Updated: (LUCENENET-390) Align visibility of LogMergePolicy.IsOptimized with Java version

2011-02-05 Thread Andy Pook (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Pook updated LUCENENET-390: Attachment: LUCENENET-390.patch apply to "src" directory of either 2.9.2 branc

[jira] Closed: (LUCENENET-390) Align visibility of LogMergePolicy.IsOptimized with Java version

2011-02-05 Thread Andy Pook (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Pook closed LUCENENET-390. --- Resolution: Won't Fix Oops, I was looking at trunk. (Changed in r1025577 20/10/2010) As the

[jira] Commented: (LUCENENET-391) Luke.Net for Lucene.Net

2011-02-07 Thread Andy Pook (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991425#comment-12991425 ] Andy Pook commented on LUCENENET-391: - A much appreciated work. I had

[jira] Created: (LUCENENET-340) Fieldable.ReaderValue should return TextReader not StreamReader

2010-02-09 Thread Andy Pook (JIRA)
Reporter: Andy Pook Priority: Minor Using the more abstract type makes creating custome Fieldables easier as they can use other TextReader descendants (such as StringReader). Internally the main use seems to be from DocInverterPerField (eg line 125) where it is used via a

[jira] Updated: (LUCENENET-340) Fieldable.ReaderValue should return TextReader not StreamReader

2010-02-09 Thread Andy Pook (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Pook updated LUCENENET-340: Attachment: LUCENENET-340-Filedable.ReaderValue.patch Fieldable and implimenters patched

[jira] Updated: (LUCENENET-340) Fieldable.ReaderValue should return TextReader not StreamReader

2010-02-18 Thread Andy Pook (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Pook updated LUCENENET-340: Attachment: LUCENENET-340-Fieldable.ReaderValue-r911211.patch nothing changed other than taking

[jira] Created: (LUCENENET-341) Fix "Compiler warnings to worry about"

2010-02-19 Thread Andy Pook (JIRA)
Fix "Compiler warnings to worry about" -- Key: LUCENENET-341 URL: https://issues.apache.org/jira/browse/LUCENENET-341 Project: Lucene.Net Issue Type: Bug Reporter:

[jira] Updated: (LUCENENET-341) Fix "Compiler warnings to worry about"

2010-02-19 Thread Andy Pook (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Pook updated LUCENENET-341: Attachment: LUCENENET-341-SupportClass.ThreadClass.patch Add GetHashCode method Fixes CS0661

[jira] Updated: (LUCENENET-341) Fix "Compiler warnings to worry about"

2010-02-19 Thread Andy Pook (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Pook updated LUCENENET-341: Attachment: LUCENENET-341-Term.patch LUCENENET-341-NumericRangeQuery.patch

[jira] Commented: (LUCENENET-341) Fix "Compiler warnings to worry about"

2010-02-19 Thread Andy Pook (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835832#action_12835832 ] Andy Pook commented on LUCENENET-341: - Changing ISerializable ctors to private

[jira] Commented: (LUCENENET-343) Use TextReader instead of StreamReader in Field ctor

2010-02-23 Thread Andy Pook (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837321#action_12837321 ] Andy Pook commented on LUCENENET-343: - A lot of this is covered by the patc

[jira] Updated: (LUCENENET-343) Use TextReader instead of StreamReader in Field ctor

2010-02-23 Thread Andy Pook (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Pook updated LUCENENET-343: Attachment: TextReader-2.9.2.patch TextReader-2.9.2.patch adds the additional fixes suggested

[jira] Created: (LUCENENET-348) Avoidable compiler warning

2010-03-10 Thread Andy Pook (JIRA)
Avoidable compiler warning -- Key: LUCENENET-348 URL: https://issues.apache.org/jira/browse/LUCENENET-348 Project: Lucene.Net Issue Type: Bug Reporter: Andy Pook Compiler warning that can be easier

[jira] Updated: (LUCENENET-348) Avoidable compiler warning

2010-03-10 Thread Andy Pook (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Pook updated LUCENENET-348: Attachment: CustomScoreQuery.patch remove reader member. So use inherited member from ancestor