[lxc-devel] [PATCH v3] Parse rootfs->path

2015-10-20 Thread Christian Brauner
The mount_entry_overlay_dirs() and mount_entry_aufs_dirs() functions create workdirs and upperdirs for overlay and aufs lxc.mount.entry entries. They try to make sure that the workdirs and upperdirs can only be created under the containerdir (e.g. /path/to/the/container/CONTAINERNAME). In order to

[lxc-devel] [PATCH v3] Parse rootfs->path

2015-10-20 Thread Christian Brauner
- add NULL-pointer check - initialize rootfslen Christian Brauner (1): Parse rootfs->path src/lxc/conf.c | 115 - 1 file changed, 90 insertions(+), 25 deletions(-) -- 2.6.1 ___ lxc-devel

[lxc-devel] LXC Console issue.

2015-10-20 Thread visweswara
Hi All, I am running LXC in embedded machine which uses busybox and it make use of ttyHSL (Qualcomm UART with baud rate 115200) for serial console. I find all other tty[0-7] of the embedded machine were set to baud rate of 38400; I am trying to run LXC busybox inside this embedded

[lxc-devel] [PATCH v4] Parse rootfs->path

2015-10-20 Thread Christian Brauner
The mount_entry_overlay_dirs() and mount_entry_aufs_dirs() functions create workdirs and upperdirs for overlay and aufs lxc.mount.entry entries. They try to make sure that the workdirs and upperdirs can only be created under the containerdir (e.g. /path/to/the/container/CONTAINERNAME). In order to

Re: [lxc-devel] [PATCH v2] Update absolute paths for overlay and aufs mounts

2015-10-20 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > When using overlay and aufs mounts with lxc.mount.entry users have to specify > absolute paths for upperdir and workdir which will then get created > automatically by mount_entry_create_overlay_dirs() and > mount_entry_create_aufs_dirs()

Re: [lxc-devel] [PATCH v3] Parse rootfs->path

2015-10-20 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > On Tue, Oct 20, 2015 at 04:31:19PM +, Serge Hallyn wrote: > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > On Tue, Oct 20, 2015 at 03:30:19PM +, Serge Hallyn wrote: > > > > Quoting Christian Brauner

[lxc-devel] [PATCH v4] Parse rootfs->path

2015-10-20 Thread Christian Brauner
A fresh set of eyes would be nice. :) New solution: Use strstr() to search for ":/". If we find ":/" move the string to "/". Check for a second ":/". If we find it replace ':' with '\0'. If we do not find ":/" return strdup(rootfs->path). Christian Brauner (1): Parse rootfs->path

Re: [lxc-devel] [PATCH v3] Parse rootfs->path

2015-10-20 Thread Christian Brauner
On Tue, Oct 20, 2015 at 04:31:19PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > On Tue, Oct 20, 2015 at 03:30:19PM +, Serge Hallyn wrote: > > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > > The mount_entry_overlay_dirs() and

Re: [lxc-devel] [PATCH v3] Parse rootfs->path

2015-10-20 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > The mount_entry_overlay_dirs() and mount_entry_aufs_dirs() functions create > workdirs and upperdirs for overlay and aufs lxc.mount.entry entries. They try > to make sure that the workdirs and upperdirs can only be created under the >

Re: [lxc-devel] [PATCH v3] Parse rootfs->path

2015-10-20 Thread Christian Brauner
On Tue, Oct 20, 2015 at 03:30:19PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > The mount_entry_overlay_dirs() and mount_entry_aufs_dirs() functions create > > workdirs and upperdirs for overlay and aufs lxc.mount.entry entries. They > > try > > to

Re: [lxc-devel] [PATCH v3] Parse rootfs->path

2015-10-20 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > On Tue, Oct 20, 2015 at 03:30:19PM +, Serge Hallyn wrote: > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > The mount_entry_overlay_dirs() and mount_entry_aufs_dirs() functions > > > create > > > workdirs and

Re: [lxc-devel] [PATCH v2] Update absolute paths for overlay and aufs mounts

2015-10-20 Thread Christian Brauner
On Tue, Oct 20, 2015 at 04:17:18PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > When using overlay and aufs mounts with lxc.mount.entry users have to > > specify > > absolute paths for upperdir and workdir which will then get created > >

Re: [lxc-devel] [PATCH v4] Parse rootfs->path

2015-10-20 Thread Christian Brauner
On Tue, Oct 20, 2015 at 09:21:48PM +0200, Christian Brauner wrote: > The mount_entry_overlay_dirs() and mount_entry_aufs_dirs() functions create > workdirs and upperdirs for overlay and aufs lxc.mount.entry entries. They try > to make sure that the workdirs and upperdirs can only be created under