[lxc-devel] [PATCH 1/1] add lxc.console.logpath

2014-08-06 Thread Serge Hallyn
Some time ago, lxc.console was changed to require a device. lxc-start gained an lxc console logfile argument, but this was not supported through the container config. This patch adds the option through container config as 'lxc.console.logfile'. This allows for instance cloud providers to configur

Re: [lxc-devel] Working with glibc (PID/TID caches).

2014-08-06 Thread Serge Hallyn
Quoting Eric W. Biederman (ebied...@xmission.com): > > While talking about pain points there is a very large one. In short > pthreads break fork(). > > At least according to the open group after fork (when more than one > pthread is active) and by extension clone(CLONE_NEW...) it is only safe >

Re: [lxc-devel] Working with glibc (PID/TID caches).

2014-08-06 Thread Eric W. Biederman
Serge Hallyn writes: > Quoting Eric W. Biederman (ebied...@xmission.com): >> It would be nice if at least malloc and C++ new were safe (and >> documented as safe) after fork in a pthread environment. That would go >> a long ways to allowing running interesting set up code without having >> to ju

Re: [lxc-devel] Working with glibc (PID/TID caches).

2014-08-06 Thread Serge Hallyn
Quoting Eric W. Biederman (ebied...@xmission.com): > Serge Hallyn writes: > > > Quoting Eric W. Biederman (ebied...@xmission.com): > >> It would be nice if at least malloc and C++ new were safe (and > >> documented as safe) after fork in a pthread environment. That would go > >> a long ways to a

Re: [lxc-devel] [PATCH 1/1] add lxc.console.logpath

2014-08-06 Thread Stéphane Graber
On Wed, Aug 06, 2014 at 05:30:58PM +, Serge Hallyn wrote: > Some time ago, lxc.console was changed to require a device. lxc-start > gained an lxc console logfile argument, but this was not supported > through the container config. > > This patch adds the option through container config as 'lx

Re: [lxc-devel] [PATCH 1/1] add lxc.console.logpath

2014-08-06 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > On Wed, Aug 06, 2014 at 05:30:58PM +, Serge Hallyn wrote: > > Some time ago, lxc.console was changed to require a device. lxc-start > > gained an lxc console logfile argument, but this was not supported > > through the container config. > > > >

Re: [lxc-devel] [PATCH 1/1] add lxc.console.logpath

2014-08-06 Thread Stéphane Graber
On Wed, Aug 06, 2014 at 10:10:44PM +, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): > > On Wed, Aug 06, 2014 at 05:30:58PM +, Serge Hallyn wrote: > > > Some time ago, lxc.console was changed to require a device. lxc-start > > > gained an lxc console logfile argument,

[lxc-devel] [PATCH] add lxc.console.logpath (v2)

2014-08-06 Thread Serge Hallyn
v2: add get_config_item clear_config_item is not supported, as it isn't for lxc.console, bc you can do 'lxc.console.logfile =' to clear it. Likewise save_config is not needed because the config is now just written through the unexpanded char*. Signed-off-by: Serge Hallyn --- doc/lxc.container.

Re: [lxc-devel] [PATCH 1/1] add lxc.console.logpath

2014-08-06 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > On Wed, Aug 06, 2014 at 10:10:44PM +, Serge Hallyn wrote: > > Quoting Stéphane Graber (stgra...@ubuntu.com): > > > On Wed, Aug 06, 2014 at 05:30:58PM +, Serge Hallyn wrote: > > > > Some time ago, lxc.console was changed to require a device.

Re: [lxc-devel] [PATCH] add lxc.console.logpath (v2)

2014-08-06 Thread Stéphane Graber
On Wed, Aug 06, 2014 at 10:39:45PM +, Serge Hallyn wrote: > v2: add get_config_item > > clear_config_item is not supported, as it isn't for lxc.console, bc > you can do 'lxc.console.logfile =' to clear it. Likewise save_config > is not needed because the config is now just written through the

[lxc-devel] [lxc/lxc] 96f15c: add lxc.console.logpath

2014-08-06 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 96f15ca18cd18d451e5d67adfc11ef5a130ab35c https://github.com/lxc/lxc/commit/96f15ca18cd18d451e5d67adfc11ef5a130ab35c Author: Serge Hallyn Date: 2014-08-06 (Wed, 06 Aug 2014) Changed paths: M doc/lxc.contai

[lxc-devel] [PATCH] ubuntu templates: don't check for $rootfs/run/shm

2014-08-06 Thread Serge Hallyn
/dev/shm must be turned from a directory into a symlink to /run/shm. The templates do this only if they find -d $rootfs/run/shm. Since /run will be a tmpfs, checking for it in the rootfs is silly. It also is currently broken as ubuntu cloud images have an empty /run. (this should fix https://bug