Re: [lxc-devel] [PATCH 1/1] parse.c: don't print error message on callback rv 0

2013-10-18 Thread Stéphane Graber
if rv 0. Otherwise, lxc-create -B lvm --fstype ext3 -t ubuntu -n u1 will print an (innocuous) error message about being unable to parse the config value 'ext3'. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc

Re: [lxc-devel] [PATCH 1/1] lxc-test-ubuntu: improve apparmor policy test

2013-10-18 Thread Stéphane Graber
On Fri, Oct 18, 2013 at 10:43:24AM -0500, Serge Hallyn wrote: Also allow the standard non-nested apparmor policy. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/tests/lxc-test-ubuntu | 2 +- 1 file changed, 1 insertion(+), 1

[lxc-devel] [PATCH] lxc-start-ephemeral: Fix broken mount logic

2013-10-18 Thread Stéphane Graber
-mounts passed through the -b option are mounted by the pre-mount script and don't need processing by the fstab generator. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-start-ephemeral.in | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src

Re: [lxc-devel] lxc: Use Jessie and http.debian.net by default in Jessie/Sid?

2013-10-18 Thread Stéphane Graber
if it something you want to include upstream. This change won't apply upstream since the current version of the template doesn't appear to hardcode the release anymore, instead using the host's version by default or failing with an error telling the user to pass -r release. -- Stéphane Graber Ubuntu

Re: [lxc-devel] what happened to the autostart proposals?

2013-10-18 Thread Stéphane Graber
this upstream. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance

[lxc-devel] New LXC website

2013-10-18 Thread Stéphane Graber
: https://github.com/lxc/lxc.github.io There's a bit of room for distros to put links to their packages and other useful resources, so far I've just listed Ubuntu as that's the one I know most, other maintainers, please send me a patch for your distro. -- Stéphane Graber Ubuntu developer http

[lxc-devel] LXC 1.0 alpha2 to be released this Friday (18th of October)

2013-10-15 Thread Stéphane Graber
, I've now renamed the early RCs to Beta and will only call RC releases that may actually end up being the final release (as any good release candidate should be). -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature

[lxc-devel] [PATCH] Make 'make dist' match git content

2013-10-15 Thread Stéphane Graber
to dist tarball: - src/python-lxc/examples/pyconsole.py - src/python-lxc/examples/pyconsole-vte.py - Mark all the python API tests executable - Mark lxc-test-ubuntu executable Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/list.c | 23 - src/lxc/lxc

[lxc-devel] [PATCH] Improper pty permissions - missing mode=0620, gid=5

2013-10-15 Thread Stéphane Graber
is guaranteed to be gid=5 on at least all RedHat based and Debian based systems. So this hardcode gid shouldn't be a big problem. If we however support any distro where that's not the case, we'll need to implement an extra lxc.conf option and matching template changes. Signed-off-by: Stéphane Graber stgra

Re: [lxc-devel] [PATCH] define list container api (v2)

2013-10-14 Thread Stéphane Graber
the names and the name array, as showsn in the testcase. Sorry, missed that one in my mailbox... I quite like the new implementation, I think it'll be flexible enough for all our needs. Acked-by: Stéphane Graber stgra...@ubuntu.com Changelog: Check for the container config file before

Re: [lxc-devel] [PATCH] define list container api

2013-10-10 Thread Stéphane Graber
On Thu, Oct 10, 2013 at 08:33:28AM -0500, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On Wed, Oct 09, 2013 at 07:17:43AM -0500, Serge Hallyn wrote: Two new commands are defined: list_defined_containers() and list_active_containers(). Both take an lxcpath (NULL

Re: [lxc-devel] [PATCH] define list container api

2013-10-09 Thread Stéphane Graber
-- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips

Re: [lxc-devel] How to import/access raw devices inside the container ?

2013-10-08 Thread Stéphane Graber
root root 4096 Oct  8 06:08 .. Any ideas? Thank you, Dragos -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- October Webinars: Code for Performance Free Intel

Re: [lxc-devel] [PATCH] lxc-ubuntu-cloud: pass --numeric-owner and -p to untar

2013-10-08 Thread Stéphane Graber
On Mon, Oct 07, 2013 at 08:41:23PM -0400, Scott Moser wrote: On Mon, 7 Oct 2013, Stéphane Graber wrote: On Mon, Oct 07, 2013 at 04:16:05PM -0500, Serge Hallyn wrote: An example of where this can break is if you pass in sshkey to user ubuntu in the container, where user ubuntu exists

Re: [lxc-devel] [PATCH] lxc-ubuntu-cloud: pass --numeric-owner and -p to untar

2013-10-07 Thread Stéphane Graber
On Mon, Oct 07, 2013 at 04:16:05PM -0500, Serge Hallyn wrote: An example of where this can break is if you pass in sshkey to user ubuntu in the container, where user ubuntu exists with different uid on host. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra

Re: [lxc-devel] [PATCH 1/1] add basic lxc-test-ubuntu (v3)

2013-10-03 Thread Stéphane Graber
as stgraber suggested Don't look for 'expect' as I'm not using it yet. changelog v3: Make sure to only read one ip address from container. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac | 1 + src/tests

[lxc-devel] [PATCH] lxc-ubuntu: Remove trim option

2013-10-03 Thread Stéphane Graber
Container trimming is a bad idea in general, Ubuntu since 12.04 allows standard systems to run in containers and we've got separate code to deal with 10.04, so let's just drop trim. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-ubuntu.in | 96

Re: [lxc-devel] [lxc/lxc] 431fdc: Update lxc-fedora.in

2013-10-02 Thread Stéphane Graber
...@woralelandia.com Acked-by: Stéphane Graber stgra...@ubuntu.com Commit: 8983aa6e1e831f690be9cf38ae434a0de8b5107d https://github.com/lxc/lxc/commit/8983aa6e1e831f690be9cf38ae434a0de8b5107d Author: Stéphane Graber stgra...@ubuntu.com Date: 2013-10-02 (Wed, 02 Oct 2013

Re: [lxc-devel] [PATCH] fix lxc-info segv on stopped container

2013-10-02 Thread Stéphane Graber
On Wed, Oct 02, 2013 at 12:14:58PM -0400, Dwight Engen wrote: Signed-off-by: Dwight Engen dwight.en...@oracle.com Doh, not sure how I managed to miss that one! Thanks! Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc_info.c | 14 -- 1 file changed, 8 insertions

Re: [lxc-devel] [PATCH 1/1] add basic lxc-test-ubuntu

2013-10-02 Thread Stéphane Graber
abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134791iu=/4140/ostg.clktrk ___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer

Re: [lxc-devel] [PATCH 1/1] add basic lxc-test-ubuntu

2013-10-02 Thread Stéphane Graber
On Wed, Oct 02, 2013 at 02:21:47PM -0500, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On Wed, Oct 02, 2013 at 01:11:12PM -0500, Serge Hallyn wrote: From the file comments: Some features of lxc - networking and LSM configuration for instance

[lxc-devel] Migration of bug tracker from sourceforge to github

2013-10-02 Thread Stéphane Graber
goal is to make it so we don't have to :) That new website is backed by git (git://github.com/lxc/lxc.github.io) so if you want to help, add content to the site, send patches my way. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature

Re: [lxc-devel] [PATCH 1/1] add basic lxc-test-ubuntu (v2)

2013-10-02 Thread Stéphane Graber
-- Stéphane Graber Ubuntu developer http://www.canonical.com signature.asc Description: Digital signature -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore

Re: [lxc-devel] [PATCH 1/1] add basic lxc-test-ubuntu (v2)

2013-10-02 Thread Stéphane Graber
On Wed, Oct 02, 2013 at 05:09:17PM -0500, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On Wed, Oct 02, 2013 at 04:48:12PM -0500, Serge Hallyn wrote: From the file comments: Some features of lxc - networking and LSM configuration for instance

[lxc-devel] [PATCH] Improve behaviour for unprivileged users

2013-10-02 Thread Stéphane Graber
abilities and I confirmed they all build fine at least. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc_attach.c | 3 +++ src/lxc/lxc_cgroup.c | 9 + src/lxc/lxc_checkpoint.c | 3 +++ src/lxc/lxc_clone.c | 6 ++ src/lxc/lxc_console.c| 8 src/lxc

Re: [lxc-devel] [PATCH 1/1] add c-may_control

2013-09-30 Thread Stéphane Graber
-- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore

Re: [lxc-devel] [PATCH 1/1] add c-may_control

2013-09-30 Thread Stéphane Graber
On Mon, Sep 30, 2013 at 12:58:47PM -0500, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On Mon, Sep 30, 2013 at 09:53:56AM -0400, Dwight Engen wrote: On Fri, 27 Sep 2013 21:01:07 -0500 Serge Hallyn serge.hal...@ubuntu.com wrote: This is an api function which

[lxc-devel] [PATCH 1/2] lxc-info: Port to LXC API

2013-09-26 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc_info.c | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/src/lxc/lxc_info.c b/src/lxc/lxc_info.c index e61ae63..ab3aacf 100644 --- a/src/lxc/lxc_info.c +++ b/src/lxc

[lxc-devel] [PATCH 2/2] lxc-info: Allow printing IP addresses

2013-09-26 Thread Stéphane Graber
-by: Stéphane Graber stgra...@ubuntu.com --- doc/lxc-info.sgml.in | 12 src/lxc/lxc_info.c | 24 2 files changed, 32 insertions(+), 4 deletions(-) diff --git a/doc/lxc-info.sgml.in b/doc/lxc-info.sgml.in index c6fc624..819d5ca 100644 --- a/doc/lxc-info.sgml.in +++ b

Re: [lxc-devel] [PATCH] doc: Japanese man pages is not generated when docbook-utils is used

2013-09-25 Thread Stéphane Graber
-off-by: KATOH Yasufumi ka...@jazz.email.ne.jp Acked-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac| 1 + doc/Makefile.am | 9 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index a523583..092a67d 100644 --- a/configure.ac

Re: [lxc-devel] [minor] Changing the version naming

2013-09-25 Thread Stéphane Graber
change format, I'd only start doing it with alpha2 to avoid some extra confusion) -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- October Webinars: Code

Re: [lxc-devel] [RFC] rootfs pinning

2013-09-24 Thread Stéphane Graber
affecting the outside world. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- October Webinars: Code for Performance Free Intel webinars can help you accelerate

Re: [lxc-devel] [PATCH 3/4] doc: Make everything use the @docdtd@ variable

2013-09-23 Thread Stéphane Graber
On Mon, Sep 23, 2013 at 03:22:47PM -0500, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): Signed-off-by: Stéphane Graber stgra...@ubuntu.com I assume it doesn't really matter, but note that configure.ac doesn't have the V4.5//EN as the entries you are replacing do

[lxc-devel] Git moved to github

2013-09-22 Thread Stéphane Graber
on sourceforge after making a last backup. Please make sure to update your git config! -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- LIMITED TIME SALE - Full Year

[lxc-devel] Proposal for use of config includes by templates

2013-09-21 Thread Stéphane Graber
something that'd be useful for them and that they'd use? Are there common cases I didn't think in my proposal? -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature

[lxc-devel] [PATCH 4/4] doc: Fixed my first name

2013-09-21 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- doc/ja/lxc-checkconfig.sgml.in | 2 +- doc/ja/lxc-device.sgml.in | 2 +- doc/ja/lxc-info.sgml.in| 2 +- doc/ja/lxc-netstat.sgml.in | 2 +- doc/ja/lxc-start-ephemeral.sgml.in | 3 +-- doc/ja/lxc-version.sgml.in

[lxc-devel] [PATCH 2/4] Add some missing comments to configure.ac

2013-09-21 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index 6c74dcd..a523583 100644 --- a/configure.ac +++ b/configure.ac @@ -52,6 +52,7 @@ esac AC_MSG_RESULT([$with_distro]) AM_CONDITIONAL

[lxc-devel] [PATCH 1/4] Consistently use lxc/lxccontainer.h for the API

2013-09-21 Thread Stéphane Graber
The API header was included in a variety of ways before, standardize those to include lxc/lxccontainer.h as this will always work both in tree and on a system with the headers installed. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/bdev.h | 2 +- src/lxc/console.c

[lxc-devel] [PATCH 3/4] doc: Make everything use the @docdtd@ variable

2013-09-21 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- doc/ja/legacy/lxc-ls.sgml.in | 2 +- doc/ja/lxc-attach.sgml.in | 2 +- doc/ja/lxc-cgroup.sgml.in | 2 +- doc/ja/lxc-checkconfig.sgml.in | 2 +- doc/ja/lxc-checkpoint.sgml.in | 2 +- doc/ja/lxc-clone.sgml.in

[lxc-devel] Some important project changes

2013-09-20 Thread Stéphane Graber
for the hard work he's been putting into LXC for over 5 years now and wish him all the best for his new projects! -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature

Re: [lxc-devel] [PATCH] fix console deadlocks

2013-09-20 Thread Stéphane Graber
a good idea... But here I just drop the locks which make lxc-start-ephemeral deadlock. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/console.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/lxc/console.c b

Re: [lxc-devel] Linux Plumbers 2013 - Container mini-summit, (hopefully) final schedule

2013-09-18 Thread Stéphane Graber
On Wed, Sep 18, 2013 at 09:30:28AM +0200, Claudio Kuenzler wrote: On Tue, Sep 17, 2013 at 3:01 AM, Stéphane Graber stgra...@ubuntu.comwrote: Hey everyone, So I just went through everything the other track leads accepted over the past couple of weeks and split the remaining time as well

Re: [lxc-devel] [PATCH] Add get_interfaces to the API - v3

2013-09-18 Thread Stéphane Graber
. Support for python bindings also introduced as a part of this version. Signed-off-by: S.Çağlar Onur cag...@10ur.org Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxccontainer.c | 129 ++-- src/lxc/lxccontainer.h | 3

Re: [lxc-devel] [PATCH trivial] lxc-create: add -P to --lxcpath option help text

2013-09-18 Thread Stéphane Graber
On Wed, Sep 18, 2013 at 02:00:42PM -0500, Serge Hallyn wrote: Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc_create.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git

Re: [lxc-devel] [PATCH] Add get_interfaces to the API - v3

2013-09-18 Thread Stéphane Graber
)! On Wed, Sep 18, 2013 at 2:47 PM, Stéphane Graber stgra...@ubuntu.comwrote: On Mon, Sep 16, 2013 at 05:01:11PM -0400, S.Çağlar Onur wrote: get_ips accepts an interface name as a parameter but there was no way to get the interfaces names from the container. This patch introduces a new

Re: [lxc-devel] [PATCH] Add get_interfaces to the API - v2

2013-09-16 Thread Stéphane Graber
On Mon, Sep 16, 2013 at 02:54:44PM -0400, S.Çağlar Onur wrote: On Mon, Sep 16, 2013 at 2:39 PM, Stéphane Graber stgra...@ubuntu.comwrote: On Mon, Sep 16, 2013 at 02:26:47PM -0400, S.Çağlar Onur wrote: get_ips accepts an interface name as a parameter but there was no way to get

Re: [lxc-devel] [PATCH] .gitignore generated Japanese manpages

2013-09-16 Thread Stéphane Graber
On Mon, Sep 16, 2013 at 04:25:38PM -0400, Dwight Engen wrote: Signed-off-by: Dwight Engen dwight.en...@oracle.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 0061609..84c060f 100644

Re: [lxc-devel] [PATCH] Add get_interfaces to the API - v2

2013-09-16 Thread Stéphane Graber
://pubads.g.doubleclick.net/gampad/clk?id=58041151iu=/4140/ostg.clktrk ___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description

Re: [lxc-devel] [PATCH] make process_lock return void

2013-09-16 Thread Stéphane Graber
___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature

[lxc-devel] Linux Plumbers 2013 - Container mini-summit, (hopefully) final schedule

2013-09-16 Thread Stéphane Graber
is as follow: == On the road to LXC 1.0 == Presented by: Serge Hallyn and Stéphane Graber Duration: 20 minutes Excerpt: Overview of what features to expect for LXC 1.0 and hints on how to help us get there. . LXC upstream is currently doing a big development push to get LXC 1.0 out in early 2014

Re: [lxc-devel] [PATCH] cgroup: add bdev.h to fix the build error

2013-09-15 Thread Stéphane Graber
cgroup.c:1219: error: for each function it appears in.) Signed-off-by: Qiang Huang h.huangqi...@huawei.com Reproduced the issue when building on Android. Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/cgroup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lxc/cgroup.c b

Re: [lxc-devel] [PATCH] lxc-create: conside create succeed when container is already created

2013-09-15 Thread Stéphane Graber
-lxc_conf c-lxc_conf-rootfs.path + access(c-lxc_conf-rootfs.path, F_OK) == 0) { + bret = true; goto out; + } /* Mark that this container is being created */ if ((partial_fd = create_partial(c)) 0) -- 1.8.3 -- Stéphane Graber Ubuntu

Re: [lxc-devel] Change rootfs pinning mechnism

2013-09-13 Thread Stéphane Graber
start because .lxc-running exists... - perhaps we could write the pid of the lxc-start process in there, so that it may check whether the container is really running? -- Christian -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital

Re: [lxc-devel] [PATCH] add pstore to container fstab

2013-09-13 Thread Stéphane Graber
On Fri, Sep 13, 2013 at 03:43:56PM -0500, Serge Hallyn wrote: Otherwise user-namespace containers will hang on mountall. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com I'll cherry-pick that in the Ubuntu package. --- templates/lxc-ubuntu

Re: [lxc-devel] [PATCH] Add get_interfaces to the API and start not to filter out loopback interface

2013-09-13 Thread Stéphane Graber
. So I see two ways not to regress in that regard: 1) Make scope filtering work with IPv4, so that get_ips() user can pass scope=0 and only get global IPv4 and IPv6 addresses. 2) Add a no_loopback argument to get_ips. As it's: Nacked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc

Re: [lxc-devel] [PATCH] Add get_interfaces to the API and start not to filter out loopback interface

2013-09-13 Thread Stéphane Graber
On Fri, Sep 13, 2013 at 06:44:34PM -0400, S.Çağlar Onur wrote: Hey Stéphane, On Fri, Sep 13, 2013 at 6:32 PM, Stéphane Graber stgra...@ubuntu.comwrote: On Fri, Sep 13, 2013 at 06:21:20PM -0400, S.Çağlar Onur wrote: Signed-off-by: S.Çağlar Onur cag...@10ur.org The loopback filtering

Re: [lxc-devel] [RFC] rootfs pinning

2013-09-12 Thread Stéphane Graber
@castiana:~# -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems

Re: [lxc-devel] [PATCH 1/1] snapshots: add man page and fix up help info a bit.

2013-09-12 Thread Stéphane Graber
On Thu, Sep 12, 2013 at 03:08:26PM -0500, Serge Hallyn wrote: Awesome, I noticed it was missing when going through lintian output this morning and added it to my TODO for later this cycle, glad I won't have to do it myself then :) Acked-by: Stéphane Graber stgra...@ubuntu.com Signed-off

Re: [lxc-devel] patch for the opensuse template

2013-09-11 Thread Stéphane Graber
On Wed, Sep 11, 2013 at 01:16:02PM +0200, Cedric Bosdonnat wrote: Hello Stéphane, On Tue, 2013-09-10 at 12:29 -0400, Stéphane Graber wrote: Yes, the mailing-list is the right way to send patches upstream. Great. Note that we usually require you to add a Signed-off-by tag to your

Re: [lxc-devel] [PATCH] cgroup: re-introduce ns cgroup support

2013-09-11 Thread Stéphane Graber
probably won't work. However as ns cgroup is very much legacy, that should be ok. Eventually we should be able to drop ns cgroup support altogether, but not just yet. Tested on Android with a 2.6.32 kernel, I can confirm that I'm now able to start containers! Acked-by: Stéphane Graber stgra

[lxc-devel] regression: lxc-start -d hangs in lxc_monitor_sock_name (at process_lock)

2013-09-11 Thread Stéphane Graber
, until then, lxc-start -d is broken in staging. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- How ServiceNow helps IT people transform IT departments: 1

Re: [lxc-devel] [PATCH 2/2] introduce lxc-snapshot

2013-09-10 Thread Stéphane Graber
-by: Serge Hallyn serge.hal...@ubuntu.com Simple works for me :) Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/Makefile.am| 4 +- src/lxc/lxc_snapshot.c | 201 + 2 files changed, 204 insertions(+), 1 deletion(-) create mode

Re: [lxc-devel] [PATCH 1/1] error.c: don't return error if container init signaled

2013-09-10 Thread Stéphane Graber
the cleaner shutdown mechanism than people depending on the hold behaviour. Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/error.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/lxc/error.c b/src/lxc/error.c index 15e6ab0..46c34bb 100644 --- a/src/lxc/error.c +++ b/src/lxc

Re: [lxc-devel] [PATCH 1/2] API support for container snapshots (v2)

2013-09-10 Thread Stéphane Graber
to) rather than segving. . when choosing a snapshot index, use the correct path to check for. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxccontainer.c | 278 + src/lxc

Re: [lxc-devel] [PATCH] lua: fix logic to enable lua support in configure

2013-09-06 Thread Stéphane Graber
if lua headers was missing. Signed-off-by: Natanael Copa nc...@alpinelinux.org Acked-by: Stéphane Graber stgra...@ubuntu.com --- PS. I wonder it it would be an idea to replace the 2 switches: --enable-lua --with-lua-pc[=PKG] with a single switch: --with-lua[=PKG

Re: [lxc-devel] [PATCH] API support for container snapshots

2013-09-06 Thread Stéphane Graber
://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover

Re: [lxc-devel] [PATCH] lxc_spawn: don't close pinfd until container is stopped

2013-09-06 Thread Stéphane Graber
On Fri, Sep 06, 2013 at 12:28:48PM -0500, Serge Hallyn wrote: Otherwise containers may be able to remount -o ro their rootfs at shutdown. Reported-by: Harald Dunkel ha...@afaics.de Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- src

Re: [lxc-devel] [PATCH] configure: enable Lua if found and continue without if not

2013-09-06 Thread Stéphane Graber
. Signed-off-by: Natanael Copa nc...@alpinelinux.org I suppose at some point it'd be nice to find a way not to have configure show checking for LUA... no 3 times in a row, but that's really just a cosmetic issue. Thanks for the change! Acked-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac

Re: [lxc-devel] [PATCH] API support for container snapshots

2013-09-06 Thread Stéphane Graber
On Fri, Sep 06, 2013 at 02:13:23PM -0500, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): +static struct lxc_container *lxcsnap_open(struct lxc_snapshot *s) +{ + return NULL; +} I guess that's because we may want to do some more stuff in there later right

Re: [lxc-devel] [PATCH v2] configure/makefile: Allow specify Lua pkg-config file with --with-lua-pc

2013-09-05 Thread Stéphane Graber
@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- Learn the latest--Visual Studio 2012

Re: [lxc-devel] [RFC 1/1] snapshots in api: define lxcapi_snapshot

2013-09-04 Thread Stéphane Graber
___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature

Re: [lxc-devel] [RFC 1/1] snapshots in api: define lxcapi_snapshot

2013-09-04 Thread Stéphane Graber
On Wed, Sep 04, 2013 at 05:14:49PM -0500, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On Wed, Sep 04, 2013 at 11:05:02AM -0500, Serge Hallyn wrote: Hi, before I go on with the snapshots-in-api patchset, I wanted to floar this and ask a few questions, as I'm

Re: [lxc-devel] [PATCH] lxc-commands: add a comment explaining CMD_* rules

2013-09-03 Thread Stéphane Graber
...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/commands.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/lxc/commands.c b/src/lxc/commands.c index a7981ba..aad376a 100644 --- a/src/lxc/commands.c +++ b/src/lxc/commands.c @@ -59,6 +59,16 @@ * Each

Re: [lxc-devel] Clarifying the licensing of LXC

2013-09-03 Thread Stéphane Graber
On Fri, Aug 30, 2013 at 03:46:45PM -0400, Stéphane Graber wrote: On Fri, Aug 30, 2013 at 03:42:03PM -0400, Stéphane Graber wrote: Hello, First of all, sorry for the boring e-mail, nobody likes to deal with licenses but it's an unfortunate thing we have to deal with from time to time

Re: [lxc-devel] RFC: Device Namespaces

2013-09-03 Thread Stéphane Graber
be nice to have. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master

[lxc-devel] LXC 1.0~alpha1 pull request

2013-09-03 Thread Stéphane Graber
comments (lxc-clone is now implemented) lxc-commands: add a comment explaining CMD_* rules lua: update license Stéphane Graber (50): python: Fix memory management Revert utils: reimplement/fix mkdir_p() Revert start: Detect early failure of the new child python

Re: [lxc-devel] Clarifying the licensing of LXC

2013-08-30 Thread Stéphane Graber
On Fri, Aug 30, 2013 at 03:42:03PM -0400, Stéphane Graber wrote: Hello, First of all, sorry for the boring e-mail, nobody likes to deal with licenses but it's an unfortunate thing we have to deal with from time to time. Thomas Moschny reported some inconsistencies in the way LXC

[lxc-devel] [PATCH] Add a section about licensing to CONTRIBUTING

2013-08-30 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- CONTRIBUTING | 24 1 file changed, 24 insertions(+) diff --git a/CONTRIBUTING b/CONTRIBUTING index f6447c1..81edd3b 100644 --- a/CONTRIBUTING +++ b/CONTRIBUTING @@ -40,6 +40,30 @@ You can submit your patches

[lxc-devel] Clarifying the licensing of LXC

2013-08-30 Thread Stéphane Graber
(in the form, not the content). I'll be fixing those too before I send the alpha1 pull-request. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- Learn the latest

Re: [lxc-devel] [PATCH] start.c: handle potential signal flood

2013-08-29 Thread Stéphane Graber
unlikely) race which apw pointed out while we were trying to create a reproducer for the kernel bug. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/start.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions

Re: [lxc-devel] [PATCH 11/17] Use srand/rand instead of initstate/random

2013-08-19 Thread Stéphane Graber
On Fri, Aug 16, 2013 at 05:25:34PM +0100, Daniel P. Berrange wrote: On Fri, Aug 16, 2013 at 06:01:25PM +0200, Stéphane Graber wrote: On Fri, Aug 16, 2013 at 10:36:58AM -0500, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): initstate/random doesn't work on bionic, srand

Re: [lxc-devel] [PATCH] install attach_options.h into /usr/include/lxc

2013-08-19 Thread Stéphane Graber
\ lxclock.h \ bdev.h \ -- 1.8.1.2 I already did that change a couple days back as it was breaking the automated builds (which use make dist to make an upstream tarball). -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description

Re: [lxc-devel] [PATCH 00/17] Android/Bionic compatibility changes

2013-08-19 Thread Stéphane Graber
On Fri, Aug 16, 2013 at 05:13:46PM +0200, Stéphane Graber wrote: LXC recently regressed with regard to Android/Bionic buildability, the following commits try to address that. With those changes, LXC now builds with an up to date NDK using android-9. This patchset has now been pushed

Re: [lxc-devel] [PATCH 1/5] cgroup: minor bugfixes so start and attach work again

2013-08-19 Thread Stéphane Graber
or whatever else uses cgroups these days. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- Introducing Performance Central, a new site from SourceForge and AppDynamics

[lxc-devel] [PATCH 04/17] Define BLKGETSIZE64 and LO_FLAGS_AUTOCLEAR

2013-08-16 Thread Stéphane Graber
Those two aren't always around (specifically on bionic), so add some defines in case they aren't already defined. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/bdev.c | 8 1 file changed, 8 insertions(+) diff --git a/src/lxc/bdev.c b/src/lxc/bdev.c index e244550

[lxc-devel] [PATCH 08/17] Add missing sys/select.h include for fd_set

2013-08-16 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lxc/lxc.h b/src/lxc/lxc.h index b9eb52c..253c440 100644 --- a/src/lxc/lxc.h +++ b/src/lxc/lxc.h @@ -28,6 +28,7 @@ extern C { #endif #include stddef.h +#include sys

[lxc-devel] [PATCH 03/17] Export the local getmntent_r implementation

2013-08-16 Thread Stéphane Graber
New code now uses getmntent_r so we need it exported so that it can be used when building on bionic. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/include/lxcmntent.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/include/lxcmntent.h b/src/include/lxcmntent.h index 528e8bc

[lxc-devel] [PATCH 16/17] Add missing namespace.h include

2013-08-16 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxccontainer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c index a64babe..39789fd 100644 --- a/src/lxc/lxccontainer.c +++ b/src/lxc/lxccontainer.c @@ -42,6 +42,7 @@ #include

[lxc-devel] [PATCH 09/17] Import local getline copy on bionic

2013-08-16 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/cgroup.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/lxc/cgroup.c b/src/lxc/cgroup.c index b2b1aa3..221c018 100644 --- a/src/lxc/cgroup.c +++ b/src/lxc/cgroup.c @@ -53,6 +53,12 @@ #include mntent.h #endif

[lxc-devel] [PATCH 17/17] Fix lxc-user-nic to work on bionic

2013-08-16 Thread Stéphane Graber
This adds a couple of missing includes, uses the local version of getline on bionic and replaces getpwuid_r by getpwuid. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc_user_nic.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/lxc

[lxc-devel] [PATCH 15/17] Allow building without confstr

2013-08-16 Thread Stéphane Graber
We use confstr to grab the default PATH value. If it's not there, just use a standard one with bin and sbin for /, /usr and /usr/local. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac | 2 +- src/lxc/attach.c | 9 +++-- 2 files changed, 8 insertions(+), 3 deletions

[lxc-devel] [PATCH 12/17] Define SOCK_CLOEXEC when missing

2013-08-16 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/attach.c | 4 1 file changed, 4 insertions(+) diff --git a/src/lxc/attach.c b/src/lxc/attach.c index 950fe9a..3e9fb5f 100644 --- a/src/lxc/attach.c +++ b/src/lxc/attach.c @@ -54,6 +54,10 @@ #include sys/personality.h #endif

[lxc-devel] [PATCH 13/17] Add missing sys/socket.h include

2013-08-16 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/attach.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lxc/attach.c b/src/lxc/attach.c index 3e9fb5f..99b9c89 100644 --- a/src/lxc/attach.c +++ b/src/lxc/attach.c @@ -31,6 +31,7 @@ #include sys/param.h #include sys/prctl.h

[lxc-devel] [PATCH 05/17] Android now uses a sane clone() definition

2013-08-16 Thread Stéphane Graber
The current Android NDK provides a clone() defintion that's identical to eglibc's so we can drop the ifdef from that one. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/namespace.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/lxc/namespace.h b/src/lxc/namespace.h

[lxc-devel] [PATCH 11/17] Use srand/rand instead of initstate/random

2013-08-16 Thread Stéphane Graber
initstate/random doesn't work on bionic, srand/rand works on everything, so let's use that. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/conf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/lxc/conf.c b/src/lxc/conf.c index 867a150..3d99469 100644

[lxc-devel] [PATCH 07/17] Add missing syscall.h include to utils.h

2013-08-16 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/utils.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lxc/utils.h b/src/lxc/utils.h index cd08f05..20853b2 100644 --- a/src/lxc/utils.h +++ b/src/lxc/utils.h @@ -25,6 +25,7 @@ #include errno.h #include stdarg.h +#include

[lxc-devel] [PATCH 06/17] Add arm defines for __NR_signalfd(4)

2013-08-16 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/utils.h | 4 1 file changed, 4 insertions(+) diff --git a/src/lxc/utils.h b/src/lxc/utils.h index 1818ee3..cd08f05 100644 --- a/src/lxc/utils.h +++ b/src/lxc/utils.h @@ -114,6 +114,8 @@ struct signalfd_siginfo # define

[lxc-devel] [PATCH 14/17] Don't define new_personality when building without personalities

2013-08-16 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/attach.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lxc/attach.c b/src/lxc/attach.c index 99b9c89..19fe61d 100644 --- a/src/lxc/attach.c +++ b/src/lxc/attach.c @@ -830,7 +830,9 @@ int attach_child_main(void* data

[lxc-devel] [PATCH 10/17] Include stdio.h in getline.h for FILE

2013-08-16 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/include/getline.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/include/getline.h b/src/include/getline.h index b030d7a..23d6f04 100644 --- a/src/include/getline.h +++ b/src/include/getline.h @@ -1,6 +1,8 @@ #ifndef

[lxc-devel] [PATCH 01/17] Add a local implementation of ifaddrs.h

2013-08-16 Thread Stéphane Graber
This adds a local ifaddrs implementation to be used on Bionic or other C libraries that don't come with a getifaddrs implementation. This code was written by Kenneth MacKay and is under a two-clause BSD license (copyright information in the file headers). Signed-off-by: Stéphane Graber stgra

<    1   2   3   4   5   6   >