Re: [lxc-devel] autostart

2013-02-19 Thread Jäkel , Guido
Oh, forgot to add: - Get some kind of upstream support for container autostart. The actual autostart would still be done by distro's init scripts, but the way it's set should be standardized. Dear Stéphane, like a corresponding BIOS feature of most real hardware, autostart maybe should

Re: [lxc-devel] [PATCH] Link against pthread when not on bionic.

2013-02-19 Thread Natanael Copa
On Mon, 18 Feb 2013 21:40:42 +0100 Daniel Lezcano daniel.lezc...@free.fr wrote: On 02/18/2013 06:23 PM, Stéphane Graber wrote: dpkg spotted that we're not explicitly linking against pthread even though we use some of its symbols (sem_*). uh ? wait. We shouldn't link against the lib

Re: [lxc-devel] [PATCH] Link against pthread when not on bionic.

2013-02-19 Thread Natanael Copa
On Mon, 18 Feb 2013 12:23:24 -0500 Stéphane Graber stgra...@ubuntu.com wrote: dpkg spotted that we're not explicitly linking against pthread even though we use some of its symbols (sem_*). Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/Makefile.am | 2 +- 1 file changed,

[lxc-devel] [PATCH] configure: replace deprecated AM_CONFIG_HEADER

2013-02-19 Thread Natanael Copa
Replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADER. This is needed for automake-1.13. Signed-off-by: Natanael Copa nc...@alpinelinux.org --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 931e0d6..c5c71e4 100644 ---

Re: [lxc-devel] [PATCH] Link against pthread when not on bionic.

2013-02-19 Thread Stéphane Graber
On 02/19/2013 09:19 AM, Serge Hallyn wrote: Quoting Natanael Copa (nc...@alpinelinux.org): On Mon, 18 Feb 2013 21:40:42 +0100 Daniel Lezcano daniel.lezc...@free.fr wrote: On 02/18/2013 06:23 PM, Stéphane Graber wrote: dpkg spotted that we're not explicitly linking against pthread even though

Re: [lxc-devel] [PATCH] configure: replace deprecated AM_CONFIG_HEADER

2013-02-19 Thread Stéphane Graber
On 02/19/2013 10:09 AM, Stéphane Graber wrote: On 02/19/2013 04:17 AM, Natanael Copa wrote: Replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADER. This is needed for automake-1.13. Signed-off-by: Natanael Copa nc...@alpinelinux.org --- configure.ac | 2 +- 1 file changed, 1

Re: [lxc-devel] [PATCH] Link against pthread when not on bionic.

2013-02-19 Thread Dwight Engen
On Tue, 19 Feb 2013 10:02:37 -0500 Stéphane Graber stgra...@ubuntu.com wrote: On 02/19/2013 09:19 AM, Serge Hallyn wrote: Quoting Natanael Copa (nc...@alpinelinux.org): On Mon, 18 Feb 2013 21:40:42 +0100 Daniel Lezcano daniel.lezc...@free.fr wrote: On 02/18/2013 06:23 PM, Stéphane

Re: [lxc-devel] [PATCH] Link against pthread when not on bionic.

2013-02-19 Thread Daniel Lezcano
On 02/19/2013 04:28 PM, Dwight Engen wrote: On Tue, 19 Feb 2013 10:02:37 -0500 Stéphane Graber stgra...@ubuntu.com wrote: On 02/19/2013 09:19 AM, Serge Hallyn wrote: Quoting Natanael Copa (nc...@alpinelinux.org): On Mon, 18 Feb 2013 21:40:42 +0100 Daniel Lezcano daniel.lezc...@free.fr

Re: [lxc-devel] [PATCH] Link against pthread when not on bionic.

2013-02-19 Thread Stéphane Graber
On 02/19/2013 10:39 AM, Daniel Lezcano wrote: On 02/19/2013 04:28 PM, Dwight Engen wrote: On Tue, 19 Feb 2013 10:02:37 -0500 Stéphane Graber stgra...@ubuntu.com wrote: On 02/19/2013 09:19 AM, Serge Hallyn wrote: Quoting Natanael Copa (nc...@alpinelinux.org): On Mon, 18 Feb 2013 21:40:42

[lxc-devel] [PATCH] Use AC_SEARCH_LIBS instead of hardcoded lists

2013-02-19 Thread Stéphane Graber
Use AC_SEARCH_LIBS to detect what library provides sem_*. This allows us to stop hardcoding the ld arguments in the various MakeFiles. Suggested-by: Natanael Copa nc...@alpinelinux.org Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac | 3 +++ src/lxc/Makefile.am | 8

Re: [lxc-devel] [PATCH 1/6] various fixes for openSUSE template for lxc-clone usage

2013-02-19 Thread Serge Hallyn
Quoting Jiri Slaby (jsl...@suse.cz): From: Frederic Crozat fcro...@suse.com - create /etc/hostname as symlink to /etc/HOSTNAME - fix inadequate space in lxc.mount config, preventing lxc-clone to work Jiri Slaby: some cleanups Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com ---

Re: [lxc-devel] [PATCH 2/6] shutdown fixes for openSUSE container

2013-02-19 Thread Serge Hallyn
Quoting Jiri Slaby (jsl...@suse.cz): From: Frederic Crozat fcro...@suse.com - mount /run on tmpfs outside container - replace /var/run bind mount on /run by a symlink --- Formality, but could you please sign off your patches? Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com

Re: [lxc-devel] [PATCH 7/7] lxc-opensuse: print \n from one echo

2013-02-19 Thread Serge Hallyn
Quoting Jiri Slaby (jsl...@suse.cz): Otherwise the output looks like: Copying rootfs to /var/lib/lxc/tomcat/rootfs ...Please change root-password ! --- templates/lxc-opensuse.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/lxc-opensuse.in

Re: [lxc-devel] [PATCH 3/6] give a hint if old cgroup can't be moved

2013-02-19 Thread Serge Hallyn
Quoting Jiri Slaby (jsl...@suse.cz): From: Frederic Crozat fcro...@suse.com When cgroup can't be moved, it might be a hint container is already running. This becomes obsolete with the patch I sent last week. (Mind you, it reminds us that we need to make sure the monitor test for this

Re: [lxc-devel] [PATCH 4/6] lxc-opensuse: update for 12.2

2013-02-19 Thread Serge Hallyn
Quoting Jiri Slaby (jsl...@suse.cz): From: Frederic Crozat fcro...@suse.com This adaptation of systemd. We also add network configuration support. Is there any point in worrying about support for older versions? (If not, that's fine) Jiri Slaby: cleanups, rebase ---

Re: [lxc-devel] [PATCH 5/6] lxc-opensuse: extend base

2013-02-19 Thread Serge Hallyn
Quoting Jiri Slaby (jsl...@suse.cz): Base no longer provides bash, sed and tar, but we need those. So add them. --- templates/lxc-opensuse.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com diff --git a/templates/lxc-opensuse.in

[lxc-devel] [PATCH] remove redundant, too-early call to clearenv in api_start call.

2013-02-19 Thread Serge Hallyn
Ok, took a look, what happened was the clearenv calls used to be in lxc_start and lxccontainer and lxc_execute (do lxc_start() callers) themselves. I moved those into do_start(), but the calls in lxccontainer.c were never removed. They should simply be removed altogether. Trivial patch follows.

[lxc-devel] [PATCH] Add example hooks from Ubuntu package

2013-02-19 Thread Stéphane Graber
We've been shipping those two hooks for a while in Ubuntu. Yesterday I reworked them to use the new environment variables and avoid hardcoding any path that we have available as a variable. I tested both to work on Ubuntu 13.04 but they should work just as well on any distro shipping with the

Re: [lxc-devel] [PATCH] remove redundant, too-early call to clearenv in api_start call.

2013-02-19 Thread Stéphane Graber
On 02/19/2013 03:39 PM, Serge Hallyn wrote: Ok, took a look, what happened was the clearenv calls used to be in lxc_start and lxccontainer and lxc_execute (do lxc_start() callers) themselves. I moved those into do_start(), but the calls in lxccontainer.c were never removed. They should

Re: [lxc-devel] [PATCH] Add example hooks from Ubuntu package

2013-02-19 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): We've been shipping those two hooks for a while in Ubuntu. Yesterday I reworked them to use the new environment variables and avoid hardcoding any path that we have available as a variable. I tested both to work on Ubuntu 13.04 but they should