[lxc-devel] [PATCH 0/2] Template update for Oneiric and armel

2011-05-24 Thread Stéphane Graber
Some small template changes to add Oneiric and fix armel support. Stéphane Graber (2): Convert all Debian (and derivative) templates from using 'arch' to using 'dpkg --print-architecture' as debootstrap does Add initial oneiric template .gitignore|1 + configure.ac

[lxc-devel] [PATCH 1/2] Convert all Debian (and derivative) templates from using 'arch' to using 'dpkg --print-architecture' as debootstrap does

2011-05-24 Thread Stéphane Graber
--- templates/lxc-debian.in |9 + templates/lxc-lenny.in|9 + templates/lxc-lucid.in|9 + templates/lxc-maverick.in |9 + templates/lxc-natty.in|9 + 5 files changed, 5 insertions(+), 40 deletions(-) diff --git

[lxc-devel] [PATCH 2/2] Add initial oneiric template

2011-05-24 Thread Stéphane Graber
--- .gitignore |1 + configure.ac |1 + templates/Makefile.am|1 + templates/lxc-oneiric.in | 285 ++ 4 files changed, 288 insertions(+), 0 deletions(-) create mode 100644 templates/lxc-oneiric.in diff --git

Re: [lxc-devel] security of mounting sysfs in LXC container?

2012-05-15 Thread Stéphane Graber
and we can only mitigate the issue by using apparmor or selinux (we can't know for a fact that we didn't miss something in the profile, so can't assume it to be safe). - -- Stéphane Graber Ubuntu developer http://www.ubuntu.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux

[lxc-devel] [PATCH] Always close all inherited fds and drop --close-all-fds

2012-05-24 Thread Stéphane Graber
it makes sense to do away with that option and just make it the default. Stéphane Graber (1): Remove --close-all-fds (-C) from lxc-start and always close any inherited fd. doc/lxc-start.sgml.in | 15 --- src/lxc/arguments.h |3 --- src/lxc/conf.h|1 - src/lxc

[lxc-devel] [PATCH] Remove --close-all-fds (-C) from lxc-start and always close any inherited fd.

2012-05-24 Thread Stéphane Graber
This changes the default behaviour from complaining about it but not closing the inherited fds to logging an INFO entry and closing them automatically. That's the same as always calling lxc-start with --close-all-fds. Signed-off-by: Stéphane Graber stgra...@ubuntu.com Cc: Daniel Lezcano

[lxc-devel] Getting some hooks into the container configuration

2012-05-24 Thread Stéphane Graber
they wouldn't work as mount hooks). These would be configurable in the container as: lxc.hook.HOOK = PATH Does that sound good to everyone? Are there other hooks we should make sure we implement? Anything else I missed? Thanks -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc

Re: [lxc-devel] Getting some hooks into the container configuration

2012-05-25 Thread Stéphane Graber
but without calling the stop, umount or post-stop hooks. (I'm mostly looking at http://download.openvz.org/doc/OpenVZ-Users-Guide.pdf in the OpenVZ Action Scripts section) -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] Shutting down containers properly

2012-05-25 Thread Stéphane Graber
branch yet but I poked Serge about it on IRC so it should be pushed soon. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Live Security Virtual Conference

Re: [lxc-devel] Please make -f mandatory in lxc-create

2012-05-28 Thread Stéphane Graber
-n foo -f foo.cfg. At least in Ubuntu -f isn't mandatory because calling lxc-create without it will simply default to a system wide configuration in /etc/lxc/lxc.conf. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] Please make -f mandatory in lxc-create

2012-05-28 Thread Stéphane Graber
On 05/28/2012 06:29 PM, richard -rw- weinberger wrote: On Tue, May 29, 2012 at 12:06 AM, Stéphane Graber stgra...@ubuntu.com wrote: At least in Ubuntu -f isn't mandatory because calling lxc-create without it will simply default to a system wide configuration in /etc/lxc/lxc.conf

Re: [lxc-devel] Does lxc support unionfs ?

2012-06-05 Thread Stéphane Graber
on tmpfs using overlayfs/aufs. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Live Security Virtual Conference Exclusive live event will cover all

Re: [lxc-devel] liblxc api

2012-06-09 Thread Stéphane Graber
be expected from any public library). I'm currently testing it using Serge's branch and I'm already working on the python binding using the not yet stable liblxc but I'm expecting both the python module API and liblxc ABI to be stable before they land in any upstream release. -- Stéphane Graber Ubuntu

Re: [lxc-devel] lxc-unshare default behavior

2012-06-11 Thread Stéphane Graber
]; Objections? -serge Sounds good to me. +1 -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Live Security Virtual Conference Exclusive live event

Re: [lxc-devel] Closing all fds by default

2012-06-12 Thread Stéphane Graber
Well, the easiest way to achieve that with LXC is simply to bind mount a socket into the container. Just create a socket outside of the container, add it to the container's fstab and make sure the file exists in the container, and you're done. -- Stéphane Graber Ubuntu developer http

Re: [lxc-devel] [PATCH 1/1] Fix lxc's handling of CAP_LAST_CAP (v2)

2012-06-29 Thread Stéphane Graber
); Acked-by: Stéphane Graber stgra...@ubuntu.com -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Live Security Virtual Conference Exclusive live event

Re: [lxc-devel] set shmmax for container in lxc-execute

2012-07-05 Thread Stéphane Graber
but lxc currently doesn't have any support for it, so it's unlikely to be the problem. Maybe something is dropping some capabilities that are preventing you from changing these limits? -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital

Re: [lxc-devel] [PATCH 1/3] lxc-doc-synopsis-args

2012-09-10 Thread Stéphane Graber
failing because of some of the other changes we have in there (lxc-attach improvements being the first conflict). Any chance you can update this change to apply to the staging branch? https://github.com/lxc/lxc Thanks -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc

Re: [lxc-devel] [PATCH 3/3] lxc-rpm-build

2012-09-10 Thread Stéphane Graber
On 12-09-10 01:26 PM, Dwight Engen wrote: On Mon, 10 Sep 2012 10:36:17 -0400 Stéphane Graber stgra...@ubuntu.com wrote: On 12-09-10 10:28 AM, Dwight Engen wrote: Expand variables to get correct paths in man pages and fix building of rpm by non-root user. Include templates in rpm, fix rpm

Re: [lxc-devel] [PATCH 1/2] fix gcc error: typedef redefinition (against git staging)

2012-09-10 Thread Stéphane Graber
to staging branch. Thanks. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Live Security Virtual Conference Exclusive live event will cover all the ways

Re: [lxc-devel] [PATCH 1/3] lxc-doc-synopsis-args

2012-09-10 Thread Stéphane Graber
On 12-09-10 04:49 PM, Dwight Engen wrote: On Mon, 10 Sep 2012 11:10:24 -0400 Stéphane Graber stgra...@ubuntu.com wrote: [...] I briefly tried applying this to the staging branch but it's failing because of some of the other changes we have in there (lxc-attach improvements being the first

Re: [lxc-devel] lxc staging branch on github

2012-09-10 Thread Stéphane Graber
On 12-09-07 04:47 PM, Stéphane Graber wrote: Hello everyone, As you probably noticed Serge and I have been trying to keep up with all the changes going to the lxc-users and lxc-devel mailing lists with some varying success. For quite a while now Serge has been maintaining a separate git

Re: [lxc-devel] [PATCH 3/3] lxc-rpm-build

2012-09-11 Thread Stéphane Graber
On 12-09-11 02:30 PM, Dwight Engen wrote: On Mon, 10 Sep 2012 13:53:50 -0400 Stéphane Graber stgra...@ubuntu.com wrote: [...] The reason I changed them to expand was so the docs would be right (they had SUBST paths with ${var} still in them) but obviously I don't want to break code just

Re: [lxc-devel] [PATCH 3/3] lxc-rpm-build

2012-09-11 Thread Stéphane Graber
On 12-09-11 05:06 PM, Dwight Engen wrote: On Tue, 11 Sep 2012 14:30:22 -0400 Dwight Engen dwight.en...@oracle.com wrote: On Mon, 10 Sep 2012 13:53:50 -0400 Stéphane Graber stgra...@ubuntu.com wrote: [...] The reason I changed them to expand was so the docs would be right (they had SUBST

Re: [lxc-devel] [PATCH] busybox: for all lib dirs create mounts only if directories exist

2012-09-12 Thread Stéphane Graber
Thanks for your contribution -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Live Security Virtual Conference Exclusive live event will cover all

Re: [lxc-devel] [PATCH] Add mechanism for container to notify host about end of boot

2012-09-13 Thread Stéphane Graber
and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane -- Stéphane Graber Ubuntu

Re: [lxc-devel] [PATCH] Add mechanism for container to notify host about end of boot

2012-09-13 Thread Stéphane Graber
-- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat

Re: [lxc-devel] [PATCH] Add mechanism for container to notify host about end of boot

2012-09-19 Thread Stéphane Graber
'status NEWSTATUS' is supported, where NEWSTATUS may be either RUNNING or STOPPING - now returns either 'OK' or 'ERR message' to the caller Regards, Christian -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] [PATCH 2/2] allow short -h and -n options to lxc-ps

2012-09-19 Thread Stéphane Graber
;; -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat

Re: [lxc-devel] [PATCH] [trivial] lxc-ls: Scan cgroup mount points from fstype and not device

2012-09-24 Thread Stéphane Graber
/mounts | cut -d ' ' -f 2) if [ -z $mountpoint ]; then continue; fi # Return the absolute path to the containers' parent cgroup Sounds reasonable. I'll push to staging later today. Thanks -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc

Re: [lxc-devel] [PATCH] [trivial] lxc-ls: Scan cgroup mount points from fstype and not device

2012-09-24 Thread Stéphane Graber
On 12-09-24 09:25 AM, Stéphane Graber wrote: On 12-09-24 05:21 AM, Christian Seiler wrote: lxc-ls --active now scans mount points that have the 'cgroup' filesystem type and not the 'cgroup' device name (which is ignored anyway and may be anything). Signed-off-by: Christian Seiler christ

Re: [lxc-devel] [PATCH] fix minor spelling error

2012-09-26 Thread Stéphane Graber
to attach to, as a pipe-separated list, e.g. replaceableNETWORK|IPC/replaceable. Allowed values are replaceableMOUNT/replaceable, replaceablePID/replaceable, replaceableUTSNAME/replaceable, replaceableIPC/replaceable, Looks good, applied to staging. Thanks -- Stéphane

Re: [lxc-devel] [PATCH] if the rootfs is a btrfs subvolume, delete it instead of rm -rf

2012-09-26 Thread Stéphane Graber
, remove it + rm -rf --one-file-system --preserve-root $rootdev + fi fi fi Looks good, applied to staging. Thanks -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] [PATCH] handle clone of btrfs snapshots

2012-09-26 Thread Stéphane Graber
/ echo lxc.rootfs = $rootfs $lxc_path/$lxc_new/config if [ $container_running = True ]; then lxc-unfreeze -n $lxc_orig -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] [PATCH] handle clone of btrfs snapshots

2012-09-26 Thread Stéphane Graber
-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- How fast is your code

Re: [lxc-devel] [PATCH] Add Oracle Linux template

2012-10-01 Thread Stéphane Graber
+container_rootfs_configure + +echo Container : $container_rootfs +echo Template : $template_rootfs +echo Config: $cfg_dir/config +echo Network : eth0 ($lxc_network_type) on $lxc_network_link -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital

Re: [lxc-devel] [PATCH] display warning when yum missing in fedora template

2012-10-05 Thread Stéphane Graber
Looks good, applied to staging. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Don't let slow site performance ruin your business. Deploy New Relic

[lxc-devel] Pull request bugfix branch

2012-10-31 Thread Stéphane Graber
of default user templates: mount devtmpfs in ubuntu containers revert devtmpfs in ubuntu templates replace HOOK define with proper code. Stuart Yoder (1): busybox: for all lib dirs create mounts only if directories exist Stéphane Graber (17): Fix lxc-ubuntu and lxc-ubuntu

Re: [lxc-devel] [PATCH 3/3] lxc: include sched.h to have a declaration of clone().

2012-11-11 Thread Stéphane Graber
. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite

[lxc-devel] staging branch has been rebased

2012-11-12 Thread Stéphane Graber
. I'm expecting automated builds for Ubuntu to start again a bit later today. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Monitor your physical

Re: [lxc-devel] [PATCH] ensure btrfs subvolume is removed when container creating fails

2012-11-14 Thread Stéphane Graber
-by: Serge E. Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com And applied to staging branch. -- Frederic Crozat fcro...@suse.com SUSE From 028d1b3eb110229113dc99f3587fac1f9fca9b0e Mon Sep 17 00:00:00 2001 From: Frederic Crozat fcro...@suse.com Date: Wed, 14 Nov

Re: [lxc-devel] [PATCH v2] lxc-start: add option -p, --pidfile=FILE

2012-11-15 Thread Stéphane Graber
. Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com Applied to staging with an extra commit changing the error message to Serge's suggested one. Only one comment below --- Changes v1 - v2: - allow use --pidfile without --daemon - update the doc to reflect the above

Re: [lxc-devel] [PATCH] lxc-create: use posix shell instead of bash

2012-11-21 Thread Stéphane Graber
is empty looks good to me, thanks. Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com And pushed to staging. Thanks! Signed-off-by: Natanael Copa nc...@alpinelinux.org --- I have tested it with 'lxc-create -t debian ...' with busybox as /bin/sh

[lxc-devel] [PATCH] Rewrite lxc-ls in python

2012-11-21 Thread Stéphane Graber
with the following fields: - name - state - ipv4 - ipv6 - pid of init Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- .gitignore | 1 - configure.ac| 1 - doc/lxc-ls.sgml.in | 150 ++--- src/lxc/Makefile.am | 2 +- src/lxc/lxc-ls

Re: [lxc-devel] [PATCH] Rewrite lxc-ls in python

2012-11-21 Thread Stéphane Graber
On 11/21/2012 06:04 PM, Stéphane Graber wrote: This rewrite is mostly compatible with the shell version. --active and -1 still work and behave as they used to. This adds --running, --stopped and --frozen as state filters. A new fancy view is also implemented (can be used with --fancy

Re: [lxc-devel] [PATCH] lxc-create: fix passing over first argument to template script

2012-11-22 Thread Stéphane Graber
like local isn't posix shell according to a bit of googling. That's when running under Ubuntu and Debian's default shell, dash. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] [PATCH] Rewrite lxc-ls in python

2012-11-22 Thread Stéphane Graber
On 11/22/2012 08:39 AM, Natanael Copa wrote: On Wed, 21 Nov 2012 18:04:03 -0500 Stéphane Graber stgra...@ubuntu.com wrote: This rewrite is mostly compatible with the shell version. --active and -1 still work and behave as they used to. Does this mean that python will be a requirement

[lxc-devel] [PATCH 2/2] python: Add new lxc-device tool

2012-11-22 Thread Stéphane Graber
Add a new lxc-device tool which uses the new add_device() function of the python API and lets you add a new device node to a running container. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/Makefile.am | 1 + src/lxc/lxc-device | 59

[lxc-devel] [PATCH 1/2] python: Add add_device() function

2012-11-22 Thread Stéphane Graber
in the container. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/python-lxc/lxc/__init__.py | 61 ++ 1 file changed, 61 insertions(+) diff --git a/src/python-lxc/lxc/__init__.py b/src/python-lxc/lxc/__init__.py index 4da3d41..c572e10 100644

Re: [lxc-devel] [PATCH 1/2] python: Add add_device() function

2012-11-23 Thread Stéphane Graber
On 11/23/2012 10:39 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): This introduces a new add_devices() call to the python API. Parameters: - path = Mandatory, path to a character or block device on the host - destpath = Optional, alternative path inside

Re: [lxc-devel] [PATCH] lxc-create: do not use 'local'

2012-11-26 Thread Stéphane Graber
On 11/26/2012 06:00 AM, Natanael Copa wrote: Apparently 'local' is not POSIX. Don't use it. Signed-off-by: Natanael Copa nc...@alpinelinux.org Acked-by: Stéphane Graber stgra...@ubuntu.com Applied to staging branch. Thanks. --- src/lxc/lxc-create.in | 7 +++ 1 file changed, 3

Re: [lxc-devel] [PATCH] lxc-create: fix passing over first argument to template script

2012-11-26 Thread Stéphane Graber
break;; -?) usage_err unknown option '$opt' Acked-by: Stéphane Graber stgra...@ubuntu.com Applied to staging branch. Thanks. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] [PATCH 1/2] python: Add add_device() function

2012-11-26 Thread Stéphane Graber
On 11/23/2012 03:19 PM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): The cgroup tweaking should be done using generic code. Maybe it's time to add those to the c api... Totally agreed, I was actually going to nag you again this cycle about getting a set_cgroup_item

Re: [lxc-devel] [PATCH] Add lxc.autodev (v2)

2012-11-26 Thread Stéphane Graber
than autodev. Changelog: Don't error out if we couldn't mknod a /dev/ttyN. Changelog: Describe the option in lxc.conf manpage. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com I'll push the fix I highlighted below too. This change is now

[lxc-devel] [PATCH 2/3] python: Use builtin len() function for network interfaces

2012-11-26 Thread Stéphane Graber
Use our own len() function for network interfaces as doing len(container.get_config_item(lxc.network)) will fail when the list is empty. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/python-lxc/lxc/__init__.py | 14 +- 1 file changed, 9 insertions(+), 5 deletions

Re: [lxc-devel] [PATCH] Fix checkconfig to handle kernel memory cgroup name change

2012-11-26 Thread Stéphane Graber
-by: Stéphane Graber stgra...@ubuntu.com Pushed to staging. Thanks. --- src/lxc/lxc-checkconfig.in | 25 +++-- 1 files changed, 15 insertions(+), 10 deletions(-) diff --git a/src/lxc/lxc-checkconfig.in b/src/lxc/lxc-checkconfig.in index 8c2b5e5..8263c17 100644 --- a/src

Re: [lxc-devel] [PATCH] Fix fd leak in lxc log

2012-11-26 Thread Stéphane Graber
or applications! http://p.sf.net/sfu/zoho_dev2dev_nov ___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description

Re: [lxc-devel] [PATCH] Free allocated configuration memory

2012-11-26 Thread Stéphane Graber
or applications! http://p.sf.net/sfu/zoho_dev2dev_nov ___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc

Re: [lxc-devel] [PATCH] lxc-info: add option -t, --state-is=STATE to test for a given test

2012-11-26 Thread Stéphane Graber
. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov ___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer

Re: [lxc-devel] [PATCH 1/1] fix lxc-ubuntu-cloud option parsing bugs

2012-11-26 Thread Stéphane Graber
On 11/26/2012 03:08 PM, Serge Hallyn wrote: The -u shortopt matching --userdata was not specified, and when -L is found shift should have been by 1 not 2 since there is no optarg. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com Pushed

Re: [lxc-devel] [PATCH v2] lxc-version: use POSIX shell instead of bash

2012-11-27 Thread Stéphane Graber
-version.in @@ -1,3 +1,3 @@ -#!/bin/bash +#!/bin/sh echo lxc version: @PACKAGE_VERSION@ -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Monitor your

Re: [lxc-devel] [PATCH v2] lxc-checkconfig: use POSIX shell instead of bash

2012-11-27 Thread Stéphane Graber
can check its configuration -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Monitor your physical, virtual and cloud infrastructure from a single web

Re: [lxc-devel] [PATCH] Use autoconf LXCPATH instead of hardcoded LXCDIR

2012-11-27 Thread Stéphane Graber
. Acked-by: Stéphane Graber stgra...@ubuntu.com And pushed to staging. --- src/lxc/lxccontainer.c |6 +++--- src/lxc/lxccontainer.h |1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c index ed2c483..cc91e05 100644

Re: [lxc-devel] [PATCH] Make config api items const

2012-11-27 Thread Stéphane Graber
and lxcapi_create to match that of execv(3). Signed-off-by: Dwight Engen dwight.en...@oracle.com Thanks. Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com And applied to staging. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] [PATCH] Oracle template: make container also boot under libvirt

2012-11-27 Thread Stéphane Graber
On 11/27/2012 11:07 AM, Dwight Engen wrote: This allows containers created with lxc-create to also boot under libvirt/Virtual Machine Monitor Signed-off-by: Dwight Engen dwight.en...@oracle.com Acked-by: Stéphane Graber stgra...@ubuntu.com Applied to staging. Thanks! --- templates/lxc

[lxc-devel] [PATCH 4/4] lxc-ubuntu: Fix mixed indent

2012-11-28 Thread Stéphane Graber
Replace all remaining tabs by 8 spaces, to properly indent by 4 spaces. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-ubuntu | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/templates/lxc-ubuntu b/templates/lxc-ubuntu index ce1e065

[lxc-devel] [PATCH 1/4] lxc-ubuntu: Always create the needed locales

2012-11-28 Thread Stéphane Graber
Move some old code from the trim() function into the main configure_ubuntu function so that we always create a locale in the container. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-ubuntu.in | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff

Re: [lxc-devel] [PATCH 2/4] lxc-ubuntu: Guess a list of langpacks to install

2012-11-29 Thread Stéphane Graber
On 11/29/2012 09:49 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): In addition to creating the current locale in the container, also try to scan the host and extra the list of langpacks installed there, then pass that list to debootstrap as additional packages

Re: [lxc-devel] [PATCH] Fix busybox template to not have extra aa_profile hunk

2012-11-29 Thread Stéphane Graber
Engen dwight.en...@oracle.com Looks like something went wrong with the last rebase. Acked-by: Stéphane Graber stgra...@ubuntu.com Pushed to staging. Thanks --- templates/lxc-busybox.in |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/templates/lxc-busybox.in b

Re: [lxc-devel] [PATCH 2/4] lxc-ubuntu: Guess a list of langpacks to install

2012-11-29 Thread Stéphane Graber
On 11/29/2012 10:18 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On 11/29/2012 09:49 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): In addition to creating the current locale in the container, also try to scan the host and extra the list

Re: [lxc-devel] [PATCH] Fix build with --enable-tests on Fedora

2012-11-29 Thread Stéphane Graber
. Signed-off-by: Dwight Engen dwight.en...@oracle.com Drat, sounds like there's a bug in sem_getvalue(3) manpage, which says Link with -lrt or -pthread. Thanks. Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com Applied to staging. Thanks

Re: [lxc-devel] [PATCH 1/1] Description: run MAKEDEV console when doing lxc.autodev

2012-11-29 Thread Stéphane Graber
exactly what log entry type we have ;)) Anyway. Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/conf.c | 153 +++- 1 file changed, 106 insertions(+), 47 deletions(-) diff --git a/src/lxc/conf.c b/src/lxc/conf.c index eb0c07e

Re: [lxc-devel] [PATCH] Include lxc-ubuntu when doing make dist

2012-11-29 Thread Stéphane Graber
should remember to test make dist. I only tried a make install and as it worked here, I assumed that the change was correct. Is it the only file that's included in make install but not in make dist? (just wondering if I made that mistake somewhere else :)). Acked-by: Stéphane Graber stgra

[lxc-devel] API wishlist

2012-11-29 Thread Stéphane Graber
in the API so we can rebase the tools on the API and make things a bit more consistent. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Keep yourself connected

Re: [lxc-devel] API wishlist

2012-11-29 Thread Stéphane Graber
On 11/29/2012 02:42 PM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): So, I've been thinking a bit about what functions we're currently missing in the API which would make the bindings and scripts much easier. So far, I've been thinking of: - get_cgroup_item(cgroup, key

[lxc-devel] [PATCH] lxc-create: Store template information in config

2012-11-29 Thread Stéphane Graber
Change lxc-create to add the name of the template and any parameters to the container's configuration. This makes it easier to debug and figure out exactly how a container was built. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-create.in | 9 - 1 file changed, 8

Re: [lxc-devel] [PATCH] lxc-create: Store template information in config

2012-11-30 Thread Stéphane Graber
On 11/30/2012 08:56 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): Change lxc-create to add the name of the template and any parameters to the container's configuration. This makes it easier to debug and figure out exactly how a container was built. Signed-off

Re: [lxc-devel] [PATCH] Use LXCPATH and LOCALSTATEDIR instead of hardcoded /var

2012-11-30 Thread Stéphane Graber
/lxc-ubucloud +) 200@LOCALSTATEDIR@/lock/subsys/lxc-ubucloud copy_configuration $path $rootfs $name $arch $release -- Stéphane Graber -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] [PATCH] Create busybox commands as symlinks instead of hardlinks

2012-11-30 Thread Stéphane Graber
of a hardcoded list in the template. Also set the root password to root, to match what other templates do. Signed-off-by: Dwight Engen dwight.en...@oracle.com Looks good, thanks. Acked-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-busybox.in | 49

Re: [lxc-devel] [PATCHv2] lxc-create: Store template information in config

2012-11-30 Thread Stéphane Graber
On 11/30/2012 05:23 PM, Natanael Copa wrote: On Fri, 30 Nov 2012 17:01:59 -0500 Stéphane Graber stgra...@ubuntu.com wrote: Change lxc-create to add the name of the template, checksum and any parameters to the container's configuration. This makes it easier to debug and figure out exactly

[lxc-devel] [PATCH] lxc-create: Script cleanup

2012-12-03 Thread Stéphane Graber
- Removes the mixed tabs/spaces, replacing by standard 4 spaces indent. - Fix a bunch of bashisms. - Use shell syntax for and/or in if statements instead of the test syntax. - Improve block spacing a bit. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-create.in | 175

Re: [lxc-devel] [PATCH RFC] lxc_conf logfile and loglevel support

2012-12-04 Thread Stéphane Graber
it but the code matches what I think we should be doing. Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/conf.c |3 +++ src/lxc/conf.h |3 +++ src/lxc/confile.c | 58 +++- src/lxc/log.c | 38

[lxc-devel] [PATCH] Install legacy scripts when built without python.

2012-12-04 Thread Stéphane Graber
Re-introduce the old lxc-ls script and manpage under a new legacy sub-directory. Those will be installed in place of their python equivalent when LXC is built without --enable-python. Any other script ported to python should be added to those lists. Signed-off-by: Stéphane Graber stgra

Re: [lxc-devel] [PATCH] Rewrite lxc-ls in python

2012-12-04 Thread Stéphane Graber
On 12/03/2012 09:01 PM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): This rewrite is mostly compatible with the shell version. --active and -1 still work and behave as they used to. This adds --running, --stopped and --frozen as state filters. A new fancy view is also

Re: [lxc-devel] [PATCH] Install legacy scripts when built without python.

2012-12-04 Thread Stéphane Graber
On 12/04/2012 12:35 PM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): Re-introduce the old lxc-ls script and manpage under a new legacy sub-directory. Those will be installed in place of their python equivalent when LXC is built without --enable-python. Any other

Re: [lxc-devel] [PATCH] rename physical nics at shutdown

2012-12-04 Thread Stéphane Graber
://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1086244 Reported-by: Avijit Ghosh avijit.gh...@aricent.com Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Just one comment below, but looks good. Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/conf.c| 28

[lxc-devel] [PATCH 3/3] lxc-device: Show an error message when non-root

2012-12-04 Thread Stéphane Graber
Instead of returning a python stacktrace, check what the current euid is and show an argparse error message similar to that used in lxc-start-ephemeral. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-device | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/lxc/lxc

[lxc-devel] [PATCH 2/3] lxc-ls: Show a simple error message when non-root

2012-12-04 Thread Stéphane Graber
Instead of returning a python stacktrace, check what the current euid is and show an argparse error message similar to that used in lxc-start-ephemeral. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-ls | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/lxc/lxc-ls

[lxc-devel] [PATCH 0/3] Make python scripts deal better when non-root

2012-12-04 Thread Stéphane Graber
scripts to check whether the user is root before invoking the python module so that we can return a nicer error message to the user, suggesting the use of sudo to run the script as root. Stéphane Graber (3): lxc-start-ephemeral: Use argparse errors lxc-ls: Show a simple error message when non-root

[lxc-devel] [PATCH 1/3] lxc-start-ephemeral: Use argparse errors

2012-12-04 Thread Stéphane Graber
Use argparse's error function instead of our own print + exit. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-start-ephemeral.in | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/lxc/lxc-start-ephemeral.in b/src/lxc/lxc-start-ephemeral.in

[lxc-devel] [PATCH] python: Update to the device related functions

2012-12-04 Thread Stéphane Graber
setup to better cope with variable number of arguments - Add support for network devices (currently auto-detected) - Support for different names on the host and in the container Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-device | 48

[lxc-devel] [PATCH] lxc-ls: Update code to allow non-root listing

2012-12-04 Thread Stéphane Graber
-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-ls | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/src/lxc/lxc-ls b/src/lxc/lxc-ls index 2ad1f7f..98b7861 100644 --- a/src/lxc/lxc-ls +++ b/src/lxc/lxc-ls @@ -116,12 +116,6

Re: [lxc-devel] [PATCH v2] Use LXCPATH and LOCALSTATEDIR instead of hardcoded /var

2012-12-05 Thread Stéphane Graber
On 12/05/2012 12:33 PM, Dwight Engen wrote: Signed-off-by: Dwight Engen dwight.en...@oracle.com Acked-by: Stéphane Graber stgra...@ubuntu.com And applied to staging, thanks! I also noticed that lxc-archlinux.in was missing similar changes so I did the same changes there and pushed that commit

Re: [lxc-devel] [PATCH] make install should create /var/cache/lxc directory

2012-12-05 Thread Stéphane Graber
On 12/05/2012 03:05 PM, Dwight Engen wrote: On Thu, 29 Nov 2012 16:37:21 -0500 Stéphane Graber stgra...@ubuntu.com wrote: On 11/29/2012 04:24 PM, Dwight Engen wrote: The $LXCPATH (default /var/lib/lxc) directory was not being created by make install, so unless it gets created by some other

[lxc-devel] [PATCH 2/4] Minor documentation updates

2012-12-05 Thread Stéphane Graber
- Update COPYING to the current copy of the LPGL-2.1 license from common-licences (only difference is some indentation). - Remove mixed tabs/spaces in CONTRIBUTING - Make INSTALL fit on 79 cols. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- CONTRIBUTING | 7 +++ COPYING

[lxc-devel] [PATCH 1/4] Update README

2012-12-05 Thread Stéphane Graber
This adds a section about the staging branch to the README and updates the list of supported architectures. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- README | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/README b/README index b81e7a9..d7dacfd 100644

Re: [lxc-devel] oracle template: fixes when using fedora host

2012-12-05 Thread Stéphane Graber
-by: Stéphane Graber stgra...@ubuntu.com Looks like my tab/space consistency patch will need a bit of updating when applying to account for this change, but that's easy enough to do. Applied to staging. --- templates/lxc-oracle.in | 28 +++- 1 files changed, 23

[lxc-devel] [PATCH 2/4] lxc-archlinux: Don't hardcode /var/lib/lxc in help

2012-12-05 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-archlinux.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/lxc-archlinux.in b/templates/lxc-archlinux.in index 5db5b85..cf274d4 100644 --- a/templates/lxc-archlinux.in +++ b/templates/lxc

[lxc-devel] [PATCH 3/4] templates: Consistent use of locking

2012-12-05 Thread Stéphane Graber
Move to per-template lock (except for oracle that's per-container). Also ensure that the path used for the lock is relative to LOCALSTATEDIR. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-altlinux.in | 4 ++-- templates/lxc-debian.in | 4 ++-- templates/lxc

[lxc-devel] [PATCH 1/4] lxc-ubuntu: Don't hardcode path to cache

2012-12-05 Thread Stéphane Graber
Use LOCALSTATEDIR to generate the path to the cache. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac| 1 + templates/lxc-ubuntu| 729 templates/lxc-ubuntu.in | 729

  1   2   3   4   5   6   >