Re: [Lynx-dev] Fixing some warnings.

2017-06-06 Thread Juan Manuel Guerrero
Am 06.06.2017 02:15, schrieb Thomas Dickey: On Mon, Jun 05, 2017 at 10:45:36PM +0200, Juan Manuel Guerrero wrote: While I was checking the DJGPP code I have submitted, I have found certain warnings/issues that I have tried to fix. See patch below; it is only a suggestion. thanks (will review

[Lynx-dev] Fixing some warnings.

2017-06-05 Thread Juan Manuel Guerrero
While I was checking the DJGPP code I have submitted, I have found certain warnings/issues that I have tried to fix. See patch below; it is only a suggestion. Regards, Juan M. Guerrero 2017-06-05 Juan Manuel Guerrero <juan.guerr...@gmx.de> * src/GridText.c (ALLOC_IN_POOL

[Lynx-dev] Proposal of DJGPP specific improvements.

2017-06-05 Thread Juan Manuel Guerrero
some minor adjustments to this code was necessary. If there is any interest in the changes proposed and there are suggestions, objection or comments related to this, please contact me. The patch is based on lynx2.8.9dev.14.tar.bz2. Kind regards, Juan M. Guerrero 2017-06-05 Juan Manuel Guerrero &

Re: [Lynx-dev] Small patches for lynx2.8.9dev.16

2017-08-27 Thread Juan Manuel Guerrero
lynx.patch_for_289dev16-3 discribes a really serious issue but not only for windows but also for all other DOS like file systems too, thus I would suggest something like the small fix shown below. It shows a modification of the original patch. It is is a classical bug produced when the coding

Re: [Lynx-dev] Small patches for lynx2.8.9dev.16

2017-08-28 Thread Juan Manuel Guerrero
Am 28.08.2017 18:00, schrieb Takeshi Hataguchi: Thanks for your useful comment. I agree with your comment regarding DOS like file systems. bug produced when the coding is posix centric. It remains unclear to me why stat is used instead of access. Something like: access(dst, F_OK) != 0 is

Re: [Lynx-dev] Small patches for lynx2.8.9dev.16

2017-08-29 Thread Juan Manuel Guerrero
Am 29.08.2017 06:51, schrieb patak...@users.sourceforge.jp: The issue is that resize_term_WinPDC is compiled also by some compilers that are not windows compilers. I would suggest a small modification like the patch below. After this change everthing compiled and worked flawlessly for me.

Re: [Lynx-dev] LYMain.c fails to compile if USE_PERSISTENT_COOKIES is undefined.

2018-07-14 Thread Juan Manuel Guerrero
Am 11.07.2018 22:17, schrieb Thorsten Glaser: [snip] Also, consider something like this: #ifdef USE_PERSISTENT_COOKIES if (LYCookieFile != 0&& LYCookieSaveFile != 0) #else if (0) #endif { [snip] If we assume that "if (0)" is the right choice instead of omitting the

[Lynx-dev] LYMain.c fails to compile if USE_PERSISTENT_COOKIES is undefined.

2018-07-11 Thread Juan Manuel Guerrero
I have tried to compile lynx with djgpp. This fails because the macro USE_PERSISTENT_COOKIES is undefined. The compilation of LYMain.c fails at line 2364 because LYCookieFile and LYCookieSaveFile are used in the if-clause when they are not defined at all in the case that USE_PERSISTENT_COOKIES