[LyX/master] Do not dereference getFormat() if it is null

2020-06-18 Thread Jean-Marc Lasgouttes
commit c42776868db7eb13deb5d2c16d3e6a2b047318e7 Author: Jean-Marc Lasgouttes Date: Thu Jun 18 11:39:45 2020 +0200 Do not dereference getFormat() if it is null Return early when format is unknown. I am not sure whether this is supposed to happen and whether we should assert

[LyX/master] Initialize properly Counter::saved_value_ member

2020-06-18 Thread Jean-Marc Lasgouttes
commit 48d164ddef14bb75ed80d5dc531488a09a93299c Author: Jean-Marc Lasgouttes Date: Thu Jun 18 11:23:26 2020 +0200 Initialize properly Counter::saved_value_ member Spotted by coverity. --- src/Counters.cpp |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[LyX/master] Pass BufferParams by address

2020-06-18 Thread Jean-Marc Lasgouttes
commit 5aadf0879f0cb1811bb4333aecc294d408615c56 Author: Jean-Marc Lasgouttes Date: Thu Jun 18 11:17:32 2020 +0200 Pass BufferParams by address Spotted by coverity. Note that this probably fixes a bug in getTokenValue(), where an author was added to the BufferParams

[LyX/2.3.x] Fixup d207e85c: paint sublabel with the correct background color

2020-06-07 Thread Jean-Marc Lasgouttes
commit f01c23bd5a6c0adcd0bb9238112c3303d1adbc96 Author: Jean-Marc Lasgouttes Date: Mon Feb 24 10:37:14 2020 +0100 Fixup d207e85c: paint sublabel with the correct background color The above mentionned patch did paint the background of the sublabel to avoid "bold-like&qu

[LyX/master] Move BulletsModule to frontend namespace

2020-06-06 Thread Jean-Marc Lasgouttes
commit 6b221751c1adc72af1727b6072f2346a15282df0 Author: Jean-Marc Lasgouttes Date: Sun Jun 7 00:57:03 2020 +0200 Move BulletsModule to frontend namespace --- src/frontends/qt/BulletsModule.cpp |4 src/frontends/qt/BulletsModule.h |4 2 files changed, 8 insertions(+), 0

[LyX/master] Get rid of Qt resources

2020-06-06 Thread Jean-Marc Lasgouttes
commit 2d48072e664099385b2442f7166b3c57129799bb Author: Jean-Marc Lasgouttes Date: Sun Jun 7 00:57:40 2020 +0200 Get rid of Qt resources It turns out that the resources were mostly not used anyway. Removing them shrinks LyX binary by ~6MB. Only autotools have been

[LyX/master] Allow to provide explicit icons for things like command-alternative

2020-06-05 Thread Jean-Marc Lasgouttes
commit 12a9753fb527161cc25ba2a8df6166c96ceabe07 Author: Jean-Marc Lasgouttes Date: Thu May 14 16:35:51 2020 +0200 Allow to provide explicit icons for things like command-alternative The automatic icons for "command-alternative", "math-insert", "math

[LyX/master] Use combined toolbar icons for depth-(in|de)crement and outline-(in|out)

2020-06-05 Thread Jean-Marc Lasgouttes
commit b08791f7314965e3d8ff515d51ff0567d442b0bf Author: Jean-Marc Lasgouttes Date: Tue May 12 19:53:47 2020 +0200 Use combined toolbar icons for depth-(in|de)crement and outline-(in|out) The Tab binding already combines those (and more). --- lib/Makefile.am

[LyX/master] Fixup 74540c98: handle selection for label background

2020-06-05 Thread Jean-Marc Lasgouttes
commit a71b96ac426438abb4fe835d0ad000c769693421 Author: Jean-Marc Lasgouttes Date: Fri Jun 5 22:32:58 2020 +0200 Fixup 74540c98: handle selection for label background 74540c98 was a fixup of d207e85c, which avoided using inset background as inset label background

[LyX/master] Revert part of 56e012be: hardcode again "too small" preview size

2020-05-28 Thread Jean-Marc Lasgouttes
commit e06e2e24e74789356bdf73373c5abc32ead8f802 Author: Jean-Marc Lasgouttes Date: Thu May 28 20:40:30 2020 +0200 Revert part of 56e012be: hardcode again "too small" preview size It seems that the use of zoom in determining the size of the minimal value was

[LyX/master] Simplify code by using initializer lists for vectors.

2020-05-23 Thread Jean-Marc Lasgouttes
commit 8d51b3e7bb439e815bb96fa7959aa332227fab6a Author: Jean-Marc Lasgouttes Date: Sat May 23 17:10:17 2020 +0200 Simplify code by using initializer lists for vectors. { REFERENCE_NEXT, NOTE_NEXT } can be used as a value for a vector since C++11. --- src/BufferView.cpp | 25

[LyX/master] Fix first draw of auto-open inset

2020-05-23 Thread Jean-Marc Lasgouttes
commit 7761e1317eaa2c880446f05b707b03067d665681 Author: Jean-Marc Lasgouttes Date: Sat May 23 16:47:48 2020 +0200 Fix first draw of auto-open inset note-next and reference-next should trigger an update so that metrics are updated when the cursor ends up in an auto-open inset

[LyX/master] Add rtl version of outline-in/out icons

2020-05-15 Thread Jean-Marc Lasgouttes
commit 125f5d5d20100adc68b8da39a2ebb9a98f22fac2 Author: Jean-Marc Lasgouttes Date: Fri May 15 12:10:30 2020 +0200 Add rtl version of outline-in/out icons --- lib/Makefile.am|6 ++ lib/images/classic/outline-in+rtl.png | Bin 0 -> 3248 bytes lib/ima

[LyX/master] Fix missing backslashes

2020-05-15 Thread Jean-Marc Lasgouttes
commit 5cbc87f6a6301aa592ef9243cb205fcd5385f7de Author: Jean-Marc Lasgouttes Date: Fri May 15 10:34:37 2020 +0200 Fix missing backslashes --- po/ia.po |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/po/ia.po b/po/ia.po index d80e47b..dbc3988 100644 --- a/po

[LyX/master] Get rid of lyx::next uses for RandomAccessList

2020-05-14 Thread Jean-Marc Lasgouttes
commit fc5b22a2f1009538abbfb335f2afe97ef16e433a Author: Jean-Marc Lasgouttes Date: Mon May 11 12:31:25 2020 +0200 Get rid of lyx::next uses for RandomAccessList These uses are inefficient (a loop really) and require that pit_type is ptrdiff_t. Instead

[LyX/master] Revert "Get rid of lyx::next uses for RandomAccessList"

2020-05-13 Thread Jean-Marc Lasgouttes
commit c75674999127c58b5132e3ab713bd91bd88e75c6 Author: Jean-Marc Lasgouttes Date: Wed May 13 10:33:38 2020 +0200 Revert "Get rid of lyx::next uses for RandomAccessList" This is not ready (see #11861). This reverts commit 6d97e3993489a23aea79f899f156fd2f6e21cc4d

[LyX/master] Avoid a warning

2020-05-12 Thread Jean-Marc Lasgouttes
commit e52af398649d33825cd41d63db83b41d770ce88e Author: Jean-Marc Lasgouttes Date: Tue May 12 17:42:50 2020 +0200 Avoid a warning --- src/TextMetrics.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/TextMetrics.cpp b/src/TextMetrics.cpp index c92af02

[LyX/master] Get rid of lyx::next uses for RandomAccessList

2020-05-12 Thread Jean-Marc Lasgouttes
commit 6d97e3993489a23aea79f899f156fd2f6e21cc4d Author: Jean-Marc Lasgouttes Date: Mon May 11 12:31:25 2020 +0200 Get rid of lyx::next uses for RandomAccessList These uses are inefficient (a loop really) and require that pit_type is ptrdiff_t. Instead

Re: [LyX/master] Tools: recognize math font in listFontWithLang.pl

2020-05-09 Thread Jean-Marc Lasgouttes
Le 9 mai 2020 12:59:10 GMT+02:00, Kornel Benko a écrit >diff --git a/development/tools/listFontWithLang.pl >b/development/tools/listFontWithLang.pl >index 95524df..9824708 100644 >--- a/development/tools/listFontWithLang.pl >+++ b/development/tools/listFontWithLang.pl >@@ -39,6 +39,7 @@ sub

Re: [LyX/master] Revert last three commits.

2020-05-01 Thread Jean-Marc Lasgouttes
Le 26/04/2020 à 08:49, Richard Kimberly Heck a écrit : commit 7b9dc7bc9e26b26d15ca4c3e5b2d0383ea97733f Author: Richard Kimberly Heck Date: Sun Apr 26 03:08:35 2020 -0400 Revert last three commits. There are other issues here. The big one is in TextMetrics::getPitNearY,

[LyX/2.3.x] Disable deprecated-copy warning with clang10 and gcc10

2020-04-30 Thread Jean-Marc Lasgouttes
commit 7898e0741260ad0454d81d3c1bedffe46dde4526 Author: Jean-Marc Lasgouttes Date: Tue Apr 28 13:16:45 2020 +0200 Disable deprecated-copy warning with clang10 and gcc10 This was already done for gcc9 and saves tons of warnings. Note that the warning in Qt are gone

Re: [LyX/master] Avoid warnings about deprecated copy in gcc 10 too

2020-04-30 Thread Jean-Marc Lasgouttes
Le 30/04/2020 à 11:48, Jean-Marc Lasgouttes a écrit : commit db5021c42eb5828c3fa0fd786b14eafcf9fed52f Author: Jean-Marc Lasgouttes Date: Thu Apr 30 12:09:17 2020 +0200 Avoid warnings about deprecated copy in gcc 10 too Riki, do you want all the warning-related fixes in branch too

[LyX/master] Avoid warnings about deprecated copy in gcc 10 too

2020-04-30 Thread Jean-Marc Lasgouttes
commit db5021c42eb5828c3fa0fd786b14eafcf9fed52f Author: Jean-Marc Lasgouttes Date: Thu Apr 30 12:09:17 2020 +0200 Avoid warnings about deprecated copy in gcc 10 too --- config/lyxinclude.m4 |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/config/lyxinclude.m4 b

[LyX/2.3.x] Adopt a 'belt and braces' approach to bidi forcing

2020-04-29 Thread Jean-Marc Lasgouttes
commit e47834104a5d68e0e0a5141fa1824ce34ea2ae46 Author: Jean-Marc Lasgouttes Date: Mon Jan 27 18:38:21 2020 +0100 Adopt a 'belt and braces' approach to bidi forcing There are two techniques that I know of for forcing the direction of a string, regardlessly of whether its

[LyX/master] Avoid some more copies in range-based for loops

2020-04-28 Thread Jean-Marc Lasgouttes
commit 7035e230caa69a2e35f16dcf0d9696c59cef5c4c Author: Jean-Marc Lasgouttes Date: Tue Apr 28 15:28:21 2020 +0200 Avoid some more copies in range-based for loops This triggers warnings with clang++ 10. --- src/frontends/qt/Menus.cpp |4 ++-- 1 files changed, 2 insertions

[LyX/master] Do not for copies in range-based for loops.

2020-04-28 Thread Jean-Marc Lasgouttes
commit a85c48de5a15c4f70f79a53b451fbe0d083e9ece Author: Jean-Marc Lasgouttes Date: Tue Apr 28 13:27:50 2020 +0200 Do not for copies in range-based for loops. Spotted by clang++ 10. --- src/HunspellChecker.cpp |4 ++-- src/LaTeX.cpp|2 +- src/tex2lyx

[LyX/master] Disable deprecated-copy warning with clang10

2020-04-28 Thread Jean-Marc Lasgouttes
commit e9e8069b170ef3128402bc6e6f657339da1760a2 Author: Jean-Marc Lasgouttes Date: Tue Apr 28 13:16:45 2020 +0200 Disable deprecated-copy warning with clang10 This was already done for gcc9 and saves tons of warnings. Note that the warning in Qt are gone with Qt5.13, so

[LyX/master] Ignore some more files when building in source tree

2020-04-23 Thread Jean-Marc Lasgouttes
commit b9538b10d41eb693bdd92d0a775ee434e9045429 Author: Jean-Marc Lasgouttes Date: Thu Apr 23 19:17:15 2020 +0200 Ignore some more files when building in source tree --- .gitignore |1 + 3rdparty/mythes/.gitignore |1 + lib/.gitignore |6 +++--- src

[LyX/2.3.x] Fix embarassing crash caused by debug message

2020-04-17 Thread Jean-Marc Lasgouttes
commit 8bb317c8db6038dd4db391da73f94e9275356923 Author: Jean-Marc Lasgouttes Date: Mon Apr 13 12:02:26 2020 +0200 Fix embarassing crash caused by debug message After commit 6a936d63, the helpful debug message tries to display non-existing elements and crashes the program

[LyX/2.3.x] Do not try to put cursor after space if no space was kept

2020-04-17 Thread Jean-Marc Lasgouttes
commit cc5d3bd9f445e99018dc94e6dceb9c1140c09d09 Author: Jean-Marc Lasgouttes Date: Mon Apr 13 12:58:43 2020 +0200 Do not try to put cursor after space if no space was kept The logic was wrong and could cause crashes Fixes bug #11777. --- src/Text2.cpp |3 ++- status

Re: [LyX/master] Fix bug #11635

2020-04-16 Thread Jean-Marc Lasgouttes
Le 16/04/2020 à 22:56, Richard Kimberly Heck a écrit : bool LyXComm::loadFilesInOtherInstance() { + if (theFilesToLoad().size() == 0) + return true; + The following seems nicer to me: if (theFilesToLoad().empty()) return true; JMarc -- lyx-cvs

[LyX/master] Simplify code for bidi icons

2020-04-16 Thread Jean-Marc Lasgouttes
commit bb0117d182cae7da31228a03ac848f95fd77841a Author: Jean-Marc Lasgouttes Date: Thu Apr 16 19:21:54 2020 +0200 Simplify code for bidi icons Most of the RtL icons that we provide are simply mirrors of the LtR ones. Therefore let the code do that by default if no +rtl icon

[LyX/master] Revert "Add mechanism to change icons in RTL mode"

2020-04-14 Thread Jean-Marc Lasgouttes
commit ce0538e37259372aa96f8106d790f98d98d09b9b Author: Jean-Marc Lasgouttes Date: Tue Apr 14 18:30:44 2020 +0200 Revert "Add mechanism to change icons in RTL mode" This is really too clumsy. Revert in preparation for a better mechanism. This reve

[LyX/master] Reimplement properly bidi icons

2020-04-14 Thread Jean-Marc Lasgouttes
commit 43eda5ad734e20e4759a225698f8977b9e38aa80 Author: Jean-Marc Lasgouttes Date: Tue Apr 14 22:41:00 2020 +0200 Reimplement properly bidi icons When the cursor in RTL text, icons for "depth-increment" or "layout-toggle Enumerate" look wrong.

[LyX/master] Fixup 294969c6: do not forget to update metrics

2020-04-14 Thread Jean-Marc Lasgouttes
commit 543038e64e055050dfd03725f88b462571bab9f0 Author: Jean-Marc Lasgouttes Date: Tue Apr 14 17:57:49 2020 +0200 Fixup 294969c6: do not forget to update metrics --- src/BufferView.cpp |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/BufferView.cpp b

[LyX/master] Fix embarassing crash caused by debug message

2020-04-13 Thread Jean-Marc Lasgouttes
commit b5d6caac4149cc72cd5a734ffc8e9da1382bc9ee Author: Jean-Marc Lasgouttes Date: Mon Apr 13 12:02:26 2020 +0200 Fix embarassing crash caused by debug message After commit 6a936d63, the helpful debug message tries to display non-existing elements and crashes the program

Re: [LyX/master] fix distcheck

2020-04-10 Thread Jean-Marc Lasgouttes
Le 10/04/2020 à 14:08, Pavel Sanda a écrit : commit 59e84a525fe70f28e3c0f8887f9d779e641d28ed Author: Pavel Sanda Date: Fri Apr 10 14:28:59 2020 +0200 fix distcheck Thanks for doing it, I did not find time yet. JMarc -- lyx-cvs mailing list lyx-cvs@lists.lyx.org

[LyX/2.3.x] Do not compute caret geometry when we are not ready to do so.

2020-04-09 Thread Jean-Marc Lasgouttes
commit b7f6b979d0f889f08e735f35378bb20ba3788b4b Author: Jean-Marc Lasgouttes Date: Sat Apr 4 18:02:04 2020 +0200 Do not compute caret geometry when we are not ready to do so. This avoid crashes with invalid cache. Fixes bug #11763. --- src/frontends/qt4/GuiWorkArea.cpp

[LyX/master] Add automake support for dtl

2020-04-09 Thread Jean-Marc Lasgouttes
commit 2aff8937ecaeb96f0ead93536e527599444a6aa2 Author: Jean-Marc Lasgouttes Date: Thu Apr 9 12:40:00 2020 +0200 Add automake support for dtl --- 3rdparty/Makefile.am |6 +- 3rdparty/dtl/Makefile.am | 24 config/lyxinclude.m4 | 15

[LyX/master] Do not put C++-only options in AM_CPPFLAGS

2020-04-09 Thread Jean-Marc Lasgouttes
commit c3bf053dd308a97f221695ed48d26fc703f2afec Author: Jean-Marc Lasgouttes Date: Thu Apr 9 12:24:44 2020 +0200 Do not put C++-only options in AM_CPPFLAGS --- config/lyxinclude.m4 |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/config/lyxinclude.m4 b/config

[LyX/master] Do not compute caret geometry when we are not ready to do so.

2020-04-04 Thread Jean-Marc Lasgouttes
commit 5202d44ef5a9ac491651215405f4cc83a531d865 Author: Jean-Marc Lasgouttes Date: Sat Apr 4 18:10:44 2020 +0200 Do not compute caret geometry when we are not ready to do so. This avoid crashes with invalid cache. Fixes bug #11763. --- src/frontends/qt/GuiWorkArea.cpp

[LyX/2.3.x] Avoid bleeding of inset background outside of inset

2020-04-03 Thread Jean-Marc Lasgouttes
commit ee7c607b5e8e4d3bdb7e4af6058d24ed9586c705 Author: Jean-Marc Lasgouttes Date: Tue Mar 24 12:01:43 2020 +0100 Avoid bleeding of inset background outside of inset As a consequence of fix e64ea357 to ticket #10797, we draw a bit too much of the inset background outside

[LyX/master] Change tootip for Labeling layout toolbar button

2020-04-03 Thread Jean-Marc Lasgouttes
commit c8ebd2117c36a1428a4e07fa5e1eb9975fe7bcf0 Author: Jean-Marc Lasgouttes Date: Fri Apr 3 19:16:04 2020 +0200 Change tootip for Labeling layout toolbar button Labeled List sounds better that Labeling. Part of bug #11770. --- lib/ui/stdtoolbars.inc |4 ++-- 1 files

[LyX/master] Avoid bleeding of inset background outside of inset

2020-03-24 Thread Jean-Marc Lasgouttes
commit eb92f74d1f7ae63112b9439058d746f7ff93e8f4 Author: Jean-Marc Lasgouttes Date: Tue Mar 24 12:01:43 2020 +0100 Avoid bleeding of inset background outside of inset As a consequence of fix e64ea357 to ticket #10797, we draw a bit too much of the inset background outside

[LyX/master] Revert "Do not display caret when we're not ready"

2020-03-13 Thread Jean-Marc Lasgouttes
commit 7d54d78691a02b090da75da15fabc81e27552cad Author: Jean-Marc Lasgouttes Date: Fri Mar 13 16:23:01 2020 +0100 Revert "Do not display caret when we're not ready" I did not mean to push this. This reverts commit 9bc255dc89b58bfdb2d9692136b2f2715eab256b

[LyX/master] remove constructs and comments about old compilers

2020-03-13 Thread Jean-Marc Lasgouttes
commit 65e0aa767d56ffda5972a85459e8f073001e0324 Author: Jean-Marc Lasgouttes Date: Fri Mar 13 16:15:31 2020 +0100 remove constructs and comments about old compilers --- src/CutAndPaste.cpp | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src

[LyX/master] Do not display caret when we're not ready

2020-03-13 Thread Jean-Marc Lasgouttes
commit 9bc255dc89b58bfdb2d9692136b2f2715eab256b Author: Jean-Marc Lasgouttes Date: Fri Feb 28 15:21:40 2020 +0100 Do not display caret when we're not ready Using a dialog may trigger a redraw at times where the metrics caches have not been updated yet. To fix this, do

[LyX/master] Fixup cf9827df: do not forget keyboard bindings and docs

2020-03-04 Thread Jean-Marc Lasgouttes
commit 0b5ce4b5ba7a78245b87c623b83a05cfc1084030 Author: Jean-Marc Lasgouttes Date: Wed Mar 4 12:21:11 2020 +0100 Fixup cf9827df: do not forget keyboard bindings and docs Keyboard bindings are easy. For lfun icons in documentation, both the UserGuide and Tutorial have

[LyX/master] List is obsoleted by Labeling: update icons

2020-03-04 Thread Jean-Marc Lasgouttes
commit cf9827dfc149ed8eeb9d8facc65e11d2e5766f74 Author: Jean-Marc Lasgouttes Date: Wed Mar 4 11:01:31 2020 +0100 List is obsoleted by Labeling: update icons This does not change much in master but it is cleaner since the List layout has been obsolete since 2010 (7f8b868f

[LyX/master] Do not display caret when we're not ready

2020-03-03 Thread Jean-Marc Lasgouttes
commit e99436b529fc83a5a89e3ec053f977117c339082 Author: Jean-Marc Lasgouttes Date: Fri Feb 28 15:21:40 2020 +0100 Do not display caret when we're not ready Using a dialog may trigger a redraw at times where the metrics caches have not been updated yet. To fix this, do

[LyX/master] Fixup d207e85c: paint sublabel with the correct background color

2020-02-24 Thread Jean-Marc Lasgouttes
commit 74540c9896892b8f956f52258a59613af83a5cf8 Author: Jean-Marc Lasgouttes Date: Mon Feb 24 10:37:14 2020 +0100 Fixup d207e85c: paint sublabel with the correct background color The above mentionned patch did paint the background of the sublabel to avoid "bold-like&qu

[LyX/master] Make sure that spelling marks do not spill ouside of row

2020-02-22 Thread Jean-Marc Lasgouttes
commit 57b400cdffa7f0008adf5c697604e5110ea9b304 Author: Jean-Marc Lasgouttes Date: Sat Feb 22 17:59:37 2020 +0100 Make sure that spelling marks do not spill ouside of row This avoids annoying remnants of dotted red lines. Fixes bug #11755. --- src/RowPainter.cpp |9

Re: [LyX/master] Put the LyX window frontmost automatically on Mac on successful reverse search

2020-02-13 Thread Jean-Marc Lasgouttes
Le 13/02/2020 à 16:21, Stephan Witt a écrit : commit 983da7d6dea0af6658debac3cf338c4c6a3c810e Author: Stephan Witt Date: Thu Feb 13 16:38:37 2020 +0100 Put the LyX window frontmost automatically on Mac on successful reverse search while read line ; do echo

[LyX/master] Adopt a 'belt and braces' approach to bidi forcing

2020-01-27 Thread Jean-Marc Lasgouttes
commit 4d6041a7b68de5856b657cfd3b735596b3d7e0e0 Author: Jean-Marc Lasgouttes Date: Mon Jan 27 18:38:21 2020 +0100 Adopt a 'belt and braces' approach to bidi forcing There are two techniques that I know of for forcing the direction of a string, regardlessly of whether its

[LyX/master] Fix missing backspace in msgstr

2020-01-27 Thread Jean-Marc Lasgouttes
commit c5530589bb956c2f37555c002fbc70d3fcf8aca1 Author: Jean-Marc Lasgouttes Date: Mon Jan 27 15:40:40 2020 +0100 Fix missing backspace in msgstr --- po/ar.po |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/po/ar.po b/po/ar.po index fa546a3..b8827e7 100644

[LyX/master] Fix warning with --disable-nls

2020-01-27 Thread Jean-Marc Lasgouttes
commit 4f4d52e8c09d798359071590ed3624ecaa5b2b8a Author: Jean-Marc Lasgouttes Date: Mon Jan 27 15:34:27 2020 +0100 Fix warning with --disable-nls --- src/support/Messages.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/support/Messages.cpp b/src/support

[LyX/2.3.x] Avoid blinking change tracking cur for math inset.

2020-01-26 Thread Jean-Marc Lasgouttes
commit b7c098c3fafba45e0af98cfa11aeee89c367b235 Author: Jean-Marc Lasgouttes Date: Sat Jan 11 13:39:20 2020 +0100 Avoid blinking change tracking cur for math inset. Since there is a margin above and below the inset, there is no problem for putting it higher. Fixes bug

[LyX/master] Fix distcheck target

2020-01-26 Thread Jean-Marc Lasgouttes
commit 9017581ecf26c5e651ee1bccc053285a1b21ca29 Author: Jean-Marc Lasgouttes Date: Sun Jan 26 19:46:19 2020 +0100 Fix distcheck target 1/ The most annoying part was the error in po/. It turns out that reading and understanding the po/Makevars file was the key. A simple change

[LyX/master] Make graĥics and external insets tighter

2020-01-15 Thread Jean-Marc Lasgouttes
commit ba79a4b89e1dd3c3bf5fc6cf69281593e1e40356 Author: Jean-Marc Lasgouttes Date: Wed Jan 15 15:54:47 2020 +0100 Make graĥics and external insets tighter Now RenderGraphics adds offsets that depends on its parent inset. These offsets are set to 0 for InsetGraphics

[LyX/master] Fixup eeb4187a: copy-paste errors

2020-01-15 Thread Jean-Marc Lasgouttes
commit 7d3d07ff401e15a5e7c5027f717129eb728cb4be Author: Jean-Marc Lasgouttes Date: Wed Jan 15 15:19:38 2020 +0100 Fixup eeb4187a: copy-paste errors --- src/insets/InsetCollapsible.cpp |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/insets

[LyX/master] Remove some spacing above InsetColapsible when possible

2020-01-15 Thread Jean-Marc Lasgouttes
commit eeb4187a281b9a5b4bfe8a0576f80f28334b3c90 Author: Jean-Marc Lasgouttes Date: Wed Jan 15 11:12:47 2020 +0100 Remove some spacing above InsetColapsible when possible --- src/insets/InsetCollapsible.cpp | 25 + src/insets/InsetCollapsible.h |6 ++ 2

[LyX/master] Replace the hardcoded TEXT_TO_INSET_OFFSET by tunable values

2020-01-15 Thread Jean-Marc Lasgouttes
commit 0ef2c192c02dfb4578c189e68a0951280ebeea47 Author: Jean-Marc Lasgouttes Date: Mon Jan 13 22:09:06 2020 +0100 Replace the hardcoded TEXT_TO_INSET_OFFSET by tunable values The basic value is Inset::textOffset(BufferView*), which can in theory change with the BufferView zoom

[LyX/master] Make script inset much tighter in texted.

2020-01-15 Thread Jean-Marc Lasgouttes
commit 9176e60b7bcab3e355521a86ddb4c2778cd9b29e Author: Jean-Marc Lasgouttes Date: Wed Jan 15 11:08:38 2020 +0100 Make script inset much tighter in texted. We use the fact that offsets can be set separately for each inset. --- src/insets/InsetScript.h | 10 ++ 1 files

[LyX/master] Rename PainterMetrics::change_ to change

2020-01-14 Thread Jean-Marc Lasgouttes
commit a187cbeb64a9bb02d38d22f8a5249d149a224070 Author: Jean-Marc Lasgouttes Date: Tue Jan 14 11:50:44 2020 +0100 Rename PainterMetrics::change_ to change This is not a private variable. --- src/MetricsInfo.cpp |6 +++--- src/MetricsInfo.h |2

[LyX/master] Streamline RowPainter a bit

2020-01-14 Thread Jean-Marc Lasgouttes
commit 5bb9ded4d6db8de93f0a17783fc7a635559510dd Author: Jean-Marc Lasgouttes Date: Tue Jan 14 11:42:01 2020 +0100 Streamline RowPainter a bit --- src/RowPainter.cpp | 23 --- src/RowPainter.h | 13 - 2 files changed, 8 insertions(+), 28 deletions

[LyX/master] Do make changebar shorter for last row

2020-01-13 Thread Jean-Marc Lasgouttes
commit cbabff4686dd8c26383e294131243b7dbd0bc960 Author: Jean-Marc Lasgouttes Date: Mon Jan 13 17:42:31 2020 +0100 Do make changebar shorter for last row I do not know what the intent was, but it is ugly. --- src/RowPainter.cpp |6 +- 1 files changed, 1 insertions(+), 5

[LyX/master] Implement isChanged for tabular inset.

2020-01-13 Thread Jean-Marc Lasgouttes
commit 93794d6fea9845a0b6ce7227cf966906a8238215 Author: Jean-Marc Lasgouttes Date: Mon Jan 13 16:34:38 2020 +0100 Implement isChanged for tabular inset. --- src/insets/InsetTabular.cpp | 10 ++ src/insets/InsetTabular.h |2 ++ 2 files changed, 12 insertions(+), 0 deletions

[LyX/master] Only show pencil change mark when inset is collapsed

2020-01-13 Thread Jean-Marc Lasgouttes
commit b0371714a063f8e9ae81207e49bc358783185549 Author: Jean-Marc Lasgouttes Date: Mon Jan 13 15:23:32 2020 +0100 Only show pencil change mark when inset is collapsed --- src/insets/InsetCollapsible.cpp |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/insets

[LyX/master] When iterator is in a table cell, set Changed indicator for the right inset.

2020-01-13 Thread Jean-Marc Lasgouttes
commit 1baa8cdc93d123381055ff03f37b1984b2fa7e2a Author: Jean-Marc Lasgouttes Date: Mon Jan 13 15:08:50 2020 +0100 When iterator is in a table cell, set Changed indicator for the right inset. --- src/Buffer.cpp |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

[LyX/master] Fixup bf7f4d71: Let changeRefsIfUnique handle undo

2020-01-12 Thread Jean-Marc Lasgouttes
commit e340f46476000b933693772a5f3ce9d204504a0b Author: Jean-Marc Lasgouttes Date: Sun Jan 12 22:18:36 2020 +0100 Fixup bf7f4d71: Let changeRefsIfUnique handle undo This allows for a much lower memory consumption than a plain recordUnfoFullBuffer. Related to bug 6494

[LyX/master] This should not have been reverted

2020-01-12 Thread Jean-Marc Lasgouttes
commit 0f0ed8073a804a6ca0c9d71a835f012902d4cc53 Author: Jean-Marc Lasgouttes Date: Sun Jan 12 21:47:54 2020 +0100 This should not have been reverted --- lib/ui/default.ui |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/ui/default.ui b/lib/ui/default.ui index

[LyX/master] Revert "Automatically show the review toolbar if the document has tracked changes"

2020-01-12 Thread Jean-Marc Lasgouttes
commit dba1e40b520f67faeb49759b7cec9ec4f981f9a1 Author: Jean-Marc Lasgouttes Date: Sun Jan 12 18:33:01 2020 +0100 Revert "Automatically show the review toolbar if the document has tracked changes" We will replace this with a better solution For now,

[LyX/master] Reimplement computation of change tracking status

2020-01-12 Thread Jean-Marc Lasgouttes
commit 4a4ded2297ece7548aa6cbf731e9a90253cdeb63 Author: Jean-Marc Lasgouttes Date: Sun Jan 12 20:09:41 2020 +0100 Reimplement computation of change tracking status This is a reimplementation of 6d4e6aad that is both simpler and more complete. This uses

[LyX/master] Fixup b321bb1a: set changebar when inset contains changes

2020-01-12 Thread Jean-Marc Lasgouttes
commit ce950f1ea50ec1fcc3df3938cb94c20347f5b71e Author: Jean-Marc Lasgouttes Date: Sat Jan 11 21:21:34 2020 +0100 Fixup b321bb1a: set changebar when inset contains changes Add Paragraph::isChanged() and InetText::isCgchanged() which indicate the presence of a change

[LyX/master] Avoid blinking change tracking cur for math inset.

2020-01-11 Thread Jean-Marc Lasgouttes
commit bf7f4d716cf0ef148495d7ecd616a1aaea57a13d Author: Jean-Marc Lasgouttes Date: Sat Jan 11 13:39:20 2020 +0100 Avoid blinking change tracking cur for math inset. Since there is a margin above and below the inset, there is no problem for putting it higher. Fixes bug

[LyX/2.3.x] Do not check again and again for non existing files

2020-01-10 Thread Jean-Marc Lasgouttes
commit b7ec3d8515b539260a16e9c5987c4116f4d1257c Author: Jean-Marc Lasgouttes Date: Mon Dec 16 18:26:55 2019 +0100 Do not check again and again for non existing files If the file of an InsetInclude does not exist, loadIfNeeded will try again and again to look

[LyX/master] Update to boost 1.72

2020-01-09 Thread Jean-Marc Lasgouttes
commit 09130d7a6220267c78f371fb4603b843b9fd5232 Author: Jean-Marc Lasgouttes Date: Tue Jan 7 16:23:03 2020 +0100 Update to boost 1.72 This requires to add a assertion_failed_msg handler. Take this occasion to cleanup and uniformize the various boost.cpp files that we have

[LyX/master] Improve Update::FitCursor when there is a selection

2020-01-07 Thread Jean-Marc Lasgouttes
commit 294969c6a2ba456c231e52d79b4637cdd50a6a95 Author: Jean-Marc Lasgouttes Date: Mon Jan 6 17:10:38 2020 +0100 Improve Update::FitCursor when there is a selection It is better indeed to try to make the whole selection fit on screen. Fixes bug #11012. --- src

[LyX/2.3.x] Disable inset-dissolve in table cells

2019-12-30 Thread Jean-Marc Lasgouttes
commit 440271540f1d79b0c4d27a94debca10f782d9fb9 Author: Jean-Marc Lasgouttes Date: Wed Dec 4 15:56:30 2019 +0100 Disable inset-dissolve in table cells This is better than making sure that the inset has exactly one cell. In the future, inset-dissolve could be extended

[LyX/master] Do not check again and again for non existing files

2019-12-26 Thread Jean-Marc Lasgouttes
commit aeed6fb8fa35c045697fe6950c6109be8d30884c Author: Jean-Marc Lasgouttes Date: Mon Dec 16 18:26:55 2019 +0100 Do not check again and again for non existing files If the file of an InsetInclude does not exist, loadIfNeeded will try again and again to look

[LyX/master] Fixup e1be71da: do not enforce plain layout when dissolving

2019-12-06 Thread Jean-Marc Lasgouttes
commit 2e784b2f061d23f179b263d685789526e5872ea8 Author: Jean-Marc Lasgouttes Date: Fri Dec 6 10:20:18 2019 +0100 Fixup e1be71da: do not enforce plain layout when dissolving Instead of checking whether the dissolved inset enforces plain layout, it is better to check whether

[LyX/master] Disable inset-dissolve in table cells

2019-12-06 Thread Jean-Marc Lasgouttes
commit 5ac3b880075794130492c2fe63c35104b207ad73 Author: Jean-Marc Lasgouttes Date: Wed Dec 4 15:56:30 2019 +0100 Disable inset-dissolve in table cells This is better than making sure that the inset has exactly one cell. In the future, inset-dissolve could be extended

[LyX/2.3.x] Revert "Set buffer when expanding macro"

2019-11-16 Thread Jean-Marc Lasgouttes
commit 0310dcb19e884d1ce6b56feff74d3ea02334f283 Author: Jean-Marc Lasgouttes Date: Sat Nov 16 11:59:15 2019 +0100 Revert "Set buffer when expanding macro" This patch is not ready yet. Moreover, change the assertion in InsetMathGrid::colAlign to a s

[LyX/master] Add a setBuffer method to InsetArgumentProxy

2019-11-15 Thread Jean-Marc Lasgouttes
commit 49ed5b4626d0aa4c77829c7a2bb068f9b18d81e1 Author: Jean-Marc Lasgouttes Date: Fri Nov 15 20:43:00 2019 +0100 Add a setBuffer method to InsetArgumentProxy This is needed to set the buffer of default values of optional arguments. Fixes bug #11695. --- src/mathed

[LyX/2.3.x] Use backing store also with wayland platform

2019-11-07 Thread Jean-Marc Lasgouttes
commit aaf96b30250e68b5e54320aa2477f627691835a7 Author: Jean-Marc Lasgouttes Date: Sat Jul 13 16:21:37 2019 +0200 Use backing store also with wayland platform Like with macOS, the Wayland compositor seems to require a backingstore when doing partial updates like we do

[LyX/master] Constify and un-constify

2019-11-06 Thread Jean-Marc Lasgouttes
commit 2a2019d77e936e46c1ae8f49142bd1ad89aef2d3 Author: Jean-Marc Lasgouttes Date: Wed Nov 6 10:36:21 2019 +0100 Constify and un-constify --- src/Session.cpp |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Session.cpp b/src/Session.cpp index 3947883

[LyX/master] Amend 464d6262: Forgot these

2019-10-26 Thread Jean-Marc Lasgouttes
commit 69fca0df1a3b4d45f60e51bbfdafbfc18a668242 Author: Jean-Marc Lasgouttes Date: Sun Oct 27 00:17:01 2019 +0200 Amend 464d6262: Forgot these --- src/Encoding.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Encoding.h b/src/Encoding.h index 8e97b74

[LyX/master] Simplify boolean expressions

2019-10-26 Thread Jean-Marc Lasgouttes
commit 464d6262b17dfd8c8db6ca32b94ac230668cba52 Author: Jean-Marc Lasgouttes Date: Sun Oct 27 00:08:02 2019 +0200 Simplify boolean expressions Spottd by cppcheck. --- src/Encoding.h | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Encoding.h

[LyX/master] Remove some useless expressions

2019-10-26 Thread Jean-Marc Lasgouttes
commit d9edf32b67ba0256aeacfe6100790576e0fe90b5 Author: Jean-Marc Lasgouttes Date: Sun Oct 27 00:09:05 2019 +0200 Remove some useless expressions Spotted by cppcheck --- src/BiblioInfo.cpp |1 - src/BufferView.cpp |1 - src/Text3.cpp

[LyX/master] Do not use same name for members and arguments

2019-10-26 Thread Jean-Marc Lasgouttes
commit c73d397d328c219242f54441bb56a91a7b3276db Author: Jean-Marc Lasgouttes Date: Sun Oct 27 00:06:54 2019 +0200 Do not use same name for members and arguments Spotted by cppcheck. --- src/lyxfind.cpp | 18 +- 1 files changed, 9 insertions(+), 9 deletions

[LyX/master] Use unsigned values for enum

2019-10-26 Thread Jean-Marc Lasgouttes
commit 68c88bc427123a410a803a6ff34dc1478f3ce71f Author: Jean-Marc Lasgouttes Date: Sun Oct 27 00:03:55 2019 +0200 Use unsigned values for enum Otherwise 1 << 31 overflows. Spotted by cppcheck. --- src/support/debug.h

[LyX/2.3.x] Get full version of gcc

2019-10-26 Thread Jean-Marc Lasgouttes
commit f0f48232f045fe96ac5727c80a63e7e3d668814d Author: Jean-Marc Lasgouttes Date: Wed Jun 12 20:17:55 2019 +0200 Get full version of gcc Recent gcc versions return a short version with -dumpversion, e.g. 9. In this case, use -dumpfullversion, which gives something like

[LyX/2.3.x] Keep last file positions in last-use ordering

2019-10-23 Thread Jean-Marc Lasgouttes
commit a7b5aea9b68fe039fdf4f57ddfd25c2f2348765f Author: Jean-Marc Lasgouttes Date: Sun Oct 20 11:47:04 2019 +0200 Keep last file positions in last-use ordering Using a map would sort the elements in alphabetic ordering, which means that when the number of elements is larger

[LyX/2.3.x] Set buffer when expanding macro

2019-10-22 Thread Jean-Marc Lasgouttes
commit d3fd91566249b722dbc553b921283f2507ce5e17 Author: Jean-Marc Lasgouttes Date: Sun Oct 20 12:54:59 2019 +0200 Set buffer when expanding macro This avoids a crash in InsetMathSplit which uses the buffer() value. Fixes bug #11686. (cherry picked from commit

[LyX/2.3.x] Be careful before using buffer parameters in colAlign

2019-10-22 Thread Jean-Marc Lasgouttes
commit f6282dfec7c7d53fd92d7270f8806a39a9c5d75b Author: Jean-Marc Lasgouttes Date: Sun Oct 20 20:50:23 2019 +0200 Be careful before using buffer parameters in colAlign Make InsetGrid::colAlign a normal method and make it check whether buffer is valid before using

[LyX/master] Be careful before using buffer parameters in colAlign

2019-10-21 Thread Jean-Marc Lasgouttes
commit 44816adce634c8a06c1ff0591adbcf042ec4c072 Author: Jean-Marc Lasgouttes Date: Sun Oct 20 20:50:23 2019 +0200 Be careful before using buffer parameters in colAlign Make InsetGrid::colAlign a normal method and make it check whether buffer is valid before using

[LyX/master] Mark insets with invalid buffer() in red in devel-mode.

2019-10-21 Thread Jean-Marc Lasgouttes
commit 067d6dc759b819d2a40a4dea0b09736d474ddc24 Author: Jean-Marc Lasgouttes Date: Mon Oct 21 16:45:03 2019 +0200 Mark insets with invalid buffer() in red in devel-mode. We tend to have insets which buffer() member is invalid. To help debugging, this commit paints

[LyX/master] Set buffer when expanding macro

2019-10-20 Thread Jean-Marc Lasgouttes
commit 19abf29ea0cf89cdc99b9327448146aeb35d1dc1 Author: Jean-Marc Lasgouttes Date: Sun Oct 20 12:54:59 2019 +0200 Set buffer when expanding macro This avoids a crash in InsetMathSplit which uses the buffer() value. Fixes bug #11686. --- src/mathed/InsetMathMacro.cpp

[LyX/master] Keep last file positions in last-use ordering

2019-10-20 Thread Jean-Marc Lasgouttes
commit 58d22e0c6edab4cb68af63d3ccaafcb875be995d Author: Jean-Marc Lasgouttes Date: Sun Oct 20 11:47:04 2019 +0200 Keep last file positions in last-use ordering Using a map would sort the elements in alphabetic ordering, which means that when the number of elements is larger

[LyX/2.3.x] Fix bad caret position with horizontal scrolling

2019-10-16 Thread Jean-Marc Lasgouttes
commit 7c35081d0c4e48b2ff73c5a11c5446f5288802af Author: Jean-Marc Lasgouttes Date: Mon Oct 7 12:31:20 2019 +0200 Fix bad caret position with horizontal scrolling Horizontal scrolling used to be taken into account when updating caret geometry. This is wrong since it may have

<    4   5   6   7   8   9   10   11   12   13   >