Re: r19838 - in /lyx-devel/trunk/src: TextMetrics.cpp insets/...

2007-08-28 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: I think this should go in branch as well Jurgen. OK. Jürgen

Re: r19659 - /lyx-devel/trunk/src/frontends/qt4/ui/CitationUi.ui

2007-08-28 Thread Peter Kümmel
Andre Poenitz wrote: On Mon, Aug 27, 2007 at 07:51:24AM +0200, Peter Kümmel wrote: Hm... not sure. I've been using the commercial version of Qt for three years and now in the new job some in-house version from which both the commercial and the OS versions are build. I think I never used the OS

Re: Unloadable layout with 1.5.1

2007-08-28 Thread Jürgen Spitzmüller
Jonathan Vogt wrote: I got a layout file here, which I can't open either with 1.5.1 or 1.5.x svn. It looks like layout2layout is running in an endless loop. Could you create a bugzilla entry for this please? In the meantime, if you change Format 2 to Format 4 in the layout file, your

Re: Vertical space in a table cell gives latex errors

2007-08-28 Thread Helge Hafting
Paul A. Rubin wrote: I'm no TeXpert, but I think the logic here is that there is a baseline for text in each row of the table. Vertical alignment is with reference to the baseline. So setting middle in the fixed-width column says that you want the middle of each cell in that column to

Re: Shortcut problem in trunk

2007-08-28 Thread Abdelrazak Younes
Richard Heck wrote: I'm getting a command not allowed message when trying to use Alt-whatever to access the menu with no buffer open. I know, Alfredo reported this already. It should work with the mouse as a work-around. I cannot reproduce it in Windows but I know the origin of the

Re: Shortcut problem in trunk

2007-08-28 Thread Abdelrazak Younes
Richard Heck wrote: I'm getting a command not allowed message when trying to use Alt-whatever to access the menu with no buffer open. By the way, do Ctrl-n works for you? Abdel.

Re: Things we do wrong

2007-08-28 Thread Abdelrazak Younes
Andre Poenitz wrote: Of course it's a somewhat pathological example and we won't suddenly compile 7 times faster within 1/146 diskspace when we kick anon namespaces out. But the direction is clear... That would be very fine with me but Lars would be displeased I guess... Using the static

Re: [Cvslog] r19834 - in /lyx-devel/trunk/src: insets/InsetCaption.h i...

2007-08-28 Thread younes . a
Quoting Martin Vermeer [EMAIL PROTECTED]: On Mon, Aug 27, 2007 at 02:38:31PM +, [EMAIL PROTECTED] wrote: Author: younes Date: Mon Aug 27 16:38:29 2007 New Revision: 19834 URL: http://www.lyx.org/trac/changeset/19834 Log: Remove the wide() hack. This simplifies quite a few

Re: [Cvslog] r19834 - in /lyx-devel/trunk/src: insets/InsetCaption.h i...

2007-08-28 Thread Martin Vermeer
On Tue, Aug 28, 2007 at 12:02:11PM +0200, [EMAIL PROTECTED] wrote: Quoting Martin Vermeer [EMAIL PROTECTED]: On Mon, Aug 27, 2007 at 02:38:31PM +, [EMAIL PROTECTED] wrote: Author: younes Date: Mon Aug 27 16:38:29 2007 New Revision: 19834 URL:

Re: Things we do wrong

2007-08-28 Thread Tommaso Cucinotta
Infact, a few weeks ago, I was told LyX were using unnamed namespaces instead of statics, so I've got to the usual TIC++vone.pdf, where it says: If you put local names in an unnamed namespace, you don’t need to give them internal linkage by making them static. C++ deprecates the use of file

Re: Things we do wrong

2007-08-28 Thread Helge Hafting
Tommaso Cucinotta wrote: [...] the new C++ Standard reads in section 7.3.1.1 Unnamed Spaces, paragraph 2: The use of the static keyword is deprecated when declaring objects in a namespace scope, the unnamed namespace provides a superior alternative. Superior how - is the question. If all

Re: Things we do wrong

2007-08-28 Thread Andre Poenitz
On Tue, Aug 28, 2007 at 02:33:23AM +, Angus Leeming wrote: Andre Poenitz [EMAIL PROTECTED] writes: So anybody who remembers the reasons to use the anon namespace (for _functions_)? [Rhetorical question...] I seem to remember that Lars told us that it was a good thing (TM). However,

Re: Things we do wrong

2007-08-28 Thread Andre Poenitz
On Tue, Aug 28, 2007 at 10:33:31AM +0200, Abdelrazak Younes wrote: Andre Poenitz wrote: Of course it's a somewhat pathological example and we won't suddenly compile 7 times faster within 1/146 diskspace when we kick anon namespaces out. But the direction is clear... That would be very fine

Re: Things we do wrong

2007-08-28 Thread Andre Poenitz
On Tue, Aug 28, 2007 at 12:45:57PM +0200, Tommaso Cucinotta wrote: Infact, a few weeks ago, I was told LyX were using unnamed namespaces instead of statics, so I've got to the usual TIC++vone.pdf, where it says: If you put local names in an unnamed namespace, you don’t need to give them

Define some more logical charstyles

2007-08-28 Thread Martin Vermeer
Attached. I'll put this in if people feel that this is the right direction. Note that character styles still are not enabled by default. It has been my long standing wish that at least Noun and Emph would replace the similar named 'font-like' styles. (What to do with underbar? Underlining is

Re: Things we do wrong

2007-08-28 Thread José Matos
On Tuesday 28 August 2007 15:45:15 Helge Hafting wrote: That's a really stupid argument.  Thw word static has too many meanings, so lets disable some of them ???  The sane thing would be a clean rename from static to several new keywords - one for each use.  And to keep the existing nice

Re: [Cvslog] r19847 - in /lyx-devel/branches/personal/rgheck/lib/layou...

2007-08-28 Thread José Matos
On Tuesday 28 August 2007 07:35:43 [EMAIL PROTECTED] wrote: Added: lyx-devel/branches/personal/rgheck/lib/layouts/theorems-ams-withinsection.module lyx-devel/branches/personal/rgheck/lib/layouts/theorems-ams.module lyx-devel/branches/personal/rgheck/lib/layouts/theorems-std.module

Re: Things we do wrong

2007-08-28 Thread Andre Poenitz
On Tue, Aug 28, 2007 at 04:34:40PM +0100, José Matos wrote: On Tuesday 28 August 2007 15:45:15 Helge Hafting wrote: That's a really stupid argument.  Thw word static has too many meanings, so lets disable some of them ???  The sane thing would be a clean rename from static to several new

Re: Shortcut problem in trunk

2007-08-28 Thread Richard Heck
Abdelrazak Younes wrote: Richard Heck wrote: I'm getting a command not allowed message when trying to use Alt-whatever to access the menu with no buffer open. I know, Alfredo reported this already. It should work with the mouse as a work-around. Yes, I've got this. I cannot reproduce it in

Re: Define some more logical charstyles

2007-08-28 Thread Richard Heck
Martin Vermeer wrote: Attached. I'll put this in if people feel that this is the right direction. Very much so, but you already know how I feel about this. Note that character styles still are not enabled by default. It has been my long standing wish that at least Noun and Emph would

Modules Explained

2007-08-28 Thread Richard Heck
José Matos wrote: Hi Richard, I have some small (and probably pedantic) questions regarding you work on modules: Why are the new files called modules and how they differ from the current .inc files internally? Are the modules supposed to superseed the previous .inc files? The .inc

Modules Commits

2007-08-28 Thread Richard Heck
Jose, I don't know how much of this you've seen at this point, but here is where this stands. The work is basically done, except for some lyx2lyx and the accompanying format change. Some re-arranging type stuff went in a few days ago. I've just committed some re-factoring code in

No 1.5.x Export in Trunk

2007-08-28 Thread Richard Heck
As said. Saw this while testing some lyx2lyx. Richard -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ == Get my public

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread Martin Vermeer
On Tue, Aug 28, 2007 at 04:39:47PM +, [EMAIL PROTECTED] wrote: Author: younes Date: Tue Aug 28 18:39:46 2007 New Revision: 19859 URL: http://www.lyx.org/trac/changeset/19859 Log: We are not forced to redraw the row each time the cursor is moved. * TextMetrics.cpp: CursorOnRow()

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread younes . a
Quoting Martin Vermeer [EMAIL PROTECTED]: - bool cursor_on_row = CursorOnRow(pi, pit, rit, *text_); - // If selection is on, the current row signature differs // from cache, or cursor is inside an inset _on this row_, Forgot this comment? - Martin Yes,

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread Martin Vermeer
On Tue, Aug 28, 2007 at 09:02:10PM +0200, [EMAIL PROTECTED] wrote: Quoting Martin Vermeer [EMAIL PROTECTED]: - bool cursor_on_row = CursorOnRow(pi, pit, rit, *text_); - // If selection is on, the current row signature differs // from cache, or cursor is

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread Martin Vermeer
On Tue, Aug 28, 2007 at 04:39:47PM +, [EMAIL PROTECTED] wrote: Author: younes Date: Tue Aug 28 18:39:46 2007 New Revision: 19859 URL: http://www.lyx.org/trac/changeset/19859 Log: We are not forced to redraw the row each time the cursor is moved. * TextMetrics.cpp: CursorOnRow()

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread Abdelrazak Younes
Martin Vermeer wrote: On Tue, Aug 28, 2007 at 04:39:47PM +, [EMAIL PROTECTED] wrote: Author: younes Date: Tue Aug 28 18:39:46 2007 New Revision: 19859 URL: http://www.lyx.org/trac/changeset/19859 Log: We are not forced to redraw the row each time the cursor is moved. * TextMetrics.cpp:

LyX 1.5.2svn crashes (too often)

2007-08-28 Thread Michael Gerz
Hi, one reason is bug #4178: http://bugzilla.lyx.org/show_bug.cgi?id=4178 Regards, Michael

LyX 1.5.x patch candidate list

2007-08-28 Thread Michael Gerz
Jürgen, all, here comes a new edition of the 1.5.x patch candidate list. Patches recommended by Abdel are marked with !. Michael PS: I will continue sending this list by email. It forces me (and you) to stay active. Wiki pages are just to easy to ignore :-) ?

Drawing Error

2007-08-28 Thread Richard Heck
Abdel, Know you're working on the drawing stuff, and not trying to make your life more difficult...rather, trying to help. Open a document, put the cursor at the beginning of a word in the middle of a sentence, hit space (which you're not allowed to do). The line becomes oddly darker. This

Re: LyX 1.5.x patch candidate list

2007-08-28 Thread Richard Heck
Michael Gerz wrote: ? http://www.lyx.org/trac/changeset/19331 - Deal with a UI bug Jurgen suggested this one could wait. rh -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/

[PATCH] Bug 4170: Window not closed when saved on close

2007-08-28 Thread Richard Heck
http://bugzilla.lyx.org/show_bug.cgi?id=4170 The patch fixes the bug. Please test. We were returning early. I think it's right to clear the AutosaveFile here even if the buffer wasn't unnamed, but if not please let me know. Richard --

[PATCH] Bug 4170: Window not closed when saved on close

2007-08-28 Thread Uwe Stöhr
http://bugzilla.lyx.org/show_bug.cgi?id=4170 The patch fixes the bug. Please test. I tested this and it works as expected. regards Uwe

Re: Things we do wrong

2007-08-28 Thread Roger Mc Murtrie
In this whole lengthy diatribe, nobody seems to mention the words good programming practice; perhaps it died with C++? Programing standards are not usually the provence of good programming practice, no more than car technical manuals provide instruction on good driving practice. The only

Re: Embedding Patch Comments

2007-08-28 Thread Bo Peng
On 8/24/07, Bo Peng [EMAIL PROTECTED] wrote: And here is another one with some minor adjustments. I will only look into this next Monday. :-( I will be happy to spend more time with my kids this weekend, so take your time. :-) Forgotten? Bo

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread Martin Vermeer
On Tue, Aug 28, 2007 at 10:53:09PM +0200, Abdelrazak Younes wrote: Martin Vermeer wrote: On Tue, Aug 28, 2007 at 04:39:47PM +, [EMAIL PROTECTED] wrote: Author: younes Date: Tue Aug 28 18:39:46 2007 New Revision: 19859 URL: http://www.lyx.org/trac/changeset/19859 Log: We are not

Re: r19838 - in /lyx-devel/trunk/src: TextMetrics.cpp insets/...

2007-08-28 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > I think this should go in branch as well Jurgen. OK. Jürgen

Re: r19659 - /lyx-devel/trunk/src/frontends/qt4/ui/CitationUi.ui

2007-08-28 Thread Peter Kümmel
Andre Poenitz wrote: On Mon, Aug 27, 2007 at 07:51:24AM +0200, Peter Kümmel wrote: Hm... not sure. I've been using the commercial version of Qt for three years and now in the new job some in-house version from which both the commercial and the OS versions are build. I think I never used the OS

Re: Unloadable layout with 1.5.1

2007-08-28 Thread Jürgen Spitzmüller
Jonathan Vogt wrote: > I got a layout file here, which I can't open either with 1.5.1 or 1.5.x > svn. It looks like layout2layout is running in an endless loop. Could you create a bugzilla entry for this please? In the meantime, if you change Format 2 to Format 4 in the layout file, your

Re: Vertical space in a table cell gives latex errors

2007-08-28 Thread Helge Hafting
Paul A. Rubin wrote: I'm no TeXpert, but I think the logic here is that there is a baseline for text in each row of the table. Vertical alignment is with reference to the baseline. So setting "middle" in the fixed-width column says that you want the middle of each cell in that column to

Re: Shortcut problem in trunk

2007-08-28 Thread Abdelrazak Younes
Richard Heck wrote: I'm getting a "command not allowed" message when trying to use Alt-whatever to access the menu with no buffer open. I know, Alfredo reported this already. It should work with the mouse as a work-around. I cannot reproduce it in Windows but I know the origin of the

Re: Shortcut problem in trunk

2007-08-28 Thread Abdelrazak Younes
Richard Heck wrote: I'm getting a "command not allowed" message when trying to use Alt-whatever to access the menu with no buffer open. By the way, do Ctrl-n works for you? Abdel.

Re: Things we do wrong

2007-08-28 Thread Abdelrazak Younes
Andre Poenitz wrote: Of course it's a somewhat pathological example and we won't suddenly compile 7 times faster within 1/146 diskspace when we kick anon namespaces out. But the direction is clear... That would be very fine with me but Lars would be displeased I guess... Using the static

Re: [Cvslog] r19834 - in /lyx-devel/trunk/src: insets/InsetCaption.h i...

2007-08-28 Thread younes . a
Quoting Martin Vermeer <[EMAIL PROTECTED]>: > On Mon, Aug 27, 2007 at 02:38:31PM +, [EMAIL PROTECTED] wrote: > > Author: younes > > Date: Mon Aug 27 16:38:29 2007 > > New Revision: 19834 > > > > URL: http://www.lyx.org/trac/changeset/19834 > > Log: > > Remove the wide() hack. This simplifies

Re: [Cvslog] r19834 - in /lyx-devel/trunk/src: insets/InsetCaption.h i...

2007-08-28 Thread Martin Vermeer
On Tue, Aug 28, 2007 at 12:02:11PM +0200, [EMAIL PROTECTED] wrote: > Quoting Martin Vermeer <[EMAIL PROTECTED]>: > > > On Mon, Aug 27, 2007 at 02:38:31PM +, [EMAIL PROTECTED] wrote: > > > Author: younes > > > Date: Mon Aug 27 16:38:29 2007 > > > New Revision: 19834 > > > > > > URL:

Re: Things we do wrong

2007-08-28 Thread Tommaso Cucinotta
Infact, a few weeks ago, I was told LyX were using unnamed namespaces instead of statics, so I've got to the usual TIC++vone.pdf, where it says: "If you put local names in an unnamed namespace, you don’t need to give them internal linkage by making them static. C++ deprecates the use of file

Re: Things we do wrong

2007-08-28 Thread Helge Hafting
Tommaso Cucinotta wrote: [...] the new C++ Standard reads in section 7.3.1.1 Unnamed Spaces, paragraph 2: "The use of the static keyword is deprecated when declaring objects in a namespace scope, the unnamed namespace provides a superior alternative." Superior how - is the question. If all

Re: Things we do wrong

2007-08-28 Thread Andre Poenitz
On Tue, Aug 28, 2007 at 02:33:23AM +, Angus Leeming wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > So anybody who remembers the reasons to use the anon namespace (for > > _functions_)? [Rhetorical question...] > > I seem to remember that Lars told us that it was "a good thing" (TM).

Re: Things we do wrong

2007-08-28 Thread Andre Poenitz
On Tue, Aug 28, 2007 at 10:33:31AM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >Of course it's a somewhat pathological example and we won't suddenly > >compile 7 times faster within 1/146 diskspace when we kick anon > >namespaces out. But the direction is clear... > > That would be

Re: Things we do wrong

2007-08-28 Thread Andre Poenitz
On Tue, Aug 28, 2007 at 12:45:57PM +0200, Tommaso Cucinotta wrote: > Infact, a few weeks ago, I was told LyX were using unnamed > namespaces instead of statics, so I've got to the usual > TIC++vone.pdf, where it says: > > "If you put local names in an unnamed namespace, you don’t > need to give

Define some more logical charstyles

2007-08-28 Thread Martin Vermeer
Attached. I'll put this in if people feel that this is the right direction. Note that character styles still are not enabled by default. It has been my long standing wish that at least Noun and Emph would replace the similar named 'font-like' styles. (What to do with underbar? Underlining is

Re: Things we do wrong

2007-08-28 Thread José Matos
On Tuesday 28 August 2007 15:45:15 Helge Hafting wrote: > That's a really stupid argument.  Thw word "static" has too many meanings, > so lets disable some of them ???  The sane thing would be a > clean rename from "static" to several new keywords - one for each > use.  And to keep the existing

Re: [Cvslog] r19847 - in /lyx-devel/branches/personal/rgheck/lib/layou...

2007-08-28 Thread José Matos
On Tuesday 28 August 2007 07:35:43 [EMAIL PROTECTED] wrote: > Added: > > lyx-devel/branches/personal/rgheck/lib/layouts/theorems-ams-withinsection.module >lyx-devel/branches/personal/rgheck/lib/layouts/theorems-ams.module > lyx-devel/branches/personal/rgheck/lib/layouts/theorems-std.module >

Re: Things we do wrong

2007-08-28 Thread Andre Poenitz
On Tue, Aug 28, 2007 at 04:34:40PM +0100, José Matos wrote: > On Tuesday 28 August 2007 15:45:15 Helge Hafting wrote: > > That's a really stupid argument.  Thw word "static" has too many meanings, > > so lets disable some of them ???  The sane thing would be a > > clean rename from "static" to

Re: Shortcut problem in trunk

2007-08-28 Thread Richard Heck
Abdelrazak Younes wrote: Richard Heck wrote: I'm getting a "command not allowed" message when trying to use Alt-whatever to access the menu with no buffer open. I know, Alfredo reported this already. It should work with the mouse as a work-around. Yes, I've got this. I cannot reproduce it

Re: Define some more logical charstyles

2007-08-28 Thread Richard Heck
Martin Vermeer wrote: Attached. I'll put this in if people feel that this is the right direction. Very much so, but you already know how I feel about this. Note that character styles still are not enabled by default. It has been my long standing wish that at least Noun and Emph would

Modules Explained

2007-08-28 Thread Richard Heck
José Matos wrote: Hi Richard, I have some small (and probably pedantic) questions regarding you work on modules: Why are the new files called modules and how they differ from the current .inc files internally? Are the modules supposed to superseed the previous .inc files? The .inc

Modules Commits

2007-08-28 Thread Richard Heck
Jose, I don't know how much of this you've seen at this point, but here is where this stands. The work is basically done, except for some lyx2lyx and the accompanying format change. Some re-arranging type stuff went in a few days ago. I've just committed some re-factoring code in

No 1.5.x Export in Trunk

2007-08-28 Thread Richard Heck
As said. Saw this while testing some lyx2lyx. Richard -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ == Get my public

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread Martin Vermeer
On Tue, Aug 28, 2007 at 04:39:47PM +, [EMAIL PROTECTED] wrote: > Author: younes > Date: Tue Aug 28 18:39:46 2007 > New Revision: 19859 > > URL: http://www.lyx.org/trac/changeset/19859 > Log: > We are not forced to redraw the row each time the cursor is moved. > > * TextMetrics.cpp:

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread younes . a
Quoting Martin Vermeer <[EMAIL PROTECTED]>: > > - bool cursor_on_row = CursorOnRow(pi, pit, rit, *text_); > > - > > // If selection is on, the current row signature differs > > // from cache, or cursor is inside an inset _on this row_, > > Forgot this comment? -

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread Martin Vermeer
On Tue, Aug 28, 2007 at 09:02:10PM +0200, [EMAIL PROTECTED] wrote: > Quoting Martin Vermeer <[EMAIL PROTECTED]>: > > > > - bool cursor_on_row = CursorOnRow(pi, pit, rit, *text_); > > > - > > > // If selection is on, the current row signature differs > > > // from

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread Martin Vermeer
On Tue, Aug 28, 2007 at 04:39:47PM +, [EMAIL PROTECTED] wrote: > Author: younes > Date: Tue Aug 28 18:39:46 2007 > New Revision: 19859 > > URL: http://www.lyx.org/trac/changeset/19859 > Log: > We are not forced to redraw the row each time the cursor is moved. > > * TextMetrics.cpp:

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread Abdelrazak Younes
Martin Vermeer wrote: On Tue, Aug 28, 2007 at 04:39:47PM +, [EMAIL PROTECTED] wrote: Author: younes Date: Tue Aug 28 18:39:46 2007 New Revision: 19859 URL: http://www.lyx.org/trac/changeset/19859 Log: We are not forced to redraw the row each time the cursor is moved. * TextMetrics.cpp:

LyX 1.5.2svn crashes (too often)

2007-08-28 Thread Michael Gerz
Hi, one reason is bug #4178: http://bugzilla.lyx.org/show_bug.cgi?id=4178 Regards, Michael

LyX 1.5.x patch candidate list

2007-08-28 Thread Michael Gerz
Jürgen, all, here comes a new edition of the 1.5.x patch candidate list. Patches recommended by Abdel are marked with "!". Michael PS: I will continue sending this list by email. It forces me (and you) to stay active. Wiki pages are just to easy to ignore :-) ?

Drawing Error

2007-08-28 Thread Richard Heck
Abdel, Know you're working on the drawing stuff, and not trying to make your life more difficult...rather, trying to help. Open a document, put the cursor at the beginning of a word in the middle of a sentence, hit space (which you're not allowed to do). The line becomes oddly darker. This

Re: LyX 1.5.x patch candidate list

2007-08-28 Thread Richard Heck
Michael Gerz wrote: ? http://www.lyx.org/trac/changeset/19331 - Deal with a UI bug Jurgen suggested this one could wait. rh -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/

[PATCH] Bug 4170: Window not closed when saved on close

2007-08-28 Thread Richard Heck
http://bugzilla.lyx.org/show_bug.cgi?id=4170 The patch fixes the bug. Please test. We were returning early. I think it's right to clear the AutosaveFile here even if the buffer wasn't unnamed, but if not please let me know. Richard --

[PATCH] Bug 4170: Window not closed when saved on close

2007-08-28 Thread Uwe Stöhr
> http://bugzilla.lyx.org/show_bug.cgi?id=4170 > > The patch fixes the bug. Please test. I tested this and it works as expected. regards Uwe

Re: Things we do wrong

2007-08-28 Thread Roger Mc Murtrie
In this whole lengthy diatribe, nobody seems to mention the words "good programming practice"; perhaps it died with C++? Programing standards are not usually the provence of "good programming practice", no more than car technical manuals provide instruction on good driving practice. The

Re: Embedding Patch Comments

2007-08-28 Thread Bo Peng
On 8/24/07, Bo Peng <[EMAIL PROTECTED]> wrote: > > > And here is another one with some minor adjustments. > > > > I will only look into this next Monday. :-( > > I will be happy to spend more time with my kids this weekend, so take > your time. :-) Forgotten? Bo

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread Martin Vermeer
On Tue, Aug 28, 2007 at 10:53:09PM +0200, Abdelrazak Younes wrote: > Martin Vermeer wrote: > >On Tue, Aug 28, 2007 at 04:39:47PM +, [EMAIL PROTECTED] wrote: > > > >>Author: younes > >>Date: Tue Aug 28 18:39:46 2007 > >>New Revision: 19859 > >> > >>URL: http://www.lyx.org/trac/changeset/19859